---
phase: 08-oauth2-1-authorization-server
plan: 10
type: execute
wave: 9
depends_on: [08-09]
files_modified:
  - wristband/phase08_coverage_test.go
  - ../fonoteka.go/plugins/golem15/fonoteka/phase08_coverage_test.go
  - ../fonoteka.go/parity/oauth_audit_test.go
  - scripts/check-phase8.sh
  - .planning/phases/08-oauth2-1-authorization-server/08-PHP-TEST-MAP.md
  - .planning/phases/08-oauth2-1-authorization-server/08-SECURITY-REVIEW.md
  - .planning/phases/08-oauth2-1-authorization-server/08-VALIDATION.md
autonomous: false
requirements: [AUTH-05, AUTH-06, AUTH-07]
must_haves:
  truths:
    - "D-18: Every PHP OAuth functional/security test method maps to a named passing Go test or subtest, and both repositories pass vet/test/race."
    - "D-04: Every T-08 threat maps to a failing-when-broken test with zero open high-severity findings."
    - "D-14: The final phase gate refuses missing tests, UI/route parity, secret scans, unchanged-client evidence, or an unverified security review."
  artifacts:
    - path: ".planning/phases/08-oauth2-1-authorization-server/08-PHP-TEST-MAP.md"
      provides: "Auditable one-to-one map of all 103 PHP methods to Go evidence"
    - path: ".planning/phases/08-oauth2-1-authorization-server/08-SECURITY-REVIEW.md"
      provides: "ASVS L1 threat disposition and executed evidence"
    - path: ".planning/phases/08-oauth2-1-authorization-server/08-VALIDATION.md"
      provides: "Nyquist-complete task/status and gate sign-off"
  key_links:
    - from: "08-SECURITY-REVIEW.md"
      to: "named Go tests"
      via: "file:TestName evidence for every mitigated threat"
      pattern: "T-08-"
    - from: "scripts/check-phase8.sh"
      to: "08-SECURITY-REVIEW.md"
      via: "fail-closed verified/zero-open audit check"
      pattern: "08-SECURITY-REVIEW"
---

<objective>
Close Phase 8 with complete unit/security coverage, an independent security-review agent pass, and one fail-closed verification gate.

Purpose: Demonstrate that the exact OAuth implementation is not merely functional but resistant to every identified high-severity replay, redirect, timing, scope, ownership, leakage, flooding, and surface threat.
Output: Coverage tests, 103-method audit map, verified security review, signed validation strategy, and final gate.
</objective>

## Phase Goal

**As a** Płytarium operator, **I want to** rely on independently reviewed OAuth behavior and complete regression evidence, **so that** unchanged connectors can be enabled without accepting an unproven high-severity security risk.

<execution_context>
@/home/jin/.codex/get-shit-done/workflows/execute-plan.md
@/home/jin/.codex/get-shit-done/templates/summary.md
</execution_context>

<context>
@.planning/PROJECT.md
@.planning/ROADMAP.md
@.planning/STATE.md
@.planning/phases/08-oauth2-1-authorization-server/08-CONTEXT.md
@.planning/phases/08-oauth2-1-authorization-server/08-RESEARCH.md
@.planning/phases/08-oauth2-1-authorization-server/08-VALIDATION.md
@.planning/phases/08-oauth2-1-authorization-server/08-09-SUMMARY.md
@.planning/phases/06-http-routing-auth-groups-and-rate-limiting/06-SECURITY-REVIEW.md

<interfaces>
Security-review evidence contract:
- One register row per `T-08-*` threat with category, component, disposition, mitigation, and exact `file:TestName` evidence.
- Frontmatter reports total/closed/open and status; completion requires `status: verified`, `threats_open: 0`, and no unmitigated HIGH.

PHP test inventory contract:
- 103 methods: authorize 11, client-command 8, metadata 2, migration 7, register 10, token 10, consent/scope 7, refresh rotation 10, revocation 8, surface isolation 30.
</interfaces>
</context>

<tasks>

<task type="auto" tdd="true">
  <name>Task 1: Close the 103-method PHP audit and Phase 8 coverage gaps</name>
  <files>wristband/phase08_coverage_test.go, ../fonoteka.go/plugins/golem15/fonoteka/phase08_coverage_test.go, ../fonoteka.go/parity/oauth_audit_test.go, .planning/phases/08-oauth2-1-authorization-server/08-PHP-TEST-MAP.md</files>
  <read_first>
    .planning/phases/08-oauth2-1-authorization-server/08-CONTEXT.md
    .planning/phases/08-oauth2-1-authorization-server/08-VALIDATION.md
    wristband/registration_test.go
    wristband/authorize_test.go
    wristband/token_test.go
    ../fonoteka.go/plugins/golem15/fonoteka/controllers/api/oauth_consent_controller_test.go
    ../fonoteka.go/plugins/golem15/fonoteka/controllers/api/connected_app_controller_test.go
    ../fonoteka.go/plugins/golem15/fonoteka/oauth_registration_test.go
    ../fonoteka.go/plugins/golem15/fonoteka/oauth_connect_test.go
    ../fonoteka.go/plugins/golem15/fonoteka/oauth_lifecycle_test.go
    ../fonoteka.go/plugins/golem15/fonoteka/oauth_tools_test.go
    /media/nvme/dev/golem15/fonoteka/plugins/golem15/fonoteka/tests/functional/OAuthAuthorizeTest.php
    /media/nvme/dev/golem15/fonoteka/plugins/golem15/fonoteka/tests/functional/OAuthClientCommandTest.php
    /media/nvme/dev/golem15/fonoteka/plugins/golem15/fonoteka/tests/functional/OAuthMetadataTest.php
    /media/nvme/dev/golem15/fonoteka/plugins/golem15/fonoteka/tests/functional/OAuthMigrationTest.php
    /media/nvme/dev/golem15/fonoteka/plugins/golem15/fonoteka/tests/functional/OAuthRegisterTest.php
    /media/nvme/dev/golem15/fonoteka/plugins/golem15/fonoteka/tests/functional/OAuthTokenTest.php
    /media/nvme/dev/golem15/fonoteka/plugins/golem15/fonoteka/tests/security/OAuthConsentScopeCeilingTest.php
    /media/nvme/dev/golem15/fonoteka/plugins/golem15/fonoteka/tests/security/OAuthRefreshRotationTest.php
    /media/nvme/dev/golem15/fonoteka/plugins/golem15/fonoteka/tests/security/OAuthRevocationTest.php
    /media/nvme/dev/golem15/fonoteka/plugins/golem15/fonoteka/tests/security/TokenSurfaceIsolationTest.php
  </read_first>
  <behavior>
    - Every PHP method is listed once with its source class, behavior, and a named Go test/subtest that actually runs.
    - Coverage tests exercise error branches, encoding failures, nil/misconfigured dependencies, clock/entropy errors, parser edges, and route/config drift not already covered.
    - Audit fails if a mapped Go test is renamed/missing or if any PHP method is unmapped/duplicated.
  </behavior>
  <action>D-18: enumerate all 103 PHP methods into `08-PHP-TEST-MAP.md`, map each to existing Phase 8 tests, and add focused coverage tests only where no named evidence exists. Add an executable audit that parses the inventory/map and Go test list so counts alone cannot hide missing or duplicate mappings. Close framework handler/store branches, app boot/config/route/controller/command branches, parity projections, UI harness invocation, and every exact response/header path. Do not replace behavior assertions with coverage-only calls or map one broad test to methods whose distinct assertions are absent.</action>
  <verify>
    <automated>go test ./wristband -run '^Test(Phase08Coverage|PHPTestMap)' -count=1 &amp;&amp; (cd ../fonoteka.go &amp;&amp; go test ./plugins/golem15/fonoteka ./parity -run '^Test(Phase08Coverage|PHPTestMap)$' -count=1)</automated>
  </verify>
  <acceptance_criteria>
    - The map contains exactly 103 unique PHP method rows distributed 11/8/2/7/10/10/7/10/8/30 by source suite.
    - The executable audit confirms every mapped Go `TestName[/subtest]` exists and executes; missing or duplicate rows make it fail.
    - The focused map/coverage audit is designed for under 30 seconds; complete repository vet/test/race runs only in Task 3's final gate.
    - Coverage additions retain exact byte/header/concurrency assertions for security branches.
  </acceptance_criteria>
  <done>All PHP OAuth behavior has one-to-one named Go evidence and the phase's code paths are covered by meaningful regression tests.</done>
</task>

<task type="auto">
  <name>Task 2: Run the mandated security-review agent and close every high-severity finding</name>
  <files>.planning/phases/08-oauth2-1-authorization-server/08-SECURITY-REVIEW.md, .planning/phases/08-oauth2-1-authorization-server/08-VALIDATION.md, scripts/check-phase8.sh</files>
  <read_first>
    .planning/phases/08-oauth2-1-authorization-server/08-CONTEXT.md
    .planning/phases/08-oauth2-1-authorization-server/08-RESEARCH.md
    .planning/phases/08-oauth2-1-authorization-server/08-PHP-TEST-MAP.md
    .planning/phases/08-oauth2-1-authorization-server/08-VALIDATION.md
    .planning/phases/06-http-routing-auth-groups-and-rate-limiting/06-SECURITY-REVIEW.md
    scripts/check-phase8.sh
    wristband/server.go
    wristband/authorize.go
    wristband/token.go
    wristband/register.go
    wristband/crypto.go
    ../fonoteka.go/plugins/golem15/fonoteka/classes/auth/oauth_store.go
    ../fonoteka.go/plugins/golem15/fonoteka/controllers/api/oauth_consent_controller.go
    ../fonoteka.go/plugins/golem15/fonoteka/controllers/api/connected_app_controller.go
    ../fonoteka.go/plugins/golem15/fonoteka/routes.go
  </read_first>
  <action>D-04: invoke the `gsd-security-auditor` against all Phase 8 production/test changes and the locked threat map, requiring OWASP ASVS L1 review of every named T-08 threat and supply-chain status. Write `08-SECURITY-REVIEW.md` in the Phase 6 format with executed `file:TestName` evidence. If any HIGH exists, stop sign-off and create a targeted Phase 8 gap plan that explicitly declares the owning production and regression-test files; do not modify undeclared production files from this audit task. Execute that gap plan, rerun focused evidence, and re-run the auditor until no HIGH remains before resuming this task. Update VALIDATION task IDs/statuses and Nyquist flags only after evidence is green. Add the fail-closed review check to `check-phase8.sh`, but reserve the complete gate for Task 3.</action>
  <verify>
    <automated>scripts/check-phase8.sh --security-review-only</automated>
  </verify>
  <acceptance_criteria>
    - `08-SECURITY-REVIEW.md` has `status: verified`, `threats_open: 0`, and one evidence-backed disposition for every named T-08 threat plus T-08-SC.
    - Every HIGH finding is mitigated by a named failing-when-broken test; no HIGH is accepted, deferred, or omitted.
    - Static evidence finds `crypto/subtle.ConstantTimeCompare` for client secret and PKCE, row locks for code/refresh, committed replay kill, 64 KiB register cap, raw/JWT/personal route isolation, and no sensitive-value logging.
    - `08-VALIDATION.md` maps final plan/task IDs, all required test/gate files exist, all statuses are green, and both Nyquist flags are true.
    - `scripts/check-phase8.sh` exits nonzero if the review is missing, unverified, has a nonzero open count, or lacks any required T-08 row.
  </acceptance_criteria>
  <done>An independent security agent has reviewed the implemented phase, all high-severity findings are closed with executable evidence, and the final gate enforces the review.</done>
</task>

<task type="checkpoint:human-verify" gate="blocking-human">
  <name>Task 3: Approve the OAuth security and unchanged-client evidence</name>
  <files>.planning/phases/08-oauth2-1-authorization-server/08-SECURITY-REVIEW.md, .planning/phases/08-oauth2-1-authorization-server/08-VALIDATION.md</files>
  <read_first>
    .planning/phases/08-oauth2-1-authorization-server/08-SECURITY-REVIEW.md
    .planning/phases/08-oauth2-1-authorization-server/08-PHP-TEST-MAP.md
    .planning/phases/08-oauth2-1-authorization-server/08-VALIDATION.md
    .planning/phases/08-oauth2-1-authorization-server/08-09-SUMMARY.md
  </read_first>
  <action>After the security-review agent reports zero open high-severity findings, execute `scripts/check-phase8.sh` exactly once as the sole complete long gate. It must run both repositories' `go vet ./...`, `go test ./...`, and `go test -race ./...`; 103-method executable audit; nine-route/full-lifecycle parity and corpus secret scan; full return-path/i18n/Playwright UI matrix; disposable Postgres/app plus unchanged real MCP discovery/DCR/PKCE/JWT consent/token/`/me`/tool/refresh/replay/revoke; security-review fail-closed checks; and scoped unchanged Nuxt/MCP worktree assertions. Present the completed evidence; do not ask the user to rerun automation. Block completion if any displayed result is missing or non-green.</action>
  <verify>
    <automated>scripts/check-phase8.sh</automated>
  </verify>
  <what-built>Direct standard-library OAuth authorization server with DCR, S256 PKCE, JWT consent, authorization-code and rotating-refresh grants, connected-app revocation, operator client command, MCP bootstrap endpoint, PHP parity, and unchanged real-MCP proof.</what-built>
  <how-to-verify>
    1. Review `08-SECURITY-REVIEW.md`; expect `status: verified`, zero open threats, and named test evidence for every T-08 row.
    2. Review the recorded gate transcript; expect both repositories' vet/test/race, 103/103 PHP method map, nine OAuth route replays, secret scan, and real MCP lifecycle to be green.
    3. Confirm the Nuxt and fonoteka-mcp repositories have no Phase 8 source diff.
  </how-to-verify>
  <acceptance_criteria>
    - Human approval occurs only after zero open HIGH findings and a passing `scripts/check-phase8.sh` result are shown.
    - The evidence explicitly includes exact Basic `WWW-Authenticate` at backend invalid-client, unchanged no-challenge token 401, and MCP-owned rich Bearer/resource-metadata behavior.
    - Rejection includes the failing threat/test/gate identifier so remediation is deterministic.
  </acceptance_criteria>
  <resume-signal>Type "approved" to close Phase 8, or provide the failed threat/test/gate identifier.</resume-signal>
  <done>The user has accepted the complete automated OAuth compatibility and security evidence.</done>
</task>

</tasks>

<threat_model>
## Trust Boundaries

| Boundary | Description |
|----------|-------------|
| Phase implementation → independent auditor | Claims must be supported by executable evidence, not implementation intent. |
| Test inventory → completion status | Missing/renamed tests or unmapped PHP methods must fail closed. |
| Security report → phase gate | Stale, missing, or open findings must prevent sign-off. |

## STRIDE Threat Register

| Threat ID | Category | Component | Disposition | Mitigation Plan |
|-----------|----------|-----------|-------------|-----------------|
| T-08-PKCE | Spoofing/Elevation | authorize/exchange | mitigate | Independent audit plus missing/plain/wrong/syntax/constant-time tests. |
| T-08-CODE-REPLAY | Spoofing | code transaction | mitigate | Sequential/concurrent single-winner tests and row-lock source evidence. |
| T-08-REFRESH-REPLAY | Spoofing/Elevation | refresh transaction | mitigate | Branch-concurrency and post-error persisted lineage-kill evidence. |
| T-08-OPEN-REDIRECT | Spoofing/Disclosure | redirect construction | mitigate | Exact allow-list/validation-order and no-Location tests. |
| T-08-SECRET-TIMING | Information Disclosure | crypto/client auth | mitigate | `subtle.ConstantTimeCompare` source gate and invalid-secret behavior tests. |
| T-08-SCOPE-CEILING | Elevation | authorize/consent/refresh | mitigate | End-to-end requested/submitted/ceiling/mintable and server-derived tenant proofs. |
| T-08-CROSS-USER | Elevation | consent/connected apps | mitigate | Foreign ownership tests with indistinguishable 404s. |
| T-08-REQUEST-LEAK | Information Disclosure | logs/fixtures/output | mitigate | Log capture, source scan, fixture secret scan, positive output allow-lists. |
| T-08-DCR-FLOOD | Denial of Service | register | mitigate | 64 KiB cap, limiter, atomic client cap, sweep, concurrency evidence. |
| T-08-SURFACE | Elevation | route/MCP boundary | mitigate | Assembled route table and real client header-ownership gate. |
| T-08-SC | Tampering | package supply chain | mitigate | No added package; module-diff and package-audit checks. |
</threat_model>

<verification>
- `go vet ./... && go test ./... && go test -race ./...`
- `cd ../fonoteka.go && go vet ./... && go test ./... && go test -race ./...`
- `scripts/check-phase8.sh`
- Human approval after independent security review reports zero open HIGH findings.
</verification>

<success_criteria>
- All 103 PHP methods map uniquely to named passing Go tests/subtests.
- All T-08 threats have explicit dispositions and executable evidence; zero high-severity findings remain open.
- Nyquist validation, parity, secret scan, and unchanged real-MCP lifecycle are green in the final gate.
- The blocking human security checkpoint is approved.
</success_criteria>

<output>
Create `.planning/phases/08-oauth2-1-authorization-server/08-10-SUMMARY.md` when done.
</output>