2.1 KiB
2.1 KiB
Phase 14 deferred items
Out-of-scope discoveries logged by executors. They are not fixed in the plan that found them.
From 14-03
- Phase 12 album cover imports dial the real cover hosts during the parity replay.
POST albums(six-covers),PUT albums/{id}(cover-urls),POST albums/bulk(cover-failures) andPOST albums/{id}/photosimportcover_urlsthroughclasses.CoverImporterFromConfig, whose default fetch is the one-shotfetchguard.Fetch. That fetch does not honourfetchguard.WithTransport, so the replay reachesi.discogs.cominstead of an upstream fake, and PHP's recordings of those cases were made against the live hosts too. 14-03 addedclasses.NewGuardedCoverImporter(afetchguard.Clientthat honours the seam, with PHP'sGuzzleHttp/7User-Agent) and uses it only on the Discogs routes. Moving the Phase 12 routes onto it needs their cases re-recorded with cover sidecars. Candidate owner: 14-06 or a quick task.
From 14-06
- The Phase 12 cover-import replay (from 14-03) is still open. 14-06 kept it out of scope: moving the Phase 12 album routes onto
classes.NewGuardedCoverImporterneeds their cases re-recorded against PHP with cover sidecars. Until thenclasses/cover_importer.gofetch's 2xx path can only run against the live image hosts, which is whycheck-phase14.sh --coverageexempts that one function (72.7%). TestCoverFetcherHostLockfailed once under the full-racerun ofcheck-phase14.sh --go(the first run of 14-06, with the whole fonoteka.go tree under test in parallel). The failure output was not kept, and the test passed in every later run: three-raceruns of its package under load, two further--goruns and two--allruns. The gate now keeps the full log of a failedgo testrun (phase14-failed-<pid>.jsonunder$TMPDIR) so a repeat can be diagnosed. Candidate owner: a quick task if it recurs.- A testcontainers Postgres start can exceed its 60 s wait under the gate's parallel load (the
updatespackage, seen once in--allat the coverage stage). The gate refuses, as it must; a rerun passed. Raising the wait in the shared test harnesses is a candidate quick task.