summercms/.planning/phases/10.2-nest-framework-packages-under-modules-and-write-run-docs/10.2-REVIEW.md

phase, reviewed, depth, files_reviewed, files_reviewed_list, findings, status

phase	reviewed	depth	files_reviewed	files_reviewed_list	findings	status
10.2-nest-framework-packages-under-modules-and-write-run-docs	2026-09-28T11:30:22Z	standard	424	summercms.go: 299 paths resolved by git diff --name-only 195bf2ce757d1802f2ae5d0e3052b3e43815822d..HEAD -- . ':!.planning/' ':!boardwalk/dist/' ':!modules/boardwalk/dist/' fonoteka.go: 125 paths resolved by git -C ../fonoteka.go diff --name-only 21c0f12747d824637fdc1a126e5922947432fb6b..HEAD -- . All 18 new modules/*/README.md files and scripts/check-phase10.2.sh were read in full; all real content deltas were inspected. The remaining moved Go/test files were verified as package-identity-preserving moves with import-path-only deltas, with representative current-source inspection across every module.	critical warning info total 0 1 0 1	issues_found

Phase 10.2: Code Review Report

Reviewed: 2026-09-28T11:30:22Z Depth: standard Files Reviewed: 424 Status: issues_found

Summary

This review covered the framework and sibling Fonoteka import migration, the moved package layout, all new module and root onboarding documentation, and the Phase 10.2 gate. The import graph consistently uses modules/, generated/build paths point to the moved locations, and the two-repository Go vet/test stage passes. One fail-closed gate rule does not implement its declared planning-artifact exclusion.

Narrative Findings (AI reviewer)

The package moves preserve package names and the substantive source changes are path updates, apart from the Fonoteka PHP-test-map audit's deliberate modules/ resolution. No unresolved root-form framework imports were found in the tracked source scan. The warning below is based on the current gate implementation, not on test results.

Warnings

WR-01: Git-backed import scan includes planning artifacts

File: scripts/check-phase10.2.sh:33 Issue: The normal (Git-backed) source enumeration uses git ls-files without excluding .planning/. This contradicts the gate contract to skip planning/historical artifacts. A future tracked .planning/**/*.go, .tmpl, or .sh file that quotes a historical root-form import will make --imports/--all fail even though no executable source regressed, blocking the release gate on immutable planning evidence. The non-Git fallback does prune .planning/, so the two execution paths disagree. Fix: Exclude planning paths in the Git path and retain a defensive loop-level exclusion; add a self-test plant under .planning/ that proves it is ignored.

git -C "$repo" ls-files -z -- '*.go' '*.tmpl' '*.sh' ':(exclude).planning/**'

# Also in check_imports_in, before grep:
[[ "$file" == .planning/* ]] && continue

---

Reviewed: 2026-09-28T11:30:22Z Reviewer: the agent (gsd-code-reviewer) Depth: standard