4.5 KiB
Phase 12.1 deferred items
Deferred Items
-
Two inventory tests of the application's fonoteka plugin module fail against the framework at v0.1.3 status: resolved Resolved: plan 12.1-04, 2026-10-05, fonoteka.go commit
ca746fc(phase09AdminRoutesnames the bulk action and record action routes;phase10ListMessageKeysnames the three row-state messages). The form half ofTestPhase10ControllerCopyreads named keys only and needed no change. Found: plan 12.1-02 Task 6, 2026-10-05, by runninggo -C ../fonoteka.go/plugins/golem15/fonoteka test ./... -count=1in addition to the plan's gate. What:TestPhase09SecurityRoutes(admin_phase09_security_test.go) reports the two plan 01 routesPOST .../{controller}/bulk/{action}andPOST .../{controller}/{id}/actions/{action}as unexpected, because the fixed listphase09AdminRoutesdoes not name them.TestPhase10ControllerCopy(admin_phase10_copy_test.go) compares the list messages with the fixed listphase10ListMessageKeys, which lacksrowStateDeleted,rowStateNegativeandrowStateDisabled; its form half was not reached and may needpreviewandeditthe same way. Why not fixed here: the fix is two fixed lists in the application repository (fonoteka.go); plan 12.1-02 writes to summercms.go only. No framework change is needed, so the tagged commit is not affected. The same catch-up was done once before (549840d test(13-06): list the Phase 12.2 cabana admin routes in the Phase 9 route inventory). Why the gate missed it: the plan's application gatego -C ../fonoteka.go test ./... -count=1runs the root module only; the go.work plugin modules (plugins/golem15/{user,fonoteka,golem,feedback}) are separate modules and are not matched by./.... Suggested owner: plan 12.1-04 (it already writes the application's parity allow-list entry and submodule pointer) or plan 12.1-05's gate script, which should run every workspace module. -
Four more application tests fail once the user plugin registers its admin screen, its three migrations and the FrontendPermission model status: resolved Resolved: plan 12.1-04, 2026-10-05, fonoteka.go commit
b35442a(developer navigation[fonoteka user], with the publisher still seeing neither;expectedUserModels = 7, because plan 04 also registers theUsersGrouppivot; the user plugin's history has ten migrations) and35a727f(thegolem15_user_frontend_permissionsallow-list entry). Each failure was checked to be the fixed list and not a defect before the list changed. Found: plan 12.1-03 Tasks 1 and 3, 2026-10-05. The application's go.work uses the plugin's working tree, so these fail as soon as the plugin commits exist, before any submodule pointer bump. What: (1)TestAdminMetadataFiltering(plugins/golem15/fonoteka/admin_metadata_test.go) expects the developer role's navigation to be exactly[fonoteka]; it is now[fonoteka user], because the four Winter permission codes of the user plugin default to the developer role (D-02, D-04). (2)TestMigrateSeedsCanonicalGenresandTestRollbackLastIsolatesFonoteka(parity/migrate_test.go) compare the user plugin's migration history with a fixed id list, which lacks202610040001_add_users_permissions,202610040002_add_users_last_seenand202610040003_create_frontend_permissions. In history order (by id) the first of them sorts before the shipped202610040001_create_user_api_tokens. (3)TestHiddenNeverMarshals(plugins/golem15/fonoteka/classes/hidden_marshal_test.go) pinsexpectedUserModels = 5; the user plugin now registers six models (FrontendPermissionis new). With the constant at 6 (checked through ago test -overlaycopy, nothing written to the repository) the test passes, so the marshalling checks themselves hold for the new model and the newUserfields. Already known, same run:TestSchemaMatchesPHPSnapshotreports the new tablegolem15_user_frontend_permissionsuntil plan 04 adds its allow-list entry (stated in the 12.1-03 plan). Why not fixed here: all of them are fixed lists or counts in the application repository (fonoteka.go). Plan 12.1-03 commits only inside the plugin checkout. Effect on plan 12.1-03's own verify: the commandgo -C ../fonoteka.go test ./plugins/golem15/fonoteka -run '^(TestAdmin|TestPhase09|TestPhase10|TestPhase12Threats)'cannot be green before plan 04: it matchesTestAdminMetadataFilteringand the two tests of the entry above. Every other test that pattern selects passes. Suggested owner: plan 12.1-04, together with the entry above.