Files
summercms/modules/surf/assemble_router_mcp_test.go
Jakub Zych 38f7f3a777 feat(surf): AssembleRouter builds the router and handler once; the router stops the MCP endpoint it mounted (quick-261118-lbt)
- surf.AssembleRouter returns the router and the compiled handler from
  one build, so an mcp.enabled app is not built twice; Assemble keeps
  its signature and is implemented on top of it
- serve uses AssembleRouter with a deferred Router.Close
- pier.Pier.Close stops the session reaper and the Redis warm-up; the
  router that mounted the endpoint owns it
- ExampleAssembleRouter, routing/testing docs and the surf/pier READMEs
2026-11-18 15:44:56 +01:00

89 lines
2.4 KiB
Go

//go:build summercms_mcp
package surf
import (
"net/http"
"runtime"
"testing"
"time"
"git.golem15.com/golem15/summercms/modules/backpack"
"git.golem15.com/golem15/summercms/modules/party"
"git.golem15.com/golem15/summercms/modules/pier"
)
func mcpApp(t *testing.T) *backpack.App {
t.Helper()
return transportApp(t, "development", map[string]string{
"http.yaml": transportBodyLimits,
"app.yaml": "name: mount-test\nurl: http://acme.test\n",
"mcp.yaml": "enabled: true\n",
})
}
// TestAssembleRouterMCPOneBuild: pier publishes its endpoint once per app,
// so one AssembleRouter call must give the route table, the admin prefix and
// the handler of an mcp.enabled app.
func TestAssembleRouterMCPOneBuild(t *testing.T) {
app := mcpApp(t)
r, h, err := AssembleRouter(app, []party.Plugin{dispatchPlugin{}})
if err != nil {
t.Fatal(err)
}
t.Cleanup(func() { _ = r.Close() })
if h == nil {
t.Fatal("nil handler")
}
methods := map[string]bool{}
for _, ri := range r.Routes() {
if ri.Pattern == "/mcp" {
methods[ri.Method] = true
}
}
for _, m := range []string{http.MethodPost, http.MethodGet, http.MethodDelete} {
if !methods[m] {
t.Fatalf("%s /mcp missing from the route table", m)
}
}
_, _ = r.AdminPrefix()
if p, ok := app.Lookup[*pier.Pier](); !ok || p == nil {
t.Fatal("*pier.Pier not published")
}
}
// TestRouterCloseStopsPierReaper: the router that mounted the MCP endpoint
// stops its session reaper on Close.
func TestRouterCloseStopsPierReaper(t *testing.T) {
baseline := runtime.NumGoroutine()
routers := make([]*Router, 0, 5)
for range 5 {
r, _, err := AssembleRouter(mcpApp(t), []party.Plugin{dispatchPlugin{}})
if err != nil {
t.Fatal(err)
}
routers = append(routers, r)
}
if n := runtime.NumGoroutine(); n < baseline+5 {
t.Fatalf("5 MCP routers raised goroutines from %d to %d, want at least +5", baseline, n)
}
for _, r := range routers {
if err := r.Close(); err != nil {
t.Fatal(err)
}
}
if n := waitGoroutines(baseline+2, 2*time.Second); n > baseline+2 {
t.Fatalf("goroutines = %d after closing 5 MCP routers, want at most %d", n, baseline+2)
}
if err := (*pier.Pier)(nil).Close(); err != nil {
t.Fatalf("nil Pier Close: %v", err)
}
p, ok := routers[0].app.Lookup[*pier.Pier]()
if !ok {
t.Fatal("*pier.Pier not published")
}
if err := p.Close(); err != nil {
t.Fatalf("second Close: %v", err)
}
}