summercms/.planning/phases/12.2-admin-form-fields-date-file-upload-relation-editing-with-def/12.2-REVIEW-DISPOSITION.md

phase, review, titles, findings, open, total, recorded

phase	review	titles	findings	open	total	recorded
12.2	12.2-REVIEW.md	json	id severity disposition title CR-01 critical fixed Form saves can commit before an in-flight upload reaches the deferred session id severity disposition title CR-02 critical fixed Aborted or network-failed uploads have no idempotency or reconciliation path id severity disposition title CR-03 critical fixed Core CRUD, settings, and relation mutation JSON bodies are uncapped id severity disposition title WR-01 warning fixed A field may advertise a maximum file size that its request cap cannot carry id severity disposition title WR-02 warning fixed Datetime picker bounds use local days while the server validates UTC days id severity disposition title WR-03 warning fixed Concurrent reorder requests can overwrite the latest order or create a mixed order id severity disposition title WR-04 warning fixed Pending pivot hydration discards type-conversion errors	0	7	2026-10-02T21:15:00Z

Phase 12.2: Code Review Disposition

Finding	Severity	Disposition	Source
CR-01	critical	fixed	516f9c9 — FormSession.beginUpload / activeUploads; FormView and RelationChildModal refuse save while uploads are in flight
CR-02	critical	fixed	516f9c9 — X-Upload-Id stored on DeferredEnvelope.UploadID; abort deletes a stored file; network loss adopts a single pending extra
CR-03	critical	fixed	516f9c9 — decodeCappedObject / decodeCappedRelationMutation / decodeCappedBulk + writeCRUDError maps MaxBytesError to 413
WR-01	warning	fixed	516f9c9 — boot rejects maxBytes + 64 KiB multipart overhead above upload_bytes
WR-02	warning	fixed	516f9c9 — datetime bounds are UTC-day instants projected into the local zone
WR-03	warning	fixed	516f9c9 — client serializes reorder (latest snapshot only); server locks visible files with FOR UPDATE
WR-04	warning	fixed	516f9c9 — ShowPivot and updatePendingPivot return lifecycleFailure on lagoon.Fill errors

Dispositions: open (recorded, not yet triaged), fixed, skipped, deferred. Set deferred by hand and put the reason in the Source cell; both are preserved. A | in the reason is kept as prose and escaped on the next run. Re-running the gate keeps every row it can. A row the current review no longer reports is kept and its Source cell flagged, so a finding does not leave this record silently. ONE exception: when a finding id is REUSED by a different finding, the earlier decision cannot keep a row — the id is taken — and it is dropped. A RECORDED decision (anything but open) is named on the console when that happens; a row still at open is replaced silently, because open records no decision to lose.