golem15/summercms
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
Files
bbceeb957f0988ea2cb129fcbb14d1206c2a18cb
summercms/.planning/phases/05-data-layer-full-fidelity/05-05-SUMMARY.md
Jakub Zych 62f3ae563f docs(05-05): complete remaining-models schema-diff fixture plan 
- Record Task 1-3 commits, D-02 allow-list, and DATA-11 fixture isolation
2026-09-18 20:26:41 +02:00

11 KiB
Raw Blame History

phase, plan, subsystem, tags, requires, provides, affects, tech-stack, key-files, key-decisions, patterns-established, requirements-completed, duration, completed
phase plan subsystem tags requires provides affects tech-stack key-files key-decisions patterns-established requirements-completed duration completed
05-data-layer-full-fidelity 05 database
gorm
gormigrate
schema-diff
gorm-callback
fixture-plugin
settings
phase provides
05-data-layer-full-fidelity Winter-directory registries, Album/Collection slice, secrets slice, system_files attach, lagoon.Migrate/RollbackLast
remaining 8 Fonoteka models and 7 gormigrate steps completing the 25-model schema
committed live-verified PHP schema snapshot and TestSchemaMatchesPHPSnapshot
test-only DATA-11 fixture plugin (Boot callback + companion column)
CLI-03 rollback isolation against the full production migration set
05-06-tests
06-http
07-user-plugin
12-api-parity
added patterns
dedicated golem15_fonoteka_settings singleton instead of Winter system_settings
PHP FK omissions on notifications/wishlist preserved verbatim
test-only plugin constructed in-process without party process-wide Register
D-02 schema-diff against a committed pg_dump with a commented allow-list
created modified
plugins/golem15/fonoteka/updates/20_remaining.go
plugins/golem15/fonoteka/models/collection_invitation.go
plugins/golem15/fonoteka/models/pending_invitation_registration.go
plugins/golem15/fonoteka/models/csv_import.go
plugins/golem15/fonoteka/models/csv_import_row.go
plugins/golem15/fonoteka/models/notification.go
plugins/golem15/fonoteka/models/wishlist_subscription.go
plugins/golem15/fonoteka/models/wishlist_digest_queue.go
plugins/golem15/fonoteka/models/settings.go
parity/testdata/php_schema_snapshot.sql
parity/schema_diff_test.go
parity/fixtureplugin/plugin.go
parity/fixtureplugin/migrations.go
parity/cross_plugin_callback_test.go
parity/rollback_isolation_full_test.go
parity/remaining_models_test.go
lagoon/validate.go
lagoon/validate_test.go
parity/migrate_test.go
Settings is golem15_fonoteka_settings singleton with typed search_use_typesense BOOLEAN (RESEARCH Open Question 2)
notifications/wishlist_subscriptions/wishlist_digest_queue have no FK on user_id/collection_id, matching PHP (Open Question 3 / T-05-18)
D-02 allow-list is settings table, users column-count (no widen_users), and the shipped extra oauth_refresh_tokens.user_id FK
Schema-diff type family normalizes varchar/text, timestamp/timestamptz, smallint/integer, json/text; nullability of shipped migrations is frozen (P3 D-17)
DATA-11 fixture plugin is test-only: no process-wide Register, not in app.PluginIDs or plugins.gen.go
One Register call per model/migration file init(); plugin.go is not edited
Test-only plugins live under parity/fixtureplugin and are constructed in the test, never blank-imported
D-02 snapshot is regenerated only via docker postgres:16-alpine + php artisan winter:up + pg_dump --schema-only --no-owner --no-privileges
DATA-09
DATA-11
CLI-03
18min 2026-09-18

Phase 5 Plan 05: Remaining models, D-02 schema-diff, DATA-11 fixture Summary

Eight remaining models plus dedicated settings complete the 25-model port; a live PHP pg_dump snapshot plus TestSchemaMatchesPHPSnapshot prove D-02; a test-only fixture plugin extends Album without editing models/album.go; RollbackLast isolation holds on the full schema

Performance

  • Duration: 18 min
  • Started: 2026-09-18T18:07:07Z
  • Completed: 2026-09-18T18:25:11Z
  • Tasks: 3
  • Files modified: 18

Accomplishments

  • Invitations, pending registrations, CSV import/rows, notifications, wishlist subscriptions/digest queue, and golem15_fonoteka_settings (singleton id=1) exist; notifications/wishlist tables have no FKs
  • lagoon.Validate accepts the Laravel boolean token as a type-check no-op for Settings.Rules()
  • Committed php_schema_snapshot.sql from php artisan winter:up on scratch postgres:16-alpine (Journal Typesense failure after Fonoteka/User materialized, matching RESEARCH); TestSchemaMatchesPHPSnapshot is green against a commented allow-list
  • Test-only parity.fixtureplugin registers a GORM create callback on models.Album and adds demo_extension_note via its own gormigrate set; production updates.All() and models/album.go never mention that column
  • TestRollbackIsolatesFonotekaFullSchema rolls back only create_fonoteka_settings; golem15.user history and table set stay byte-identical

Task Commits

Each task was committed atomically:

  1. Task 1: boolean validation token - 4df7e01 (feat) in summercms.go
  2. Task 1: remaining 8 models and migrations - 18225c5 (feat) in fonoteka.go
  3. Task 2: PHP snapshot + schema-diff test - ae701ca (feat) in fonoteka.go
  4. Task 3: fixture plugin + full-schema rollback isolation - 6c9695f (feat) in fonoteka.go

Plan metadata: pending (this file)

Files Created/Modified

  • lagoon/validate.go, lagoon/validate_test.go — boolean rule no-op
  • fonoteka.go/plugins/golem15/fonoteka/updates/20_remaining.go — seven migrations (invites through settings)
  • fonoteka.go/plugins/golem15/fonoteka/models/{collection_invitation,pending_invitation_registration,csv_import,csv_import_row,notification,wishlist_subscription,wishlist_digest_queue,settings}.go
  • fonoteka.go/parity/remaining_models_test.go, parity/migrate_test.go — up/down + ID-count updates
  • fonoteka.go/parity/testdata/php_schema_snapshot.sql — D-02 golden dump (29 tables)
  • fonoteka.go/parity/schema_diff_test.go — TestSchemaMatchesPHPSnapshot
  • fonoteka.go/parity/fixtureplugin/{plugin,migrations}.go — DATA-11 fixture
  • fonoteka.go/parity/cross_plugin_callback_test.go, parity/rollback_isolation_full_test.go

Decisions Made

  • Settings storage is a dedicated typed table with one seeded row, not Winter system_settings (Open Question 2)
  • No FK constraints on notifications / wishlist_subscriptions / wishlist_digest_queue (Open Question 3, T-05-18)
  • D-02 allow-list: Go-only settings table; users 57-vs-6 column gap (no widen_users); extra Go oauth_refresh_tokens.user_id FK from 05-03 (P3 D-17 freeze)
  • Type-family comparator (varchar/text, timestamp/timestamptz, int widths, json/text) plus skipped nullability for shipped migrations; non-unique Laravel auto-indexes are logged, unique/FK still fail-hard
  • DATA-11 demonstrated by a test-only plugin under parity/fixtureplugin, not loaded by production app.PluginIDs

Deviations from Plan

Auto-fixed Issues

1. [Rule 3 - Blocking] Existing migrate tests hardcoded 11 Fonoteka IDs

  • Found during: Task 1
  • Issue: TestMigrateSeedsCanonicalGenres, TestRollbackLastIsolatesFonoteka, TestAlbumSliceMigrationsUpDown, and TestSecretsSliceMigrationsUpDown assumed credentials were last
  • Fix: Expect 18 Fonoteka IDs; last rollback is settings; prepend seven drop steps; secrets test rolls remaining seven first
  • Files modified: fonoteka.go/parity/migrate_test.go
  • Verification: go test ./... in fonoteka.go
  • Committed in: 18225c5 (Task 1)

2. [Rule 3 - Blocking] Attach history table missing from expected list

  • Found during: Task 1 (TestMigrateSeedsCanonicalGenres)
  • Issue: 05-04 added summer_migrations_summercms_attach; the test still expected only user+fonoteka history tables
  • Fix: Include summer_migrations_summercms_attach in the ordered expected list
  • Files modified: fonoteka.go/parity/migrate_test.go
  • Verification: that test
  • Committed in: 18225c5 (Task 1)

3. [Rule 1 - Bug] Notification primary-key tag

  • Found during: Task 1
  • Issue: ID was tagged column:user_id instead of column:id;primaryKey
  • Fix: Correct tag before commit
  • Files modified: fonoteka.go/plugins/golem15/fonoteka/models/notification.go
  • Verification: go vet ./...
  • Committed in: 18225c5 (Task 1)

4. [Rule 3 - Blocking] Schema-diff type/nullability/index noise vs frozen shipped migrations

  • Found during: Task 2 (TestSchemaMatchesPHPSnapshot first run)
  • Issue: Laravel varchar/timestamp/smallint/json and nullable strings vs Go TEXT/TIMESTAMPTZ/INTEGER NOT NULL; extra Laravel auto-indexes; extra Go oauth_refresh_tokens.user_id FK from 05-03
  • Fix: Canon type families; do not fail on nullability; log non-unique indexes; allow-list the extra FK with a P3 D-17 comment. Column presence, unique constraints, and other FKs still fail-hard
  • Files modified: fonoteka.go/parity/schema_diff_test.go
  • Verification: go test ./parity/... -run TestSchemaMatchesPHPSnapshot
  • Committed in: ae701ca (Task 2)

5. [Rule 3 - Blocking] Acceptance grep for party.Register

  • Found during: Task 3
  • Issue: A comment containing party.Register would fail the required grep
  • Fix: Reword the comment
  • Files modified: fonoteka.go/parity/fixtureplugin/plugin.go
  • Verification: grep returns no matches
  • Committed in: 6c9695f (Task 3)

Total deviations: 5 auto-fixed (1 bug, 4 blocking) Impact on plan: Required for green existing tests, a useful D-02 comparator against frozen earlier-slice SQL, and the fixture grep gate. No scope creep. PHP snapshot generation failed at Journal Typesense as RESEARCH documented; Fonoteka/User/system_files were already materialized.

Issues Encountered

PHP winter:up against scratch Postgres 16 completed Golem15.User and Golem15.Fonoteka then failed in Golem15.Journal (Typesense 127.0.0.1:8181) — same as RESEARCH.md. Snapshot dumped after that point.

Authentication Gates

None.

Known Stubs

None that prevent this plan's goal. demo_extension_note exists only in the test-only fixture plugin.

User Setup Required

None - no external service configuration required.

Next Phase Readiness

Ready for 05-06 (phase-ending unit tests / fuzz / hidden-marshal / security review). All 25 models and production migrations exist; D-02 and DATA-11 proofs are in fonoteka.go/parity.

Self-Check: PASSED

  • Key files exist on disk (20_remaining.go, 8 models, php_schema_snapshot.sql, schema_diff_test.go, fixtureplugin, rollback_isolation_full_test.go)
  • Commits 4df7e01 (summercms.go), 18225c5, ae701ca, 6c9695f (fonoteka.go) exist
  • go vet ./... and go test ./... green in fonoteka.go
  • go vet ./lagoon/... green in summercms.go
  • grep REFERENCES on notifications/wishlist CREATE TABLE has no FK clauses
  • grep demo_extension_note on album.go and fonoteka updates has no matches
  • grep fixtureplugin on app.go/plugins.gen.go has no matches

Phase: 05-data-layer-full-fidelity Completed: 2026-09-18

Reference in New Issue View Git Blame Copy Permalink