Files
summercms/.planning/phases/20-demo-instance-with-every-shared-plugin/20-REVIEW-DISPOSITION.md
Jakub Zych 399efed845 docs(20): review disposition after the gap closure
- CR-01, CR-02, CR-03, WR-01, WR-04 and WR-05 fixed, with commits, tags
  and the live checks of release 195aa213c546
- WR-02, WR-03, WR-06 and IN-01 to IN-09 deferred, one todo each
2026-11-03 23:07:32 +01:00

4.8 KiB

phase, review, recorded, closed
phase review recorded closed
20-demo-instance-with-every-shared-plugin 20-REVIEW.md 2026-11-02 2026-11-03

Phase 20 review disposition

One row per finding in 20-REVIEW.md. fixed names the commits and the release tag and the check that confirmed it on the live demo (release 195aa213c546, deployed 2026-11-02 by plan 20-09); deferred points at the todo that tracks it. No row is open.

Finding Severity Disposition Note
CR-01 critical fixed Leaving or unmounting during start/join still connects and publishes camera and microphone. vue-chatvideo-layer 69e8b83, 27ad81c (v0.1.1): a per-attempt token with stale checks after every await; leave is final at any moment. Live: check-chat.cjs --call ok against demo.summercms.io.
CR-02 critical fixed Banned-link filter bypass through URL forms the browser normalises, rendered as working links. sm-moderation-plugin 266fc60, 9715ce7 (v0.1.1): link hosts and paths canonicalised like the URL parser; vue-chat-layer a798bb1 (v0.1.1): deceptive hosts render as text; sm-demo-app 262da37 (CheckHTML on the rendered forum post). Live: check-moderation.sh ok (fixed probe, sm-demo-app da481c9), every link form refused in chat, forum reply and thread title.
CR-03 critical fixed Banned-word filter bypass through invisible characters, Unicode spaces and forum Markdown. sm-moderation-plugin 266fc60, 9715ce7, 334697b (v0.1.1): words matched after NFKC, format characters, Unicode spaces, diacritics, entities and inline markup; MatchHTML/CheckHTML; sm-forum-plugin ec1a82c (v0.1.2): PostSaving.HTML; sm-demo-app 262da37 (listener checks the rendered post). Live: check-moderation.sh ok, every word form refused.
WR-01 warning fixed Logout leaves the chat store and the realtime socket of the previous user running. vue-demo-app 188ae25 (pinned in sm-demo-app 27c48cf with layers v0.1.1): logout and unauthorized reset the chat, close the realtime socket and dismiss the ring. Local: check-chat.cjs default mode, every /ws socket closed within 5 s of Log out (not run live: it posts in #general).
WR-02 warning deferred Any member can pin or unpin any message in every public channel; the message is not checked against the channel. Todo: .planning/todos/pending/chatchannels-pin-policy.md
WR-03 warning deferred Member-visible text outside the chat and forum seams is never moderated. Todo: .planning/todos/pending/moderation-profile-group-and-filenames.md
WR-04 warning fixed A link opens a call and turns the camera and microphone on with no confirmation. vue-chatvideo-layer 5386903 (v0.1.1): the call page asks before media unless the call button or Accept handed over; vue-demo-app 9a12701 (pins). Live: check-chat.cjs --call, a direct /call load showed the confirmation with no LiveKit socket, tile or session before the click.
WR-05 warning fixed A failed LiveKit connect posts leave, not end, leaving an empty ringing session behind. vue-chatvideo-layer 27ad81c (v0.1.1): a failed connect (or livekit-client import) ends a session nobody else joined, from GET status. Unit tests in useCall.test.ts; deployed with release 195aa213c546.
WR-06 warning deferred The forum and friends clients have no 401 refresh; an expired token shows "not found". Todo: .planning/todos/pending/forum-friends-client-401-refresh.md
IN-01 info deferred Group calls in public channels are blocked only by the seeded participant count. Todo: .planning/todos/pending/chatvideo-dm-only-host-hook.md
IN-02 info deferred chatvideo checks participant rows, not live membership. Todo: .planning/todos/pending/chatvideo-live-membership.md
IN-03 info deferred check-local passes member JWTs to curl in argv. Todo: .planning/todos/pending/check-local-jwt-out-of-argv.md
IN-04 info deferred A chat message that starts with "/" can never be posted. Todo: .planning/todos/pending/chat-slash-text-escape.md
IN-05 info deferred demo:seed brings back the default moderation lists after an admin empties them. Todo: .planning/todos/pending/demo-seed-moderation-lists-once.md
IN-06 info deferred nginx /livekit/ exposes LiveKit's whole HTTP surface. Todo: .planning/todos/pending/demo-nginx-livekit-rtc-only.md
IN-07 info deferred The incoming-call runtime can leak a session handle and survives logout. The logout half was fixed by 20-08 (vue-demo-app 188ae25); the handle leak remains. Todo: .planning/todos/pending/chatvideo-incoming-handle-leak.md
IN-08 info deferred The VAPID runbook pipeline runs without pipefail. Todo: .planning/todos/pending/demo-vapid-runbook-pipefail.md
IN-09 info deferred GET /chat/members writes, and builds an unbounded IN list. Todo: .planning/todos/pending/demo-chat-members-read-only.md