Files
summercms/admin/tests/app/router.test.ts
Jakub Zych 1e00ed3d3e test(32.2-05): admin SPA tests for the consent screen, login hint and My account item rows
- ConnectView.test.ts: every C1 state, the * rule, no auto-allow, Allow and
  Deny bodies through window.location.assign, forbidden schemes, switch
  account, 401/404 handling, focus and the profile fallback
- router, LoginView and AccountContributions tests extended for /connect,
  the login hint and item rows (null items unchanged, empty block, :title
  confirm, 404 item_gone, 409 action_stale)
2026-11-21 02:00:16 +01:00

224 lines
9.6 KiB
TypeScript

import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest'
import { createMemoryHistory } from 'vue-router'
import { activateStyles, loadStyles } from '../../src/app/pluginAssets'
import { createAdminRouter, routeControllerId, safeRedirect } from '../../src/app/router'
import { setNavigation } from '../../src/state/useNavigation'
import { navigationFixture } from '../fixtures/typed'
import { mockApi, resetState, routerAt, signIn } from '../helpers'
beforeEach(() => {
resetState()
})
describe('safeRedirect', () => {
it('accepts in-app paths with exactly one leading slash', () => {
expect(safeRedirect('/acme/demo/widgets')).toBe('/acme/demo/widgets')
expect(safeRedirect('/acme/demo/widgets/1?tab=2#x')).toBe('/acme/demo/widgets/1?tab=2#x')
expect(safeRedirect('/')).toBe('/')
})
it.each([
['protocol-relative', '//evil.example/x'],
['backslash protocol-relative', '/\\evil.example'],
['absolute http', 'http://evil.example/'],
['absolute https', 'https://evil.example/'],
['javascript', 'javascript:alert(1)'],
['relative', 'acme/demo'],
['empty', ''],
])('rejects a %s value', (_label, value) => {
expect(safeRedirect(value)).toBeNull()
})
it('rejects non-string values', () => {
expect(safeRedirect(undefined)).toBeNull()
expect(safeRedirect(null)).toBeNull()
expect(safeRedirect(['/a'])).toBeNull()
expect(safeRedirect(1)).toBeNull()
})
})
describe('route guard', () => {
it('sends a visitor without a session to login with the requested path', async () => {
const router = await routerAt('/acme/demo/widgets/3?x=1')
expect(router.currentRoute.value.name).toBe('login')
expect(router.currentRoute.value.query.redirect).toBe('/acme/demo/widgets/3?x=1')
})
it('lets a visitor open the login screen', async () => {
const router = await routerAt('/login')
expect(router.currentRoute.value.name).toBe('login')
})
it('moves a signed-in admin away from login to a safe redirect', async () => {
await signIn()
const router = await routerAt('/login?redirect=/acme/demo/gadgets')
expect(router.currentRoute.value.fullPath).toBe('/acme/demo/gadgets')
})
it.each(['//evil.example/x', 'https://evil.example/', '/\\evil'])(
'ignores the unsafe redirect %j and goes home',
async (redirect) => {
await signIn()
setNavigation(navigationFixture.data)
const router = createAdminRouter(createMemoryHistory())
await router.push({ path: '/login', query: { redirect } })
expect(router.currentRoute.value.fullPath).toBe('/acme/demo/widgets')
},
)
it('lands home on the first permitted controller, or on the empty page without navigation', async () => {
await signIn()
setNavigation(navigationFixture.data)
expect((await routerAt('/')).currentRoute.value.fullPath).toBe('/acme/demo/widgets')
setNavigation([])
const empty = await routerAt('/')
expect(empty.currentRoute.value.name).toBe('home')
})
it('names the list, create, record, settings and not-found routes', async () => {
await signIn()
const cases: Array<[string, string]> = [
['/acme/demo/widgets', 'list'],
['/acme/demo/widgets/create', 'create'],
['/acme/demo/widgets/12', 'record'],
['/acme/demo/widgets/abc', 'not-found'],
['/settings', 'settings'],
['/settings/mail', 'settings-form'],
['/nowhere', 'not-found'],
]
for (const [path, name] of cases) {
const router = await routerAt(path)
expect(router.currentRoute.value.name, path).toBe(name)
expect(router.currentRoute.value.meta.shell, path).toBe(true)
}
expect((await routerAt('/acme/demo/widgets/12')).currentRoute.value.params.id).toBe('12')
})
})
describe('plugin stylesheets follow the route (D-16, T-10.1-16)', () => {
let links: HTMLLinkElement[]
beforeEach(() => {
links = []
const head = document.head
const append = head.appendChild.bind(head)
vi.spyOn(head, 'appendChild').mockImplementation(<T extends Node>(node: T): T => {
if (node instanceof HTMLLinkElement) {
links.push(node)
return node
}
return append(node)
})
})
afterEach(() => {
vi.restoreAllMocks()
activateStyles('')
})
const enabled = () => links.filter((link) => !link.disabled).map((link) => link.getAttribute('data-summer-controller'))
it('names the controller of list, create and record routes only', async () => {
await signIn()
expect(routeControllerId((await routerAt('/acme/demo/widgets')).currentRoute.value)).toBe('acme.demo.widgets')
expect(routeControllerId((await routerAt('/acme/demo/widgets/create')).currentRoute.value)).toBe('acme.demo.widgets')
expect(routeControllerId((await routerAt('/acme/demo/widgets/12')).currentRoute.value)).toBe('acme.demo.widgets')
for (const path of ['/settings', '/settings/mail', '/nowhere', '/acme/demo/widgets/abc']) {
expect(routeControllerId((await routerAt(path)).currentRoute.value), path).toBe('')
}
expect(routeControllerId((await routerAt('/login')).currentRoute.value)).toBe('')
})
it('disables every plugin stylesheet on screens that are not controller views', async () => {
await signIn()
loadStyles('acme.demo.widgets', ['/admin-test/assets/acme/demo/css/route-widgets.css'])
loadStyles('acme.demo.gadgets', ['/admin-test/assets/acme/demo/css/route-gadgets.css'])
const router = await routerAt('/acme/demo/widgets')
expect(enabled()).toEqual(['acme.demo.widgets'])
for (const path of ['/settings', '/settings/mail', '/nowhere']) {
await router.push(path)
expect(enabled(), path).toEqual([])
}
await router.push('/acme/demo/gadgets/create')
expect(enabled()).toEqual(['acme.demo.gadgets'])
// Opening another controller whose schema has not arrived yet already
// hides the previous controller's stylesheets.
await router.push('/acme/demo/sprockets')
expect(enabled()).toEqual([])
})
})
describe('preview route (UI-SPEC S3, D-11)', () => {
it('names the preview route for a numeric id only and keeps it inside the shell', async () => {
await signIn()
const preview = await routerAt('/acme/demo/widgets/12/preview')
expect(preview.currentRoute.value.name).toBe('preview')
expect(preview.currentRoute.value.params).toMatchObject({ vendor: 'acme', plugin: 'demo', controller: 'widgets', id: '12' })
expect(preview.currentRoute.value.meta.shell).toBe(true)
for (const path of ['/acme/demo/widgets/abc/preview', '/acme/demo/widgets/1e3/preview', '/acme/demo/widgets/12/preview/extra', '/acme/demo/widgets/-1/preview']) {
expect((await routerAt(path)).currentRoute.value.name, path).toBe('not-found')
}
})
it('counts preview among the controller routes, so plugin assets follow it', async () => {
await signIn()
// CONTROLLER_ROUTES holds list, create, record and preview: each of them
// answers its controller id, and no other route does.
for (const path of ['/acme/demo/widgets', '/acme/demo/widgets/create', '/acme/demo/widgets/12', '/acme/demo/widgets/12/preview']) {
expect(routeControllerId((await routerAt(path)).currentRoute.value), path).toBe('acme.demo.widgets')
}
for (const path of ['/settings', '/settings/mail', '/nowhere', '/acme/demo/widgets/abc/preview']) {
expect(routeControllerId((await routerAt(path)).currentRoute.value), path).toBeFalsy()
}
})
it('requires a signed-in admin for the preview route and returns to it after login', async () => {
mockApi({})
const router = createAdminRouter(createMemoryHistory())
await router.push('/acme/demo/widgets/12/preview')
expect(router.currentRoute.value.name).toBe('login')
expect(router.currentRoute.value.query.redirect).toBe('/acme/demo/widgets/12/preview')
expect(safeRedirect(router.currentRoute.value.query.redirect)).toBe('/acme/demo/widgets/12/preview')
})
})
describe('connect route (32.2 UI-SPEC C1)', () => {
it('sends an anonymous visitor of /connect to login with the request and returns there after sign-in', async () => {
mockApi({})
const router = createAdminRouter(createMemoryHistory())
await router.push('/connect?request=x')
expect(router.currentRoute.value.name).toBe('login')
expect(router.currentRoute.value.query.redirect).toBe('/connect?request=x')
expect(safeRedirect(router.currentRoute.value.query.redirect)).toBe('/connect?request=x')
// Signed in, the login screen of that redirect moves on to /connect.
await signIn()
const back = createAdminRouter(createMemoryHistory())
await back.push({ path: '/login', query: { redirect: router.currentRoute.value.query.redirect } })
expect(back.currentRoute.value.name).toBe('connect')
expect(back.currentRoute.value.fullPath).toBe('/connect?request=x')
expect(back.currentRoute.value.query.request).toBe('x')
})
it('is a standalone route that is neither public nor inside the shell', async () => {
await signIn()
const router = await routerAt('/connect?request=abc')
expect(router.currentRoute.value.name).toBe('connect')
expect(router.currentRoute.value.meta.shell).toBeFalsy()
expect(router.currentRoute.value.meta.public).toBeFalsy()
expect(routeControllerId(router.currentRoute.value)).toBe('')
})
it('keeps an encoded request id through the login redirect', async () => {
mockApi({})
const router = createAdminRouter(createMemoryHistory())
await router.push({ path: '/connect', query: { request: 'a b/c' } })
const redirect = router.currentRoute.value.query.redirect
expect(router.currentRoute.value.name).toBe('login')
expect(safeRedirect(redirect)).toBe(redirect)
expect(new URL(String(redirect), 'http://admin.invalid').searchParams.get('request')).toBe('a b/c')
})
})