1.0 KiB
1.0 KiB
Phase 18 deferred items
Out-of-scope findings recorded during execution. They are not fixed in this phase.
18-07 (unit tests)
cart.RegisterDetailsParamshas no reader (sm-paymentgateway-plugin). The function stores a typed parameter set inparamTypes, and its doc says a row whoseparameterscarry"_type": namedecodes into the registered struct. Nothing readsparamTypes:decodeParametersalways returns a map. No plugin or application callsRegisterDetailsParamstoday. Making typed details parameters work meansDetailshas to hold a struct beside its map, which is a design decision rather than a test-exposed bug. There are two options for a later phase: implement the typed decode, or drop the function and its README mention.TestCartRegistrypins what exists now: the allowlist, duplicate names, the nil constructor, and a_typein a row stays plain data.- gofmt in sm-paymentgateway-plugin.
mail_smoke_test.go(from plan 04) is not gofmt-clean. 18-05 noted this too. It is left untouched.