Files
summercms/.planning/phases/19.3-framework-transport-and-infrastructure-for-wavepath/deferred-items.md

3.8 KiB

Phase 19.3 deferred items

Out-of-scope findings logged by executors. Not fixed in the plan that found them.

From 19.3-03

  • internal/build/registry.go is not gofmt-clean (const block alignment, registryFileName / generatedMark). Pre-existing, untouched by 19.3-03; go vet is unaffected.
  • The 19.3-03 Task 3 acceptance grep grep -rniE 'wavepath|fonoteka|grzyby' modules/lagoon ... matches pre-existing test files outside the plan's scope: modules/lagoon/hidden_marshal_test.go (comments naming the consumer app), modules/lagoon/migrations_test.go (golem15.fonoteka as a sample plugin ID) and modules/lagoon/attach/lifecycle_test.go (Golem15\Fonoteka\Models\Album morph type). CLAUDE.md says framework code never names a consuming application; a follow-up quick task could switch these to neutral names (acme). 19.3-03 added no such names.

From 19.3-04

  • Pre-existing gofmt findings (missing trailing newlines), untouched by 19.3-04: modules/cabana/account_tokens.go, modules/cabana/account_tokens_test.go, modules/cabana/token_postgres_smoke_test.go, modules/cabana/token_routes_test.go, modules/cabana/token_scopes_test.go, and in the Journal plugin classes/blog_editor_test.go. go vet and the suites are unaffected.
  • Deployment follow-up: move the grzybyfunkcjonalne deployment from golem15.journal.site_cache.* and NUXT_JOURNAL_CACHE_PURGE_TOKEN to site_cache.purge_url/site_cache.purge_token and NUXT_SITE_CACHE_PURGE_TOKEN (route /api/__site__/cache/purge) before the Journal alias keys are removed.
  • sm-summercmsio-app mounts the Journal plugin 45 commits behind main; bump its pointer in a separate follow-up.

From 19.3-05

  • Security observation (not a test failure; plan 03 kept the stored content_type rule by design): attach.Store writes the blob with the sniffed content type as object metadata, so an HTML body uploaded as note.txt is stored as <id>.txt with Content-Type: text/html, and a generic sniff takes the type from the extension (app.js with binary bytes is stored as .bin with text/javascript). The surf uploads route neutralises this (nosniff, sandbox CSP, attachment disposition), but with storage.uploads.public_url pointing at an S3 bucket the bucket serves the object's stored Content-Type directly, so such a file renders as HTML on the bucket or CDN host. docs/services/storage.md's deploy note says a CDN "picks the Content-Type from the file extension", which is not true for S3 object metadata. A follow-up could write a non-rendering content type (or Content-Disposition: attachment) for non-inline types to the blob metadata, and correct the deploy note. Pinned by TestStoreDiskExtension rows "html named txt" and "js under octet-stream".
  • Redis outage latency (follow-up from 19.3-01 now pinned by tests): TestRateLimitFallbackOnError asserts a rate-limit attempt against a stopped Redis answers from the fallback within AttemptTimeout (about 500 ms per throttled request during an outage). Cache.Remember on the Redis driver has no internal bound: against a stopped Redis it waits for go-redis's dial retries (about 1.7 s, five dial attempts) unless the caller's context has a deadline, and go-redis logs failed to dial after 5 attempts to stderr on every failing call, outside slog and the once-per-minute warner. A follow-up could bound Remember's read and write (as Attempt does), lower MaxRetries/dial timeout in OpenRedis, and route go-redis's logger through slog.
  • Coverage note: the plugins' purgeSiteCache branch "inside a save transaction but no purger configured" cannot be reached from a unit test, because cabana has no exported way to put a transaction in a context (withTx is internal). The plugins' Docker admin suites run every save through it without purge keys; a test-only helper in cabana (like cabana.WithFieldWrites) would let a unit test reach it.