3.8 KiB
3.8 KiB
Phase 19.3 deferred items
Out-of-scope findings logged by executors. Not fixed in the plan that found them.
From 19.3-03
internal/build/registry.gois not gofmt-clean (const block alignment,registryFileName/generatedMark). Pre-existing, untouched by 19.3-03;go vetis unaffected.- The 19.3-03 Task 3 acceptance grep
grep -rniE 'wavepath|fonoteka|grzyby' modules/lagoon ...matches pre-existing test files outside the plan's scope:modules/lagoon/hidden_marshal_test.go(comments naming the consumer app),modules/lagoon/migrations_test.go(golem15.fonotekaas a sample plugin ID) andmodules/lagoon/attach/lifecycle_test.go(Golem15\Fonoteka\Models\Albummorph type). CLAUDE.md says framework code never names a consuming application; a follow-up quick task could switch these to neutral names (acme). 19.3-03 added no such names.
From 19.3-04
- Pre-existing gofmt findings (missing trailing newlines), untouched by 19.3-04:
modules/cabana/account_tokens.go,modules/cabana/account_tokens_test.go,modules/cabana/token_postgres_smoke_test.go,modules/cabana/token_routes_test.go,modules/cabana/token_scopes_test.go, and in the Journal pluginclasses/blog_editor_test.go.go vetand the suites are unaffected. - Deployment follow-up: move the grzybyfunkcjonalne deployment from
golem15.journal.site_cache.*andNUXT_JOURNAL_CACHE_PURGE_TOKENtosite_cache.purge_url/site_cache.purge_tokenandNUXT_SITE_CACHE_PURGE_TOKEN(route/api/__site__/cache/purge) before the Journal alias keys are removed. sm-summercmsio-appmounts the Journal plugin 45 commits behind main; bump its pointer in a separate follow-up.
From 19.3-05
- Security observation (not a test failure; plan 03 kept the stored
content_typerule by design):attach.Storewrites the blob with the sniffed content type as object metadata, so an HTML body uploaded asnote.txtis stored as<id>.txtwithContent-Type: text/html, and a generic sniff takes the type from the extension (app.jswith binary bytes is stored as.binwithtext/javascript). The surf uploads route neutralises this (nosniff, sandbox CSP, attachment disposition), but withstorage.uploads.public_urlpointing at an S3 bucket the bucket serves the object's stored Content-Type directly, so such a file renders as HTML on the bucket or CDN host.docs/services/storage.md's deploy note says a CDN "picks the Content-Type from the file extension", which is not true for S3 object metadata. A follow-up could write a non-rendering content type (orContent-Disposition: attachment) for non-inline types to the blob metadata, and correct the deploy note. Pinned byTestStoreDiskExtensionrows "html named txt" and "js under octet-stream". - Redis outage latency (follow-up from 19.3-01 now pinned by tests):
TestRateLimitFallbackOnErrorasserts a rate-limit attempt against a stopped Redis answers from the fallback withinAttemptTimeout(about 500 ms per throttled request during an outage).Cache.Rememberon the Redis driver has no internal bound: against a stopped Redis it waits for go-redis's dial retries (about 1.7 s, five dial attempts) unless the caller's context has a deadline, and go-redis logsfailed to dial after 5 attemptsto stderr on every failing call, outside slog and the once-per-minute warner. A follow-up could bound Remember's read and write (as Attempt does), lowerMaxRetries/dial timeout inOpenRedis, and route go-redis's logger through slog. - Coverage note: the plugins'
purgeSiteCachebranch "inside a save transaction but no purger configured" cannot be reached from a unit test, because cabana has no exported way to put a transaction in a context (withTxis internal). The plugins' Docker admin suites run every save through it without purge keys; a test-only helper in cabana (likecabana.WithFieldWrites) would let a unit test reach it.