- 19.6.1-VALIDATION.md: per-task map green, Wave 0 ticked with the files as built, wave_0_complete true - deferred-items.md: lagoon's model validator skips string min/max; granted does not expand a held leading wildcard
1.2 KiB
1.2 KiB
Deferred items: Phase 19.6.1
Out-of-scope findings logged during execution. Not fixed in this phase.
From 19.6.1-03 (tests)
- lagoon: the model validator does not apply string
min/max.lagoon.Validate(modules/lagoon/validate.go) collectsmin=/max=tags for non-numeric rules and then skips them, so a model orpact.FormRulesrule such asmin:4ormax:255on a string never refuses a value (onlybetweenis checked by length). The request validator (validate_request.go) handles them. Found because the Administrators form'spasswordrulemin:4let a 3-character password through; 19.6.1-03 fixed that one rule locally inusersAdmin.storePassword(commit461cb21). The lagoon fix changes behaviour for every model with string length rules (an over-longlogincurrently reaches Postgres and fails as a 500 instead of a 422), so it needs its own change and a check of the consuming applications. - cabana:
granteddoes not expand a held leading wildcard. A holder grant*.managedoes not grantacme.manage(grantedin contracts.go only expands held trailing wildcards). Pre-existing; WinterCMS parity unverified. TestRoleCeiling does not pin either behaviour.