Files
summercms/.planning/phases/19.6.1-backend-administrators-screen/deferred-items.md
Jakub Zych 8f3d625943 docs(19.6.1-03): validation map and deferred items
- 19.6.1-VALIDATION.md: per-task map green, Wave 0 ticked with the files
  as built, wave_0_complete true
- deferred-items.md: lagoon's model validator skips string min/max;
  granted does not expand a held leading wildcard
2026-10-22 12:24:35 +02:00

1.2 KiB

Deferred items: Phase 19.6.1

Out-of-scope findings logged during execution. Not fixed in this phase.

From 19.6.1-03 (tests)

  • lagoon: the model validator does not apply string min/max. lagoon.Validate (modules/lagoon/validate.go) collects min=/max= tags for non-numeric rules and then skips them, so a model or pact.FormRules rule such as min:4 or max:255 on a string never refuses a value (only between is checked by length). The request validator (validate_request.go) handles them. Found because the Administrators form's password rule min:4 let a 3-character password through; 19.6.1-03 fixed that one rule locally in usersAdmin.storePassword (commit 461cb21). The lagoon fix changes behaviour for every model with string length rules (an over-long login currently reaches Postgres and fails as a 500 instead of a 422), so it needs its own change and a check of the consuming applications.
  • cabana: granted does not expand a held leading wildcard. A holder grant *.manage does not grant acme.manage (granted in contracts.go only expands held trailing wildcards). Pre-existing; WinterCMS parity unverified. TestRoleCeiling does not pin either behaviour.