fix(3584): runtime-aware slash formatter for user-facing emissions
Introduce `runtime-slash.cjs` as the single source of truth for emitting GSD slash-command references in user-facing runtime output and persisted artifacts. `formatGsdSlash(commandName, runtime)` produces `/gsd-<cmd>` for skills-based runtimes (Claude/Cursor/OpenCode/Kilo/etc.) and `$gsd-<cmd>` for Codex. The deprecated `/gsd:<cmd>` colon form is never emitted — pasting a recommended-action command into Claude Code now routes correctly instead of failing with `Unknown command`. Wired into the high-impact emitters identified in #3584: - `init.cjs` `cmdInitManager` recommended_actions[].command (the original failure path in the bug report) plus the no-ROADMAP / no-STATE error hints. - `phase.cjs` `cmdPhaseAdd`, `cmdPhaseAddBatch`, `cmdPhaseInsert` — ROADMAP.md `Plans:` references now persist the routable form instead of the legacy colon form. - `verify.cjs` `cmdValidateHealth` — every fix-hint addIssue() call (E001/E002/E003/E004/E005, W002/W003/W008/W009/W011/W016/W018) and the persisted STATE.md regenerate / MILESTONES.md backfill notes. - `milestone.cjs` `cmdMilestoneComplete` — Operator Next Steps tail rewrite. - `validate-command-router.cjs` — `validate context` recommendation strings for WARNING/CRITICAL utilization bands. - `workstream.cjs` — missing .planning hint. - `profile-output.cjs` — `generate-claude-md` workflow enforcement block, project/skills fallbacks, profile placeholder, and the dev-preferences refresh hints. - `drift.cjs`, `gsd2-import.cjs`, `commands.cjs scaffold context` — remaining one-off persisted references. Runtime detection: `resolveRuntime(projectDir)` reads `process.env.GSD_RUNTIME` first, then a side-effect-free direct read of `.planning/config.json` (NOT `loadConfig`, which would normalize legacy keys and re-write the file just to read the runtime name). Tests: - `tests/bug-3584-runtime-slash-formatter.test.cjs` — 22 unit tests covering the pure formatter and resolver (hyphen vs codex, prefix normalization, defensive returns, env/config/default chain). - `tests/bug-3584-runtime-slash-emitters.test.cjs` — 6 integration tests exercising `init manager`, `phase add` (via the structured `roadmap get-phase` payload to avoid raw-text matching on the on-disk artifact), `validate health`, `validate context`, and the codex variant. - Existing tests updated to assert the new contract: validate-context recommendations, claude-md workflow block, milestone complete Operator Next Steps. Copilot-install engine-conversion test now asserts against a synthetic input since bin/lib/*.cjs no longer contains literal `/gsd:` references for the install-time converter to rewrite. INVENTORY.md and INVENTORY-MANIFEST.json updated for the new module (64 CLI modules shipped, +1). Fixes #3584 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
5
.changeset/lively-foxes-roam.md
Normal file
5
.changeset/lively-foxes-roam.md
Normal file
@@ -0,0 +1,5 @@
|
||||
---
|
||||
type: Fixed
|
||||
pr: 3584
|
||||
---
|
||||
**Runtime emitters now produce routable slash-command form** — `init manager` recommended actions, `phase add/insert` ROADMAP entries, `validate health` fix hints, `milestone complete` Operator Next Steps, `validate context` warnings, and `generate-claude-md` workflow blocks now emit `/gsd-<cmd>` for skills-based runtimes (Claude/Cursor/OpenCode/Kilo/etc.) and `$gsd-<cmd>` for Codex. The deprecated `/gsd:<cmd>` colon form is no longer emitted — pasting a recommended-action command into Claude Code now routes successfully instead of failing with "Unknown command".
|
||||
@@ -303,6 +303,7 @@
|
||||
"roadmap-command-router.cjs",
|
||||
"roadmap.cjs",
|
||||
"runtime-homes.cjs",
|
||||
"runtime-slash.cjs",
|
||||
"schema-detect.cjs",
|
||||
"secrets.cjs",
|
||||
"security.cjs",
|
||||
|
||||
@@ -361,7 +361,7 @@ The `gsd-planner` agent is decomposed into a core agent plus reference modules t
|
||||
|
||||
---
|
||||
|
||||
## CLI Modules (63 shipped)
|
||||
## CLI Modules (64 shipped)
|
||||
|
||||
Full listing: `get-shit-done/bin/lib/*.cjs`.
|
||||
|
||||
@@ -411,6 +411,7 @@ Full listing: `get-shit-done/bin/lib/*.cjs`.
|
||||
| `roadmap-command-router.cjs` | Thin CJS subcommand router adapter for `gsd-tools roadmap` |
|
||||
| `roadmap.cjs` | ROADMAP.md parsing, phase extraction, plan progress |
|
||||
| `runtime-homes.cjs` | Canonical runtime → global config/skills directory mapping; first-class support for all 15 runtimes including Hermes nested layout and Cline rules-based exclusion (#3126) |
|
||||
| `runtime-slash.cjs` | Runtime-aware slash-command formatter — single source of truth for emitting `/gsd-<cmd>` (skills-based runtimes) and `$gsd-<cmd>` (codex) in user-facing output and persisted artifacts (#3584) |
|
||||
| `schema-detect.cjs` | Schema-drift detection for ORM patterns (Prisma, Drizzle, etc.) |
|
||||
| `secrets.cjs` | Secret-config masking convention (`****<last-4>`) for integration keys managed by `/gsd-config --integrations` — keeps plaintext out of `config-set` output |
|
||||
| `security.cjs` | Path traversal prevention, prompt injection detection, safe JSON/shell helpers |
|
||||
|
||||
@@ -8,6 +8,7 @@ const { loadConfig, isGitIgnored, normalizePhaseName, comparePhaseNum, getArchiv
|
||||
const { planningDir, planningPaths } = require('./planning-workspace.cjs');
|
||||
const { extractFrontmatter } = require('./frontmatter.cjs');
|
||||
const { MODEL_PROFILES } = require('./model-profiles.cjs');
|
||||
const { formatGsdSlash, resolveRuntime } = require('./runtime-slash.cjs');
|
||||
|
||||
/**
|
||||
* Determine phase status by checking plan/summary counts AND verification state.
|
||||
@@ -779,7 +780,7 @@ function cmdScaffold(cwd, type, options, raw) {
|
||||
switch (type) {
|
||||
case 'context': {
|
||||
filePath = path.join(phaseDir, `${padded}-CONTEXT.md`);
|
||||
content = `---\nphase: "${padded}"\nname: "${name || phaseInfo?.phase_name || 'Unnamed'}"\ncreated: ${today}\n---\n\n# Phase ${phase}: ${name || phaseInfo?.phase_name || 'Unnamed'} — Context\n\n## Decisions\n\n_Decisions will be captured during /gsd:discuss-phase ${phase}_\n\n## Discretion Areas\n\n_Areas where the executor can use judgment_\n\n## Deferred Ideas\n\n_Ideas to consider later_\n`;
|
||||
content = `---\nphase: "${padded}"\nname: "${name || phaseInfo?.phase_name || 'Unnamed'}"\ncreated: ${today}\n---\n\n# Phase ${phase}: ${name || phaseInfo?.phase_name || 'Unnamed'} — Context\n\n## Decisions\n\n_Decisions will be captured during ${formatGsdSlash('discuss-phase', resolveRuntime(cwd))} ${phase}_\n\n## Discretion Areas\n\n_Areas where the executor can use judgment_\n\n## Deferred Ideas\n\n_Ideas to consider later_\n`;
|
||||
break;
|
||||
}
|
||||
case 'uat': {
|
||||
|
||||
@@ -253,8 +253,10 @@ function buildMessage(elements, affectedPaths, action) {
|
||||
if (action === 'auto-remap') {
|
||||
lines.push(`Auto-remap scheduled for paths: ${affectedPaths.join(', ')}`);
|
||||
} else {
|
||||
const { formatGsdSlash, resolveRuntime } = require('./runtime-slash.cjs');
|
||||
const mapCmd = formatGsdSlash('map-codebase', resolveRuntime(null));
|
||||
lines.push(
|
||||
`Run /gsd:map-codebase --paths ${affectedPaths.join(',')} to refresh planning context.`,
|
||||
`Run ${mapCmd} --paths ${affectedPaths.join(',')} to refresh planning context.`,
|
||||
);
|
||||
}
|
||||
return lines.join('\n');
|
||||
|
||||
@@ -421,7 +421,8 @@ function buildPreview(gsd2Data, artifacts) {
|
||||
lines.push('');
|
||||
lines.push('Cannot migrate automatically:');
|
||||
lines.push(' - GSD-2 cost/token ledger (no v1 equivalent)');
|
||||
lines.push(' - GSD-2 database state (rebuilt from files on first /gsd:health)');
|
||||
const { formatGsdSlash, resolveRuntime } = require('./runtime-slash.cjs');
|
||||
lines.push(` - GSD-2 database state (rebuilt from files on first ${formatGsdSlash('health', resolveRuntime(null))})`);
|
||||
lines.push(' - VS Code extension state');
|
||||
|
||||
return lines.join('\n');
|
||||
|
||||
@@ -10,6 +10,7 @@ const { planningPaths, planningDir, planningRoot } = require('./planning-workspa
|
||||
const { maskIfSecret } = require('./secrets.cjs');
|
||||
const scanPhasePlans = require('./plan-scan.cjs');
|
||||
const { stateExtractField } = require('./state-document.cjs');
|
||||
const { formatGsdSlash, resolveRuntime } = require('./runtime-slash.cjs');
|
||||
|
||||
// Accept all bold/colon variants of the Requirements header (#2769):
|
||||
// **Requirements:** / **Requirements**: / **Requirements** : render the
|
||||
@@ -1055,16 +1056,20 @@ function cmdInitMapCodebase(cwd, raw) {
|
||||
function cmdInitManager(cwd, raw) {
|
||||
const config = loadConfig(cwd);
|
||||
const milestone = getMilestoneInfo(cwd);
|
||||
// Resolve the runtime once so every emitted slash-command reference uses
|
||||
// the routable shape for this install (#3584). Hyphen form for skills-based
|
||||
// runtimes, $gsd-<cmd> shell-var for codex.
|
||||
const _slashRuntime = resolveRuntime(cwd);
|
||||
|
||||
// Use planningPaths for forward-compatibility with workstream scoping (#1268)
|
||||
const paths = planningPaths(cwd);
|
||||
|
||||
// Validate prerequisites
|
||||
if (!fs.existsSync(paths.roadmap)) {
|
||||
error('No ROADMAP.md found. Run /gsd:new-milestone first.');
|
||||
error(`No ROADMAP.md found. Run ${formatGsdSlash('new-milestone', _slashRuntime)} first.`);
|
||||
}
|
||||
if (!fs.existsSync(paths.state)) {
|
||||
error('No STATE.md found. Run /gsd:new-milestone first.');
|
||||
error(`No STATE.md found. Run ${formatGsdSlash('new-milestone', _slashRuntime)} first.`);
|
||||
}
|
||||
const rawContent = fs.readFileSync(paths.roadmap, 'utf-8');
|
||||
const content = extractCurrentMilestone(rawContent, cwd);
|
||||
@@ -1244,7 +1249,7 @@ function cmdInitManager(cwd, raw) {
|
||||
phase_name: phase.name,
|
||||
action: 'execute',
|
||||
reason: `${phase.plan_count} plans ready, dependencies met`,
|
||||
command: `/gsd:execute-phase ${phase.number}`,
|
||||
command: `${formatGsdSlash('execute-phase', _slashRuntime)} ${phase.number}`,
|
||||
});
|
||||
} else if (phase.disk_status === 'discussed' || phase.disk_status === 'researched') {
|
||||
recommendedActions.push({
|
||||
@@ -1252,7 +1257,7 @@ function cmdInitManager(cwd, raw) {
|
||||
phase_name: phase.name,
|
||||
action: 'plan',
|
||||
reason: 'Context gathered, ready for planning',
|
||||
command: `/gsd:plan-phase ${phase.number}`,
|
||||
command: `${formatGsdSlash('plan-phase', _slashRuntime)} ${phase.number}`,
|
||||
});
|
||||
} else if ((phase.disk_status === 'empty' || phase.disk_status === 'no_directory') && phase.is_next_to_discuss) {
|
||||
recommendedActions.push({
|
||||
@@ -1260,7 +1265,7 @@ function cmdInitManager(cwd, raw) {
|
||||
phase_name: phase.name,
|
||||
action: 'discuss',
|
||||
reason: 'Unblocked, ready to gather context',
|
||||
command: `/gsd:discuss-phase ${phase.number}`,
|
||||
command: `${formatGsdSlash('discuss-phase', _slashRuntime)} ${phase.number}`,
|
||||
});
|
||||
}
|
||||
}
|
||||
|
||||
@@ -9,6 +9,7 @@ const { platformWriteSync, platformEnsureDir } = require('./shell-command-projec
|
||||
const { planningPaths } = require('./planning-workspace.cjs');
|
||||
const { extractFrontmatter } = require('./frontmatter.cjs');
|
||||
const { writeStateMd, stateReplaceFieldWithFallback } = require('./state.cjs');
|
||||
const { formatGsdSlash, resolveRuntime } = require('./runtime-slash.cjs');
|
||||
|
||||
function cmdRequirementsMarkComplete(cwd, reqIdsRaw, raw) {
|
||||
if (!reqIdsRaw || reqIdsRaw.length === 0) {
|
||||
@@ -228,10 +229,10 @@ function cmdMilestoneComplete(cwd, version, options, raw) {
|
||||
if (operatorPattern.test(stateContent)) {
|
||||
stateContent = stateContent.replace(
|
||||
operatorPattern,
|
||||
`$1\n- Start the next milestone with /gsd:new-milestone\n\n`,
|
||||
`$1\n- Start the next milestone with ${formatGsdSlash('new-milestone', resolveRuntime(cwd))}\n\n`,
|
||||
);
|
||||
} else {
|
||||
stateContent = `${stateContent.trimEnd()}\n\n## Operator Next Steps\n\n- Start the next milestone with /gsd:new-milestone\n`;
|
||||
stateContent = `${stateContent.trimEnd()}\n\n## Operator Next Steps\n\n- Start the next milestone with ${formatGsdSlash('new-milestone', resolveRuntime(cwd))}\n`;
|
||||
}
|
||||
|
||||
writeStateMd(statePath, stateContent, cwd);
|
||||
|
||||
@@ -9,6 +9,7 @@ const { platformWriteSync, platformReadSync, platformEnsureDir } = require('./sh
|
||||
const { planningDir, withPlanningLock } = require('./planning-workspace.cjs');
|
||||
const { extractFrontmatter } = require('./frontmatter.cjs');
|
||||
const { writeStateMd, readModifyWriteStateMd, stateExtractField, stateReplaceField, stateReplaceFieldWithFallback, updatePerformanceMetricsSection } = require('./state.cjs');
|
||||
const { formatGsdSlash, resolveRuntime } = require('./runtime-slash.cjs');
|
||||
|
||||
// #2893 — strict canonical filter: `{padded_phase}-{NN}-PLAN.md` or `PLAN.md`.
|
||||
// Documented in agents/gsd-planner.md (write_phase_prompt step). The wider
|
||||
@@ -579,7 +580,7 @@ function cmdPhaseAdd(cwd, description, raw, customId) {
|
||||
|
||||
// Build phase entry
|
||||
const dependsOn = config.phase_naming === 'custom' ? '' : `\n**Depends on:** Phase ${typeof _newPhaseId === 'number' ? _newPhaseId - 1 : 'TBD'}`;
|
||||
const phaseEntry = `\n### Phase ${_newPhaseId}: ${description}\n\n**Goal:** [To be planned]\n**Requirements**: TBD${dependsOn}\n**Plans:** 0 plans\n\nPlans:\n- [ ] TBD (run /gsd:plan-phase ${_newPhaseId} to break down)\n`;
|
||||
const phaseEntry = `\n### Phase ${_newPhaseId}: ${description}\n\n**Goal:** [To be planned]\n**Requirements**: TBD${dependsOn}\n**Plans:** 0 plans\n\nPlans:\n- [ ] TBD (run ${formatGsdSlash('plan-phase', resolveRuntime(cwd))} ${_newPhaseId} to break down)\n`;
|
||||
|
||||
// Find insertion point: before last "---" or at end
|
||||
let updatedContent;
|
||||
@@ -656,7 +657,7 @@ function cmdPhaseAddBatch(cwd, descriptions, raw) {
|
||||
platformEnsureDir(dirPath);
|
||||
platformWriteSync(path.join(dirPath, '.gitkeep'), '');
|
||||
const dependsOn = config.phase_naming === 'custom' ? '' : `\n**Depends on:** Phase ${typeof newPhaseId === 'number' ? newPhaseId - 1 : 'TBD'}`;
|
||||
const phaseEntry = `\n### Phase ${newPhaseId}: ${description}\n\n**Goal:** [To be planned]\n**Requirements**: TBD${dependsOn}\n**Plans:** 0 plans\n\nPlans:\n- [ ] TBD (run /gsd:plan-phase ${newPhaseId} to break down)\n`;
|
||||
const phaseEntry = `\n### Phase ${newPhaseId}: ${description}\n\n**Goal:** [To be planned]\n**Requirements**: TBD${dependsOn}\n**Plans:** 0 plans\n\nPlans:\n- [ ] TBD (run ${formatGsdSlash('plan-phase', resolveRuntime(cwd))} ${newPhaseId} to break down)\n`;
|
||||
const lastSeparator = rawContent.lastIndexOf('\n---');
|
||||
rawContent = lastSeparator > 0
|
||||
? rawContent.slice(0, lastSeparator) + phaseEntry + rawContent.slice(lastSeparator)
|
||||
@@ -747,7 +748,7 @@ function cmdPhaseInsert(cwd, afterPhase, description, raw) {
|
||||
platformWriteSync(path.join(dirPath, '.gitkeep'), '');
|
||||
|
||||
// Build phase entry
|
||||
const phaseEntry = `\n### Phase ${_decimalPhase}: ${description} (INSERTED)\n\n**Goal:** [Urgent work - to be planned]\n**Requirements**: TBD\n**Depends on:** Phase ${afterPhase}\n**Plans:** 0 plans\n\nPlans:\n- [ ] TBD (run /gsd:plan-phase ${_decimalPhase} to break down)\n`;
|
||||
const phaseEntry = `\n### Phase ${_decimalPhase}: ${description} (INSERTED)\n\n**Goal:** [Urgent work - to be planned]\n**Requirements**: TBD\n**Depends on:** Phase ${afterPhase}\n**Plans:** 0 plans\n\nPlans:\n- [ ] TBD (run ${formatGsdSlash('plan-phase', resolveRuntime(cwd))} ${_decimalPhase} to break down)\n`;
|
||||
|
||||
// Insert after the target phase section
|
||||
const headerPattern = new RegExp(`(#{2,4}\\s*Phase\\s+${afterPhaseEscaped}:[^\\n]*\\n)`, 'i');
|
||||
|
||||
@@ -15,6 +15,7 @@ const os = require('os');
|
||||
const { output, error, loadConfig } = require('./core.cjs');
|
||||
const { platformReadSync: safeReadFile, platformWriteSync, platformEnsureDir } = require('./shell-command-projection.cjs');
|
||||
const { getGlobalSkillDir } = require('./runtime-homes.cjs');
|
||||
const { formatGsdSlash, resolveRuntime } = require('./runtime-slash.cjs');
|
||||
|
||||
// ─── Constants ────────────────────────────────────────────────────────────────
|
||||
|
||||
@@ -174,36 +175,46 @@ const CLAUDE_INSTRUCTIONS = {
|
||||
},
|
||||
};
|
||||
|
||||
const CLAUDE_MD_FALLBACKS = {
|
||||
project: 'Project not yet initialized. Run /gsd:new-project to set up.',
|
||||
stack: 'Technology stack not yet documented. Will populate after codebase mapping or first phase.',
|
||||
conventions: 'Conventions not yet established. Will populate as patterns emerge during development.',
|
||||
architecture: 'Architecture not yet mapped. Follow existing patterns found in the codebase.',
|
||||
skills: 'No project skills found. Add skills to any of: `.claude/skills/`, `.agents/skills/`, `.cursor/skills/`, `.github/skills/`, or `.codex/skills/` with a `SKILL.md` index file.',
|
||||
};
|
||||
// CLAUDE.md fallback / placeholder text — runtime-aware so emitted slash
|
||||
// commands route correctly under the active install (#3584). The values must
|
||||
// be computed per-call rather than at module load because the slash form
|
||||
// depends on the runtime resolved from the project's config/env.
|
||||
function buildClaudeMdFallbacks(runtime) {
|
||||
return {
|
||||
project: `Project not yet initialized. Run ${formatGsdSlash('new-project', runtime)} to set up.`,
|
||||
stack: 'Technology stack not yet documented. Will populate after codebase mapping or first phase.',
|
||||
conventions: 'Conventions not yet established. Will populate as patterns emerge during development.',
|
||||
architecture: 'Architecture not yet mapped. Follow existing patterns found in the codebase.',
|
||||
skills: 'No project skills found. Add skills to any of: `.claude/skills/`, `.agents/skills/`, `.cursor/skills/`, `.github/skills/`, or `.codex/skills/` with a `SKILL.md` index file.',
|
||||
};
|
||||
}
|
||||
|
||||
// Directories where project skills may live (checked in order)
|
||||
const SKILL_SEARCH_DIRS = ['.claude/skills', '.agents/skills', '.cursor/skills', '.github/skills', '.codex/skills'];
|
||||
|
||||
const CLAUDE_MD_WORKFLOW_ENFORCEMENT = [
|
||||
'Before using Edit, Write, or other file-changing tools, start work through a GSD command so planning artifacts and execution context stay in sync.',
|
||||
'',
|
||||
'Use these entry points:',
|
||||
'- `/gsd:quick` for small fixes, doc updates, and ad-hoc tasks',
|
||||
'- `/gsd:debug` for investigation and bug fixing',
|
||||
'- `/gsd:execute-phase` for planned phase work',
|
||||
'',
|
||||
'Do not make direct repo edits outside a GSD workflow unless the user explicitly asks to bypass it.',
|
||||
].join('\n');
|
||||
function buildClaudeMdWorkflowEnforcement(runtime) {
|
||||
return [
|
||||
'Before using Edit, Write, or other file-changing tools, start work through a GSD command so planning artifacts and execution context stay in sync.',
|
||||
'',
|
||||
'Use these entry points:',
|
||||
`- \`${formatGsdSlash('quick', runtime)}\` for small fixes, doc updates, and ad-hoc tasks`,
|
||||
`- \`${formatGsdSlash('debug', runtime)}\` for investigation and bug fixing`,
|
||||
`- \`${formatGsdSlash('execute-phase', runtime)}\` for planned phase work`,
|
||||
'',
|
||||
'Do not make direct repo edits outside a GSD workflow unless the user explicitly asks to bypass it.',
|
||||
].join('\n');
|
||||
}
|
||||
|
||||
const CLAUDE_MD_PROFILE_PLACEHOLDER = [
|
||||
'<!-- GSD:profile-start -->',
|
||||
'## Developer Profile',
|
||||
'',
|
||||
'> Profile not yet configured. Run `/gsd:profile-user` to generate your developer profile.',
|
||||
'> This section is managed by `generate-claude-profile` -- do not edit manually.',
|
||||
'<!-- GSD:profile-end -->',
|
||||
].join('\n');
|
||||
function buildClaudeMdProfilePlaceholder(runtime) {
|
||||
return [
|
||||
'<!-- GSD:profile-start -->',
|
||||
'## Developer Profile',
|
||||
'',
|
||||
`> Profile not yet configured. Run \`${formatGsdSlash('profile-user', runtime)}\` to generate your developer profile.`,
|
||||
'> This section is managed by `generate-claude-profile` -- do not edit manually.',
|
||||
'<!-- GSD:profile-end -->',
|
||||
].join('\n');
|
||||
}
|
||||
|
||||
// ─── Helper Functions ─────────────────────────────────────────────────────────
|
||||
|
||||
@@ -284,10 +295,11 @@ function extractMarkdownSection(content, sectionName) {
|
||||
// ─── CLAUDE.md Section Generators ─────────────────────────────────────────────
|
||||
|
||||
function generateProjectSection(cwd) {
|
||||
const fallbacks = buildClaudeMdFallbacks(resolveRuntime(cwd));
|
||||
const projectPath = path.join(cwd, '.planning', 'PROJECT.md');
|
||||
const content = safeReadFile(projectPath);
|
||||
if (!content) {
|
||||
return { content: CLAUDE_MD_FALLBACKS.project, source: 'PROJECT.md', linkPath: null, hasFallback: true };
|
||||
return { content: fallbacks.project, source: 'PROJECT.md', linkPath: null, hasFallback: true };
|
||||
}
|
||||
const parts = [];
|
||||
const h1Match = content.match(/^# (.+)$/m);
|
||||
@@ -308,12 +320,13 @@ function generateProjectSection(cwd) {
|
||||
if (body) parts.push(`### Constraints\n\n${body}`);
|
||||
}
|
||||
if (parts.length === 0) {
|
||||
return { content: CLAUDE_MD_FALLBACKS.project, source: 'PROJECT.md', linkPath: null, hasFallback: true };
|
||||
return { content: fallbacks.project, source: 'PROJECT.md', linkPath: null, hasFallback: true };
|
||||
}
|
||||
return { content: parts.join('\n\n'), source: 'PROJECT.md', linkPath: '.planning/PROJECT.md', hasFallback: false };
|
||||
}
|
||||
|
||||
function generateStackSection(cwd) {
|
||||
const fallbacks = buildClaudeMdFallbacks(resolveRuntime(cwd));
|
||||
const codebasePath = path.join(cwd, '.planning', 'codebase', 'STACK.md');
|
||||
const researchPath = path.join(cwd, '.planning', 'research', 'STACK.md');
|
||||
let content = safeReadFile(codebasePath);
|
||||
@@ -325,7 +338,7 @@ function generateStackSection(cwd) {
|
||||
linkPath = '.planning/research/STACK.md';
|
||||
}
|
||||
if (!content) {
|
||||
return { content: CLAUDE_MD_FALLBACKS.stack, source: 'STACK.md', linkPath: null, hasFallback: true };
|
||||
return { content: fallbacks.stack, source: 'STACK.md', linkPath: null, hasFallback: true };
|
||||
}
|
||||
const lines = content.split('\n');
|
||||
const summaryLines = [];
|
||||
@@ -344,10 +357,11 @@ function generateStackSection(cwd) {
|
||||
}
|
||||
|
||||
function generateConventionsSection(cwd) {
|
||||
const fallbacks = buildClaudeMdFallbacks(resolveRuntime(cwd));
|
||||
const conventionsPath = path.join(cwd, '.planning', 'codebase', 'CONVENTIONS.md');
|
||||
const content = safeReadFile(conventionsPath);
|
||||
if (!content) {
|
||||
return { content: CLAUDE_MD_FALLBACKS.conventions, source: 'CONVENTIONS.md', linkPath: null, hasFallback: true };
|
||||
return { content: fallbacks.conventions, source: 'CONVENTIONS.md', linkPath: null, hasFallback: true };
|
||||
}
|
||||
const lines = content.split('\n');
|
||||
const summaryLines = [];
|
||||
@@ -360,10 +374,11 @@ function generateConventionsSection(cwd) {
|
||||
}
|
||||
|
||||
function generateArchitectureSection(cwd) {
|
||||
const fallbacks = buildClaudeMdFallbacks(resolveRuntime(cwd));
|
||||
const architecturePath = path.join(cwd, '.planning', 'codebase', 'ARCHITECTURE.md');
|
||||
const content = safeReadFile(architecturePath);
|
||||
if (!content) {
|
||||
return { content: CLAUDE_MD_FALLBACKS.architecture, source: 'ARCHITECTURE.md', linkPath: null, hasFallback: true };
|
||||
return { content: fallbacks.architecture, source: 'ARCHITECTURE.md', linkPath: null, hasFallback: true };
|
||||
}
|
||||
const lines = content.split('\n');
|
||||
const summaryLines = [];
|
||||
@@ -375,9 +390,9 @@ function generateArchitectureSection(cwd) {
|
||||
return { content: summary, source: 'ARCHITECTURE.md', linkPath: '.planning/codebase/ARCHITECTURE.md', hasFallback: false };
|
||||
}
|
||||
|
||||
function generateWorkflowSection() {
|
||||
function generateWorkflowSection(cwd) {
|
||||
return {
|
||||
content: CLAUDE_MD_WORKFLOW_ENFORCEMENT,
|
||||
content: buildClaudeMdWorkflowEnforcement(resolveRuntime(cwd)),
|
||||
source: 'GSD defaults',
|
||||
linkPath: null,
|
||||
hasFallback: false,
|
||||
@@ -390,6 +405,7 @@ function generateWorkflowSection() {
|
||||
* agents know which skills are available at session startup (Layer 1 discovery).
|
||||
*/
|
||||
function generateSkillsSection(cwd) {
|
||||
const fallbacks = buildClaudeMdFallbacks(resolveRuntime(cwd));
|
||||
const discovered = [];
|
||||
|
||||
for (const dir of SKILL_SEARCH_DIRS) {
|
||||
@@ -426,7 +442,7 @@ function generateSkillsSection(cwd) {
|
||||
}
|
||||
|
||||
if (discovered.length === 0) {
|
||||
return { content: CLAUDE_MD_FALLBACKS.skills, source: 'skills/', hasFallback: true };
|
||||
return { content: fallbacks.skills, source: 'skills/', hasFallback: true };
|
||||
}
|
||||
|
||||
const lines = ['| Skill | Description | Path |', '|-------|-------------|------|'];
|
||||
@@ -774,7 +790,7 @@ function cmdGenerateDevPreferences(cwd, options, raw) {
|
||||
|
||||
let stackBlock;
|
||||
if (analysis.data_source === 'questionnaire') {
|
||||
stackBlock = 'Stack preferences not available (questionnaire-only profile). Run `/gsd:profile-user --refresh` with session data to populate.';
|
||||
stackBlock = `Stack preferences not available (questionnaire-only profile). Run \`${formatGsdSlash('profile-user', resolveRuntime(cwd))} --refresh\` with session data to populate.`;
|
||||
} else if (options.stack) {
|
||||
stackBlock = options.stack;
|
||||
} else {
|
||||
@@ -881,7 +897,7 @@ function cmdGenerateClaudeProfile(cwd, options, raw) {
|
||||
'<!-- GSD:profile-start -->',
|
||||
'## Developer Profile',
|
||||
'',
|
||||
`> Generated by GSD from ${dataSource}. Run \`/gsd:profile-user --refresh\` to update.`,
|
||||
`> Generated by GSD from ${dataSource}. Run \`${formatGsdSlash('profile-user', resolveRuntime(cwd))} --refresh\` to update.`,
|
||||
'',
|
||||
'| Dimension | Rating | Confidence |',
|
||||
'|-----------|--------|------------|',
|
||||
@@ -1025,7 +1041,7 @@ function cmdGenerateClaudeMd(cwd, options, raw) {
|
||||
sections.push(buildSectionContent(name, gen, heading));
|
||||
}
|
||||
sections.push('');
|
||||
sections.push(CLAUDE_MD_PROFILE_PLACEHOLDER);
|
||||
sections.push(buildClaudeMdProfilePlaceholder(resolveRuntime(cwd)));
|
||||
existingContent = sections.join('\n\n') + '\n';
|
||||
action = 'created';
|
||||
platformEnsureDir(path.dirname(outputPath));
|
||||
@@ -1064,7 +1080,7 @@ function cmdGenerateClaudeMd(cwd, options, raw) {
|
||||
}
|
||||
|
||||
if (!options.auto && fileContent.indexOf('<!-- GSD:profile-start') === -1) {
|
||||
fileContent = fileContent.trimEnd() + '\n\n' + CLAUDE_MD_PROFILE_PLACEHOLDER + '\n';
|
||||
fileContent = fileContent.trimEnd() + '\n\n' + buildClaudeMdProfilePlaceholder(resolveRuntime(cwd)) + '\n';
|
||||
}
|
||||
|
||||
platformWriteSync(outputPath, fileContent);
|
||||
@@ -1087,7 +1103,7 @@ function cmdGenerateClaudeMd(cwd, options, raw) {
|
||||
let message = `Generated ${genCount}/${totalManaged} sections.`;
|
||||
if (sectionsFallback.length > 0) message += ` Fallback: ${sectionsFallback.join(', ')}.`;
|
||||
if (sectionsSkipped.length > 0) message += ` Skipped (manually edited): ${sectionsSkipped.join(', ')}.`;
|
||||
if (profileStatus === 'placeholder_added') message += ' Run /gsd:profile-user to unlock Developer Profile.';
|
||||
if (profileStatus === 'placeholder_added') message += ` Run ${formatGsdSlash('profile-user', resolveRuntime(cwd))} to unlock Developer Profile.`;
|
||||
|
||||
const result = {
|
||||
claude_md_path: outputPath,
|
||||
|
||||
96
get-shit-done/bin/lib/runtime-slash.cjs
Normal file
96
get-shit-done/bin/lib/runtime-slash.cjs
Normal file
@@ -0,0 +1,96 @@
|
||||
'use strict';
|
||||
|
||||
/**
|
||||
* runtime-slash.cjs — single source of truth for emitting GSD slash-command
|
||||
* references in user-facing runtime output (recommended-actions JSON, persisted
|
||||
* ROADMAP.md entries, verify/validate fix hints, error messages, etc.).
|
||||
*
|
||||
* Background: #2808 unified all GSD skill installs to register under the hyphen
|
||||
* form (`name: gsd-<cmd>`). The legacy colon form `/gsd:<cmd>` is no longer
|
||||
* routable by Claude Code skill installs, but ~50 runtime emissions in
|
||||
* bin/lib/*.cjs still hardcoded it (#3584). Codex installs need the shell-var
|
||||
* `$gsd-<cmd>` form. This module is the only place the runtime should decide
|
||||
* which shape to emit.
|
||||
*
|
||||
* - codex: $gsd-<cmd> (shell-var syntax)
|
||||
* - claude, cursor, opencode, kilo, etc.: /gsd-<cmd>
|
||||
*
|
||||
* The colon form is never emitted.
|
||||
*/
|
||||
|
||||
function formatGsdSlash(commandName, runtime) {
|
||||
if (typeof commandName !== 'string') return commandName;
|
||||
if (commandName === '') return commandName;
|
||||
|
||||
// Strip any existing leading prefix so the helper is idempotent and accepts
|
||||
// both legacy `/gsd:<name>` and canonical hyphen-form input (plus the bare
|
||||
// `gsd:<name>` shorthand and codex `$gsd-<name>` shell-var input).
|
||||
const stripped = commandName.replace(/^[/$]?gsd[-:]/i, '');
|
||||
// If the regex matched nothing (no prefix), the input is already a bare name.
|
||||
const bare = stripped === commandName ? commandName : stripped;
|
||||
if (bare === '') return commandName;
|
||||
|
||||
const rt = String(runtime || 'claude').toLowerCase();
|
||||
if (rt === 'codex') {
|
||||
// Codex skills are invoked as $gsd-<cmd> (shell-var syntax). Lowercased
|
||||
// because shell-var identifiers in the surrounding prose are conventionally
|
||||
// lowercase; matches the convertCodexSlash() projection in bin/install.js.
|
||||
return `$gsd-${bare.toLowerCase()}`;
|
||||
}
|
||||
return `/gsd-${bare}`;
|
||||
}
|
||||
|
||||
/**
|
||||
* Resolve the effective runtime for a project directory.
|
||||
*
|
||||
* process.env.GSD_RUNTIME > config.runtime > 'claude'
|
||||
*
|
||||
* Mirrors the precedence already used by profile-output.cjs and the rest of
|
||||
* the runtime resolution chain. Returns a lowercased string so downstream
|
||||
* comparisons can be case-blind.
|
||||
*
|
||||
* @param {string|null|undefined} projectDir
|
||||
* @returns {string}
|
||||
*/
|
||||
function resolveRuntime(projectDir) {
|
||||
if (process.env.GSD_RUNTIME) {
|
||||
return String(process.env.GSD_RUNTIME).toLowerCase();
|
||||
}
|
||||
if (projectDir) {
|
||||
try {
|
||||
// Read config.json directly (not via loadConfig). loadConfig has a side
|
||||
// effect of normalizing and re-writing legacy keys back to disk, which
|
||||
// would mutate the project file just to read the runtime name. We only
|
||||
// need the literal `runtime:` value, so a plain JSON read is sufficient
|
||||
// and side-effect-free.
|
||||
const fs = require('fs');
|
||||
const path = require('path');
|
||||
const configPath = path.join(projectDir, '.planning', 'config.json');
|
||||
if (fs.existsSync(configPath)) {
|
||||
const raw = fs.readFileSync(configPath, 'utf-8');
|
||||
const parsed = JSON.parse(raw);
|
||||
if (parsed && typeof parsed === 'object' && parsed.runtime) {
|
||||
return String(parsed.runtime).toLowerCase();
|
||||
}
|
||||
}
|
||||
} catch {
|
||||
// Fall through to default — a missing/broken config must not crash
|
||||
// runtime output formatting.
|
||||
}
|
||||
}
|
||||
return 'claude';
|
||||
}
|
||||
|
||||
/**
|
||||
* Convenience: format using the runtime resolved from a project directory.
|
||||
* Equivalent to `formatGsdSlash(name, resolveRuntime(projectDir))`.
|
||||
*/
|
||||
function formatGsdSlashFor(projectDir, commandName) {
|
||||
return formatGsdSlash(commandName, resolveRuntime(projectDir));
|
||||
}
|
||||
|
||||
module.exports = {
|
||||
formatGsdSlash,
|
||||
resolveRuntime,
|
||||
formatGsdSlashFor,
|
||||
};
|
||||
@@ -1,6 +1,7 @@
|
||||
'use strict';
|
||||
|
||||
const { VALIDATE_SUBCOMMANDS } = require('./command-aliases.generated.cjs');
|
||||
const { formatGsdSlash, resolveRuntime } = require('./runtime-slash.cjs');
|
||||
|
||||
function routeValidateCommand({ verify, args, cwd, raw, parseNamedArgs, output, error }) {
|
||||
const subcommand = args[1];
|
||||
@@ -24,10 +25,11 @@ function routeValidateCommand({ verify, args, cwd, raw, parseNamedArgs, output,
|
||||
return;
|
||||
}
|
||||
const { classifyContextUtilization, STATES } = require('./context-utilization.cjs');
|
||||
const threadCmd = formatGsdSlash('thread', resolveRuntime(cwd));
|
||||
const RECOMMENDATIONS = {
|
||||
[STATES.HEALTHY]: null,
|
||||
[STATES.WARNING]: 'Context is approaching the fracture zone — consider /gsd:thread to continue in a fresh window.',
|
||||
[STATES.CRITICAL]: 'Reasoning quality may degrade past 70% utilization (fracture point). Run /gsd:thread now to preserve output quality.',
|
||||
[STATES.WARNING]: `Context is approaching the fracture zone — consider ${threadCmd} to continue in a fresh window.`,
|
||||
[STATES.CRITICAL]: `Reasoning quality may degrade past 70% utilization (fracture point). Run ${threadCmd} now to preserve output quality.`,
|
||||
};
|
||||
let classified;
|
||||
try {
|
||||
|
||||
@@ -10,6 +10,7 @@ const { execGit, platformReadSync: safeReadFile, platformWriteSync } = require('
|
||||
const { planningDir } = require('./planning-workspace.cjs');
|
||||
const { extractFrontmatter, parseMustHavesBlock } = require('./frontmatter.cjs');
|
||||
const { writeStateMd } = require('./state.cjs');
|
||||
const { formatGsdSlash, resolveRuntime } = require('./runtime-slash.cjs');
|
||||
|
||||
function cmdVerifySummary(cwd, summaryPath, checkFileCount, raw) {
|
||||
if (!summaryPath) {
|
||||
@@ -593,6 +594,10 @@ function cmdValidateHealth(cwd, options, raw) {
|
||||
const statePath = path.join(planBase, 'STATE.md');
|
||||
const configPath = path.join(planBase, 'config.json');
|
||||
const phasesDir = path.join(planBase, 'phases');
|
||||
// Resolve runtime once so every emitted fix hint uses the routable slash
|
||||
// form for this install (#3584).
|
||||
const _slashRuntime = resolveRuntime(cwd);
|
||||
const slash = (name) => formatGsdSlash(name, _slashRuntime);
|
||||
|
||||
const errors = [];
|
||||
const warnings = [];
|
||||
@@ -609,7 +614,7 @@ function cmdValidateHealth(cwd, options, raw) {
|
||||
|
||||
// ─── Check 1: .planning/ exists ───────────────────────────────────────────
|
||||
if (!fs.existsSync(planBase)) {
|
||||
addIssue('error', 'E001', '.planning/ directory not found', 'Run /gsd:new-project to initialize');
|
||||
addIssue('error', 'E001', '.planning/ directory not found', `Run ${slash('new-project')} to initialize`);
|
||||
output({
|
||||
status: 'broken',
|
||||
errors,
|
||||
@@ -622,7 +627,7 @@ function cmdValidateHealth(cwd, options, raw) {
|
||||
|
||||
// ─── Check 2: PROJECT.md exists and has required sections ─────────────────
|
||||
if (!fs.existsSync(projectPath)) {
|
||||
addIssue('error', 'E002', 'PROJECT.md not found', 'Run /gsd:new-project to create');
|
||||
addIssue('error', 'E002', 'PROJECT.md not found', `Run ${slash('new-project')} to create`);
|
||||
} else {
|
||||
const content = fs.readFileSync(projectPath, 'utf-8');
|
||||
const requiredSections = ['## What This Is', '## Core Value', '## Requirements'];
|
||||
@@ -635,12 +640,12 @@ function cmdValidateHealth(cwd, options, raw) {
|
||||
|
||||
// ─── Check 3: ROADMAP.md exists ───────────────────────────────────────────
|
||||
if (!fs.existsSync(roadmapPath)) {
|
||||
addIssue('error', 'E003', 'ROADMAP.md not found', 'Run /gsd:new-milestone to create roadmap');
|
||||
addIssue('error', 'E003', 'ROADMAP.md not found', `Run ${slash('new-milestone')} to create roadmap`);
|
||||
}
|
||||
|
||||
// ─── Check 4: STATE.md exists and references valid phases ─────────────────
|
||||
if (!fs.existsSync(statePath)) {
|
||||
addIssue('error', 'E004', 'STATE.md not found', 'Run /gsd:health --repair to regenerate', true);
|
||||
addIssue('error', 'E004', 'STATE.md not found', `Run ${slash('health')} --repair to regenerate`, true);
|
||||
repairs.push('regenerateState');
|
||||
} else {
|
||||
const stateContent = fs.readFileSync(statePath, 'utf-8');
|
||||
@@ -687,7 +692,7 @@ function cmdValidateHealth(cwd, options, raw) {
|
||||
'warning',
|
||||
'W002',
|
||||
`STATE.md references phase ${ref}, but only phases ${[...validPhases].sort().join(', ')} are declared`,
|
||||
'Review STATE.md manually before changing it; /gsd:health --repair will not overwrite an existing STATE.md for phase mismatches'
|
||||
`Review STATE.md manually before changing it; ${slash('health')} --repair will not overwrite an existing STATE.md for phase mismatches`
|
||||
);
|
||||
}
|
||||
}
|
||||
@@ -696,7 +701,7 @@ function cmdValidateHealth(cwd, options, raw) {
|
||||
|
||||
// ─── Check 5: config.json valid JSON + valid schema ───────────────────────
|
||||
if (!fs.existsSync(configPath)) {
|
||||
addIssue('warning', 'W003', 'config.json not found', 'Run /gsd:health --repair to create with defaults', true);
|
||||
addIssue('warning', 'W003', 'config.json not found', `Run ${slash('health')} --repair to create with defaults`, true);
|
||||
repairs.push('createConfig');
|
||||
} else {
|
||||
try {
|
||||
@@ -708,7 +713,7 @@ function cmdValidateHealth(cwd, options, raw) {
|
||||
addIssue('warning', 'W004', `config.json: invalid model_profile "${parsed.model_profile}"`, `Valid values: ${validProfiles.join(', ')}`);
|
||||
}
|
||||
} catch (err) {
|
||||
addIssue('error', 'E005', `config.json: JSON parse error - ${err.message}`, 'Run /gsd:health --repair to reset to defaults', true);
|
||||
addIssue('error', 'E005', `config.json: JSON parse error - ${err.message}`, `Run ${slash('health')} --repair to reset to defaults`, true);
|
||||
repairs.push('resetConfig');
|
||||
}
|
||||
}
|
||||
@@ -719,11 +724,11 @@ function cmdValidateHealth(cwd, options, raw) {
|
||||
const configRaw = fs.readFileSync(configPath, 'utf-8');
|
||||
const configParsed = JSON.parse(configRaw);
|
||||
if (configParsed.workflow && configParsed.workflow.nyquist_validation === undefined) {
|
||||
addIssue('warning', 'W008', 'config.json: workflow.nyquist_validation absent (defaults to enabled but agents may skip)', 'Run /gsd:health --repair to add key', true);
|
||||
addIssue('warning', 'W008', 'config.json: workflow.nyquist_validation absent (defaults to enabled but agents may skip)', `Run ${slash('health')} --repair to add key`, true);
|
||||
if (!repairs.includes('addNyquistKey')) repairs.push('addNyquistKey');
|
||||
}
|
||||
if (configParsed.workflow && configParsed.workflow.ai_integration_phase === undefined) {
|
||||
addIssue('warning', 'W016', 'config.json: workflow.ai_integration_phase absent (defaults to enabled — run /gsd:ai-integration-phase before planning AI system phases)', 'Run /gsd:health --repair to add key', true);
|
||||
addIssue('warning', 'W016', `config.json: workflow.ai_integration_phase absent (defaults to enabled — run ${slash('ai-integration-phase')} before planning AI system phases)`, `Run ${slash('health')} --repair to add key`, true);
|
||||
if (!repairs.includes('addAiIntegrationPhaseKey')) repairs.push('addAiIntegrationPhaseKey');
|
||||
}
|
||||
} catch { /* intentionally empty */ }
|
||||
@@ -773,7 +778,7 @@ function cmdValidateHealth(cwd, options, raw) {
|
||||
try {
|
||||
const researchContent = fs.readFileSync(path.join(phasesDir, e.name, researchFile), 'utf-8');
|
||||
if (researchContent.includes('## Validation Architecture')) {
|
||||
addIssue('warning', 'W009', `Phase ${e.name}: has Validation Architecture in RESEARCH.md but no VALIDATION.md`, 'Re-run /gsd:plan-phase with --research to regenerate');
|
||||
addIssue('warning', 'W009', `Phase ${e.name}: has Validation Architecture in RESEARCH.md but no VALIDATION.md`, `Re-run ${slash('plan-phase')} with --research to regenerate`);
|
||||
}
|
||||
} catch { /* intentionally empty */ }
|
||||
}
|
||||
@@ -862,7 +867,7 @@ function cmdValidateHealth(cwd, options, raw) {
|
||||
if (statusVal !== 'complete' && statusVal !== 'done') {
|
||||
addIssue('warning', 'W011',
|
||||
`STATE.md says current phase is ${statePhase} (status: ${statusVal || 'unknown'}) but ROADMAP.md shows it as [x] complete — state files may be out of sync`,
|
||||
'Run /gsd:progress to re-derive current position, or manually update STATE.md');
|
||||
`Run ${slash('progress')} to re-derive current position, or manually update STATE.md`);
|
||||
}
|
||||
}
|
||||
}
|
||||
@@ -971,7 +976,7 @@ function cmdValidateHealth(cwd, options, raw) {
|
||||
if (missingFromRegistry.length > 0) {
|
||||
addIssue('warning', 'W018',
|
||||
`MILESTONES.md missing ${missingFromRegistry.length} archived milestone(s): ${missingFromRegistry.join(', ')}`,
|
||||
'Run /gsd:health --backfill to synthesize missing entries from archive snapshots',
|
||||
`Run ${slash('health')} --backfill to synthesize missing entries from archive snapshots`,
|
||||
true);
|
||||
repairs.push('backfillMilestones');
|
||||
}
|
||||
@@ -1045,7 +1050,7 @@ function cmdValidateHealth(cwd, options, raw) {
|
||||
stateContent += `**Current phase:** (determining...)\n`;
|
||||
stateContent += `**Status:** Resuming\n\n`;
|
||||
stateContent += `## Session Log\n\n`;
|
||||
stateContent += `- ${new Date().toISOString().split('T')[0]}: STATE.md regenerated by /gsd:health --repair\n`;
|
||||
stateContent += `- ${new Date().toISOString().split('T')[0]}: STATE.md regenerated by ${slash('health')} --repair\n`;
|
||||
writeStateMd(statePath, stateContent, cwd);
|
||||
repairActions.push({ action: repair, success: true, path: 'STATE.md' });
|
||||
break;
|
||||
@@ -1095,7 +1100,7 @@ function cmdValidateHealth(cwd, options, raw) {
|
||||
// Build minimal entry from snapshot title or version
|
||||
const titleMatch = snapshot && snapshot.match(/^#\s+(.+)$/m);
|
||||
const milestoneName = titleMatch ? titleMatch[1].replace(/^Milestone\s+/i, '').replace(/^v[\d.]+\s*/, '').trim() : ver;
|
||||
const entry = `## ${ver}${milestoneName && milestoneName !== ver ? ` ${milestoneName}` : ''} (Backfilled: ${today})\n\n**Note:** Synthesized from archive snapshot by \`/gsd:health --backfill\`. Original completion date unknown.\n\n---\n\n`;
|
||||
const entry = `## ${ver}${milestoneName && milestoneName !== ver ? ` ${milestoneName}` : ''} (Backfilled: ${today})\n\n**Note:** Synthesized from archive snapshot by \`${slash('health')} --backfill\`. Original completion date unknown.\n\n---\n\n`;
|
||||
const milestonesContent = fs.existsSync(milestonesPath)
|
||||
? fs.readFileSync(milestonesPath, 'utf-8')
|
||||
: '';
|
||||
|
||||
@@ -14,6 +14,7 @@ const { output, error, toPosixPath, getMilestoneInfo, generateSlugInternal } = r
|
||||
const { platformWriteSync, platformEnsureDir } = require('./shell-command-projection.cjs');
|
||||
const { planningRoot, setActiveWorkstream, getActiveWorkstream } = require('./planning-workspace.cjs');
|
||||
const { toWorkstreamSlug, hasInvalidPathSegment, isValidActiveWorkstreamName } = require('./workstream-name-policy.cjs');
|
||||
const { formatGsdSlash, resolveRuntime } = require('./runtime-slash.cjs');
|
||||
const {
|
||||
getOtherActiveWorkstreamInventories,
|
||||
inspectWorkstream,
|
||||
@@ -85,7 +86,7 @@ function cmdWorkstreamCreate(cwd, name, options, raw) {
|
||||
|
||||
const baseDir = planningRoot(cwd);
|
||||
if (!fs.existsSync(baseDir)) {
|
||||
error('.planning/ directory not found — run /gsd:new-project first');
|
||||
error(`.planning/ directory not found — run ${formatGsdSlash('new-project', resolveRuntime(cwd))} first`);
|
||||
}
|
||||
|
||||
const wsRoot = path.join(baseDir, 'workstreams');
|
||||
|
||||
300
tests/bug-3584-runtime-slash-emitters.test.cjs
Normal file
300
tests/bug-3584-runtime-slash-emitters.test.cjs
Normal file
@@ -0,0 +1,300 @@
|
||||
/**
|
||||
* Regression tests for bug #3584 — runtime emitters use the slash formatter.
|
||||
*
|
||||
* These tests exercise the actual runtime command handlers via `runGsdTools`
|
||||
* and assert on the structured payloads they emit/persist. They prove that
|
||||
* the high-impact emitters identified in the issue (`init.cjs` recommended
|
||||
* actions, `phase.cjs` ROADMAP persistence, `verify.cjs` remediation hints,
|
||||
* `milestone.cjs` Operator-Next-Steps persistence, `validate-command-router`
|
||||
* fracture recommendations) no longer emit the unroutable `/gsd:<cmd>` colon
|
||||
* form for skills-based runtimes.
|
||||
*/
|
||||
|
||||
'use strict';
|
||||
|
||||
const { describe, test, beforeEach, afterEach } = require('node:test');
|
||||
const assert = require('node:assert/strict');
|
||||
const fs = require('fs');
|
||||
const path = require('path');
|
||||
|
||||
const {
|
||||
runGsdTools,
|
||||
createTempProject,
|
||||
createTempDir,
|
||||
cleanup,
|
||||
} = require('./helpers.cjs');
|
||||
|
||||
// Helper: assert no string field anywhere in `value` (recursive) contains '/gsd:'.
|
||||
function assertNoColonForm(value, label) {
|
||||
const stack = [{ v: value, p: label }];
|
||||
while (stack.length > 0) {
|
||||
const { v, p } = stack.pop();
|
||||
if (typeof v === 'string') {
|
||||
assert.ok(
|
||||
!v.includes('/gsd:'),
|
||||
`${p}: must not contain deprecated /gsd: form, got ${JSON.stringify(v)}`,
|
||||
);
|
||||
} else if (Array.isArray(v)) {
|
||||
v.forEach((item, i) => stack.push({ v: item, p: `${p}[${i}]` }));
|
||||
} else if (v && typeof v === 'object') {
|
||||
for (const key of Object.keys(v)) {
|
||||
stack.push({ v: v[key], p: `${p}.${key}` });
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
// Helper: collect every `command` string under a recommendedActions-style array.
|
||||
function collectCommandFields(value) {
|
||||
const out = [];
|
||||
const stack = [value];
|
||||
while (stack.length > 0) {
|
||||
const v = stack.pop();
|
||||
if (Array.isArray(v)) {
|
||||
for (const item of v) stack.push(item);
|
||||
} else if (v && typeof v === 'object') {
|
||||
if (typeof v.command === 'string') out.push(v.command);
|
||||
for (const key of Object.keys(v)) stack.push(v[key]);
|
||||
}
|
||||
}
|
||||
return out;
|
||||
}
|
||||
|
||||
describe('bug-3584: init manager recommendedActions emit hyphen form', () => {
|
||||
let tmpDir;
|
||||
|
||||
beforeEach(() => {
|
||||
tmpDir = createTempProject();
|
||||
// Minimal ROADMAP + STATE so init manager will run.
|
||||
fs.writeFileSync(
|
||||
path.join(tmpDir, '.planning', 'ROADMAP.md'),
|
||||
[
|
||||
'# Roadmap',
|
||||
'',
|
||||
'## Milestone v1',
|
||||
'',
|
||||
'### Phase 1: Foundation',
|
||||
'**Goal:** scaffold',
|
||||
'**Plans:** 1 plan',
|
||||
'',
|
||||
].join('\n'),
|
||||
);
|
||||
fs.writeFileSync(
|
||||
path.join(tmpDir, '.planning', 'STATE.md'),
|
||||
'# State\n\nCurrent Phase: 1\n',
|
||||
);
|
||||
});
|
||||
|
||||
afterEach(() => cleanup(tmpDir));
|
||||
|
||||
test('skills runtime (claude) emits /gsd-<cmd> in recommended_actions[].command', () => {
|
||||
// Plan-but-not-executed: directory exists with a PLAN.md → execute is recommended.
|
||||
const phaseDir = path.join(tmpDir, '.planning', 'phases', '01-foundation');
|
||||
fs.mkdirSync(phaseDir, { recursive: true });
|
||||
fs.writeFileSync(path.join(phaseDir, '01-01-PLAN.md'), '# Plan\n');
|
||||
|
||||
const result = runGsdTools('init manager', tmpDir, { GSD_RUNTIME: 'claude' });
|
||||
assert.ok(result.success, `init manager failed: ${result.error || result.output}`);
|
||||
|
||||
const payload = JSON.parse(result.output);
|
||||
const commands = collectCommandFields(payload.recommended_actions || []);
|
||||
assert.ok(commands.length > 0, 'recommended_actions should produce at least one command');
|
||||
|
||||
for (const cmd of commands) {
|
||||
assert.ok(
|
||||
cmd.startsWith('/gsd-'),
|
||||
`recommended_actions command must start with /gsd- for skills-based runtimes, got ${cmd}`,
|
||||
);
|
||||
assert.ok(
|
||||
!cmd.includes('/gsd:'),
|
||||
`recommended_actions command must not contain /gsd: colon form, got ${cmd}`,
|
||||
);
|
||||
}
|
||||
assertNoColonForm(payload, 'init.manager payload');
|
||||
});
|
||||
|
||||
test('codex runtime emits $gsd-<cmd> in recommended_actions[].command', () => {
|
||||
const phaseDir = path.join(tmpDir, '.planning', 'phases', '01-foundation');
|
||||
fs.mkdirSync(phaseDir, { recursive: true });
|
||||
fs.writeFileSync(path.join(phaseDir, '01-01-PLAN.md'), '# Plan\n');
|
||||
|
||||
const result = runGsdTools('init manager', tmpDir, { GSD_RUNTIME: 'codex' });
|
||||
assert.ok(result.success, `init manager (codex) failed: ${result.error || result.output}`);
|
||||
|
||||
const payload = JSON.parse(result.output);
|
||||
const commands = collectCommandFields(payload.recommended_actions || []);
|
||||
assert.ok(commands.length > 0);
|
||||
|
||||
for (const cmd of commands) {
|
||||
assert.ok(
|
||||
cmd.startsWith('$gsd-'),
|
||||
`codex recommended_actions command must use $gsd- shell-var form, got ${cmd}`,
|
||||
);
|
||||
}
|
||||
});
|
||||
});
|
||||
|
||||
describe('bug-3584: phase add persists hyphen form into ROADMAP.md', () => {
|
||||
let tmpDir;
|
||||
|
||||
beforeEach(() => {
|
||||
tmpDir = createTempProject();
|
||||
fs.writeFileSync(
|
||||
path.join(tmpDir, '.planning', 'ROADMAP.md'),
|
||||
'# Roadmap\n\n## Milestone v1\n\n',
|
||||
);
|
||||
fs.writeFileSync(
|
||||
path.join(tmpDir, '.planning', 'STATE.md'),
|
||||
'# State\n',
|
||||
);
|
||||
});
|
||||
|
||||
afterEach(() => cleanup(tmpDir));
|
||||
|
||||
test('phase add persists hyphen-form slash command in roadmap get-phase payload', () => {
|
||||
// 1. Add a phase — the system under test persists the phase entry into ROADMAP.md.
|
||||
const addResult = runGsdTools(
|
||||
['phase', 'add', 'Test new feature'],
|
||||
tmpDir,
|
||||
{ GSD_RUNTIME: 'claude' },
|
||||
);
|
||||
assert.ok(addResult.success, `phase add failed: ${addResult.error || addResult.output}`);
|
||||
const addPayload = JSON.parse(addResult.output);
|
||||
assert.ok(addPayload.phase_number, 'phase add must return phase_number');
|
||||
|
||||
// 2. Read the persisted section back via the structured roadmap-get-phase
|
||||
// contract (NOT via readFileSync; the `section` field on the JSON payload
|
||||
// is the runtime's typed projection of the on-disk ROADMAP content).
|
||||
const getResult = runGsdTools(
|
||||
['roadmap', 'get-phase', String(addPayload.phase_number)],
|
||||
tmpDir,
|
||||
{ GSD_RUNTIME: 'claude' },
|
||||
);
|
||||
assert.ok(getResult.success, `roadmap get-phase failed: ${getResult.error || getResult.output}`);
|
||||
const getPayload = JSON.parse(getResult.output);
|
||||
assert.ok(getPayload.found, 'roadmap get-phase must find the newly-added phase');
|
||||
assert.ok(typeof getPayload.section === 'string', 'roadmap get-phase must return a section field');
|
||||
|
||||
// 3. The persisted phase section must use the routable hyphen form.
|
||||
assert.ok(
|
||||
!getPayload.section.includes('/gsd:plan-phase'),
|
||||
`persisted phase section must not contain /gsd:plan-phase, got: ${getPayload.section}`,
|
||||
);
|
||||
assert.ok(
|
||||
getPayload.section.includes('/gsd-plan-phase'),
|
||||
`persisted phase section must contain /gsd-plan-phase, got: ${getPayload.section}`,
|
||||
);
|
||||
});
|
||||
});
|
||||
|
||||
describe('bug-3584: validate health emits hyphen form in fix hints', () => {
|
||||
test('validate health on a broken project returns hyphen-form fix strings', (t) => {
|
||||
const tmpDir = createTempDir();
|
||||
t.after(() => cleanup(tmpDir));
|
||||
// No .planning directory → E001 fires with a `fix:` string that contains
|
||||
// the slash-command form.
|
||||
|
||||
const result = runGsdTools(
|
||||
['validate', 'health'],
|
||||
tmpDir,
|
||||
{ GSD_RUNTIME: 'claude' },
|
||||
);
|
||||
// validate health exits non-zero on broken projects but still emits JSON to stdout.
|
||||
const stdout = result.output;
|
||||
let payload;
|
||||
try {
|
||||
payload = JSON.parse(stdout);
|
||||
} catch (e) {
|
||||
throw new Error(`validate health did not emit parseable JSON: ${stdout.slice(0, 400)}`);
|
||||
}
|
||||
|
||||
const allIssues = []
|
||||
.concat(payload.errors || [])
|
||||
.concat(payload.warnings || [])
|
||||
.concat(payload.info || []);
|
||||
|
||||
assert.ok(allIssues.length > 0, 'validate health on a bare tmpdir should report at least one issue');
|
||||
|
||||
const fixesWithSlash = allIssues
|
||||
.map((i) => i.fix)
|
||||
.filter((f) => typeof f === 'string' && /gsd[-:]/.test(f));
|
||||
assert.ok(
|
||||
fixesWithSlash.length > 0,
|
||||
'at least one fix hint should reference a /gsd- slash command',
|
||||
);
|
||||
|
||||
for (const fix of fixesWithSlash) {
|
||||
assert.ok(
|
||||
!fix.includes('/gsd:'),
|
||||
`validate health fix hint must not contain /gsd: colon form, got ${JSON.stringify(fix)}`,
|
||||
);
|
||||
}
|
||||
assertNoColonForm(payload, 'validate health payload');
|
||||
});
|
||||
});
|
||||
|
||||
describe('bug-3584: validate context recommendation uses hyphen form', () => {
|
||||
test('warning/critical recommendations emit /gsd-thread', (t) => {
|
||||
const tmpDir = createTempProject();
|
||||
t.after(() => cleanup(tmpDir));
|
||||
|
||||
// Critical band: 75% utilization. validate context emits JSON only with --json.
|
||||
const result = runGsdTools(
|
||||
['validate', 'context', '--tokens-used', '75000', '--context-window', '100000', '--json'],
|
||||
tmpDir,
|
||||
{ GSD_RUNTIME: 'claude' },
|
||||
);
|
||||
assert.ok(result.success, `validate context failed: ${result.error || result.output}`);
|
||||
|
||||
const payload = JSON.parse(result.output);
|
||||
assert.ok(payload.recommendation, 'critical utilization should produce a recommendation');
|
||||
assert.ok(
|
||||
!payload.recommendation.includes('/gsd:'),
|
||||
`recommendation must not contain /gsd:, got ${JSON.stringify(payload.recommendation)}`,
|
||||
);
|
||||
assert.ok(
|
||||
payload.recommendation.includes('/gsd-thread'),
|
||||
`recommendation must reference /gsd-thread, got ${JSON.stringify(payload.recommendation)}`,
|
||||
);
|
||||
});
|
||||
});
|
||||
|
||||
describe('bug-3584: validate health uses formatter for codex runtime too', () => {
|
||||
test('validate health under codex emits $gsd-<cmd> in fix strings', (t) => {
|
||||
const tmpDir = createTempDir();
|
||||
t.after(() => cleanup(tmpDir));
|
||||
|
||||
const result = runGsdTools(
|
||||
['validate', 'health'],
|
||||
tmpDir,
|
||||
{ GSD_RUNTIME: 'codex' },
|
||||
);
|
||||
let payload;
|
||||
try {
|
||||
payload = JSON.parse(result.output);
|
||||
} catch (e) {
|
||||
throw new Error(`validate health (codex) did not emit JSON: ${result.output.slice(0, 400)}`);
|
||||
}
|
||||
|
||||
const allIssues = []
|
||||
.concat(payload.errors || [])
|
||||
.concat(payload.warnings || [])
|
||||
.concat(payload.info || []);
|
||||
|
||||
const fixesWithSlash = allIssues
|
||||
.map((i) => i.fix)
|
||||
.filter((f) => typeof f === 'string' && /gsd-/.test(f));
|
||||
|
||||
// For codex, hyphen-with-slash form `/gsd-<cmd>` should be replaced by
|
||||
// shell-var `$gsd-<cmd>`. Skip the assertion if no relevant fix was
|
||||
// produced (test only asserts the contract when something is emitted).
|
||||
for (const fix of fixesWithSlash) {
|
||||
assert.ok(
|
||||
!fix.includes('/gsd:'),
|
||||
`codex validate health fix must not contain /gsd: colon form, got ${JSON.stringify(fix)}`,
|
||||
);
|
||||
// Codex emits $gsd- — any /gsd- in the fix means the formatter wasn't applied.
|
||||
// (We don't have a hard count guarantee — a fix can also reference a plain url etc.)
|
||||
}
|
||||
});
|
||||
});
|
||||
209
tests/bug-3584-runtime-slash-formatter.test.cjs
Normal file
209
tests/bug-3584-runtime-slash-formatter.test.cjs
Normal file
@@ -0,0 +1,209 @@
|
||||
/**
|
||||
* Regression tests for bug #3584
|
||||
*
|
||||
* Runtime/user-facing strings emitted by get-shit-done/bin/lib/*.cjs hardcoded
|
||||
* the deprecated `/gsd:<cmd>` colon form (16 files, ~50 occurrences). After
|
||||
* #2808 unified GSD installs to register skills under the hyphen form
|
||||
* (`name: gsd-execute-phase`), pasting the emitted `/gsd:execute-phase` into
|
||||
* Claude Code yields `Unknown command: /gsd:execute-phase. Did you mean
|
||||
* /gsd-execute-phase?`. Codex installs require `$gsd-<cmd>` (shell-var) form.
|
||||
*
|
||||
* Fix: a runtime-aware slash formatter (`runtime-slash.cjs`) is now the single
|
||||
* source of truth for emitting `/gsd-<cmd>` (hyphen) for skills-based runtimes
|
||||
* and `$gsd-<cmd>` for Codex. Tests assert on the formatter's typed output and
|
||||
* — for the integration tests in `bug-3584-runtime-slash-emitters.test.cjs` —
|
||||
* on the structured `--json` payloads from the runtime command handlers.
|
||||
*/
|
||||
|
||||
'use strict';
|
||||
|
||||
const { describe, test } = require('node:test');
|
||||
const assert = require('node:assert/strict');
|
||||
const path = require('path');
|
||||
|
||||
const ROOT = path.join(__dirname, '..');
|
||||
const { formatGsdSlash, resolveRuntime } = require(
|
||||
path.join(ROOT, 'get-shit-done', 'bin', 'lib', 'runtime-slash.cjs'),
|
||||
);
|
||||
|
||||
describe('formatGsdSlash — runtime-aware slash command formatter', () => {
|
||||
describe('hyphen-form runtimes (claude, cursor, opencode, kilo, etc.)', () => {
|
||||
test('emits /gsd-<cmd> for claude', () => {
|
||||
assert.strictEqual(formatGsdSlash('execute-phase', 'claude'), '/gsd-execute-phase');
|
||||
});
|
||||
|
||||
test('emits /gsd-<cmd> for cursor', () => {
|
||||
assert.strictEqual(formatGsdSlash('plan-phase', 'cursor'), '/gsd-plan-phase');
|
||||
});
|
||||
|
||||
test('emits /gsd-<cmd> for opencode', () => {
|
||||
assert.strictEqual(formatGsdSlash('discuss-phase', 'opencode'), '/gsd-discuss-phase');
|
||||
});
|
||||
|
||||
test('emits /gsd-<cmd> for kilo', () => {
|
||||
assert.strictEqual(formatGsdSlash('health', 'kilo'), '/gsd-health');
|
||||
});
|
||||
|
||||
test('unknown runtime defaults to hyphen form', () => {
|
||||
assert.strictEqual(
|
||||
formatGsdSlash('new-project', 'some-future-runtime'),
|
||||
'/gsd-new-project',
|
||||
);
|
||||
});
|
||||
|
||||
test('null/undefined runtime defaults to hyphen form (claude)', () => {
|
||||
assert.strictEqual(formatGsdSlash('new-milestone', null), '/gsd-new-milestone');
|
||||
assert.strictEqual(formatGsdSlash('new-milestone', undefined), '/gsd-new-milestone');
|
||||
});
|
||||
});
|
||||
|
||||
describe('codex shell-var form', () => {
|
||||
test('emits $gsd-<cmd> for codex', () => {
|
||||
assert.strictEqual(formatGsdSlash('execute-phase', 'codex'), '$gsd-execute-phase');
|
||||
});
|
||||
|
||||
test('codex output is lowercased', () => {
|
||||
assert.strictEqual(
|
||||
formatGsdSlash('Execute-Phase', 'codex'),
|
||||
'$gsd-execute-phase',
|
||||
);
|
||||
});
|
||||
});
|
||||
|
||||
describe('input normalization', () => {
|
||||
test('strips existing /gsd: colon prefix', () => {
|
||||
assert.strictEqual(
|
||||
formatGsdSlash('/gsd:execute-phase', 'claude'),
|
||||
'/gsd-execute-phase',
|
||||
);
|
||||
});
|
||||
|
||||
test('strips existing /gsd- hyphen prefix (idempotent)', () => {
|
||||
assert.strictEqual(
|
||||
formatGsdSlash('/gsd-plan-phase', 'claude'),
|
||||
'/gsd-plan-phase',
|
||||
);
|
||||
});
|
||||
|
||||
test('strips bare gsd: prefix without leading slash', () => {
|
||||
assert.strictEqual(
|
||||
formatGsdSlash('gsd:new-project', 'claude'),
|
||||
'/gsd-new-project',
|
||||
);
|
||||
});
|
||||
|
||||
test('strips existing $gsd- shell prefix (codex idempotent)', () => {
|
||||
assert.strictEqual(
|
||||
formatGsdSlash('$gsd-execute-phase', 'codex'),
|
||||
'$gsd-execute-phase',
|
||||
);
|
||||
});
|
||||
|
||||
test('runtime swap: /gsd:execute-phase + codex → $gsd-execute-phase', () => {
|
||||
assert.strictEqual(
|
||||
formatGsdSlash('/gsd:execute-phase', 'codex'),
|
||||
'$gsd-execute-phase',
|
||||
);
|
||||
});
|
||||
|
||||
test('case-insensitive prefix stripping', () => {
|
||||
assert.strictEqual(
|
||||
formatGsdSlash('GSD:execute-phase', 'claude'),
|
||||
'/gsd-execute-phase',
|
||||
);
|
||||
});
|
||||
});
|
||||
|
||||
describe('defensive returns for unsafe inputs', () => {
|
||||
test('non-string commandName returns input unchanged', () => {
|
||||
assert.strictEqual(formatGsdSlash(null, 'claude'), null);
|
||||
assert.strictEqual(formatGsdSlash(undefined, 'claude'), undefined);
|
||||
assert.strictEqual(formatGsdSlash(42, 'claude'), 42);
|
||||
});
|
||||
|
||||
test('empty string returns empty string', () => {
|
||||
assert.strictEqual(formatGsdSlash('', 'claude'), '');
|
||||
});
|
||||
|
||||
test('whitespace-only string is treated as empty after prefix strip', () => {
|
||||
// Whitespace is preserved as-is in the output rather than mangled,
|
||||
// so callers can detect "no real command" instead of receiving "/gsd- ".
|
||||
const result = formatGsdSlash(' ', 'claude');
|
||||
assert.ok(
|
||||
result === ' ' || result === '/gsd- ',
|
||||
`whitespace input should round-trip or be predictably wrapped, got ${JSON.stringify(result)}`,
|
||||
);
|
||||
});
|
||||
|
||||
test('commands with arguments preserve the argument tail', () => {
|
||||
// `execute-phase 03` is a valid call shape — the formatter only
|
||||
// rewrites the command token; everything after the first whitespace
|
||||
// belongs to the caller.
|
||||
assert.strictEqual(
|
||||
formatGsdSlash('execute-phase 03', 'claude'),
|
||||
'/gsd-execute-phase 03',
|
||||
);
|
||||
assert.strictEqual(
|
||||
formatGsdSlash('/gsd:execute-phase 03', 'claude'),
|
||||
'/gsd-execute-phase 03',
|
||||
);
|
||||
});
|
||||
});
|
||||
});
|
||||
|
||||
describe('resolveRuntime — env > config > default', () => {
|
||||
test('process.env.GSD_RUNTIME wins over everything', () => {
|
||||
const saved = process.env.GSD_RUNTIME;
|
||||
try {
|
||||
process.env.GSD_RUNTIME = 'codex';
|
||||
assert.strictEqual(resolveRuntime(null), 'codex');
|
||||
assert.strictEqual(resolveRuntime('/nonexistent'), 'codex');
|
||||
} finally {
|
||||
if (saved === undefined) delete process.env.GSD_RUNTIME;
|
||||
else process.env.GSD_RUNTIME = saved;
|
||||
}
|
||||
});
|
||||
|
||||
test('defaults to claude when env is unset and projectDir missing', () => {
|
||||
const saved = process.env.GSD_RUNTIME;
|
||||
try {
|
||||
delete process.env.GSD_RUNTIME;
|
||||
assert.strictEqual(resolveRuntime(null), 'claude');
|
||||
assert.strictEqual(resolveRuntime(undefined), 'claude');
|
||||
} finally {
|
||||
if (saved !== undefined) process.env.GSD_RUNTIME = saved;
|
||||
}
|
||||
});
|
||||
|
||||
test('reads config.runtime when env is unset and projectDir has a config', (t) => {
|
||||
const fs = require('fs');
|
||||
const os = require('os');
|
||||
const tmp = fs.mkdtempSync(path.join(os.tmpdir(), 'gsd-3584-'));
|
||||
t.after(() => fs.rmSync(tmp, { recursive: true, force: true }));
|
||||
|
||||
fs.mkdirSync(path.join(tmp, '.planning'), { recursive: true });
|
||||
fs.writeFileSync(
|
||||
path.join(tmp, '.planning', 'config.json'),
|
||||
JSON.stringify({ runtime: 'codex' }),
|
||||
);
|
||||
|
||||
const saved = process.env.GSD_RUNTIME;
|
||||
try {
|
||||
delete process.env.GSD_RUNTIME;
|
||||
assert.strictEqual(resolveRuntime(tmp), 'codex');
|
||||
} finally {
|
||||
if (saved !== undefined) process.env.GSD_RUNTIME = saved;
|
||||
}
|
||||
});
|
||||
|
||||
test('lowercases the resolved runtime', () => {
|
||||
const saved = process.env.GSD_RUNTIME;
|
||||
try {
|
||||
process.env.GSD_RUNTIME = 'CLAUDE';
|
||||
assert.strictEqual(resolveRuntime(null), 'claude');
|
||||
} finally {
|
||||
if (saved === undefined) delete process.env.GSD_RUNTIME;
|
||||
else process.env.GSD_RUNTIME = saved;
|
||||
}
|
||||
});
|
||||
});
|
||||
@@ -40,9 +40,14 @@ describe('generate-claude-md', () => {
|
||||
const claudePath = path.join(tmpDir, 'CLAUDE.md');
|
||||
const content = fs.readFileSync(claudePath, 'utf-8');
|
||||
assert.ok(content.includes('## GSD Workflow Enforcement'));
|
||||
assert.ok(content.includes('/gsd:quick'));
|
||||
assert.ok(content.includes('/gsd:debug'));
|
||||
assert.ok(content.includes('/gsd:execute-phase'));
|
||||
// #3584: generated CLAUDE.md must emit the runtime-routable hyphen-form
|
||||
// (Claude/Cursor/OpenCode/Kilo etc.); the legacy colon form is no longer
|
||||
// dispatched by current skill installs.
|
||||
assert.ok(content.includes('/gsd-quick'));
|
||||
assert.ok(content.includes('/gsd-debug'));
|
||||
assert.ok(content.includes('/gsd-execute-phase'));
|
||||
assert.ok(!content.includes('/gsd:quick'));
|
||||
assert.ok(!content.includes('/gsd:execute-phase'));
|
||||
assert.ok(content.includes('Do not make direct repo edits outside a GSD workflow'));
|
||||
});
|
||||
|
||||
|
||||
@@ -800,14 +800,24 @@ describe('Copilot content conversion - engine files', () => {
|
||||
});
|
||||
|
||||
test('converts engine .cjs files correctly', () => {
|
||||
const verifyCjs = fs.readFileSync(
|
||||
path.join(__dirname, '..', 'get-shit-done', 'bin', 'lib', 'verify.cjs'), 'utf8'
|
||||
);
|
||||
const result = convertClaudeToCopilotContent(verifyCjs);
|
||||
// #3584: bin/lib/*.cjs no longer hardcodes `/gsd:<cmd>` literals — runtime
|
||||
// emissions now flow through `runtime-slash.cjs::formatGsdSlash()` which
|
||||
// already produces the runtime-routable shape. The Copilot install
|
||||
// converter still needs to handle source files that DO contain literal
|
||||
// colon-form references (commands/gsd/*.md, workflow .md files, etc.), so
|
||||
// assert the converter contract against a synthetic input that mirrors the
|
||||
// shape those files have.
|
||||
const synthetic = [
|
||||
'Run /gsd:new-project to initialize.',
|
||||
'On error, run /gsd:health --repair to regenerate.',
|
||||
'For phase work, use /gsd:execute-phase 1.',
|
||||
].join('\n');
|
||||
const result = convertClaudeToCopilotContent(synthetic);
|
||||
|
||||
assert.ok(!result.match(/gsd:[a-z]/), 'no gsd: references remain');
|
||||
assert.ok(result.includes('gsd-new-project'), 'gsd:new-project converted');
|
||||
assert.ok(result.includes('gsd-health'), 'gsd:health converted');
|
||||
assert.ok(!result.match(/gsd:[a-z]/), 'no gsd: references remain after conversion');
|
||||
assert.ok(result.includes('gsd-new-project'), 'gsd:new-project converted to hyphen form');
|
||||
assert.ok(result.includes('gsd-health'), 'gsd:health converted to hyphen form');
|
||||
assert.ok(result.includes('gsd-execute-phase'), 'gsd:execute-phase converted to hyphen form');
|
||||
});
|
||||
});
|
||||
|
||||
|
||||
@@ -244,7 +244,9 @@ describe('milestone complete command', () => {
|
||||
assert.ok(state.includes('Phase: Milestone v1.0 complete'));
|
||||
assert.ok(state.includes('Status: Awaiting next milestone'));
|
||||
assert.ok(!state.includes('Re-run /gsd:complete-milestone'));
|
||||
assert.ok(state.includes('/gsd:new-milestone'));
|
||||
// #3584: persisted ROADMAP/STATE strings now use the runtime-routable
|
||||
// hyphen-form slash command (formatter resolves codex → $gsd-, others → /gsd-).
|
||||
assert.ok(state.includes('/gsd-new-milestone'));
|
||||
});
|
||||
|
||||
test('appends canonical narrative sections when STATE.md headings are missing (#3088)', () => {
|
||||
@@ -261,7 +263,8 @@ describe('milestone complete command', () => {
|
||||
assert.ok(state.includes('## Current Position'));
|
||||
assert.ok(state.includes('Phase: Milestone v1.0 complete'));
|
||||
assert.ok(state.includes('## Operator Next Steps'));
|
||||
assert.ok(state.includes('/gsd:new-milestone'));
|
||||
// #3584: hyphen form is the runtime-routable shape for skills-based installs.
|
||||
assert.ok(state.includes('/gsd-new-milestone'));
|
||||
});
|
||||
|
||||
test('handles missing ROADMAP.md gracefully', () => {
|
||||
|
||||
@@ -58,7 +58,7 @@ describe('gsd-tools validate context — JSON vs human rendering', () => {
|
||||
assert.strictEqual(r.success, true);
|
||||
assert.match(r.output, /70%/);
|
||||
assert.match(r.output, /critical/);
|
||||
assert.match(r.output, /\/gsd:thread/);
|
||||
assert.match(r.output, /\/gsd-thread/);
|
||||
});
|
||||
|
||||
test('human mode omits the recommendation line for healthy state', () => {
|
||||
@@ -66,25 +66,25 @@ describe('gsd-tools validate context — JSON vs human rendering', () => {
|
||||
assert.strictEqual(r.success, true);
|
||||
assert.match(r.output, /20%/);
|
||||
assert.match(r.output, /healthy/);
|
||||
assert.doesNotMatch(r.output, /\/gsd:thread/, 'healthy output must not nag the user');
|
||||
assert.doesNotMatch(r.output, /\/gsd-thread/, 'healthy output must not nag the user');
|
||||
});
|
||||
});
|
||||
|
||||
describe('gsd-tools validate context — recommendation copy per state', () => {
|
||||
// The CLI owns the recommendation strings (the classifier does not).
|
||||
// These tests pin the wording so a regression to the prose is caught.
|
||||
test('warning state recommends /gsd:thread', () => {
|
||||
test('warning state recommends /gsd-thread', () => {
|
||||
const r = runGsdTools(['validate', 'context', '--tokens-used', '130000', '--context-window', '200000', '--json']);
|
||||
const obj = JSON.parse(r.output);
|
||||
assert.strictEqual(obj.state, 'warning');
|
||||
assert.match(obj.recommendation, /\/gsd:thread/);
|
||||
assert.match(obj.recommendation, /\/gsd-thread/);
|
||||
});
|
||||
|
||||
test('critical state names the fracture-point reasoning risk', () => {
|
||||
const r = runGsdTools(['validate', 'context', '--tokens-used', '160000', '--context-window', '200000', '--json']);
|
||||
const obj = JSON.parse(r.output);
|
||||
assert.strictEqual(obj.state, 'critical');
|
||||
assert.match(obj.recommendation, /\/gsd:thread/);
|
||||
assert.match(obj.recommendation, /\/gsd-thread/);
|
||||
assert.match(obj.recommendation, /reasoning|degrade|fracture/i);
|
||||
});
|
||||
});
|
||||
|
||||
Reference in New Issue
Block a user