scripts/ci-test-scope.cjs's classify() previously set full_matrix=true for ANY changed tests/**/*.test.cjs file, unconditionally (restored by #4421 after #962's narrowing let a real macOS-only regression, PR #4384, land undetected). This replaces that blanket rule with a reachability check against real data instead of a path prefix: - A changed test file forces full_matrix only when it is present in Phase 2's committed CONFORMANCE_TIER_FILES list (scripts/lib/platform- conformance-tier.generated.cjs) -- direct membership, not a graph walk. - A changed src/ file forces full_matrix when its own content carries a genuine platform-conditional signal, reusing gen-platform-conformance- tier.cjs's classifyContent with a narrowed, source-code-safe signal subset (excludes two categories -- hardcoded-path-vs-path-call and symlink-keyword -- empirically found to flag 100/235 src/ files when applied verbatim, versus 28/235 with the narrow subset, all verified to carry genuine platform branches). New export: NOISY_FOR_SOURCE_REACHABILITY. - A change to the classification mechanism's own definition files (gen-platform-conformance-tier.cjs, the generated tier list, or suite-detection.cjs) always forces full_matrix -- the mechanism being changed cannot presume its own new output is safe. - Any computation error (a require/read failure, a malformed module) fails safe to full_matrix=true, per the issue's explicit requirement. The existing RULES array entries with their own fullMatrix:true (workflow automation, installer/package layout, hooks, environment/dependency gates, test harness) are deliberately left untouched -- they are curated, narrowly-scoped triggers for "this diff changes the CI/installer/hooks mechanism itself," a different and still-valid reason than "product code might reach a platform branch." Disclosed in .gsd/phase/.../40-design.md as a scope decision, since the issue's "Done when" wording read broader than its "Proposed work" bullets. Two design assumptions were caught and corrected before any code was written (rubber-duck pass, documented in 40-design.md): (1) reusing Phase 2's classifyContent verbatim against src/ was far too noisy; (2) a single hardcoded seam file (src/shell-command-projection.cts only, per CLAUDE.md's "single platform seam" framing) would have silently missed genuine, independent platform branches in src/runtime-hooks-surface.cts, src/capability-lock.cts, src/capability-ledger.cts, and src/surface.cts -- reintroducing the #4421 failure shape inside src/ instead of tests/. An isolated code-review pass found and fixed one real defect (a dead, untested branch that would have survived Stryker mutation testing) and one design-doc completeness gap (2 of 8 "narrow" signal categories were left implicitly rather than explicitly audited). An isolated security-review pass found no qualifying findings. tests/ci-test-scope.test.cjs gains the full #4592 boundary-case matrix (.gsd/phase/.../50-test-matrix.md), including a named #4421 regression case proving tests/state-todos-render.test.cjs still forces full_matrix, now for the documented reason instead of the removed blanket rule. Two pre-existing tests were corrected: one used a nonexistent fixture path (src/semver.cts -> src/semver-compare.cts, a real file); one (A3) asserted the exact old blanket-rule behavior this issue removes, updated to the new, verified- correct expectation. Co-authored-by: sim <sim@local> Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
This commit is contained in:
Tom Boucher
@@ -3,9 +3,10 @@
|
||||
|
||||
const path = require('path');
|
||||
const { execFileSync } = require('child_process');
|
||||
const { existsSync, readdirSync, appendFileSync } = require('fs');
|
||||
const { existsSync, readdirSync, appendFileSync, readFileSync } = require('fs');
|
||||
|
||||
const { ExitError, runMain } = require('./lib/cli-exit.cjs');
|
||||
const { classifyContent, NOISY_FOR_SOURCE_REACHABILITY } = require('./gen-platform-conformance-tier.cjs');
|
||||
|
||||
// Workflow files that are purely administrative / policy bots. Changes to these
|
||||
// files do NOT require the cross-platform test matrix — only a lightweight
|
||||
@@ -487,7 +488,55 @@ function addAll(set, values) {
|
||||
const WINDOWS_HINTS = ['windows', 'win32', 'shell', 'path'];
|
||||
const isWindowsHint = s => WINDOWS_HINTS.some(k => s.toLowerCase().includes(k));
|
||||
|
||||
function classify(files) {
|
||||
// A change to the classification mechanism itself cannot be presumed safe by
|
||||
// the very mechanism being changed (#4592).
|
||||
const CLASSIFIER_DEFINITION_FILES = new Set([
|
||||
'scripts/gen-platform-conformance-tier.cjs',
|
||||
'scripts/lib/platform-conformance-tier.generated.cjs',
|
||||
'scripts/lib/suite-detection.cjs',
|
||||
]);
|
||||
|
||||
/**
|
||||
* Does `file`'s blast radius reach (a) Phase 2's conformance-tier test-file
|
||||
* list or (b) a live platform-conditional signal in src/? Fail-safe: any
|
||||
* thrown error (a require failure, a readFileSync failure, a malformed
|
||||
* generated module, etc.) is treated as uncertainty and returns true — per
|
||||
* #4592's explicit "fail-safe to full_matrix=true on any reachability-
|
||||
* computation error or uncertainty" requirement.
|
||||
* `loadConformanceTier` is injectable (defaults to the real generated module)
|
||||
* solely so tests can simulate a load failure without touching the real,
|
||||
* committed generated file.
|
||||
* @param {string} file
|
||||
* @param {{loadConformanceTier?: () => {CONFORMANCE_TIER_FILES: string[]}}} [deps]
|
||||
* @returns {boolean}
|
||||
*/
|
||||
function reachesConformanceTierOrSeam(file, deps = {}) {
|
||||
const loadConformanceTier =
|
||||
deps.loadConformanceTier || (() => require('./lib/platform-conformance-tier.generated.cjs'));
|
||||
try {
|
||||
if (file.startsWith('tests/') && file.endsWith('.test.cjs')) {
|
||||
const { CONFORMANCE_TIER_FILES } = loadConformanceTier();
|
||||
return CONFORMANCE_TIER_FILES.includes(file);
|
||||
}
|
||||
|
||||
if (file.startsWith('src/')) {
|
||||
const content = readFileSync(file, 'utf8');
|
||||
const { signals } = classifyContent(content);
|
||||
const narrowSignals = signals.filter(signal => !NOISY_FOR_SOURCE_REACHABILITY.has(signal));
|
||||
return narrowSignals.length > 0;
|
||||
}
|
||||
|
||||
return false;
|
||||
} catch {
|
||||
return true;
|
||||
}
|
||||
}
|
||||
|
||||
// `reachabilityDeps` is injectable (defaults to {}, which makes
|
||||
// reachesConformanceTierOrSeam use the real generated module) solely so
|
||||
// tests can simulate a reachability-computation failure without touching
|
||||
// the real, committed generated file.
|
||||
function classify(files, reachabilityDeps = {}) {
|
||||
const targeted = new Set();
|
||||
const windows = new Set();
|
||||
const reasons = [];
|
||||
@@ -532,8 +581,30 @@ function classify(files) {
|
||||
// lane already covered them. Rescinded per #4421: PR #4384 landed a
|
||||
// macOS-only regression on 2026-09-06 that stayed invisible pre-merge
|
||||
// precisely because this carve-out suppressed the only macOS signal.
|
||||
// The ~25-runner-minute cost on test-touching PRs is accepted.
|
||||
// #4592: the blanket rule is replaced with a reachability check — only
|
||||
// a changed test file that actually reaches Phase 2's conformance-tier
|
||||
// list (or is the classification mechanism itself) forces full_matrix.
|
||||
if (reachesConformanceTierOrSeam(file, reachabilityDeps)) {
|
||||
fullMatrix = true;
|
||||
reasons.push(`${file}: conformance-tier reachability`);
|
||||
}
|
||||
}
|
||||
|
||||
// #4592: a src/-only diff (no test file touched) must still be able to
|
||||
// set full_matrix=true when it carries a live platform-conditional
|
||||
// signal — this is independent of the tests/ branch above.
|
||||
if (file.startsWith('src/') && reachesConformanceTierOrSeam(file, reachabilityDeps)) {
|
||||
fullMatrix = true;
|
||||
reasons.push(`${file}: platform seam reachability`);
|
||||
}
|
||||
|
||||
// #4592: a changed file that IS the classification mechanism itself
|
||||
// (neither under tests/ nor src/, so neither branch above reaches it)
|
||||
// must also force full_matrix — a change to the mechanism cannot be
|
||||
// presumed safe by the very mechanism being changed.
|
||||
if (CLASSIFIER_DEFINITION_FILES.has(file)) {
|
||||
fullMatrix = true;
|
||||
reasons.push(`${file}: reachability classifier definition changed`);
|
||||
}
|
||||
|
||||
for (const rule of RULES) {
|
||||
@@ -629,4 +700,12 @@ if (require.main === module) {
|
||||
runMain(main);
|
||||
}
|
||||
|
||||
module.exports = { RULES, missingRuleTestFiles, PROTECTED_WORKFLOWS, INERT_WORKFLOWS, missingProtectedWorkflows };
|
||||
module.exports = {
|
||||
RULES,
|
||||
missingRuleTestFiles,
|
||||
PROTECTED_WORKFLOWS,
|
||||
INERT_WORKFLOWS,
|
||||
missingProtectedWorkflows,
|
||||
classify,
|
||||
reachesConformanceTierOrSeam,
|
||||
};
|
||||
|
||||
@@ -150,6 +150,14 @@ const CATEGORIES = [
|
||||
},
|
||||
];
|
||||
|
||||
// Two CATEGORIES entries precise enough for TEST-file classification (this
|
||||
// module's own purpose) but far too broad for SOURCE-file reachability
|
||||
// (scripts/ci-test-scope.cjs's #4592 use). Empirically verified: applying
|
||||
// classifyContent to every file under src/ (235 files) flags 100 of them,
|
||||
// driven almost entirely by these two categories; excluding them narrows it
|
||||
// to 28 files, all verified to carry a genuine platform-conditional branch.
|
||||
const NOISY_FOR_SOURCE_REACHABILITY = new Set(['hardcoded-path-vs-path-call', 'symlink-keyword']);
|
||||
|
||||
/**
|
||||
* Pure classifier: given a test file's raw string content, returns which
|
||||
* platform-conformance categories matched and whether the file needs real-OS
|
||||
@@ -333,4 +341,4 @@ if (require.main === module) {
|
||||
runMain(main);
|
||||
}
|
||||
|
||||
module.exports = { classifyContent, CATEGORIES, walkTestFiles, classifyTree, renderGeneratedFile };
|
||||
module.exports = { classifyContent, CATEGORIES, NOISY_FOR_SOURCE_REACHABILITY, walkTestFiles, classifyTree, renderGeneratedFile };
|
||||
|
||||
@@ -15,12 +15,16 @@ const ROOT = path.join(__dirname, '..');
|
||||
const SCRIPT = path.join(ROOT, 'scripts', 'ci-test-scope.cjs');
|
||||
const WORKFLOWS_DIR = path.join(ROOT, '.github', 'workflows');
|
||||
|
||||
function scopeFor(files) {
|
||||
const r = runNode([SCRIPT, '--files', files.join(' ')], { cwd: ROOT, timeoutMs: PROBE_TIMEOUT_MS });
|
||||
function scopeForAt(files, cwd) {
|
||||
const r = runNode([SCRIPT, '--files', files.join(' ')], { cwd, timeoutMs: PROBE_TIMEOUT_MS });
|
||||
assert.strictEqual(r.exitCode, 0, `stderr: ${r.stderr}\nstdout: ${r.stdout}`);
|
||||
return JSON.parse(r.stdout);
|
||||
}
|
||||
|
||||
function scopeFor(files) {
|
||||
return scopeForAt(files, ROOT);
|
||||
}
|
||||
|
||||
describe('ci-test-scope.cjs', () => {
|
||||
test('docs-only changes: code_changed is false, product_changed false (skip matrix entirely)', () => {
|
||||
const result = scopeFor(['docs/usage.md']);
|
||||
@@ -77,8 +81,14 @@ describe('ci-test-scope.cjs', () => {
|
||||
`expected policy-lint-shallow-checkout in targeted_tests for inert CI, got: ${JSON.stringify(result.targeted_tests)}`);
|
||||
});
|
||||
|
||||
test('TS runtime sources (src/semver.cts) — code_changed true, product_changed true, full_matrix false, semver tests targeted', () => {
|
||||
const result = scopeFor(['src/semver.cts']);
|
||||
test('TS runtime sources (src/semver-compare.cts) — code_changed true, product_changed true, full_matrix false, semver tests targeted', () => {
|
||||
// #4592: must be a REAL, on-disk src/ file with no narrow platform signal.
|
||||
// A nonexistent path (the former fixture, 'src/semver.cts', names no real
|
||||
// file in this repo) now hits reachesConformanceTierOrSeam's readFileSync
|
||||
// fail-safe (ENOENT → full_matrix=true by design), which would silently
|
||||
// test the fail-safe path instead of this test's actual subject: the "TS
|
||||
// runtime sources" RULES entry has no fullMatrix field of its own.
|
||||
const result = scopeFor(['src/semver-compare.cts']);
|
||||
assert.strictEqual(result.code_changed, true,
|
||||
`expected code_changed=true for src/ change, got: ${JSON.stringify(result)}`);
|
||||
assert.strictEqual(result.product_changed, true,
|
||||
@@ -284,8 +294,13 @@ describe('ci-test-scope superset invariant (#494, rescinded by #4421)', () => {
|
||||
// the scoped windows lane instead of triggering the full parity matrix.
|
||||
// Rescinded per #4421 (2026-09-06 RCA: PR #4384 shipped a macOS-only
|
||||
// regression invisible pre-merge because of exactly this carve-out) — a
|
||||
// changed test file now ALWAYS sets full_matrix=true, in addition to still
|
||||
// joining the scoped windows lane.
|
||||
// changed test file always joins the scoped windows lane, and (until
|
||||
// #4592) ALWAYS set full_matrix=true too. #4592 replaces that blanket rule
|
||||
// with a reachability check: full_matrix now fires only when the changed
|
||||
// test file is tagged in Phase 2's CONFORMANCE_TIER_FILES (or is the
|
||||
// classification mechanism itself). A1/A2 below are real, committed
|
||||
// conformance-tier files, so they still assert full_matrix=true — for the
|
||||
// new, documented reason, not the removed blanket rule.
|
||||
test('A1: a changed test file joins the windows scoped lane AND triggers full_matrix', () => {
|
||||
const result = scopeFor(['tests/perf-317-context-monitor-fs.test.cjs']);
|
||||
assert.strictEqual(result.full_matrix, true,
|
||||
@@ -306,10 +321,17 @@ describe('ci-test-scope superset invariant (#494, rescinded by #4421)', () => {
|
||||
`expected hint-less changed test in windows_tests, got: ${JSON.stringify(result.windows_tests)}`);
|
||||
});
|
||||
|
||||
test('A3: a deleted/nonexistent test path falls back to the unit token, still triggers full_matrix', () => {
|
||||
test('A3: a deleted/nonexistent test path falls back to the unit token; full_matrix now depends on conformance-tier reachability (#4592)', () => {
|
||||
// Pre-#4592, the removed blanket rule forced full_matrix=true for ANY
|
||||
// changed tests/*.test.cjs path regardless of on-disk existence or
|
||||
// content. #4592 replaces that with direct CONFORMANCE_TIER_FILES
|
||||
// membership — a path absent from the committed list is treated as
|
||||
// genuinely Linux-safe, not as uncertain (design doc's explicit policy),
|
||||
// so a synthetic/nonexistent path with no tier entry now yields
|
||||
// full_matrix=false.
|
||||
const result = scopeFor(['tests/some-new.test.cjs']);
|
||||
assert.strictEqual(result.full_matrix, true,
|
||||
`expected full_matrix=true even for a nonexistent tests/*.test.cjs path — the matrix decision is made on the changed-file name, not on-disk existence (rescinded #494 carve-out, see #4421), got: ${JSON.stringify(result)}`);
|
||||
assert.strictEqual(result.full_matrix, false,
|
||||
`expected full_matrix=false for a tests/*.test.cjs path absent from CONFORMANCE_TIER_FILES (#4592), got: ${JSON.stringify(result)}`);
|
||||
// The nonexistent file is filtered by existingTests(); with nothing left,
|
||||
// the #408 fallback applies so the targeted lane still runs something.
|
||||
assert.deepStrictEqual(result.targeted_tests, ['unit']);
|
||||
@@ -840,6 +862,173 @@ describe('code_changed=false implies clean output invariant', () => {
|
||||
});
|
||||
|
||||
|
||||
describe('#4592 reachability-based full_matrix classifier', () => {
|
||||
// Row 1: a real, committed conformance-tier test file forces full_matrix,
|
||||
// and the reason names the new mechanism (not a generic path-prefix rule).
|
||||
test('full_matrix true for a conformance-tier test file', () => {
|
||||
const { CONFORMANCE_TIER_FILES } = require('../scripts/lib/platform-conformance-tier.generated.cjs');
|
||||
assert.ok(CONFORMANCE_TIER_FILES.length > 0, 'precondition: committed tier list must be non-empty');
|
||||
const file = CONFORMANCE_TIER_FILES[0];
|
||||
const result = scopeFor([file]);
|
||||
assert.strictEqual(result.full_matrix, true,
|
||||
`expected full_matrix=true for conformance-tier file ${file}, got: ${JSON.stringify(result)}`);
|
||||
assert.ok(result.reasons.includes(`${file}: conformance-tier reachability`),
|
||||
`expected reasons to name the conformance-tier mechanism, got: ${JSON.stringify(result.reasons)}`);
|
||||
});
|
||||
|
||||
// Row 2: the whole point of the change — a changed test file that is NOT in
|
||||
// CONFORMANCE_TIER_FILES and matches no other RULES entry must NOT force
|
||||
// full_matrix.
|
||||
test('full_matrix false for a non-conformance-tier test file alone', () => {
|
||||
const { CONFORMANCE_TIER_FILES } = require('../scripts/lib/platform-conformance-tier.generated.cjs');
|
||||
const file = 'tests/some-brand-new-non-tier.test.cjs';
|
||||
assert.ok(!CONFORMANCE_TIER_FILES.includes(file), 'precondition: fixture path must not be tier-tagged');
|
||||
const result = scopeFor([file]);
|
||||
assert.strictEqual(result.full_matrix, false,
|
||||
`expected full_matrix=false for a non-conformance-tier test file, got: ${JSON.stringify(result)}`);
|
||||
});
|
||||
|
||||
// Row 3: named #4421 regression — the exact file from PR #4384 must still
|
||||
// force full_matrix, now for the documented reachability reason instead of
|
||||
// the removed blanket rule.
|
||||
test('#4421 regression: state-todos-render.test.cjs still forces full_matrix, for the documented reason', () => {
|
||||
const file = 'tests/state-todos-render.test.cjs';
|
||||
const { CONFORMANCE_TIER_FILES } = require('../scripts/lib/platform-conformance-tier.generated.cjs');
|
||||
assert.ok(CONFORMANCE_TIER_FILES.includes(file),
|
||||
'precondition: state-todos-render.test.cjs must be present in the committed conformance tier');
|
||||
const result = scopeFor([file]);
|
||||
assert.strictEqual(result.full_matrix, true,
|
||||
`expected full_matrix=true for the #4421 regression file, got: ${JSON.stringify(result)}`);
|
||||
assert.ok(result.reasons.includes(`${file}: conformance-tier reachability`),
|
||||
`expected reasons to name the conformance-tier mechanism (not the removed blanket rule), got: ${JSON.stringify(result.reasons)}`);
|
||||
});
|
||||
|
||||
// Row 4: the seam file itself always forces full_matrix — its own content
|
||||
// carries genuine narrow platform signals (process-platform, raw-child-
|
||||
// process, etc.), so this is the organic content-check path, not a special
|
||||
// case in the code.
|
||||
test('full_matrix true when the seam file itself changes', () => {
|
||||
const result = scopeFor(['src/shell-command-projection.cts']);
|
||||
assert.strictEqual(result.full_matrix, true,
|
||||
`expected full_matrix=true for the seam file, got: ${JSON.stringify(result)}`);
|
||||
assert.ok(result.reasons.includes('src/shell-command-projection.cts: platform seam reachability'),
|
||||
`expected reasons to name platform seam reachability, got: ${JSON.stringify(result.reasons)}`);
|
||||
});
|
||||
|
||||
// Rows 5-7: minimal constructed src/ fixtures (not a real, drifting file) —
|
||||
// same temp-tree pattern as the '#837 three-dot diff' test above, but
|
||||
// invoked via --files (no git commit needed).
|
||||
test('full_matrix true for a non-seam src/ file with a genuine platform signal', () => {
|
||||
const tmp = fs.mkdtempSync(path.join(os.tmpdir(), 'ci-scope-4592-narrow-'));
|
||||
try {
|
||||
fs.mkdirSync(path.join(tmp, 'tests'), { recursive: true });
|
||||
fs.mkdirSync(path.join(tmp, 'src'), { recursive: true });
|
||||
const file = 'src/narrow-signal-fixture.cts';
|
||||
fs.writeFileSync(path.join(tmp, file), "if (process.platform === 'win32') { doWindowsThing(); }\n");
|
||||
|
||||
const result = scopeForAt([file], tmp);
|
||||
assert.strictEqual(result.full_matrix, true,
|
||||
`expected full_matrix=true for a src/ file with a narrow platform signal, got: ${JSON.stringify(result)}`);
|
||||
assert.ok(result.reasons.includes(`${file}: platform seam reachability`),
|
||||
`expected reasons to name platform seam reachability, got: ${JSON.stringify(result.reasons)}`);
|
||||
} finally {
|
||||
cleanup(tmp);
|
||||
}
|
||||
});
|
||||
|
||||
test('full_matrix false for a src/ file with only noisy signals', () => {
|
||||
const tmp = fs.mkdtempSync(path.join(os.tmpdir(), 'ci-scope-4592-noisy-'));
|
||||
try {
|
||||
fs.mkdirSync(path.join(tmp, 'tests'), { recursive: true });
|
||||
fs.mkdirSync(path.join(tmp, 'src'), { recursive: true });
|
||||
const file = 'src/noisy-only-fixture.cts';
|
||||
// Matches ONLY hardcoded-path-vs-path-call (path.join + a leading-slash
|
||||
// literal) and symlink-keyword ("symlink") — no narrow signal at all.
|
||||
fs.writeFileSync(
|
||||
path.join(tmp, file),
|
||||
"const p = path.join(root, 'x');\nassert.equal(rendered, '/etc/passwd');\n// see symlink handling elsewhere\n",
|
||||
);
|
||||
|
||||
const result = scopeForAt([file], tmp);
|
||||
assert.strictEqual(result.full_matrix, false,
|
||||
`expected full_matrix=false for a src/ file with only noisy signals, got: ${JSON.stringify(result)}`);
|
||||
} finally {
|
||||
cleanup(tmp);
|
||||
}
|
||||
});
|
||||
|
||||
test('full_matrix false for a src/ file with no platform signal', () => {
|
||||
const tmp = fs.mkdtempSync(path.join(os.tmpdir(), 'ci-scope-4592-clean-'));
|
||||
try {
|
||||
fs.mkdirSync(path.join(tmp, 'tests'), { recursive: true });
|
||||
fs.mkdirSync(path.join(tmp, 'src'), { recursive: true });
|
||||
const file = 'src/no-signal-fixture.cts';
|
||||
fs.writeFileSync(path.join(tmp, file), 'function add(a, b) { return a + b; }\n');
|
||||
|
||||
const result = scopeForAt([file], tmp);
|
||||
assert.strictEqual(result.full_matrix, false,
|
||||
`expected full_matrix=false for a src/ file with zero signals, got: ${JSON.stringify(result)}`);
|
||||
} finally {
|
||||
cleanup(tmp);
|
||||
}
|
||||
});
|
||||
|
||||
// Rows 8-10: the classifier's own definition files always fail-safe to
|
||||
// full_matrix=true — a change to the classification mechanism itself
|
||||
// cannot be presumed safe by the very mechanism being changed.
|
||||
for (const file of [
|
||||
'scripts/lib/platform-conformance-tier.generated.cjs',
|
||||
'scripts/gen-platform-conformance-tier.cjs',
|
||||
'scripts/lib/suite-detection.cjs',
|
||||
]) {
|
||||
test(`full_matrix true when ${file} itself changes`, () => {
|
||||
const result = scopeFor([file]);
|
||||
assert.strictEqual(result.full_matrix, true,
|
||||
`expected full_matrix=true for classifier definition file ${file}, got: ${JSON.stringify(result)}`);
|
||||
assert.ok(result.reasons.includes(`${file}: reachability classifier definition changed`),
|
||||
`expected reasons to name the classifier-definition fail-safe, got: ${JSON.stringify(result.reasons)}`);
|
||||
});
|
||||
}
|
||||
|
||||
// Row 11: fail-safe when the generated tier module fails to load. Exercised
|
||||
// in-process against the real, exported classify()/reachesConformanceTierOrSeam
|
||||
// with an injected loader that throws — no real file is corrupted, and this
|
||||
// proves the failure propagates all the way through classify() without an
|
||||
// uncaught exception escaping it.
|
||||
describe('full_matrix true when the generated tier module fails to load', () => {
|
||||
const { classify, reachesConformanceTierOrSeam } = require('../scripts/ci-test-scope.cjs');
|
||||
const throwingDeps = { loadConformanceTier: () => { throw new Error('simulated load failure'); } };
|
||||
|
||||
test('reachesConformanceTierOrSeam fails safe to true, does not throw', () => {
|
||||
let result;
|
||||
assert.doesNotThrow(() => {
|
||||
result = reachesConformanceTierOrSeam('tests/some.test.cjs', throwingDeps);
|
||||
});
|
||||
assert.strictEqual(result, true);
|
||||
});
|
||||
|
||||
test('classify() propagates the fail-safe without an uncaught exception', () => {
|
||||
let result;
|
||||
assert.doesNotThrow(() => {
|
||||
result = classify(['tests/some.test.cjs'], throwingDeps);
|
||||
});
|
||||
assert.strictEqual(result.full_matrix, true,
|
||||
`expected full_matrix=true when the tier module fails to load, got: ${JSON.stringify(result)}`);
|
||||
});
|
||||
});
|
||||
|
||||
// Row 13: pairing a conformance-tier test file with an inert-workflow-only
|
||||
// file must not be overridden by the inert-CI normalization, since
|
||||
// productOrPipelineChanged is already true for any tests/ path.
|
||||
test('full_matrix stays true when a conformance-tier test file is paired with an inert workflow file', () => {
|
||||
const { CONFORMANCE_TIER_FILES } = require('../scripts/lib/platform-conformance-tier.generated.cjs');
|
||||
const tierFile = CONFORMANCE_TIER_FILES[0];
|
||||
const result = scopeFor([tierFile, '.github/workflows/stale.yml']);
|
||||
assert.strictEqual(result.full_matrix, true,
|
||||
`expected full_matrix=true even paired with an inert workflow file, got: ${JSON.stringify(result)}`);
|
||||
});
|
||||
});
|
||||
|
||||
// ────────────────────────────────────────────────────────────────────────
|
||||
// Folded from tests/bug-641-files-from-suite-token.test.cjs — consolidation epic #1969 (B6 #1975)
|
||||
// ────────────────────────────────────────────────────────────────────────
|
||||
|
||||
@@ -22,7 +22,7 @@ const path = require('node:path');
|
||||
|
||||
const { createTempDir, cleanup } = require('./helpers.cjs');
|
||||
const { runNode } = require('./helpers/process-seam.cjs');
|
||||
const { classifyContent, classifyTree } = require('../scripts/gen-platform-conformance-tier.cjs');
|
||||
const { classifyContent, classifyTree, NOISY_FOR_SOURCE_REACHABILITY } = require('../scripts/gen-platform-conformance-tier.cjs');
|
||||
|
||||
const ROOT = path.resolve(__dirname, '..');
|
||||
const SCRIPT = path.join(ROOT, 'scripts', 'gen-platform-conformance-tier.cjs');
|
||||
@@ -144,6 +144,20 @@ describe('classifyContent — negative / hostile inputs', () => {
|
||||
});
|
||||
});
|
||||
|
||||
// ─── Row 15 (#4592): NOISY_FOR_SOURCE_REACHABILITY drift guard ────────────────
|
||||
|
||||
describe('NOISY_FOR_SOURCE_REACHABILITY (#4592)', () => {
|
||||
test('NOISY_FOR_SOURCE_REACHABILITY exports exactly the two noisy categories', () => {
|
||||
assert.ok(NOISY_FOR_SOURCE_REACHABILITY instanceof Set,
|
||||
`expected a Set, got: ${typeof NOISY_FOR_SOURCE_REACHABILITY}`);
|
||||
assert.deepEqual(
|
||||
[...NOISY_FOR_SOURCE_REACHABILITY].sort(),
|
||||
['hardcoded-path-vs-path-call', 'symlink-keyword'].sort(),
|
||||
`expected exactly the two named noisy categories, got: ${JSON.stringify([...NOISY_FOR_SOURCE_REACHABILITY])}`,
|
||||
);
|
||||
});
|
||||
});
|
||||
|
||||
// ─── Rows 16-18: CLI --check/--write against a temp fixture tree ──────────────
|
||||
|
||||
/** Spawn the real generator CLI via the process seam. */
|
||||
|
||||
Reference in New Issue
Block a user