fix: standardize debug file naming and invoke execute-plan
- Debug files from UAT use same naming as regular debug (slug only) - UAT.md tracks link via debug_session field - plan-fix actually invokes execute-plan when user selects it Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
@@ -191,9 +191,7 @@ Priority: {blocker count} blocker, {major count} major, {minor count} minor, {co
|
||||
@.planning/phases/XX-name/{phase}-UAT.md
|
||||
|
||||
**Debug sessions (if diagnosed):**
|
||||
@.planning/debug/uat-001-*.md
|
||||
@.planning/debug/uat-002-*.md
|
||||
[etc - reference each debug session for full investigation context]
|
||||
[Reference each debug_session path from UAT.md for full investigation context]
|
||||
|
||||
**Original plans for reference:**
|
||||
@.planning/phases/XX-name/{phase}-01-PLAN.md
|
||||
@@ -238,13 +236,6 @@ After completion, create `.planning/phases/XX-name/{phase}-FIX-SUMMARY.md`
|
||||
| Major | {n} |
|
||||
| Minor | {n} |
|
||||
| Cosmetic | {n} |
|
||||
|
||||
---
|
||||
|
||||
Next steps:
|
||||
- Execute: `/gsd:execute-plan .planning/phases/XX-name/{phase}-FIX.md`
|
||||
- Review plan first: `cat .planning/phases/XX-name/{phase}-FIX.md`
|
||||
- Re-test after fixes: `/gsd:verify-work {phase}`
|
||||
```
|
||||
|
||||
Use AskUserQuestion:
|
||||
@@ -254,6 +245,18 @@ Use AskUserQuestion:
|
||||
- "Execute fix plan" — Run the fixes now
|
||||
- "Review plan first" — Look at the plan before executing
|
||||
- "Done for now" — Come back later
|
||||
|
||||
**If "Execute fix plan":**
|
||||
Invoke `/gsd:execute-plan .planning/phases/XX-name/{phase}-FIX.md`
|
||||
|
||||
**If "Review plan first":**
|
||||
Display the plan contents, then ask again whether to execute.
|
||||
|
||||
**If "Done for now":**
|
||||
```
|
||||
Fix plan saved. Run when ready:
|
||||
`/gsd:execute-plan .planning/phases/XX-name/{phase}-FIX.md`
|
||||
```
|
||||
</step>
|
||||
|
||||
</process>
|
||||
|
||||
@@ -122,7 +122,7 @@ result: issue
|
||||
reported: "works but doesn't show until I refresh the page"
|
||||
severity: major
|
||||
root_cause: useEffect in CommentList.tsx missing commentCount dependency
|
||||
debug_session: .planning/debug/uat-001-comment-refresh.md
|
||||
debug_session: .planning/debug/comment-not-refreshing.md
|
||||
```
|
||||
|
||||
```markdown
|
||||
@@ -211,7 +211,7 @@ result: issue
|
||||
reported: "works but doesn't show until I refresh the page"
|
||||
severity: major
|
||||
root_cause: useEffect in CommentList.tsx missing commentCount dependency
|
||||
debug_session: .planning/debug/uat-001-comment-refresh.md
|
||||
debug_session: .planning/debug/comment-not-refreshing.md
|
||||
|
||||
### 3. Reply to a Comment
|
||||
expected: Click Reply, inline composer appears, submit shows nested reply
|
||||
|
||||
@@ -54,9 +54,10 @@ The fix will be planned and applied separately by /gsd:plan-fix.
|
||||
</mode>
|
||||
|
||||
<debug_file>
|
||||
Create: `.planning/debug/uat-{issue_id_lower}-{slug}.md`
|
||||
Create: `.planning/debug/{slug}.md`
|
||||
|
||||
Example: `.planning/debug/uat-001-comment-refresh.md`
|
||||
Generate slug from issue summary (same as regular /gsd:debug).
|
||||
Example: `comment-not-refreshing.md`
|
||||
|
||||
Pre-fill Symptoms section:
|
||||
```markdown
|
||||
@@ -69,6 +70,8 @@ reproduction: Test {test_num} - {test_name}
|
||||
started: discovered during UAT
|
||||
```
|
||||
|
||||
The debug file is identical to a regular debug session. The only difference is symptoms are pre-filled. UAT.md tracks the link via `debug_session` field.
|
||||
|
||||
Then proceed with investigation.
|
||||
</debug_file>
|
||||
|
||||
@@ -89,7 +92,7 @@ When root cause is confirmed, return:
|
||||
- [file1.ts]: [what's wrong]
|
||||
- [file2.ts]: [related issue]
|
||||
|
||||
**Debug Session:** .planning/debug/uat-{issue_id_lower}-{slug}.md
|
||||
**Debug Session:** .planning/debug/{slug}.md
|
||||
|
||||
**Suggested Fix Direction:** [brief hint for plan-fix, not implementation]
|
||||
```
|
||||
@@ -109,12 +112,12 @@ If unable to determine root cause after thorough investigation:
|
||||
|
||||
**Recommendation:** Manual review needed
|
||||
|
||||
**Debug Session:** .planning/debug/uat-{issue_id_lower}-{slug}.md
|
||||
**Debug Session:** .planning/debug/{slug}.md
|
||||
```
|
||||
</return_format>
|
||||
|
||||
<success_criteria>
|
||||
- [ ] DEBUG-UAT-{NNN}.md created with symptoms pre-filled
|
||||
- [ ] Debug file created with symptoms pre-filled
|
||||
- [ ] Investigation completed (evidence gathered, hypotheses tested)
|
||||
- [ ] Root cause identified with supporting evidence
|
||||
- [ ] Debug session file updated throughout
|
||||
@@ -129,7 +132,6 @@ If unable to determine root cause after thorough investigation:
|
||||
| Placeholder | Source | Example |
|
||||
|-------------|--------|---------|
|
||||
| `{issue_id}` | UAT issue ID | `UAT-001` |
|
||||
| `{issue_id_lower}` | Lowercase for filenames | `001` |
|
||||
| `{issue_summary}` | Brief description | `Comment doesn't appear until refresh` |
|
||||
| `{expected}` | From UAT test | `Submit comment, appears in list` |
|
||||
| `{reported}` | User's description | `works but doesn't show until refresh` |
|
||||
@@ -138,7 +140,7 @@ If unable to determine root cause after thorough investigation:
|
||||
| `{test_name}` | Test name | `Create Top-Level Comment` |
|
||||
| `{phase}` | Phase number | `04` |
|
||||
| `{phase_dir}` | Phase directory name | `04-comments` |
|
||||
| `{slug}` | Generated from summary | `comment-refresh` |
|
||||
| `{slug}` | Generated from summary | `comment-not-refreshing` |
|
||||
|
||||
---
|
||||
|
||||
|
||||
@@ -99,7 +99,7 @@ Each agent returns with:
|
||||
|
||||
**Root Cause:** {specific cause with evidence}
|
||||
**Files Involved:** {list of files}
|
||||
**Debug Session:** .planning/debug/uat-{nnn}-{slug}.md
|
||||
**Debug Session:** .planning/debug/{slug}.md
|
||||
|
||||
**Evidence Summary:**
|
||||
- {key finding 1}
|
||||
@@ -109,7 +109,7 @@ Each agent returns with:
|
||||
Parse each return to extract:
|
||||
- root_cause: The diagnosed cause
|
||||
- files: Files involved
|
||||
- debug_path: Path to debug session file
|
||||
- debug_path: Path to debug session file (standard debug location)
|
||||
|
||||
If agent fails or can't determine root cause:
|
||||
- root_cause: "Investigation inconclusive - manual review needed"
|
||||
@@ -128,7 +128,7 @@ result: issue
|
||||
reported: "works but doesn't show until I refresh the page"
|
||||
severity: major
|
||||
root_cause: "useEffect in CommentList.tsx missing commentCount dependency - doesn't re-render when new comment added"
|
||||
debug_session: .planning/debug/uat-001-comment-refresh.md
|
||||
debug_session: .planning/debug/comment-not-refreshing.md
|
||||
```
|
||||
|
||||
Update the "Issues for /gsd:plan-fix" section with root causes:
|
||||
|
||||
Reference in New Issue
Block a user