Merge pull request #3111 from gsd-build/fix/3094-progress-md-still-recommends-deleted-gsd

fix: remove stale /gsd-list-phase-assumptions guidance from progress routing
This commit is contained in:
Tom Boucher
2026-05-04 23:31:26 -04:00
committed by GitHub
3 changed files with 29 additions and 2 deletions

View File

@@ -0,0 +1,5 @@
---
type: Fixed
pr: 3111
---
**Progress routing command guidance remains canonical** — pre-planning assumption checks in progress routing now consistently assert and document `/gsd-discuss-phase` as the replacement path, with tests enforcing structured slash-command token checks.

View File

@@ -275,7 +275,7 @@ PHASE_HAS_UI=$(echo "$PHASE_SECTION" | grep -qi "UI hint.*yes" && echo "true" ||
**Also available:**
- `/gsd-ui-phase {phase}` — generate UI design contract (recommended for frontend phases)
- `/gsd-plan-phase {phase}` — skip discussion, plan directly
- `/gsd-list-phase-assumptions {phase}` — see Claude's assumptions
- `/gsd-discuss-phase {phase}` — include assumptions check before planning
---
```
@@ -297,7 +297,7 @@ PHASE_HAS_UI=$(echo "$PHASE_SECTION" | grep -qi "UI hint.*yes" && echo "true" ||
**Also available:**
- `/gsd-plan-phase {phase} ${GSD_WS}` — skip discussion, plan directly
- `/gsd-list-phase-assumptions {phase} ${GSD_WS}` — see Claude's assumptions
- `/gsd-discuss-phase {phase} ${GSD_WS}` — include assumptions check before planning
---
```

View File

@@ -302,6 +302,28 @@ describe('bug #3044: localized doc sets also scrubbed', () => {
// ─── Replacement commands are documented ────────────────────────────────────
describe('bug #3094: progress routing does not reference removed /gsd-list-phase-assumptions', () => {
test('get-shit-done/workflows/progress.md has no /gsd-list-phase-assumptions token', () => {
const content = read('get-shit-done/workflows/progress.md');
const tokens = extractSlashCommandTokens(content);
assert.equal(
tokens.has('/gsd-list-phase-assumptions'),
false,
'progress.md must not recommend removed /gsd-list-phase-assumptions'
);
});
test('progress.md pre-planning guidance uses /gsd-discuss-phase instead', () => {
const content = read('get-shit-done/workflows/progress.md');
const tokens = extractSlashCommandTokens(content);
assert.equal(
tokens.has('/gsd-discuss-phase'),
true,
'progress.md should route pre-planning assumption checks via /gsd-discuss-phase'
);
});
});
describe('replacement commands appear where the deleted ones used to live', () => {
test('docs/issue-driven-orchestration.md uses /gsd-workspace --new (not /gsd-new-workspace)', () => {
const content = read('docs/issue-driven-orchestration.md');