golem15/msd-core
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(#2784): suppress detectApiIntegration on negated prose (#3127)

Browse Source 
* fix(#2784): suppress detectApiIntegration on negated prose clauses

The compound verb+noun rule had no negation awareness. A clause like "This
phase integrates no external API" matched verb=integrates + noun=API and
fired a false positive, halting the blocking verify:pre gate and forcing a
coverage matrix for a non-existent API.

Added clause-local negation suppression: if the clause contains an
unambiguous negation qualifier (no, not, without, zero, neither, nor,
none, and common contractions), the pair is suppressed. True positives
("integrate the Stripe API") are unaffected. The human override (COVERAGE.md
"no integration" declaration) remains valid.

* chore(#2784): backfill changeset PR number 3125

* chore(#2784): fix changeset PR number to 3127

* chore(#2784): trigger CI re-run

---------

Co-authored-by: sim <sim@local>
This commit is contained in:
Tom Boucher
2026-08-06 17:39:18 -04:00
committed by GitHub
parent fee72d5560
commit 1c9f6a08e3
2 changed files with 35 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
.changeset/calm-foxes-travel.md Normal file
View File

@@ -0,0 +1,5 @@
---
type: Fixed
pr: 3127
---
**`detectApiIntegration` no longer triggers on negated prose** — a clause pairing an integration verb with an API noun but also containing a negation qualifier (`no`, `not`, `without`, `neither`, `nor`, etc.) is now suppressed. "This phase integrates no external API" no longer fires a false positive that halts verification. (#2784)

30
src/api-coverage.cts
View File

@@ -481,10 +481,30 @@ export function detectApiIntegration(
// boundary is the whole relationship test. Nouns are NOT filtered on
// "internal" qualification here — "integrate the internal API" is a
// fail-closed positive; the declaration dismisses it if wrong.
//
// #2784: negation suppression. A clause that pairs an integration verb with
// an API noun but the verb itself is directly negated (e.g. "does not
// integrate", "integrates no external API", "without any API integration")
// is suppressed. The check is scoped to the verb's immediate context (the
// word directly before the verb, or the word directly between verb and noun)
// — NOT a blanket clause-wide scan, because "without changing runtime
// dependencies" in a long clause does NOT negate the integration.
const NEGATION_QUALIFIERS = new Set([
'no', 'not', 'without', 'zero', 'neither', 'nor', 'none', "don't", "doesn't", "didn't", "won't", "can't", "cannot",
]);
if (verbRe && nounRe) {
for (const clause of clauses) {
const verbs = collectTermMatches(verbRe, clause.text);
if (verbs.length === 0) continue;
// #2784: check if any verb is immediately preceded by a negation
// qualifier (within 2 words before the verb match).
const clauseText = clause.text.toLowerCase();
const hasNegatedVerb = verbs.some((v) => {
const before = clauseText.slice(Math.max(0, v.start - clause.start - 20), v.start - clause.start);
const beforeWords = before.split(/\s+/).filter(Boolean).slice(-2);
return beforeWords.some((w: string) => NEGATION_QUALIFIERS.has(w.replace(/[^a-z']/g, '')));
});
// Also check if "no"/"zero"/"none" appears between the verb and the noun.
const nouns = collectTermMatches(nounRe, clause.text);
const nounTerms = new Set(nouns.map((t) => t.term));
for (const u of extraNouns) {
@@ -493,6 +513,16 @@ export function detectApiIntegration(
}
}
if (nounTerms.size === 0) continue;
// Check for negation between verb and noun
const hasNegatedNoun = verbs.some((v) => {
return nouns.some((n) => {
if (n.start <= v.start) return false;
const between = clauseText.slice(v.start - clause.start + v.term.length, n.start - clause.start);
const betweenWords = between.split(/\s+/).filter(Boolean);
return betweenWords.some((w: string) => ['no', 'zero', 'none'].includes(w.replace(/[^a-z']/g, '')));
});
});
if (hasNegatedVerb || hasNegatedNoun) continue;
for (const vTerm of new Set(verbs.map((t) => t.term))) {
for (const nTerm of nounTerms) emitPair(vTerm, nTerm, rawLine);
}