golem15/msd-core
3
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

fix(#4306): forward real bytes through the #3912 A6 stderr-bytes mocks (#4328)

Browse Source 
Same defect class as the bug #1008 fault-injection mocks: fabricated
a return byte count without ever calling the real fs.writeSync,
silently discarding any write to fd 2 landing during the mocked
window instead of letting it reach the real pipe.

Co-authored-by: sim <sim@local>
Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
This commit is contained in:
Tom Boucher
2026-09-05 14:42:26 -04:00
committed by GitHub
parent 13309a1921
commit 26b8e9abad
1 changed files with 10 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

35
tests/io.test.cjs
View File

@@ -16,6 +16,7 @@ const assert = require('node:assert/strict');
const path = require('node:path');
const os = require('node:os');
const fs = require('node:fs');
const { captureFdSync } = require('./helpers.cjs');
const io = require('../gsd-core/bin/lib/io.cjs');
const {
@@ -1059,47 +1060,31 @@ describe('#3912 A6: error() stderr bytes are unchanged by this phase', () => {
for (const version of VERSIONS_3912) {
resolveContractVersion({ argv: ['node', 'x', `--exit-contract=${version}`], env: {} });
let caught;
const chunks = [];
const origWrite = fs.writeSync;
fs.writeSync = (fd, buf, offset, length) => {
if (fd !== 2) return origWrite(fd, buf, offset, length);
const slice = Buffer.isBuffer(buf) ? buf.subarray(offset, offset + length) : Buffer.from(String(buf));
chunks.push(slice.toString('utf8'));
return slice.length;
};
try {
const stderr = captureFdSync(2, () => {
io.setJsonErrorMode(false);
try { io.error('boundary case', io.ERROR_REASON.SDK_MISSING_ARG); } catch (e) { caught = e; }
} finally {
fs.writeSync = origWrite;
}
});
assert.ok(caught instanceof ExitError);
assert.strictEqual(chunks.join(''), 'Error: boundary case\n', `version=${version}`);
assert.strictEqual(stderr, 'Error: boundary case\n', `version=${version}`);
}
});
test('json mode: the stderr envelope is identical regardless of contract version (only the thrown exit code differs)', () => {
for (const version of VERSIONS_3912) {
resolveContractVersion({ argv: ['node', 'x', `--exit-contract=${version}`], env: {} });
const chunks = [];
const origWrite = fs.writeSync;
fs.writeSync = (fd, buf, offset, length) => {
if (fd !== 2) return origWrite(fd, buf, offset, length);
const slice = Buffer.isBuffer(buf) ? buf.subarray(offset, offset + length) : Buffer.from(String(buf));
chunks.push(slice.toString('utf8'));
return slice.length;
};
let caught;
let stderr;
try {
io.setJsonErrorMode(true);
try { io.error('boundary case', io.ERROR_REASON.SDK_MISSING_ARG); } catch (e) { caught = e; }
stderr = captureFdSync(2, () => {
io.setJsonErrorMode(true);
try { io.error('boundary case', io.ERROR_REASON.SDK_MISSING_ARG); } catch (e) { caught = e; }
});
} finally {
fs.writeSync = origWrite;
io.setJsonErrorMode(false);
}
assert.ok(caught instanceof ExitError);
assert.deepStrictEqual(
JSON.parse(chunks.join('').trim()),
JSON.parse(stderr.trim()),
{ ok: false, reason: 'sdk_missing_arg', message: 'boundary case' },
`version=${version}`,
);