feat(#773): add --ephemeral and --dangerously-bypass-hook-trust to automated codex exec wrappers (#824)

* feat(#773): add --ephemeral and --dangerously-bypass-hook-trust to automated codex exec invocations

Automated codex exec calls in the review workflow now carry --ephemeral
(no session-state accumulation across CI runs) and
--dangerously-bypass-hook-trust (skip hook-trust prompts for hooks
whose provenance gsd-core already controls). Both flags were verified
present in the installed codex CLI (codex exec --help).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* fix(#773): correct changeset pr: reference to #824

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>

.changeset/mellow-yaks-bark.md

@@ -0,0 +1,6 @@
+---
+type: Changed
+pr: 824
+---
+<!-- docs-exempt: internal workflow change to automated codex exec invocations only; the flags affect session isolation and hook-trust behavior in non-interactive CI runs, not any user-facing command, config key, or output format -->
+Automated `codex exec` invocations in the review workflow now include `--ephemeral` (no session-state accumulation across automated/CI runs) and `--dangerously-bypass-hook-trust` (skip hook-trust prompts for hooks managed by gsd-core itself). These flags apply only to the non-interactive reviewer invocations in `gsd-core/workflows/review.md`. (#773)

gsd-core/workflows/review.md

@@ -248,9 +248,9 @@ fi
 **Codex:**
 ```bash
 if [ -n "$CODEX_MODEL" ] && [ "$CODEX_MODEL" != "null" ]; then
-  cat /tmp/gsd-review-prompt-{phase}.md | codex exec --model "$CODEX_MODEL" --skip-git-repo-check - 2>/dev/null > /tmp/gsd-review-codex-{phase}.md
+  cat /tmp/gsd-review-prompt-{phase}.md | codex exec --ephemeral --dangerously-bypass-hook-trust --model "$CODEX_MODEL" --skip-git-repo-check - 2>/dev/null > /tmp/gsd-review-codex-{phase}.md
 else
-  cat /tmp/gsd-review-prompt-{phase}.md | codex exec --skip-git-repo-check - 2>/dev/null > /tmp/gsd-review-codex-{phase}.md
+  cat /tmp/gsd-review-prompt-{phase}.md | codex exec --ephemeral --dangerously-bypass-hook-trust --skip-git-repo-check - 2>/dev/null > /tmp/gsd-review-codex-{phase}.md
 fi
 ```
 

tests/enh-773-codex-exec-automation-flags.test.cjs

@@ -0,0 +1,68 @@
+'use strict';
+
+// allow-test-rule: source-text-is-the-product
+// Workflow markdown is runtime contract; these assertions verify that
+// automated codex exec invocations carry the correct automation flags.
+
+const { describe, test } = require('node:test');
+const assert = require('node:assert/strict');
+const fs = require('node:fs');
+const path = require('node:path');
+
+describe('enh-773: automated codex exec invocations include --ephemeral and --dangerously-bypass-hook-trust', () => {
+  const workflow = fs.readFileSync(
+    path.join(process.cwd(), 'gsd-core', 'workflows', 'review.md'),
+    'utf8'
+  );
+
+  // Extract all codex exec invocation lines from code fences
+  const codexExecLines = workflow
+    .split('\n')
+    .filter((line) => line.includes('codex exec'));
+
+  test('review.md contains at least one codex exec invocation', () => {
+    assert.ok(
+      codexExecLines.length > 0,
+      'review.md must contain at least one codex exec invocation'
+    );
+  });
+
+  test('every codex exec invocation includes --ephemeral', () => {
+    for (const line of codexExecLines) {
+      assert.ok(
+        line.includes('--ephemeral'),
+        `codex exec invocation is missing --ephemeral:\n  ${line.trim()}`
+      );
+    }
+  });
+
+  test('every codex exec invocation includes --dangerously-bypass-hook-trust', () => {
+    for (const line of codexExecLines) {
+      assert.ok(
+        line.includes('--dangerously-bypass-hook-trust'),
+        `codex exec invocation is missing --dangerously-bypass-hook-trust:\n  ${line.trim()}`
+      );
+    }
+  });
+
+  test('--ephemeral appears before the prompt argument (flag ordering)', () => {
+    for (const line of codexExecLines) {
+      const ephemeralPos = line.indexOf('--ephemeral');
+      const promptPos = line.indexOf(' - ');
+      if (promptPos === -1) continue; // no stdin prompt arg on this line
+      assert.ok(
+        ephemeralPos < promptPos,
+        `--ephemeral must appear before the stdin prompt argument:\n  ${line.trim()}`
+      );
+    }
+  });
+
+  test('--skip-git-repo-check is preserved alongside automation flags', () => {
+    for (const line of codexExecLines) {
+      assert.ok(
+        line.includes('--skip-git-repo-check'),
+        `codex exec invocation lost --skip-git-repo-check:\n  ${line.trim()}`
+      );
+    }
+  });
+});