golem15/msd-core
4
0
Fork 0
Code Issues 1 Pull Requests Actions 2 Packages Projects Releases Wiki Activity

fix: address CodeRabbit findings on phase mode parsing

Browse Source
This commit is contained in:
Tom Boucher
2026-05-15 20:20:25 -04:00
parent ceb7a948d8
commit 34ac1f5e59
1 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
tests/feat-3251-command-aliases-manifest-coverage.test.cjs
View File

@@ -147,7 +147,7 @@ function runGsdTools(args, projectDir) {
}); });
} }
function listProjectFiles(projectDir) { function snapshotProjectState(projectDir) {
const files = []; const files = [];
function walk(dir) { function walk(dir) {
if (!fs.existsSync(dir)) return; if (!fs.existsSync(dir)) return;
@@ -203,7 +203,7 @@ describe('feat-3251: generated aliases dispatch through real gsd-tools behavior'
'', '',
].join('\n'), ].join('\n'),
); );
const beforeFiles = listProjectFiles(projectDir); const beforeFiles = snapshotProjectState(projectDir);
const result = runGsdTools(['phase', 'mvp-mode', '1'], projectDir); const result = runGsdTools(['phase', 'mvp-mode', '1'], projectDir);
assert.equal(result.status, 0, result.stderr); assert.equal(result.status, 0, result.stderr);
@@ -214,7 +214,7 @@ describe('feat-3251: generated aliases dispatch through real gsd-tools behavior'
assert.equal(output.roadmap_mode, 'mvp'); assert.equal(output.roadmap_mode, 'mvp');
assert.equal(output.config_mvp_mode, false); assert.equal(output.config_mvp_mode, false);
assert.equal(output.cli_flag_present, false); assert.equal(output.cli_flag_present, false);
assert.deepEqual(listProjectFiles(projectDir), beforeFiles); assert.deepEqual(snapshotProjectState(projectDir), beforeFiles);
} finally { } finally {
fs.rmSync(projectDir, { recursive: true, force: true }); fs.rmSync(projectDir, { recursive: true, force: true });
} }
@@ -239,7 +239,7 @@ describe('feat-3251: generated aliases dispatch through real gsd-tools behavior'
'', '',
].join('\n'), ].join('\n'),
); );
const beforeFiles = listProjectFiles(projectDir); const beforeFiles = snapshotProjectState(projectDir);
const result = runGsdTools(['phase', 'mvp-mode', '1'], projectDir); const result = runGsdTools(['phase', 'mvp-mode', '1'], projectDir);
assert.equal(result.status, 0, result.stderr); assert.equal(result.status, 0, result.stderr);
@@ -248,7 +248,7 @@ describe('feat-3251: generated aliases dispatch through real gsd-tools behavior'
assert.equal(output.active, false); assert.equal(output.active, false);
assert.equal(output.source, 'none'); assert.equal(output.source, 'none');
assert.equal(output.roadmap_mode, null); assert.equal(output.roadmap_mode, null);
assert.deepEqual(listProjectFiles(projectDir), beforeFiles); assert.deepEqual(snapshotProjectState(projectDir), beforeFiles);
} finally { } finally {
fs.rmSync(projectDir, { recursive: true, force: true }); fs.rmSync(projectDir, { recursive: true, force: true });
} }
@@ -257,7 +257,7 @@ describe('feat-3251: generated aliases dispatch through real gsd-tools behavior'
test('phase.mvp-mode JSON error is typed and leaves project files untouched', () => { test('phase.mvp-mode JSON error is typed and leaves project files untouched', () => {
const projectDir = createProject(); const projectDir = createProject();
try { try {
const beforeFiles = listProjectFiles(projectDir); const beforeFiles = snapshotProjectState(projectDir);
const result = runGsdTools(['--json-errors', 'phase', 'mvp-mode'], projectDir); const result = runGsdTools(['--json-errors', 'phase', 'mvp-mode'], projectDir);
assert.notEqual(result.status, 0); assert.notEqual(result.status, 0);
assert.equal(result.stdout, ''); assert.equal(result.stdout, '');
@@ -268,7 +268,7 @@ describe('feat-3251: generated aliases dispatch through real gsd-tools behavior'
assert.equal(error.reason, 'usage'); assert.equal(error.reason, 'usage');
assert.equal(typeof error.message, 'string'); assert.equal(typeof error.message, 'string');
assert.equal(/\n\s*at\s/.test(result.stderr), false, 'non-debug failure must not print a stack trace'); assert.equal(/\n\s*at\s/.test(result.stderr), false, 'non-debug failure must not print a stack trace');
assert.deepEqual(listProjectFiles(projectDir), beforeFiles); assert.deepEqual(snapshotProjectState(projectDir), beforeFiles);
} finally { } finally {
fs.rmSync(projectDir, { recursive: true, force: true }); fs.rmSync(projectDir, { recursive: true, force: true });
} }