golem15/msd-core
4
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #3123 from gsd-build/fix/3091-npx-install-gsd-sdk-symlink-never-create

Browse Source 
fix: align SDK install/fallback guidance with query-capable CLI
This commit is contained in:
Tom Boucher
2026-05-04 23:33:22 -04:00
committed by GitHub
parent 199083777a e2b12bfad2
commit 399bb80b40
8 changed files with 51 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
tests/bug-2334-quick-gsd-sdk-preflight.test.cjs
View File

@@ -56,10 +56,10 @@ describe('bug #2334: quick workflow gsd-sdk pre-flight check', () => {
const firstSdkCall = content.indexOf('gsd-sdk query init.quick', step2Start);
const step2Section = content.slice(step2Start, firstSdkCall);
const hasInstallHint = step2Section.includes('@gsd-build/sdk') || step2Section.includes('gsd-update') || step2Section.includes('/gsd-update');
const hasInstallHint = step2Section.includes('get-shit-done-cc') || step2Section.includes('gsd-update') || step2Section.includes('/gsd-update');
assert.ok(
hasInstallHint,
'Pre-flight error must include a hint on how to install gsd-sdk (npm install -g @gsd-build/sdk or /gsd-update)'
'Pre-flight error must include a hint on how to install query-capable gsd-sdk (npm install -g get-shit-done-cc or /gsd-update)'
);
});
});

32
tests/bug-3091-sdk-package-guidance-and-fallbacks.test.cjs Normal file
View File

@@ -0,0 +1,32 @@
'use strict';
const { test, describe } = require('node:test');
const assert = require('node:assert/strict');
const fs = require('node:fs');
const path = require('node:path');
const ROOT = path.join(__dirname, '..');
function read(rel) {
return fs.readFileSync(path.join(ROOT, rel), 'utf8');
}
describe('bug #3091: sdk install guidance and agent fallbacks use query-capable CLI', () => {
test('quick workflow install hint references get-shit-done-cc (not @gsd-build/sdk)', () => {
const content = read('get-shit-done/workflows/quick.md');
assert.ok(content.includes('npm install -g get-shit-done-cc'));
assert.ok(!content.includes('npm install -g @gsd-build/sdk'));
});
test('agent docs no longer reference node_modules/@gsd-build/sdk/dist/cli.js query fallback', () => {
const files = [
'agents/gsd-planner.md',
'agents/gsd-executor.md',
'agents/gsd-plan-checker.md',
'agents/gsd-roadmapper.md',
];
const offenders = files.filter((f) => read(f).includes('@gsd-build/sdk/dist/cli.js query'));
assert.deepStrictEqual(offenders, [], `stale @gsd-build/sdk query fallback references: ${offenders.join(', ')}`);
});
});