golem15/msd-core
3
0
Fork 0
Code Issues Pull Requests Actions 4 Packages Projects Releases Wiki Activity

refactor: add parseMultiwordArg helper and fix scaffold/milestone arg parsing

Browse Source 
Add parseMultiwordArg() to collect multi-token --flag values until the next
flag. Replace manual name-collection loops in milestone complete and scaffold
cases. Also fixes a bug in scaffold where args.slice() would include trailing
flags in the name value.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
SalesTeamToolbox
2026-03-20 23:41:25 -07:00
parent 5f95fea4d7
commit 415a094d26
1 changed files with 19 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

34
get-shit-done/bin/gsd-tools.cjs
View File

@@ -175,6 +175,22 @@ function parseNamedArgs(args, valueFlags = [], booleanFlags = []) {
return result;
}
/**
* Collect all tokens after --flag until the next --flag or end of args.
* Handles multi-word values like --name Foo Bar Version 1.
* Returns null if the flag is absent.
*/
function parseMultiwordArg(args, flag) {
const idx = args.indexOf(`--${flag}`);
if (idx === -1) return null;
const tokens = [];
for (let i = idx + 1; i < args.length; i++) {
if (args[i].startsWith('--')) break;
tokens.push(args[i]);
}
return tokens.length > 0 ? tokens.join(' ') : null;
}
// ─── CLI Router ───────────────────────────────────────────────────────────────
async function main() {
@@ -610,18 +626,8 @@ async function runCommand(command, args, cwd, raw) {
case 'milestone': {
const subcommand = args[1];
if (subcommand === 'complete') {
const nameIndex = args.indexOf('--name');
const milestoneName = parseMultiwordArg(args, 'name');
const archivePhases = args.includes('--archive-phases');
// Collect --name value (everything after --name until next flag or end)
let milestoneName = null;
if (nameIndex !== -1) {
const nameArgs = [];
for (let i = nameIndex + 1; i < args.length; i++) {
if (args[i].startsWith('--')) break;
nameArgs.push(args[i]);
}
milestoneName = nameArgs.join(' ') || null;
}
milestone.cmdMilestoneComplete(cwd, args[2], { name: milestoneName, archivePhases }, raw);
} else {
error('Unknown milestone subcommand. Available: complete');
@@ -674,11 +680,9 @@ async function runCommand(command, args, cwd, raw) {
case 'scaffold': {
const scaffoldType = args[1];
const phaseIndex = args.indexOf('--phase');
const nameIndex = args.indexOf('--name');
const scaffoldOptions = {
phase: phaseIndex !== -1 ? args[phaseIndex + 1] : null,
name: nameIndex !== -1 ? args.slice(nameIndex + 1).join(' ') : null,
phase: parseNamedArgs(args, ['phase']).phase,
name: parseMultiwordArg(args, 'name'),
};
commands.cmdScaffold(cwd, scaffoldType, scaffoldOptions, raw);
break;