test(#4516): migrate per-runtime install/upgrade adapters to named timeout constants (#4582)

Batch 5 of the ad hoc timeout literal migration (epic #4445). Replaces
every bare numeric timeout/timeoutMs object-literal property across
tests/augment-upgrades.test.cjs, tests/shared-hooks-dir-resolution.test.cjs,
tests/antigravity-upgrades.test.cjs, tests/cursor-hooks.test.cjs,
tests/cursor-hook-workspace-roots.test.cjs, tests/gemini-runtime-removed.test.cjs,
tests/kilo-upgrades.test.cjs, tests/kimi-upgrades.test.cjs,
tests/kimi-variant-disambiguation.test.cjs, tests/opencode-plugin-adapter.test.cjs,
tests/windsurf-hooks-bridge.test.cjs, tests/effort-sync-installed-runtime.test.cjs,
and tests/hooks-commonjs-marker.test.cjs with a named constant, per
eslint-rules/no-adhoc-timeout-literal.cjs. Removes these 13 files from the
rule's allowlist.

Adds one new shared constant to tests/helpers/timeouts.cjs for spawning a
single already-staged hook script directly (a heavier class than the
existing quick-spawn norm), shared across three files in this batch. One
new file-local constant covers a property-test driver process distinct
from any existing class. Every other site reuses an existing shared norm.
No src/bin file touched, no numeric timeout value changed anywhere.

Co-authored-by: sim <sim@local>
Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
This commit is contained in:
Tom Boucher
2026-09-10 14:11:26 -04:00
committed by GitHub
parent 0b928fe28c
commit 557a0b2876
15 changed files with 65 additions and 40 deletions

View File

@@ -141,6 +141,24 @@ const QUICK_SPAWN_TIMEOUT_MS = 10000;
*/
const FIXTURE_HOOK_TIMEOUT_SECONDS = 5;
/**
* Spawning ONE already-staged or already-bundled hook script directly --
* never the full installer, never a fan-out across several hooks -- where
* the script does a modest amount of real work: a git-root check, a
* version-cache read/write, or an ESM-vs-CommonJS module load probe under a
* hostile config root. This is a distinct, heavier class than
* `QUICK_SPAWN_TIMEOUT_MS` (10000ms, trivial invocations with no real
* git/network work), since every site using this constant measurably does
* more than that. It is also distinct from `HOOK_FANOUT_TIMEOUT_MS`, which
* bounds a different class -- nested shell fan-out across MULTIPLE hooks,
* not a single script.
*
* Shared across 3 files in batch #4516 of the ad hoc timeout literal
* migration, epic #4445 -- that is why it lives here rather than as a
* file-local constant.
*/
const STAGED_HOOK_SCRIPT_TIMEOUT_MS = 20000;
module.exports = {
PROBE_TIMEOUT_MS,
HOOK_FANOUT_TIMEOUT_MS,
@@ -151,4 +169,5 @@ module.exports = {
SEAM_DEFAULT_TIMEOUT_MS,
QUICK_SPAWN_TIMEOUT_MS,
FIXTURE_HOOK_TIMEOUT_SECONDS,
STAGED_HOOK_SCRIPT_TIMEOUT_MS,
};