golem15/msd-core
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(#1831): add state-rebuild test files to lint-test-file-count allowlist + fix ESLint errors from #1829/#1830

Browse Source 
fix(#1831): add state-rebuild test files to lint-test-file-count allowlist
This commit is contained in:
Tom Boucher
2026-06-29 20:18:16 -04:00
committed by GitHub
parent bad2c76c5e f65866f17d
commit 5e3b7e65a8
3 changed files with 13 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
scripts/lint-test-file-count.allowlist.json
View File

@@ -110,10 +110,12 @@
"bug-3454-state-dollar-backreference-growth.test.cjs",
"bug-397-state-preserve-executor-authored.test.cjs",
"bug-905-state-syncstatefrontmatter-preserve-scalars.test.cjs",
"bug-948-state-noop-write-guard.test.cjs",
"state-acquirestatelock-non-eexist.test.cjs",
"state-prune.test.cjs",
"state.test.cjs"
"bug-948-state-noop-write-guard.test.cjs",
"state-acquirestatelock-non-eexist.test.cjs",
"state-prune.test.cjs",
"state-rebuild-cli.test.cjs",
"state-rebuild.test.cjs",
"state.test.cjs"
],
"issue": "180"
},

13
src/state-transition.cts
View File

@@ -1666,8 +1666,9 @@ function reconcileCurrentPosition(
// by other transitions (beginPhase / completePhase) and reconstructed from
// total-phase counts; rebuild reconciles only the `**Current Phase:**` body
// field that frontmatter is the canonical source for.
if (fm.current_phase !== undefined && fm.current_phase !== null) {
const canonicalPhase = String(fm.current_phase);
const fmPhase = fm.current_phase;
if (typeof fmPhase === 'string' || typeof fmPhase === 'number') {
const canonicalPhase = String(fmPhase);
const existing = stateExtractField(modified, 'Current Phase');
if (existing !== null && existing !== canonicalPhase) {
const replaced = stateReplaceField(modified, 'Current Phase', canonicalPhase);
@@ -1686,8 +1687,9 @@ function reconcileCurrentPosition(
}
// Phase name prose.
if (fm.current_phase_name !== undefined && fm.current_phase_name !== null) {
const canonicalName = String(fm.current_phase_name);
const fmPhaseName = fm.current_phase_name;
if (typeof fmPhaseName === 'string' || typeof fmPhaseName === 'number') {
const canonicalName = String(fmPhaseName);
const existing = stateExtractField(modified, 'Current Phase Name');
if (existing !== null && existing !== canonicalName) {
const replaced = stateReplaceField(modified, 'Current Phase Name', canonicalName);
@@ -1821,7 +1823,6 @@ function stripTemplatePlaceholders(
const fieldName = m[1];
const value = m[2];
if (TEMPLATE_PLACEHOLDER_VALUE.test(value)) {
const placeholder = value.trim();
const cleared = `**${fieldName}:** (pending)`;
replacements.push({ lineIdx: i, before: line, after: cleared, fieldName });
}
@@ -1874,8 +1875,6 @@ function deduplicateSessionArchive(
for (let i = sectionIdx + 1; i < hs.length; i++) {
if (hs[i].level === 2) { sectionEnd = hs[i].offset; break; }
}
const sectionContent = content.slice(sectionStart, sectionEnd);
// Count `### Session — …` H3 sub-headings inside the section.
const archiveHeadings = hs.filter(
(h) => h.level === 3 && h.offset >= sectionStart && h.offset < sectionEnd && SESSION_ARCHIVE_H3.test(h.text),

4
tests/state-rebuild.test.cjs
View File

@@ -367,8 +367,7 @@ describe('ADR-1817 §2: rebuild reconciles **By Phase:** table via phaseInventor
{ number: '3', name: 'Test Phase', planCount: 5, summaryCount: 4 },
],
};
const result = transitionCore(drifted, { kind: 'rebuild' }, baseDeps);
// Note: passing baseDeps here (no provider) → reconcile is a no-op.
// First call with no phaseInventoryProvider → no-op (covered by its own test below).
// Re-run with the provider-wired deps:
const result2 = transitionCore(drifted, { kind: 'rebuild' }, deps);
// Strip the audit log so we only inspect LIVE table rows (the log's
@@ -421,7 +420,6 @@ describe('ADR-1817 §2: rebuild reconciles **By Phase:** table via phaseInventor
describe('ADR-1817 §5/§6: rebuild does not affect sync or prune (regression guard, criterion #7)', () => {
test('sync still patches its three frontmatter fields when rebuild is also available', () => {
const state = cleanState();
const before = state;
const result = transitionCore(
state,
{ kind: 'sync', totalPlansInPhase: 7, percent: 50 },