golem15/msd-core
3
0
Fork 0
Code Issues Pull Requests Actions 4 Packages Projects Releases Wiki Activity

fix(verifier): enforce human_needed status when human verification items exist

Browse Source 
The verifier agent could set status: passed even when the report contained
a non-empty "Human Verification Required" section. This bypassed the
human_needed → HUMAN-UAT.md → user approval gate, allowing phases to be
marked complete without human testing.

Replace the advisory status descriptions with an ordered decision tree
(most restrictive first): gaps_found → human_needed → passed. The passed
status is now only valid when zero human verification items exist.

Synced the same decision tree in the verify-phase workflow.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
j2h4u
2026-03-28 01:16:43 +05:00
parent 38c18ac68a
commit 655d455466
2 changed files with 23 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
agents/gsd-verifier.md
View File

@@ -442,16 +442,26 @@ npm test -- --grep "$PHASE_TEST_PATTERN" 2>&1 | grep -q "passing"
## Step 9: Determine Overall Status
**Status: passed** — All truths VERIFIED, all artifacts pass levels 1-3, all key links WIRED, no blocker anti-patterns.
Classify status using this decision tree IN ORDER (most restrictive first):
**Status: gaps_found** — One or more truths FAILED, artifacts MISSING/STUB, key links NOT_WIRED, or blocker anti-patterns found.
1. IF any truth FAILED, artifact MISSING/STUB, key link NOT_WIRED, or blocker anti-pattern found:
→ **status: gaps_found**
**Status: human_needed** — All automated checks pass but items flagged for human verification.
2. IF Step 8 produced ANY human verification items (section is non-empty):
→ **status: human_needed**
(Even if all truths are VERIFIED and score is N/N — human items take priority)
3. IF all truths VERIFIED, all artifacts pass, all links WIRED, no blockers, AND no human verification items:
→ **status: passed**
**passed is ONLY valid when the human verification section is empty.** If you identified items requiring human testing in Step 8, status MUST be human_needed.
**Score:** `verified_truths / total_truths`
## Step 10: Structure Gap Output (If Gaps Found)
Before writing VERIFICATION.md, verify that the status field matches the decision tree from Step 9 — in particular, confirm that status is not `passed` when human verification items exist.
Structure gaps in YAML frontmatter for `/gsd:plan-phase --gaps`:
```yaml

13
get-shit-done/workflows/verify-phase.md
View File

@@ -199,11 +199,18 @@ Format each as: Test Name → What to do → Expected result → Why can't verif
</step>
<step name="determine_status">
**passed:** All truths VERIFIED, all artifacts pass levels 1-3, all key links WIRED, no blocker anti-patterns.
Classify status using this decision tree IN ORDER (most restrictive first):
**gaps_found:** Any truth FAILED, artifact MISSING/STUB, key link NOT_WIRED, or blocker found.
1. IF any truth FAILED, artifact MISSING/STUB, key link NOT_WIRED, or blocker found:
→ **gaps_found**
**human_needed:** All automated checks pass but human verification items remain.
2. IF the previous step produced ANY human verification items:
→ **human_needed** (even if all truths VERIFIED and score is N/N)
3. IF all checks pass AND no human verification items:
→ **passed**
**passed is ONLY valid when no human verification items exist.**
**Score:** `verified_truths / total_truths`
</step>