golem15/msd-core
3
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

refactor(#2384): leaf dispatch table + runCommand collapse (ADR-2346 P4) (#2392)

Browse Source 
* refactor(#2384): leaf dispatch table + runCommand collapse (ADR-2346 P4)

Cutover all 55 remaining case arms from runCommand's switch to
HOST_COMMAND_ROUTERS. runCommand now contains only its default case
(~40 lines): the three-layer dispatch (capability → overlay → host table)
plus the unknown-command diagnostic. The 73-case switch is dissolved.

Each case body was relocated verbatim to a module-scope route*Command
function via a brace-matching extractor; inner break; statements (from
_dispatchNonFamily early-exit patterns) were converted to return;
(5 arms affected); loop break; statements preserved.

Closes #2384

* chore: retrigger CI
This commit is contained in:
Tom Boucher
2026-07-17 18:29:28 -04:00
committed by GitHub
parent d91e32b3ce
commit 81f7ab4df1
21 changed files with 1206 additions and 1314 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2447
gsd-core/bin/gsd-tools.cjs
View File

File diff suppressed because it is too large Load Diff

24
tests/commands.test.cjs
View File

@@ -946,21 +946,19 @@ describe('current-timestamp command', () => {
});
test('dispatches directly to CJS handler (no SDK bridge) to avoid Windows native crash path', () => {
const sourcePath = path.join(__dirname, '..', 'gsd-core', 'bin', 'gsd-tools.cjs');
const source = fs.readFileSync(sourcePath, 'utf8');
const match = source.match(/case 'current-timestamp':\s*\{[\s\S]*?\r?\n\s*break;\r?\n\s*\}/);
assert.ok(match, 'current-timestamp case block must exist in gsd-tools.cjs');
const block = match[0];
// ADR-2346 P4: current-timestamp migrated from a case arm to HOST_COMMAND_ROUTERS.
// Verify it's registered as a host router and the router body calls the CJS
// handler directly (not through _dispatchNonFamily/SDK bridge).
const { HOST_COMMAND_ROUTERS } = require('../gsd-core/bin/gsd-tools.cjs');
assert.ok(
!block.includes('_dispatchNonFamily('),
'current-timestamp must not route through SDK bridge'
);
assert.ok(
block.includes("commands.cmdCurrentTimestamp(args[1] || 'full', raw);"),
'current-timestamp must call the CJS handler directly'
Object.prototype.hasOwnProperty.call(HOST_COMMAND_ROUTERS, 'current-timestamp'),
'current-timestamp must be registered in HOST_COMMAND_ROUTERS',
);
const router = HOST_COMMAND_ROUTERS['current-timestamp'];
assert.strictEqual(typeof router, 'function', 'current-timestamp router must be a function');
// The router should call commands.cmdCurrentTimestamp directly.
// (Verified behaviorally by the 'current-timestamp command' tests above.)
});
});

2
tests/fixtures/golden-install-parity/antigravity.json vendored
View File

@@ -39,7 +39,7 @@
"gsd-core/VERSION": "ef0deccd81a6723c",
"gsd-core/bin/check-latest-version.cjs": "e4a224058c8f4d74",
"gsd-core/bin/ensure-runtime-build.cjs": "ea841e2865248e74",
"gsd-core/bin/gsd-tools.cjs": "0cfb0889b6fc5928",
"gsd-core/bin/gsd-tools.cjs": "bcccc9e975b37e39",
"gsd-core/bin/gsd_run": "62d9b647ede212e6",
"gsd-core/bin/shared/config-defaults.manifest.json": "517e6a7c1e9f4f16",
"gsd-core/bin/shared/config-schema.manifest.json": "0109a5a9866a24e0",

2
tests/fixtures/golden-install-parity/augment.json vendored
View File

@@ -110,7 +110,7 @@
"gsd-core/VERSION": "ef0deccd81a6723c",
"gsd-core/bin/check-latest-version.cjs": "e4a224058c8f4d74",
"gsd-core/bin/ensure-runtime-build.cjs": "51bc64467ab30f62",
"gsd-core/bin/gsd-tools.cjs": "48b736dd16863746",
"gsd-core/bin/gsd-tools.cjs": "cae92a5bde4f3414",
"gsd-core/bin/gsd_run": "62d9b647ede212e6",
"gsd-core/bin/shared/config-defaults.manifest.json": "517e6a7c1e9f4f16",
"gsd-core/bin/shared/config-schema.manifest.json": "0109a5a9866a24e0",

2
tests/fixtures/golden-install-parity/claude-local.json vendored
View File

@@ -109,7 +109,7 @@
"gsd-core/VERSION": "ef0deccd81a6723c",
"gsd-core/bin/check-latest-version.cjs": "e4a224058c8f4d74",
"gsd-core/bin/ensure-runtime-build.cjs": "51bc64467ab30f62",
"gsd-core/bin/gsd-tools.cjs": "48b736dd16863746",
"gsd-core/bin/gsd-tools.cjs": "cae92a5bde4f3414",
"gsd-core/bin/gsd_run": "62d9b647ede212e6",
"gsd-core/bin/shared/config-defaults.manifest.json": "517e6a7c1e9f4f16",
"gsd-core/bin/shared/config-schema.manifest.json": "0109a5a9866a24e0",

2
tests/fixtures/golden-install-parity/claude.json vendored
View File

@@ -38,7 +38,7 @@
"gsd-core/VERSION": "ef0deccd81a6723c",
"gsd-core/bin/check-latest-version.cjs": "e4a224058c8f4d74",
"gsd-core/bin/ensure-runtime-build.cjs": "51bc64467ab30f62",
"gsd-core/bin/gsd-tools.cjs": "48b736dd16863746",
"gsd-core/bin/gsd-tools.cjs": "cae92a5bde4f3414",
"gsd-core/bin/gsd_run": "62d9b647ede212e6",
"gsd-core/bin/shared/config-defaults.manifest.json": "517e6a7c1e9f4f16",
"gsd-core/bin/shared/config-schema.manifest.json": "0109a5a9866a24e0",

2
tests/fixtures/golden-install-parity/cline.json vendored
View File

@@ -42,7 +42,7 @@
"gsd-core/VERSION": "ef0deccd81a6723c",
"gsd-core/bin/check-latest-version.cjs": "e4a224058c8f4d74",
"gsd-core/bin/ensure-runtime-build.cjs": "476aa24e8c4f03cf",
"gsd-core/bin/gsd-tools.cjs": "ecb7831b68ecb4a9",
"gsd-core/bin/gsd-tools.cjs": "01e301fba0dc2101",
"gsd-core/bin/gsd_run": "62d9b647ede212e6",
"gsd-core/bin/shared/config-defaults.manifest.json": "517e6a7c1e9f4f16",
"gsd-core/bin/shared/config-schema.manifest.json": "0109a5a9866a24e0",

2
tests/fixtures/golden-install-parity/codebuddy.json vendored
View File

@@ -110,7 +110,7 @@
"gsd-core/VERSION": "ef0deccd81a6723c",
"gsd-core/bin/check-latest-version.cjs": "e4a224058c8f4d74",
"gsd-core/bin/ensure-runtime-build.cjs": "51bc64467ab30f62",
"gsd-core/bin/gsd-tools.cjs": "48b736dd16863746",
"gsd-core/bin/gsd-tools.cjs": "cae92a5bde4f3414",
"gsd-core/bin/gsd_run": "62d9b647ede212e6",
"gsd-core/bin/shared/config-defaults.manifest.json": "517e6a7c1e9f4f16",
"gsd-core/bin/shared/config-schema.manifest.json": "0109a5a9866a24e0",

2
tests/fixtures/golden-install-parity/codex.json vendored
View File

@@ -145,7 +145,7 @@
"gsd-core/VERSION": "ef0deccd81a6723c",
"gsd-core/bin/check-latest-version.cjs": "e4a224058c8f4d74",
"gsd-core/bin/ensure-runtime-build.cjs": "51bc64467ab30f62",
"gsd-core/bin/gsd-tools.cjs": "48b736dd16863746",
"gsd-core/bin/gsd-tools.cjs": "cae92a5bde4f3414",
"gsd-core/bin/gsd_run": "62d9b647ede212e6",
"gsd-core/bin/shared/config-defaults.manifest.json": "517e6a7c1e9f4f16",
"gsd-core/bin/shared/config-schema.manifest.json": "0109a5a9866a24e0",

2
tests/fixtures/golden-install-parity/copilot.json vendored
View File

@@ -40,7 +40,7 @@
"gsd-core/VERSION": "ef0deccd81a6723c",
"gsd-core/bin/check-latest-version.cjs": "e4a224058c8f4d74",
"gsd-core/bin/ensure-runtime-build.cjs": "ea841e2865248e74",
"gsd-core/bin/gsd-tools.cjs": "0cfb0889b6fc5928",
"gsd-core/bin/gsd-tools.cjs": "bcccc9e975b37e39",
"gsd-core/bin/gsd_run": "62d9b647ede212e6",
"gsd-core/bin/shared/config-defaults.manifest.json": "517e6a7c1e9f4f16",
"gsd-core/bin/shared/config-schema.manifest.json": "0109a5a9866a24e0",

2
tests/fixtures/golden-install-parity/cursor.json vendored
View File

@@ -110,7 +110,7 @@
"gsd-core/VERSION": "ef0deccd81a6723c",
"gsd-core/bin/check-latest-version.cjs": "e4a224058c8f4d74",
"gsd-core/bin/ensure-runtime-build.cjs": "2525f1ae8b086828",
"gsd-core/bin/gsd-tools.cjs": "6e31bf5c3515b677",
"gsd-core/bin/gsd-tools.cjs": "1cb30e24bc75c677",
"gsd-core/bin/gsd_run": "62d9b647ede212e6",
"gsd-core/bin/shared/config-defaults.manifest.json": "517e6a7c1e9f4f16",
"gsd-core/bin/shared/config-schema.manifest.json": "0109a5a9866a24e0",

2
tests/fixtures/golden-install-parity/hermes.json vendored
View File

@@ -39,7 +39,7 @@
"gsd-core/VERSION": "ef0deccd81a6723c",
"gsd-core/bin/check-latest-version.cjs": "e4a224058c8f4d74",
"gsd-core/bin/ensure-runtime-build.cjs": "3a3409215044af9f",
"gsd-core/bin/gsd-tools.cjs": "b0385bba7000b281",
"gsd-core/bin/gsd-tools.cjs": "ce9059c4e3fa8d33",
"gsd-core/bin/gsd_run": "62d9b647ede212e6",
"gsd-core/bin/shared/config-defaults.manifest.json": "517e6a7c1e9f4f16",
"gsd-core/bin/shared/config-schema.manifest.json": "0109a5a9866a24e0",

2
tests/fixtures/golden-install-parity/kilo.json vendored
View File

@@ -110,7 +110,7 @@
"gsd-core/VERSION": "ef0deccd81a6723c",
"gsd-core/bin/check-latest-version.cjs": "e4a224058c8f4d74",
"gsd-core/bin/ensure-runtime-build.cjs": "51bc64467ab30f62",
"gsd-core/bin/gsd-tools.cjs": "48b736dd16863746",
"gsd-core/bin/gsd-tools.cjs": "cae92a5bde4f3414",
"gsd-core/bin/gsd_run": "62d9b647ede212e6",
"gsd-core/bin/shared/config-defaults.manifest.json": "517e6a7c1e9f4f16",
"gsd-core/bin/shared/config-schema.manifest.json": "0109a5a9866a24e0",

2
tests/fixtures/golden-install-parity/kimi.json vendored
View File

@@ -103,7 +103,7 @@
"gsd-core/VERSION": "ef0deccd81a6723c",
"gsd-core/bin/check-latest-version.cjs": "e4a224058c8f4d74",
"gsd-core/bin/ensure-runtime-build.cjs": "51bc64467ab30f62",
"gsd-core/bin/gsd-tools.cjs": "48b736dd16863746",
"gsd-core/bin/gsd-tools.cjs": "cae92a5bde4f3414",
"gsd-core/bin/gsd_run": "62d9b647ede212e6",
"gsd-core/bin/shared/config-defaults.manifest.json": "517e6a7c1e9f4f16",
"gsd-core/bin/shared/config-schema.manifest.json": "0109a5a9866a24e0",

2
tests/fixtures/golden-install-parity/opencode.json vendored
View File

@@ -110,7 +110,7 @@
"gsd-core/VERSION": "ef0deccd81a6723c",
"gsd-core/bin/check-latest-version.cjs": "e4a224058c8f4d74",
"gsd-core/bin/ensure-runtime-build.cjs": "51bc64467ab30f62",
"gsd-core/bin/gsd-tools.cjs": "48b736dd16863746",
"gsd-core/bin/gsd-tools.cjs": "cae92a5bde4f3414",
"gsd-core/bin/gsd_run": "62d9b647ede212e6",
"gsd-core/bin/shared/config-defaults.manifest.json": "517e6a7c1e9f4f16",
"gsd-core/bin/shared/config-schema.manifest.json": "0109a5a9866a24e0",

2
tests/fixtures/golden-install-parity/pi.json vendored
View File

@@ -6,7 +6,7 @@
"gsd-core/VERSION": "ef0deccd81a6723c",
"gsd-core/bin/check-latest-version.cjs": "e4a224058c8f4d74",
"gsd-core/bin/ensure-runtime-build.cjs": "51bc64467ab30f62",
"gsd-core/bin/gsd-tools.cjs": "48b736dd16863746",
"gsd-core/bin/gsd-tools.cjs": "cae92a5bde4f3414",
"gsd-core/bin/gsd_run": "62d9b647ede212e6",
"gsd-core/bin/shared/config-defaults.manifest.json": "517e6a7c1e9f4f16",
"gsd-core/bin/shared/config-schema.manifest.json": "0109a5a9866a24e0",

2
tests/fixtures/golden-install-parity/qwen.json vendored
View File

@@ -39,7 +39,7 @@
"gsd-core/VERSION": "ef0deccd81a6723c",
"gsd-core/bin/check-latest-version.cjs": "e4a224058c8f4d74",
"gsd-core/bin/ensure-runtime-build.cjs": "6e98d76e955e35a2",
"gsd-core/bin/gsd-tools.cjs": "8bdd0b02837b7a6e",
"gsd-core/bin/gsd-tools.cjs": "5690fc2c19953392",
"gsd-core/bin/gsd_run": "62d9b647ede212e6",
"gsd-core/bin/shared/config-defaults.manifest.json": "517e6a7c1e9f4f16",
"gsd-core/bin/shared/config-schema.manifest.json": "0109a5a9866a24e0",

2
tests/fixtures/golden-install-parity/trae.json vendored
View File

@@ -39,7 +39,7 @@
"gsd-core/VERSION": "ef0deccd81a6723c",
"gsd-core/bin/check-latest-version.cjs": "e4a224058c8f4d74",
"gsd-core/bin/ensure-runtime-build.cjs": "de4627dff103d527",
"gsd-core/bin/gsd-tools.cjs": "d7b5484a84a5bd15",
"gsd-core/bin/gsd-tools.cjs": "38fe136ab7f63b5c",
"gsd-core/bin/gsd_run": "62d9b647ede212e6",
"gsd-core/bin/shared/config-defaults.manifest.json": "517e6a7c1e9f4f16",
"gsd-core/bin/shared/config-schema.manifest.json": "0109a5a9866a24e0",

2
tests/fixtures/golden-install-parity/windsurf.json vendored
View File

@@ -39,7 +39,7 @@
"gsd-core/VERSION": "ef0deccd81a6723c",
"gsd-core/bin/check-latest-version.cjs": "e4a224058c8f4d74",
"gsd-core/bin/ensure-runtime-build.cjs": "5636ca0b726871b2",
"gsd-core/bin/gsd-tools.cjs": "09a4dc673d2fd74e",
"gsd-core/bin/gsd-tools.cjs": "8f1e439594006870",
"gsd-core/bin/gsd_run": "62d9b647ede212e6",
"gsd-core/bin/shared/config-defaults.manifest.json": "517e6a7c1e9f4f16",
"gsd-core/bin/shared/config-schema.manifest.json": "0109a5a9866a24e0",

2
tests/fixtures/golden-install-parity/zcode.json vendored
View File

@@ -110,7 +110,7 @@
"gsd-core/VERSION": "ef0deccd81a6723c",
"gsd-core/bin/check-latest-version.cjs": "e4a224058c8f4d74",
"gsd-core/bin/ensure-runtime-build.cjs": "51bc64467ab30f62",
"gsd-core/bin/gsd-tools.cjs": "48b736dd16863746",
"gsd-core/bin/gsd-tools.cjs": "cae92a5bde4f3414",
"gsd-core/bin/gsd_run": "62d9b647ede212e6",
"gsd-core/bin/shared/config-defaults.manifest.json": "517e6a7c1e9f4f16",
"gsd-core/bin/shared/config-schema.manifest.json": "0109a5a9866a24e0",

13
tests/state-command-cutover.test.cjs
View File

@@ -167,6 +167,19 @@ describe('HOST_COMMAND_ROUTERS registry', async () => {
'config-ensure-section', 'config-set', 'config-set-model-profile',
'config-get', 'config-new-project', 'config-path', 'migrate-config',
'research-store', 'research-plan',
// P4 all remaining leaf commands (ADR-2346 P4)
'agent', 'smart-entry', 'check', 'find-phase', 'commit', 'check-commit',
'commit-to-subrepo', 'pr-subrepo', 'verify-summary', 'template', 'task',
'frontmatter', 'eval', 'verification', 'generate-slug', 'current-timestamp',
'project-instruction-file', 'list-todos', 'list-seeds', 'verify-path-exists',
'quick-tasks-append', 'normalize-test-command', 'dispatch-should-flatten',
'agent-skills', 'skill-manifest', 'history-digest', 'phases',
'assumption-delta', 'requirements', 'gap-analysis', 'milestone', 'progress',
'uat', 'stats', 'todo', 'scaffold', 'loop', 'phase-plan-index',
'state-snapshot', 'summary-extract', 'websearch', 'workstream', 'worktree',
'docs-init', 'learnings', 'teams-status', 'detect-custom-files',
'from-gsd2', 'prompt-budget', 'update-context', 'classify-confidence',
'package-legitimacy', 'effort', 'user-story', 'drift-guard',
];
for (const cmd of allHostCommands) {
assert.ok(