fix(#410): guard ~/.gsd/defaults.json write with GSD_TEST_MODE (#130 sibling) (#421)

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>

.changeset/410-install-defaults-test-mode-guard.md

@@ -0,0 +1,5 @@
+---
+type: Fixed
+pr: 410
+---
+`installAllRuntimes` no longer writes `~/.gsd/defaults.json` under `GSD_TEST_MODE` — matches the #130-class guard already applied to the opencode permission-config write.

bin/install.js

@@ -9810,8 +9810,8 @@ function finishInstall(settingsPath, settings, statuslineCommand, shouldInstallS
   // For non-Claude runtimes, set resolve_model_ids: "omit" in ~/.gsd/defaults.json
   // so resolveModelInternal() returns '' instead of Claude aliases (opus/sonnet/haiku)
   // that the runtime can't resolve. Users can still use model_overrides for explicit IDs.
-  // See #1156.
-  if (runtime !== 'claude') {
+  // See #1156. Guard matches the #130-class pattern on configureOpencodePermissions above.
+  if (runtime !== 'claude' && !process.env.GSD_TEST_MODE) {
     const gsdDir = path.join(os.homedir(), '.gsd');
     const defaultsPath = path.join(gsdDir, 'defaults.json');
     try {

tests/bug-410-install-defaults-test-mode-guard.test.cjs

@@ -0,0 +1,112 @@
+'use strict';
+
+/**
+ * Bug #410: finishInstall writes ~/.gsd/defaults.json for non-Claude runtimes
+ * without a GSD_TEST_MODE guard, polluting the real developer home directory
+ * during test runs.
+ *
+ * The opencode permission-config write a few lines above already carries the
+ * GSD_TEST_MODE guard (added for #130) — this test covers the un-fixed sibling
+ * (the resolve_model_ids: "omit" write).
+ */
+
+const { test, describe } = require('node:test');
+const assert = require('node:assert/strict');
+const path = require('node:path');
+const os = require('node:os');
+const fs = require('node:fs');
+
+const ROOT = path.join(__dirname, '..');
+
+// Point HOME at a temp dir so the defaults.json write can't reach the real
+// ~/.gsd/ even if the guard is missing.
+const FAKE_HOME = fs.mkdtempSync(path.join(os.tmpdir(), 'gsd-410-test-'));
+process.env.HOME = FAKE_HOME;
+
+// The path that finishInstall would write to for a non-Claude runtime.
+const GSD_DIR = path.join(FAKE_HOME, '.gsd');
+const DEFAULTS_PATH = path.join(GSD_DIR, 'defaults.json');
+
+// Set GSD_TEST_MODE before requiring install.js so any module-level guards
+// also see the flag.
+process.env.GSD_TEST_MODE = '1';
+
+const installModule = require(path.join(ROOT, 'bin', 'install.js'));
+
+// A synthetic settingsPath that won't exist — finishInstall should cope.
+const SETTINGS_PATH = path.join(FAKE_HOME, `gsd-test-settings-${process.pid}.json`);
+
+function callFinishInstallForRuntime(runtime) {
+  const original = console.log;
+  console.log = () => {};
+  try {
+    installModule.finishInstall(
+      SETTINGS_PATH,
+      {},       // empty settings
+      null,     // statuslineCommand
+      false,    // shouldInstallStatusline
+      runtime,
+      true,     // isGlobal
+      null,     // configDir
+    );
+  } finally {
+    console.log = original;
+  }
+}
+
+describe('Bug #410: finishInstall non-Claude runtime + GSD_TEST_MODE side-effect guard', () => {
+  test('defaults.json is NOT written for opencode runtime under GSD_TEST_MODE', () => {
+    assert.equal(
+      fs.existsSync(DEFAULTS_PATH),
+      false,
+      'defaults.json should not exist before finishInstall call',
+    );
+
+    callFinishInstallForRuntime('opencode');
+
+    assert.equal(
+      fs.existsSync(DEFAULTS_PATH),
+      false,
+      `defaults.json must NOT be created under GSD_TEST_MODE; found at ${DEFAULTS_PATH}`,
+    );
+  });
+
+  test('defaults.json is NOT written for gemini runtime under GSD_TEST_MODE', () => {
+    // Reset in case previous test left artifacts (it shouldn't).
+    assert.equal(
+      fs.existsSync(DEFAULTS_PATH),
+      false,
+      'defaults.json should not exist before gemini test',
+    );
+
+    callFinishInstallForRuntime('gemini');
+
+    assert.equal(
+      fs.existsSync(DEFAULTS_PATH),
+      false,
+      `defaults.json must NOT be created under GSD_TEST_MODE for gemini; found at ${DEFAULTS_PATH}`,
+    );
+  });
+
+  test('defaults.json IS written for opencode runtime when GSD_TEST_MODE is unset', () => {
+    // Temporarily unset GSD_TEST_MODE to verify the user-facing path still works.
+    const saved = process.env.GSD_TEST_MODE;
+    delete process.env.GSD_TEST_MODE;
+    try {
+      callFinishInstallForRuntime('opencode');
+      assert.equal(
+        fs.existsSync(DEFAULTS_PATH),
+        true,
+        `defaults.json must be written for non-Claude runtime when GSD_TEST_MODE is unset`,
+      );
+      // Verify the written content is correct.
+      const contents = JSON.parse(fs.readFileSync(DEFAULTS_PATH, 'utf8'));
+      assert.equal(contents.resolve_model_ids, 'omit', 'resolve_model_ids must be "omit"');
+    } finally {
+      // Restore GSD_TEST_MODE and clean up the written file.
+      process.env.GSD_TEST_MODE = saved;
+      try { fs.rmSync(DEFAULTS_PATH); } catch { /* already gone */ }
+      try { fs.rmdirSync(GSD_DIR); } catch { /* not empty or already gone */ }
+    }
+  });
+});