golem15/msd-core
3
0
Fork 0
Code Issues Pull Requests Actions 4 Packages Projects Releases Wiki Activity

Merge pull request #258 from open-gsd/fix/windows-current-timestamp-bridge-crash

Browse Source 
fix: avoid Windows current-timestamp crash by bypassing SDK bridge
This commit is contained in:
Tom Boucher
2026-05-24 22:49:12 -04:00
committed by GitHub
parent afbf475768 a0f16e4f23
commit 981bb7304a
3 changed files with 28 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
.changeset/sturdy-lynx-forage.md Normal file
View File

@@ -0,0 +1,5 @@
---
type: Fixed
pr: 258
---
**`current-timestamp` now runs on the CJS fast path to avoid intermittent Windows Node 24 crash exits in CI.**

18
get-shit-done/bin/gsd-tools.cjs
View File

@@ -771,19 +771,11 @@ async function runCommand(command, args, cwd, raw, defaultValue, originalCommand
}
case 'current-timestamp': {
// Phase 6 (#3575): dispatch via SDK executeForCjs when available.
// SDK handler: currentTimestamp in sdk/src/query/utils.ts.
const handled = _dispatchNonFamily({
registryCommand: 'current-timestamp',
registryArgs: args.slice(1),
legacyCommand: 'current-timestamp',
legacyArgs: args.slice(1),
cwd,
raw,
error,
output: core.output,
});
if (!handled) commands.cmdCurrentTimestamp(args[1] || 'full', raw);
// Keep this command on the CJS fast path.
// Rationale: it is a pure local formatter and avoids SDK bridge startup
// in tight subprocess loops where Windows CI has shown intermittent
// native crashes (0xC0000005 / 3221225477).
commands.cmdCurrentTimestamp(args[1] || 'full', raw);
break;
}

18
tests/commands.test.cjs
View File

@@ -888,6 +888,24 @@ describe('current-timestamp command', () => {
const output = JSON.parse(result.output);
assert.match(output.timestamp, /^\d{4}-\d{2}-\d{2}T\d{2}:\d{2}:\d{2}\.\d{3}Z$/, 'default should be full ISO format');
});
test('dispatches directly to CJS handler (no SDK bridge) to avoid Windows native crash path', () => {
const sourcePath = path.join(__dirname, '..', 'get-shit-done', 'bin', 'gsd-tools.cjs');
const source = fs.readFileSync(sourcePath, 'utf8');
const match = source.match(/case 'current-timestamp':\s*\{[\s\S]*?\n\s*break;\n\s*\}/);
assert.ok(match, 'current-timestamp case block must exist in gsd-tools.cjs');
const block = match[0];
assert.ok(
!block.includes('_dispatchNonFamily('),
'current-timestamp must not route through SDK bridge'
);
assert.ok(
block.includes("commands.cmdCurrentTimestamp(args[1] || 'full', raw);"),
'current-timestamp must call the CJS handler directly'
);
});
});
// ─────────────────────────────────────────────────────────────────────────────