golem15/msd-core
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

test(#1394): exercise the live bin/install.js convertGeminiToolName, add ask_user assertion

Browse Source 
Addresses review: the regression unit test required the tsc build artifact
(gsd-core/bin/lib/runtime-artifact-conversion.cjs) instead of the live install
path. Destructure convertGeminiToolName from the existing ../bin/install.js
import so a stale build can't false-green while the live copy is broken, and
assert the full AskUserQuestion/ask_user exclusion group.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
Behruz Nassre Esfahani
2026-06-18 07:06:00 -07:00
committed by Tom Boucher
parent ba5625bf79
commit a2511c132d
1 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
tests/runtime-converters.test.cjs
View File

@@ -18,6 +18,7 @@ const {
convertClaudeToOpencodeFrontmatter,
convertClaudeToKiloFrontmatter,
convertClaudeToGeminiAgent,
convertGeminiToolName,
convertClaudeAgentToAntigravityAgent,
convertClaudeCommandToOpencodeSkill,
convertClaudeCommandToKiloSkill,
@@ -301,13 +302,15 @@ Offer choices via AskUserQuestion when user input is needed.
// validation (tools.N: Invalid tool name) and aborts the entire agent load —
// previously killing 22 of 34 GSD agents on Gemini.
// Direct unit assertion against the canonical converter (criterion 1).
// Direct unit assertion against the LIVE install path (bin/install.js copy —
// the one that actually generates agents), not the tsc build artifact, so a
// stale build can't give a false-green while the live copy is broken.
test('convertGeminiToolName returns null for Skill and SlashCommand', () => {
const { convertGeminiToolName } = require('../gsd-core/bin/lib/runtime-artifact-conversion.cjs');
assert.equal(convertGeminiToolName('Skill'), null, 'Skill is excluded, not lowercased to "skill"');
assert.equal(convertGeminiToolName('SlashCommand'), null, 'SlashCommand is excluded, not lowercased to "slashcommand"');
// Existing AskUserQuestion exclusion must still hold.
// Existing AskUserQuestion/ask_user exclusion (the same if-block this PR extends) must still hold.
assert.equal(convertGeminiToolName('AskUserQuestion'), null, 'AskUserQuestion remains excluded');
assert.equal(convertGeminiToolName('ask_user'), null, 'ask_user remains excluded');
// Sanity: a mapped tool still converts.
assert.equal(convertGeminiToolName('Read'), 'read_file', 'mapped tools still convert');
});