Delivers the property coverage promised in #1511's test scope but not landed (follow-up #1676, epic #1507 / ADR-1508). Adds tests/enh-1676-path-prefix-collapse-idempotency.property.test.cjs covering: (A) $HOME-collapse invariant for _computePathPrefix — global-under-home projects to $HOME/<suffix>/ (exact equality, not substring, so short homes like /root or /a do not false-positive); opencode is the documented exception (absolute form, never $HOME). (B) backslash->posix invariance (#1615 Windows path-leak fix). (C) path-rewrite idempotency for _applyRuntimeRewrites across the path-rewriting runtimes (f(f(c)) === f(c); attribution held at undefined to isolate the path axis). Non-vacuous: a sanity assertion proves the first pass actually rewrites the seed ~/.claude/ refs. Pure test addition — no production code changed. Uses the shared fast-check-setup (seed=42, numRuns=200). Closes #1676
This commit is contained in:
Tom Boucher
@@ -0,0 +1,182 @@
|
||||
'use strict';
|
||||
|
||||
/**
|
||||
* Property-based tests for the relocated rewrite engine (ADR-1508 Phase 2).
|
||||
*
|
||||
* Module: gsd-core/bin/lib/runtime-artifact-conversion.cjs
|
||||
* Exports under test:
|
||||
* - _computePathPrefix (private; the path-prefix derivation owner)
|
||||
* - _applyRuntimeRewrites (the per-runtime content-rewrite engine)
|
||||
*
|
||||
* Issue #1676 (epic #1507 / ADR-1508): delivers the fast-check property
|
||||
* coverage promised in #1511's test scope but not landed there.
|
||||
*
|
||||
* Properties under test:
|
||||
* (A) $HOME-collapse invariant — a global install whose target lives under
|
||||
* $HOME (and is not opencode) MUST project to a `$HOME/<suffix>/`
|
||||
* prefix, never the resolved absolute homedir path. opencode is the
|
||||
* documented exception (it uses ~/.config/opencode, which breaks the
|
||||
* $HOME shorthand inside double-quoted content). Asserted by EXACT
|
||||
* equality (not substring) so short homes like `/root` or `/a` do not
|
||||
* false-positive — the same trap handled at
|
||||
* tests/path-replacement.test.cjs:38-47.
|
||||
* (B) backslash→posix invariance (#1615 Windows path-leak fix): feeding
|
||||
* Windows backslash paths yields the same prefix as their posix form.
|
||||
* (C) path-rewrite idempotency — applying the engine twice yields the same
|
||||
* bytes as once (no double-prefixing, no `$HOME`-of-`$HOME`).
|
||||
* attribution is held at undefined to isolate the path-rewrite axis.
|
||||
*/
|
||||
|
||||
const { describe, test } = require('node:test');
|
||||
const assert = require('node:assert/strict');
|
||||
const path = require('node:path');
|
||||
const fc = require('./helpers/fast-check-setup.cjs');
|
||||
|
||||
const conversion = require(
|
||||
path.join(__dirname, '..', 'gsd-core', 'bin', 'lib', 'runtime-artifact-conversion.cjs'),
|
||||
);
|
||||
const { getDirName } = require(
|
||||
path.join(__dirname, '..', 'gsd-core', 'bin', 'lib', 'runtime-name-policy.cjs'),
|
||||
);
|
||||
|
||||
// Runtimes whose _applyRuntimeRewrites branch performs real path rewrites
|
||||
// (~/.claude/ → pathPrefix). copilot/antigravity only do attribution; claude
|
||||
// and the gemini/kilo family are omitted to keep the property on the path axis
|
||||
// the issue names. getDirName(`.${rt}`) == `.${rt}` for every entry here.
|
||||
const PATH_REWRITE_RUNTIMES = ['codex', 'cline', 'cursor', 'windsurf', 'augment', 'trae', 'codebuddy'];
|
||||
|
||||
const HOMES = ['/home/u', '/Users/x', '/root', '/srv/app', '/a'];
|
||||
const SEG = fc.stringMatching(/^[a-z][a-z0-9]{0,8}$/);
|
||||
|
||||
// Build a posix `home/<segs>` target with no leading/trailing/double slashes.
|
||||
const target = (home, segs) => `${home}/${segs.join('/')}`;
|
||||
|
||||
describe('_computePathPrefix: $HOME-collapse invariant (#1676 / ADR-1508)', () => {
|
||||
test('property: global-under-home collapses to $HOME/<suffix>/ unless opencode', () => {
|
||||
fc.assert(
|
||||
fc.property(
|
||||
fc.record({
|
||||
home: fc.constantFrom(...HOMES),
|
||||
segs: fc.array(SEG, { minLength: 1, maxLength: 3 }),
|
||||
isOpencode: fc.boolean(),
|
||||
}),
|
||||
({ home, segs, isOpencode }) => {
|
||||
const resolvedTarget = target(home, segs);
|
||||
const suffix = segs.join('/');
|
||||
const prefix = conversion._computePathPrefix({
|
||||
isGlobal: true,
|
||||
isOpencode,
|
||||
isWindowsHost: false,
|
||||
resolvedTarget,
|
||||
homeDir: home,
|
||||
});
|
||||
if (!isOpencode) {
|
||||
// Collapse: exact $HOME form, never the resolved homedir path.
|
||||
assert.equal(prefix, `$HOME/${suffix}/`);
|
||||
assert.ok(prefix.startsWith('$HOME/'), 'prefix must start with $HOME token');
|
||||
} else {
|
||||
// opencode: absolute resolved form, never the $HOME shorthand.
|
||||
assert.equal(prefix, `${resolvedTarget}/`);
|
||||
assert.ok(!prefix.startsWith('$HOME'), 'opencode must not use $HOME shorthand');
|
||||
}
|
||||
},
|
||||
),
|
||||
);
|
||||
});
|
||||
|
||||
test('property: non-global never collapses — always the resolved absolute form', () => {
|
||||
fc.assert(
|
||||
fc.property(
|
||||
fc.record({
|
||||
home: fc.constantFrom(...HOMES),
|
||||
segs: fc.array(SEG, { minLength: 1, maxLength: 3 }),
|
||||
}),
|
||||
({ home, segs }) => {
|
||||
const resolvedTarget = target(home, segs);
|
||||
const prefix = conversion._computePathPrefix({
|
||||
isGlobal: false,
|
||||
isOpencode: false,
|
||||
isWindowsHost: false,
|
||||
resolvedTarget,
|
||||
homeDir: home,
|
||||
});
|
||||
assert.equal(prefix, `${resolvedTarget}/`);
|
||||
assert.ok(!prefix.startsWith('$HOME'));
|
||||
},
|
||||
),
|
||||
);
|
||||
});
|
||||
|
||||
test('property: backslash paths project identically to their posix form (#1615)', () => {
|
||||
fc.assert(
|
||||
fc.property(
|
||||
fc.record({
|
||||
home: fc.constantFrom(...HOMES),
|
||||
segs: fc.array(SEG, { minLength: 1, maxLength: 3 }),
|
||||
}),
|
||||
({ home, segs }) => {
|
||||
const posixTarget = target(home, segs);
|
||||
const backslashTarget = posixTarget.replace(/\//g, '\\');
|
||||
const backslashHome = home.replace(/\//g, '\\');
|
||||
const fromBackslash = conversion._computePathPrefix({
|
||||
isGlobal: true,
|
||||
isOpencode: false,
|
||||
isWindowsHost: false,
|
||||
resolvedTarget: backslashTarget,
|
||||
homeDir: backslashHome,
|
||||
});
|
||||
const fromPosix = conversion._computePathPrefix({
|
||||
isGlobal: true,
|
||||
isOpencode: false,
|
||||
isWindowsHost: false,
|
||||
resolvedTarget: posixTarget,
|
||||
homeDir: home,
|
||||
});
|
||||
assert.equal(fromBackslash, fromPosix);
|
||||
},
|
||||
),
|
||||
);
|
||||
});
|
||||
});
|
||||
|
||||
describe('_applyRuntimeRewrites: path-rewrite idempotency (#1676 / ADR-1508)', () => {
|
||||
test('property: f(f(content)) === f(content) across path-rewriting runtimes', () => {
|
||||
fc.assert(
|
||||
fc.property(
|
||||
fc.record({
|
||||
runtime: fc.constantFrom(...PATH_REWRITE_RUNTIMES),
|
||||
home: fc.constantFrom(...HOMES),
|
||||
isGlobal: fc.boolean(),
|
||||
segs: fc.array(SEG, { minLength: 1, maxLength: 4 }),
|
||||
}),
|
||||
({ runtime, home, isGlobal, segs }) => {
|
||||
// configDir under $HOME so global collapses to $HOME/.<dirName>/;
|
||||
// non-global projects to an absolute form. Both are prefix shapes
|
||||
// that contain no matchable ~/.claude or $HOME/.claude token, so a
|
||||
// second rewrite pass is a no-op.
|
||||
const dirName = getDirName(runtime).replace(/^\./, '');
|
||||
const configDir = target(home, [`.${dirName}`]);
|
||||
const pathPrefix = conversion._computePathPrefix({
|
||||
isGlobal,
|
||||
isOpencode: false,
|
||||
isWindowsHost: false,
|
||||
resolvedTarget: configDir,
|
||||
homeDir: home,
|
||||
});
|
||||
|
||||
// Seed content with every reference shape the engine rewrites,
|
||||
// interleaved with inert prose so rewrites land mid-line.
|
||||
const lines = segs.map((s) =>
|
||||
`See ~/.claude/skills/${s} or $HOME/.claude/agents/${s}; also ./.claude/${s}.`);
|
||||
const content = lines.join('\n');
|
||||
|
||||
const once = conversion._applyRuntimeRewrites(content, runtime, pathPrefix, isGlobal, undefined);
|
||||
const twice = conversion._applyRuntimeRewrites(once, runtime, pathPrefix, isGlobal, undefined);
|
||||
assert.equal(twice, once, 'second rewrite pass must be a no-op (idempotent)');
|
||||
// Sanity: the seed references were actually rewritten on the first pass.
|
||||
assert.ok(!once.includes('~/.claude/'), 'first pass must eliminate ~/.claude/ refs');
|
||||
},
|
||||
),
|
||||
);
|
||||
});
|
||||
});
|
||||
Reference in New Issue
Block a user