golem15/msd-core
3
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

fix(ci): remove stale SDK-variant tests for files deleted in 377a6d2 (#2725)

Browse Source 
377a6d2 deleted sdk/prompts/agents/ and sdk/prompts/workflows/ (13 files)
but did not update 3 test files that reference them, causing ENOENT
failures on every CI run (main and all PRs) since that commit.

Removed:
- sdk/prompts/agents variants describe block (enh-2427-sycophancy-hardening)
- PLAN_PHASE_SDK_PATH constant and headless plan-phase test (post-planning-gaps-2493)
- sdk/prompts/workflows/verify-phase.md describe block (verifier-deferred-items)

The underlying behaviour is covered by the existing main agent/workflow
tests; the SDK variant tests are moot now that the SDK loads installed
files instead of bundled stripped-down copies.

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Tom Boucher
2026-04-25 16:26:15 -04:00
committed by GitHub
parent a5a2d44121
commit caf6974bbf
3 changed files with 3 additions and 61 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
tests/enh-2427-sycophancy-hardening.test.cjs
View File

@@ -15,7 +15,6 @@ const fs = require('node:fs');
const path = require('node:path');
const AGENTS_DIR = path.join(__dirname, '../agents');
const SDK_AGENTS_DIR = path.join(__dirname, '../sdk/prompts/agents');
const AUDIT_AGENTS = [
'gsd-plan-checker.md',
@@ -29,11 +28,6 @@ const AUDIT_AGENTS = [
'gsd-doc-verifier.md',
];
const SDK_AUDIT_AGENTS = [
'gsd-plan-checker.md',
'gsd-verifier.md',
];
function readAgent(agentsDir, filename) {
return fs.readFileSync(path.join(agentsDir, filename), 'utf-8');
}
@@ -102,26 +96,5 @@ describe('enh-2427 — sycophancy hardening: audit-class agents', () => {
});
}
describe('sdk/prompts/agents variants', () => {
for (const filename of SDK_AUDIT_AGENTS) {
const label = `sdk/${filename.replace('.md', '')}`;
describe(label, () => {
test('third-person framing and adversarial_stance block present', () => {
const content = readAgent(SDK_AGENTS_DIR, filename);
const role = extractRole(content);
const firstSentence = role.trim().slice(0, 80);
assert.ok(
!firstSentence.startsWith('You are a GSD'),
`${filename}: SDK variant must not open <role> with "You are a GSD"`
);
assert.ok(
content.includes('<adversarial_stance>'),
`${filename}: SDK variant must contain <adversarial_stance> block`
);
});
});
}
});
});
// sdk/prompts/agents/ was removed in 377a6d2 — SDK now loads installed agents directly.

6
tests/post-planning-gaps-2493.test.cjs
View File

@@ -30,7 +30,6 @@ const { runGsdTools, createTempProject, cleanup } = require('./helpers.cjs');
const REPO_ROOT = path.join(__dirname, '..');
const PLAN_PHASE_PATH = path.join(REPO_ROOT, 'get-shit-done', 'workflows', 'plan-phase.md');
const PLAN_PHASE_SDK_PATH = path.join(REPO_ROOT, 'sdk', 'prompts', 'workflows', 'plan-phase.md');
// ─── Workflow file structure ──────────────────────────────────────────────────
@@ -77,10 +76,7 @@ describe('plan-phase.md Step 13e insertion (#2493)', () => {
assert.match(content, /## 13\.\s*Requirements Coverage Gate/);
});
test('Headless plan-phase variant has post_planning_gaps step', () => {
const content = fs.readFileSync(PLAN_PHASE_SDK_PATH, 'utf-8');
assert.match(content, /post_planning_gaps/);
});
// sdk/prompts/workflows/plan-phase.md removed in 377a6d2 — SDK loads installed workflow directly.
});
// ─── Decisions parser ────────────────────────────────────────────────────────

29
tests/verifier-deferred-items.test.cjs
View File

@@ -150,34 +150,7 @@ describe('verifier deferred-items filtering (#1624)', () => {
});
});
// ── verify-phase.md (SDK variant) ──────────────────────────────────────────
describe('sdk/prompts/workflows/verify-phase.md', () => {
const sdkPath = path.join(ROOT, 'sdk', 'prompts', 'workflows', 'verify-phase.md');
let sdkContent;
test('file exists', () => {
assert.ok(fs.existsSync(sdkPath), 'SDK verify-phase.md should exist');
sdkContent = fs.readFileSync(sdkPath, 'utf-8');
});
test('loads roadmap analyze in context step', () => {
sdkContent = sdkContent || fs.readFileSync(sdkPath, 'utf-8');
assert.ok(
sdkContent.includes('roadmap analyze'),
'SDK verify-phase.md should reference roadmap analyze for deferred-item filtering'
);
});
test('contains deferred-item filtering step', () => {
sdkContent = sdkContent || fs.readFileSync(sdkPath, 'utf-8');
assert.ok(
sdkContent.includes('filter_deferred_items') ||
sdkContent.includes('deferred'),
'SDK verify-phase.md should contain deferred-item filtering logic'
);
});
});
// sdk/prompts/workflows/verify-phase.md removed in 377a6d2 — SDK loads installed workflow directly.
// ── planner-gap-closure.md ─────────────────────────────────────────────────