Merge pull request #1546 from nicbarrett/fix/opencode-permission-string-guard

fix(opencode): guard string-valued permission config

bin/install.js

@@ -3985,8 +3985,14 @@ function configureOpencodePermissions(isGlobal = true) {
     }
   }
 
+  // OpenCode also allows a top-level string permission like "allow".
+  // In that case, path-specific permission entries are unnecessary.
+  if (typeof config.permission === 'string') {
+    return;
+  }
+
   // Ensure permission structure exists
-  if (!config.permission) {
+  if (!config.permission || typeof config.permission !== 'object') {
     config.permission = {};
   }
 
@@ -5207,6 +5213,7 @@ if (process.env.GSD_TEST_MODE) {
     validateHookFields,
     installSdk,
     promptSdk,
+    configureOpencodePermissions,
   };
 } else {
 

tests/opencode-permissions.test.cjs

@@ -0,0 +1,69 @@
+/**
+ * Regression tests for OpenCode permission config handling.
+ *
+ * Ensures the installer does not crash when opencode.json uses the valid
+ * top-level string form: "permission": "allow".
+ */
+
+const { test, describe, beforeEach, afterEach } = require('node:test');
+const assert = require('node:assert/strict');
+const fs = require('fs');
+const path = require('path');
+const { createTempDir, cleanup } = require('./helpers.cjs');
+
+process.env.GSD_TEST_MODE = '1';
+const { configureOpencodePermissions } = require('../bin/install.js');
+
+const envKeys = ['OPENCODE_CONFIG_DIR', 'OPENCODE_CONFIG', 'XDG_CONFIG_HOME'];
+const originalEnv = Object.fromEntries(envKeys.map(key => [key, process.env[key]]));
+
+function restoreEnv(snapshot) {
+  for (const key of envKeys) {
+    if (snapshot[key] === undefined) {
+      delete process.env[key];
+    } else {
+      process.env[key] = snapshot[key];
+    }
+  }
+}
+
+let configDir;
+
+beforeEach(() => {
+  configDir = createTempDir('gsd-opencode-');
+});
+
+afterEach(() => {
+  cleanup(configDir);
+  restoreEnv(originalEnv);
+});
+
+describe('configureOpencodePermissions', () => {
+  test('does not crash or rewrite top-level string permissions', () => {
+    const configPath = path.join(configDir, 'opencode.json');
+    const original = JSON.stringify({
+      $schema: 'https://opencode.ai/config.json',
+      permission: 'allow',
+      skills: { paths: ['/tmp/skills'] },
+    }, null, 2) + '\n';
+
+    fs.writeFileSync(configPath, original);
+    process.env.OPENCODE_CONFIG_DIR = configDir;
+
+    assert.doesNotThrow(() => configureOpencodePermissions(true));
+    assert.strictEqual(fs.readFileSync(configPath, 'utf8'), original);
+  });
+
+  test('adds path-specific read and external_directory permissions for object configs', () => {
+    const configPath = path.join(configDir, 'opencode.json');
+    fs.writeFileSync(configPath, JSON.stringify({ permission: {} }, null, 2) + '\n');
+    process.env.OPENCODE_CONFIG_DIR = configDir;
+
+    configureOpencodePermissions(true);
+
+    const config = JSON.parse(fs.readFileSync(configPath, 'utf8'));
+    const gsdPath = `${configDir.replace(/\\/g, '/')}/get-shit-done/*`;
+    assert.strictEqual(config.permission.read[gsdPath], 'allow');
+    assert.strictEqual(config.permission.external_directory[gsdPath], 'allow');
+  });
+});