golem15/msd-core
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat(workflows): add stall detection to plan-phase revision loop (#1794)

Browse Source 
* feat(workflows): add stall detection to plan-phase revision loop

Adds issue count tracking and stall detection to the plan-phase
revision loop (step 12). When issue count stops decreasing across
iterations, the loop escalates to the user instead of burning
remaining iterations. The existing 3-iteration cap remains as a
backstop. Uses normalized issue counting from checker YAML output.

Closes #1716

* fix(workflows): add parsing fallback and re-entry guard to stall detection
This commit is contained in:
Rezolv
2026-04-05 18:33:19 -04:00
committed by GitHub
parent 3bce941b2a
commit db6f999ee4
1 changed files with 25 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
get-shit-done/workflows/plan-phase.md
View File

@@ -794,10 +794,34 @@ If thinking_partner disabled: skip this block entirely.
## 12. Revision Loop (Max 3 Iterations)
Track `iteration_count` (starts at 1 after initial plan + check).
Track `prev_issue_count` (initialized to `Infinity` before the loop begins).
Track `stall_reentry_count` (starts at 0; incremented each time "Adjust approach" re-enters step 8).
**If iteration_count < 3:**
Display: `Sending back to planner for revision... (iteration {N}/3)`
Parse issue count from checker return: count BLOCKER + WARNING entries in the YAML issues block (structured output from gsd-plan-checker). If the checker's return contains no YAML issues block (i.e., the plan was approved with no issues), treat `issue_count` as 0 and skip the stall check — the plan passed. Proceed to step 13.
Display: `Revision iteration {N}/3 -- {blocker_count} blockers, {warning_count} warnings`
**Stall detection:** If `issue_count >= prev_issue_count`:
Display: `Revision loop stalled — issue count not decreasing ({issue_count} issues remain after {N} iterations)`
**If `stall_reentry_count < 2`:**
Ask user:
Question: "Issues remain after {N} revision attempts with no progress. Proceed with current output?"
Options: "Proceed anyway" | "Adjust approach"
If "Proceed anyway": accept current plans and continue to step 13.
If "Adjust approach": increment `stall_reentry_count`, open freeform discussion, then re-enter step 8 (full replanning). Note: re-entry resets `iteration_count` and `prev_issue_count` but `stall_reentry_count` persists across re-entries and is capped at 2.
**If `stall_reentry_count >= 2`:**
Display: `Stall persists after 2 re-planning attempts. The following issues could not be resolved automatically:`
List the remaining issues from the checker.
Suggest: "Consider resolving these issues manually or running `/gsd-debug` to investigate root causes."
Options: "Proceed anyway" | "Abandon"
If "Proceed anyway": accept current plans and continue to step 13.
If "Abandon": stop workflow.
Set `prev_issue_count = issue_count`.
Revision prompt: