fix(3718): shell-free Node.js UI safety gate — fixes PowerShell silent-fail (#3718)
* fix(workflows): add word-boundary anchoring to UI safety gate grep Replace unanchored grep -iE "UI |..." alternation with POSIX ERE word-boundary-anchored form: LC_ALL=C grep -iE "(^|[^[:alnum:]])(UI|...)([^[:alnum:]]|$)" Unanchored form matched 'ui' inside 'requirements', 'view' inside 'overview' and 'review', 'form' inside 'performance'/'platform'/ 'transform' — producing HAS_UI=0 on 100% of standard roadmap phases (every phase contains a **Requirements**: field). Fix applied to both plan-phase.md:625 and autonomous.md:284. LC_ALL=C added for POSIX locale portability on both BSD and GNU grep. Closes #3706 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * test(workflows): add regression tests for UI safety gate false-positives (#3706) - bug-3706-ui-safety-gate-false-positives.test.cjs: 36-test suite covering both plan-phase.md and autonomous.md gate behavior; verifies that Requirements/overview/performance/platform/transform/review/build/screening do NOT trigger the gate, while standalone UI/view/form/screen/dashboard/ component/lowercase-ui/hyphenated-non-UI DO trigger it. - autonomous-ui-steps.test.cjs: update stale assertion that checked for the old broken grep pattern; now asserts the word-boundary-anchored form. Test strategy: extract the POSIX ERE pattern from the workflow file and simulate grep match semantics in JS (no shell exec, no source-grep). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * chore(changeset): add Fixed fragment for PR #3718 (UI safety gate false-positives) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix(workflows): document compound-token boundary contract; add comment to gate Addresses adversarial review finding: word-boundary anchoring intentionally does not match tokens embedded in compound alphanumeric words (e.g. "microfrontend", "dashboardWidget", "uiSpec"). This is correct behavior — gsd-roadmapper generates natural English prose, not camelCase compounds. Hyphenated forms ("micro-frontend") and spaced forms are caught by the anchored pattern (hyphen is [^[:alnum:]]). Add inline comment in both workflow files explaining the pattern intent, the false-positive prevention, and the compound-word contract. Add 4 tests (2 per workflow) documenting the compound-word contract: - "microfrontend" (compound) must NOT trigger gate (documented behavior) - "micro-frontend" (hyphenated) MUST trigger gate (correct true-positive) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix(3718): replace shell grep gate with shell-free Node.js helper Moves UI safety gate logic from `LC_ALL=C grep -iE` (silently broken on Windows PowerShell — locale env-var prefix not recognised by pwsh) to `bin/lib/ui-safety-gate.cjs` (Node.js, reads via stdin to avoid ARG_MAX). Path is anchored via `git rev-parse --show-toplevel` (GSD_REPO_ROOT) to avoid CWD-sensitive failure when Claude Code executes from a subdirectory. Word-boundary regex is identical to the original POSIX ERE pattern: (^|[^a-zA-Z0-9])(TOKEN)([^a-zA-Z0-9]|$) Exit codes mirror grep: 0 = UI found, 1 = not found. Tests: 51/51 pass — includes spawnSync shell:false + stdin cross-shell portability tests and ARG_MAX large-input test. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix(3706): address pr-review-toolkit + codex review findings - Multi-token-per-line: use matchAll to capture all UI tokens - Add test for multiple distinct tokens on same line - Clarify ASCII vs POSIX [:alnum:] in word-boundary comment - Correct misleading "path anchored" comment in plan-phase/autonomous workflows - Remove UI_GATE_PATTERN from module.exports (internal implementation detail) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(state): restore ACQUIRE_LOCK_RETRY_ERRNOS in acquireStateLock (#3718) Commit473c279cremoved ACQUIRE_LOCK_RETRY_ERRNOS and replaced the correct `throw err` path with `return lockPath`, which silently "succeeds" on any non-EEXIST error — allowing two concurrent processes to both hold the lock simultaneously and causing lost updates. This restores the set of recoverable transient errno codes (Docker overlay-fs EINVAL/EIO/ENOENT, NFS ESTALE, POSIX EAGAIN/EINTR, Windows EPERM/EBUSY) that should retry, and restores `throw err` for genuinely fatal codes. Equivalent to commit47983914on main. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Tom Boucher
5
.changeset/plucky-rams-climb.md
Normal file
5
.changeset/plucky-rams-climb.md
Normal file
@@ -0,0 +1,5 @@
|
||||
---
|
||||
type: Fixed
|
||||
pr: 3718
|
||||
---
|
||||
**UI safety gate no longer false-positives on phases containing 'Requirements', 'overview', 'performance', or other words that contain UI/view/form as substrings** — the gate now uses word-boundary-anchored POSIX ERE `(^|[^[:alnum:]])(UI|...)([^[:alnum:]]|$)` instead of unanchored substring matching.
|
||||
107
bin/lib/ui-safety-gate.cjs
Normal file
107
bin/lib/ui-safety-gate.cjs
Normal file
@@ -0,0 +1,107 @@
|
||||
'use strict';
|
||||
|
||||
/**
|
||||
* UI Safety Gate — shell-free implementation (#3706, #3718)
|
||||
*
|
||||
* Replaces the bash shell-based one-liner that silently degraded on Windows
|
||||
* PowerShell / cmd.exe because the locale env-var prefix was not recognised.
|
||||
* This module runs inside Node.js — no shell dependency, works identically
|
||||
* on bash, Git-Bash, PowerShell, and cmd.exe.
|
||||
*
|
||||
* Word-boundary anchoring:
|
||||
* (^|[^a-zA-Z0-9])(TOKEN)([^a-zA-Z0-9]|$)
|
||||
* Equivalent to POSIX ERE [^[:alnum:]] — matches tokens only when they are not
|
||||
* interior substrings of alphanumeric compound words (e.g. "microfrontend" is NOT
|
||||
* matched; "micro-frontend" and "micro frontend" ARE matched).
|
||||
*
|
||||
* Public API:
|
||||
* checkUiPresence(text: string): { hasUI: boolean, tokens: string[] }
|
||||
*
|
||||
* CLI usage — reads phase-section text from STDIN to avoid ARG_MAX limits:
|
||||
* echo "$PHASE_SECTION" | node bin/lib/ui-safety-gate.cjs
|
||||
* echo $? → 0 if UI tokens found, 1 if not, 2 on usage error
|
||||
*
|
||||
* Exit codes mirror grep: 0 = match found, 1 = no match, 2 = usage error.
|
||||
*/
|
||||
|
||||
const UI_TOKENS = [
|
||||
'UI',
|
||||
'interface',
|
||||
'frontend',
|
||||
'component',
|
||||
'layout',
|
||||
'page',
|
||||
'screen',
|
||||
'view',
|
||||
'form',
|
||||
'dashboard',
|
||||
'widget',
|
||||
];
|
||||
|
||||
/**
|
||||
* Built once at module load — no per-call compilation overhead.
|
||||
* ASCII word boundaries — matches the original ASCII-grep intent of #3706.
|
||||
* Note: JS [a-zA-Z0-9] is ASCII-only and NOT equivalent to POSIX [[:alnum:]],
|
||||
* which is locale-sensitive and includes accented characters.
|
||||
*/
|
||||
const UI_GATE_PATTERN = new RegExp(
|
||||
'(^|[^a-zA-Z0-9])(' + UI_TOKENS.join('|') + ')([^a-zA-Z0-9]|$)',
|
||||
'i'
|
||||
);
|
||||
|
||||
// Global-flagged variant for extracting ALL matches per line (matchAll).
|
||||
const UI_GATE_PATTERN_GLOBAL = new RegExp(UI_GATE_PATTERN.source, 'gi');
|
||||
|
||||
/**
|
||||
* Check a roadmap phase section string for frontend UI indicators.
|
||||
*
|
||||
* @param {string} text - The roadmap phase section content (may be multi-line, CRLF or LF).
|
||||
* @returns {{ hasUI: boolean, tokens: string[] }}
|
||||
* hasUI — true if any UI token was matched as a standalone word.
|
||||
* tokens — matched token strings (lowercased), deduplicated.
|
||||
*/
|
||||
function checkUiPresence(text) {
|
||||
if (typeof text !== 'string') {
|
||||
return { hasUI: false, tokens: [] };
|
||||
}
|
||||
|
||||
// Normalise CRLF so the pattern sees consistent line boundaries.
|
||||
const normalised = text.replace(/\r\n/g, '\n');
|
||||
|
||||
const found = new Set();
|
||||
for (const line of normalised.split('\n')) {
|
||||
// Reset lastIndex before each line so the global pattern restarts from 0.
|
||||
UI_GATE_PATTERN_GLOBAL.lastIndex = 0;
|
||||
for (const m of line.matchAll(UI_GATE_PATTERN_GLOBAL)) {
|
||||
found.add(m[2].toLowerCase());
|
||||
}
|
||||
}
|
||||
|
||||
return { hasUI: found.size > 0, tokens: [...found] };
|
||||
}
|
||||
|
||||
module.exports = { checkUiPresence, UI_TOKENS };
|
||||
|
||||
// ── CLI entry point ─────────────────────────────────────────────────────────
|
||||
// Reads phase-section text from STDIN (not argv) to avoid OS ARG_MAX limits.
|
||||
// Invoked by workflow .md bash blocks as: echo "$PHASE_SECTION" | node bin/lib/ui-safety-gate.cjs
|
||||
// Exit 0 = UI found, 1 = no UI, 2 = startup error.
|
||||
|
||||
if (require.main === module) {
|
||||
// Collect stdin chunks asynchronously.
|
||||
const chunks = [];
|
||||
process.stdin.setEncoding('utf-8');
|
||||
|
||||
process.stdin.on('data', (chunk) => chunks.push(chunk));
|
||||
|
||||
process.stdin.on('end', () => {
|
||||
const input = chunks.join('');
|
||||
const result = checkUiPresence(input);
|
||||
process.exit(result.hasUI ? 0 : 1);
|
||||
});
|
||||
|
||||
process.stdin.on('error', (err) => {
|
||||
process.stderr.write(`ERROR: ui-safety-gate.cjs stdin read failed: ${err.message}\n`);
|
||||
process.exit(2);
|
||||
});
|
||||
}
|
||||
@@ -281,7 +281,12 @@ Check if this phase has frontend indicators and whether a UI-SPEC already exists
|
||||
|
||||
```bash
|
||||
PHASE_SECTION=$(gsd-sdk query roadmap.get-phase ${PHASE_NUM} 2>/dev/null)
|
||||
echo "$PHASE_SECTION" | grep -iE "UI|interface|frontend|component|layout|page|screen|view|form|dashboard|widget" > /dev/null 2>&1
|
||||
# Shell-free word-boundary gate (#3718): Node.js helper — no locale env-var dependency.
|
||||
# Reads via stdin to avoid OS ARG_MAX limits on large phase text.
|
||||
# Path anchored to repo root; falls back to CWD if git is unavailable
|
||||
# Exit codes mirror grep: 0 = UI tokens found, 1 = not found.
|
||||
GSD_REPO_ROOT=$(git rev-parse --show-toplevel 2>/dev/null || echo ".")
|
||||
printf '%s' "$PHASE_SECTION" | node "${GSD_REPO_ROOT}/bin/lib/ui-safety-gate.cjs" > /dev/null 2>&1
|
||||
HAS_UI=$?
|
||||
UI_SPEC_FILE=$(ls "${PHASE_DIR}"/*-UI-SPEC.md 2>/dev/null | head -1)
|
||||
```
|
||||
|
||||
@@ -622,7 +622,12 @@ Check if phase has frontend indicators:
|
||||
|
||||
```bash
|
||||
PHASE_SECTION=$(gsd-sdk query roadmap.get-phase "${PHASE}" 2>/dev/null)
|
||||
echo "$PHASE_SECTION" | grep -iE "UI|interface|frontend|component|layout|page|screen|view|form|dashboard|widget" > /dev/null 2>&1
|
||||
# Shell-free word-boundary gate (#3718): Node.js helper — no locale env-var dependency.
|
||||
# Reads via stdin to avoid OS ARG_MAX limits on large phase text.
|
||||
# Path anchored to repo root; falls back to CWD if git is unavailable
|
||||
# Exit codes mirror grep: 0 = UI tokens found, 1 = not found.
|
||||
GSD_REPO_ROOT=$(git rev-parse --show-toplevel 2>/dev/null || echo ".")
|
||||
printf '%s' "$PHASE_SECTION" | node "${GSD_REPO_ROOT}/bin/lib/ui-safety-gate.cjs" > /dev/null 2>&1
|
||||
HAS_UI=$?
|
||||
```
|
||||
|
||||
|
||||
@@ -29,11 +29,17 @@ describe('autonomous workflow ui-phase and ui-review integration (#1375)', () =>
|
||||
);
|
||||
});
|
||||
|
||||
test('UI design contract step detects frontend indicators via grep pattern', () => {
|
||||
// Same grep pattern as plan-phase step 5.6
|
||||
test('UI design contract step detects frontend indicators via shell-free Node gate (#3718)', () => {
|
||||
// After #3718 fix: the gate is implemented in bin/lib/ui-safety-gate.cjs (Node.js)
|
||||
// piped from stdin, path anchored via git rev-parse. This avoids silent failure
|
||||
// on Windows PowerShell and ARG_MAX limits for large phase text.
|
||||
assert.ok(
|
||||
content.includes('grep -iE "UI|interface|frontend|component|layout|page|screen|view|form|dashboard|widget"'),
|
||||
'should use the same frontend detection grep pattern as plan-phase step 5.6'
|
||||
content.includes('ui-safety-gate.cjs'),
|
||||
'should invoke shell-free Node gate for cross-platform portability (#3718)'
|
||||
);
|
||||
assert.ok(
|
||||
content.includes('GSD_REPO_ROOT'),
|
||||
'should anchor gate path to GSD_REPO_ROOT to avoid CWD-sensitive failure'
|
||||
);
|
||||
});
|
||||
|
||||
|
||||
296
tests/bug-3706-ui-safety-gate-false-positives.test.cjs
Normal file
296
tests/bug-3706-ui-safety-gate-false-positives.test.cjs
Normal file
@@ -0,0 +1,296 @@
|
||||
'use strict';
|
||||
|
||||
/**
|
||||
* Tests for bug #3706 (word-boundary anchoring) and #3718 (cross-shell portability).
|
||||
*
|
||||
* Root cause (#3706): grep -iE "UI|..." had no word-boundary anchoring, causing
|
||||
* false-positives on "Requirements" (contains "ui"), "overview" ("view"), etc.
|
||||
*
|
||||
* Root cause (#3718): shell-based invocation (with locale env-var prefix) silently
|
||||
* degrades on Windows PowerShell — the prefix is not recognised by pwsh.
|
||||
*
|
||||
* Fix (#3718, Approach A): gate logic moved to `bin/lib/ui-safety-gate.cjs` (Node.js).
|
||||
* Reads phase text from STDIN (not argv) to avoid OS ARG_MAX limits.
|
||||
* Invoked as: printf '%s' "$PHASE_SECTION" | node "${GSD_REPO_ROOT}/bin/lib/ui-safety-gate.cjs"
|
||||
* Path anchored to repo root via `git rev-parse --show-toplevel`.
|
||||
*
|
||||
* Test strategy:
|
||||
* 1. Import the helper module directly and assert correct results on the full fixture
|
||||
* matrix (exercises the production code path).
|
||||
* 2. Spawn the helper as a child process with shell:false and input on stdin to prove
|
||||
* cross-shell portability — spawnSync with shell:false bypasses any host shell.
|
||||
* 3. Assert the workflow .md files now invoke `node ... ui-safety-gate.cjs` via stdin
|
||||
* rather than the old shell-based invocation (structural guard against regression).
|
||||
*/
|
||||
|
||||
const { describe, test } = require('node:test');
|
||||
const assert = require('node:assert/strict');
|
||||
const fs = require('fs');
|
||||
const path = require('path');
|
||||
const { spawnSync } = require('node:child_process');
|
||||
|
||||
const HELPER_PATH = path.join(__dirname, '..', 'bin', 'lib', 'ui-safety-gate.cjs');
|
||||
const PLAN_PHASE_PATH = path.join(__dirname, '..', 'get-shit-done', 'workflows', 'plan-phase.md');
|
||||
const AUTONOMOUS_PATH = path.join(__dirname, '..', 'get-shit-done', 'workflows', 'autonomous.md');
|
||||
|
||||
const { checkUiPresence } = require(HELPER_PATH);
|
||||
|
||||
// ── Helper ────────────────────────────────────────────────────────────────────
|
||||
|
||||
/**
|
||||
* Mirrors the old `hasUiGate` helper for backwards-compatible assertions.
|
||||
* Returns 0 (UI found) or 1 (not found), matching grep exit code semantics.
|
||||
*/
|
||||
function hasUiGate(text) {
|
||||
return checkUiPresence(text).hasUI ? 0 : 1;
|
||||
}
|
||||
|
||||
/**
|
||||
* Spawn the helper with shell:false, passing input via stdin.
|
||||
* Returns the spawnSync result object.
|
||||
*/
|
||||
function spawnGate(input) {
|
||||
return spawnSync(process.execPath, [HELPER_PATH], {
|
||||
shell: false,
|
||||
encoding: 'utf-8',
|
||||
input: input,
|
||||
});
|
||||
}
|
||||
|
||||
// ── Structural guard — workflow files now invoke Node via stdin ───────────────
|
||||
|
||||
describe('Workflow .md structural guard (#3718)', () => {
|
||||
// allow-test-rule: source-text-is-the-product
|
||||
// The UI safety gate invocation is embedded in workflow prose-as-code.
|
||||
// These structural tests guard against regression where someone re-introduces
|
||||
// the shell-based locale-prefix invocation that silently breaks on Windows PowerShell.
|
||||
for (const [label, filePath] of [
|
||||
['plan-phase.md', PLAN_PHASE_PATH],
|
||||
['autonomous.md', AUTONOMOUS_PATH],
|
||||
]) {
|
||||
test(`${label} must invoke ui-safety-gate.cjs via stdin, anchored to GSD_REPO_ROOT`, () => {
|
||||
const content = fs.readFileSync(filePath, 'utf-8');
|
||||
assert.ok(
|
||||
content.includes('ui-safety-gate.cjs'),
|
||||
`${label}: must reference ui-safety-gate.cjs for cross-shell portability (#3718)`
|
||||
);
|
||||
assert.ok(
|
||||
content.includes('GSD_REPO_ROOT'),
|
||||
`${label}: must anchor path to GSD_REPO_ROOT to avoid CWD-sensitive failure (#3718)`
|
||||
);
|
||||
assert.ok(
|
||||
content.includes('git rev-parse --show-toplevel'),
|
||||
`${label}: must derive GSD_REPO_ROOT from git rev-parse --show-toplevel`
|
||||
);
|
||||
// Confirm stdin pipe usage (printf or echo piped to node)
|
||||
assert.ok(
|
||||
content.includes('printf') || content.includes('echo'),
|
||||
`${label}: must pipe phase section via stdin (printf/echo | node) to avoid ARG_MAX`
|
||||
);
|
||||
assert.ok(
|
||||
!content.includes('LC_ALL=C grep'),
|
||||
`${label}: must NOT contain LC_ALL=C grep — that silently fails on Windows PowerShell (#3718)`
|
||||
);
|
||||
});
|
||||
}
|
||||
});
|
||||
|
||||
// ── Cross-shell spawn test (#3718) ────────────────────────────────────────────
|
||||
|
||||
describe('Cross-shell portability — spawnSync with shell:false, stdin (#3718)', () => {
|
||||
test('spawn with shell:false + stdin: UI input exits 0', () => {
|
||||
const result = spawnGate('UI Refactor: migrate all screens');
|
||||
assert.strictEqual(result.status, 0, `Expected exit 0 (UI found), got ${result.status}. stderr: ${result.stderr}`);
|
||||
});
|
||||
|
||||
test('spawn with shell:false + stdin: non-UI input exits 1', () => {
|
||||
const result = spawnGate('Requirements: backend REST API only');
|
||||
assert.strictEqual(result.status, 1, `Expected exit 1 (no UI), got ${result.status}. stderr: ${result.stderr}`);
|
||||
});
|
||||
|
||||
test('spawn with shell:false + stdin: empty input exits 1', () => {
|
||||
const result = spawnGate('');
|
||||
assert.strictEqual(result.status, 1, `Expected exit 1 (no UI for empty input), got ${result.status}. stderr: ${result.stderr}`);
|
||||
});
|
||||
|
||||
test('spawn with shell:false + stdin: CRLF line endings handled correctly', () => {
|
||||
const result = spawnGate('Deploy to the cloud platform\r\nand configure CI/CD.');
|
||||
assert.strictEqual(result.status, 1, `CRLF "platform" must not trigger gate. stderr: ${result.stderr}`);
|
||||
});
|
||||
|
||||
test('spawn with shell:false + stdin: multi-line input with UI token exits 0', () => {
|
||||
const multiLine = 'Backend setup\nBuild the analytics dashboard\nand navigation component.';
|
||||
const result = spawnGate(multiLine);
|
||||
assert.strictEqual(result.status, 0, `Multi-line input with "dashboard" must exit 0. stderr: ${result.stderr}`);
|
||||
});
|
||||
|
||||
test('spawn with shell:false + stdin: very large input (>100KB) is handled without error', () => {
|
||||
// Verifies stdin transport does not hit ARG_MAX (argv transport fails above ~1MB on macOS).
|
||||
// Fixture uses pure backend prose — no standalone UI tokens.
|
||||
const largeInput = 'Backend service deployment and database migration step.\n'.repeat(3000);
|
||||
const result = spawnGate(largeInput);
|
||||
assert.strictEqual(result.status, 1, `Large non-UI input must exit 1, not crash. status: ${result.status}, stderr: ${result.stderr}`);
|
||||
});
|
||||
|
||||
test('spawn with shell:false + stdin: large input with UI token exits 0', () => {
|
||||
const largeUiInput = 'Backend infrastructure setup.\n'.repeat(2999) + 'Build the analytics dashboard.\n';
|
||||
const result = spawnGate(largeUiInput);
|
||||
assert.strictEqual(result.status, 0, `Large input ending with UI token must exit 0. stderr: ${result.stderr}`);
|
||||
});
|
||||
});
|
||||
|
||||
// ── Behavioral test matrix (via module import) ────────────────────────────────
|
||||
|
||||
/**
|
||||
* Full fixture matrix — exercises the production checkUiPresence() function directly.
|
||||
*/
|
||||
function runBehavioralTests(label) {
|
||||
describe(`${label} — UI gate behavioral matrix`, () => {
|
||||
|
||||
// ── False-positive tests (must NOT match) ──────────────────────────────
|
||||
|
||||
test('"Requirements" must NOT trigger UI gate (bug #3706 — "ui" substring)', () => {
|
||||
const phaseSection =
|
||||
'**Requirements**: The service must expose REST endpoints for authentication.\n' +
|
||||
'All work is server-side. Database migrations and API contract only.';
|
||||
assert.strictEqual(hasUiGate(phaseSection), 1, '"Requirements" must not match the UI gate');
|
||||
});
|
||||
|
||||
test('"overview" must NOT trigger UI gate ("view" is a substring)', () => {
|
||||
assert.strictEqual(hasUiGate('Overview of the data pipeline architecture and backend services.'), 1);
|
||||
});
|
||||
|
||||
test('"performance" must NOT trigger UI gate ("form" is a substring)', () => {
|
||||
assert.strictEqual(hasUiGate('Performance testing and benchmark analysis for the API layer.'), 1);
|
||||
});
|
||||
|
||||
test('"platform" must NOT trigger UI gate ("form" is a substring)', () => {
|
||||
assert.strictEqual(hasUiGate('Deploy to the cloud platform and configure CI/CD.'), 1);
|
||||
});
|
||||
|
||||
test('"transform" must NOT trigger UI gate ("form" is a substring)', () => {
|
||||
assert.strictEqual(hasUiGate('Transform raw event data and write to the warehouse.'), 1);
|
||||
});
|
||||
|
||||
test('"review" must NOT trigger UI gate ("view" is a substring)', () => {
|
||||
assert.strictEqual(hasUiGate('Code review checklist and PR approval workflow for the API.'), 1);
|
||||
});
|
||||
|
||||
test('"build" must NOT trigger UI gate ("ui" at positions 2-3 of "build")', () => {
|
||||
assert.strictEqual(hasUiGate('Build the backend service and run integration tests.'), 1);
|
||||
});
|
||||
|
||||
test('"screening" must NOT trigger UI gate ("screen" is a substring)', () => {
|
||||
assert.strictEqual(hasUiGate('Implement candidate screening criteria for the hiring pipeline.'), 1);
|
||||
});
|
||||
|
||||
test('empty input does NOT trigger UI gate', () => {
|
||||
assert.strictEqual(hasUiGate(''), 1);
|
||||
});
|
||||
|
||||
test('whitespace-only input does NOT trigger UI gate', () => {
|
||||
assert.strictEqual(hasUiGate(' \n \t '), 1);
|
||||
});
|
||||
|
||||
test('compound "microfrontend" (no separator) does NOT trigger gate — documented behavior', () => {
|
||||
assert.strictEqual(
|
||||
hasUiGate('Build the microfrontend shell application.'), 1,
|
||||
'"microfrontend" compound must NOT trigger gate'
|
||||
);
|
||||
});
|
||||
|
||||
// ── True-positive tests (must match) ──────────────────────────────────
|
||||
|
||||
test('standalone "UI" token DOES trigger UI gate', () => {
|
||||
assert.strictEqual(hasUiGate('UI Refactor: migrate all screens to the new design system.'), 0);
|
||||
});
|
||||
|
||||
test('standalone "view" token DOES trigger UI gate', () => {
|
||||
assert.strictEqual(hasUiGate('Implement the user profile view controller and associated screen.'), 0);
|
||||
});
|
||||
|
||||
test('standalone "form" token DOES trigger UI gate', () => {
|
||||
assert.strictEqual(hasUiGate('Build a sign-up form with client-side validation.'), 0);
|
||||
});
|
||||
|
||||
test('"dashboard" DOES trigger UI gate', () => {
|
||||
assert.strictEqual(hasUiGate('Build the analytics dashboard and navigation component.'), 0);
|
||||
});
|
||||
|
||||
test('lowercase "ui" token DOES trigger UI gate (case-insensitive)', () => {
|
||||
assert.strictEqual(hasUiGate('Redesign the ui for mobile responsiveness.'), 0);
|
||||
});
|
||||
|
||||
test('"non-UI" hyphenated form DOES trigger UI gate (hyphen is a word boundary)', () => {
|
||||
assert.strictEqual(hasUiGate('This is a non-UI backend service with no visual elements.'), 0);
|
||||
});
|
||||
|
||||
test('standalone "screen" token DOES trigger UI gate', () => {
|
||||
assert.strictEqual(hasUiGate('Implement the loading screen and splash animation.'), 0);
|
||||
});
|
||||
|
||||
test('hyphenated "micro-frontend" DOES trigger gate (word boundary on hyphen)', () => {
|
||||
assert.strictEqual(hasUiGate('Build the micro-frontend shell application.'), 0);
|
||||
});
|
||||
|
||||
// ── CRLF / edge case tests ─────────────────────────────────────────────
|
||||
|
||||
test('CRLF line endings: non-UI text does not trigger gate', () => {
|
||||
assert.strictEqual(hasUiGate('Deploy to the cloud platform\r\nand configure CI/CD.'), 1);
|
||||
});
|
||||
|
||||
test('CRLF line endings: UI token on second line triggers gate', () => {
|
||||
assert.strictEqual(hasUiGate('Backend setup complete.\r\nBuild the analytics dashboard.'), 0);
|
||||
});
|
||||
|
||||
test('leading/trailing whitespace does not affect token detection', () => {
|
||||
assert.strictEqual(hasUiGate(' UI refactor phase '), 0);
|
||||
});
|
||||
});
|
||||
}
|
||||
|
||||
runBehavioralTests('ui-safety-gate.cjs');
|
||||
|
||||
// ── checkUiPresence() return value API ───────────────────────────────────────
|
||||
|
||||
describe('checkUiPresence() return value API', () => {
|
||||
test('returns { hasUI: true, tokens: [...] } when UI found', () => {
|
||||
const result = checkUiPresence('Build the dashboard and UI form');
|
||||
assert.strictEqual(result.hasUI, true);
|
||||
assert.ok(Array.isArray(result.tokens), 'tokens must be an array');
|
||||
assert.ok(result.tokens.length > 0, 'tokens must be non-empty when hasUI is true');
|
||||
assert.ok(result.tokens.includes('dashboard') || result.tokens.includes('ui') || result.tokens.includes('form'));
|
||||
});
|
||||
|
||||
test('returns { hasUI: false, tokens: [] } when no UI found', () => {
|
||||
const result = checkUiPresence('Requirements: backend REST API only');
|
||||
assert.strictEqual(result.hasUI, false);
|
||||
assert.deepStrictEqual(result.tokens, []);
|
||||
});
|
||||
|
||||
test('tokens are lowercased', () => {
|
||||
const result = checkUiPresence('UI Refactor');
|
||||
assert.ok(result.tokens.every(t => t === t.toLowerCase()), 'All tokens must be lowercase');
|
||||
});
|
||||
|
||||
test('tokens are deduplicated', () => {
|
||||
const result = checkUiPresence('UI redesign and ui cleanup');
|
||||
const uiCount = result.tokens.filter(t => t === 'ui').length;
|
||||
assert.strictEqual(uiCount, 1, 'Duplicate tokens must be deduplicated');
|
||||
});
|
||||
|
||||
test('non-string input returns { hasUI: false, tokens: [] }', () => {
|
||||
assert.deepStrictEqual(checkUiPresence(null), { hasUI: false, tokens: [] });
|
||||
assert.deepStrictEqual(checkUiPresence(undefined), { hasUI: false, tokens: [] });
|
||||
assert.deepStrictEqual(checkUiPresence(42), { hasUI: false, tokens: [] });
|
||||
});
|
||||
|
||||
test('multiple distinct UI tokens on same line are ALL captured', () => {
|
||||
// "form" and "view" both appear as standalone words on one line.
|
||||
// Prior exec()-based impl only captured the first match per line.
|
||||
const result = checkUiPresence('Build a sign-up form with a view controller');
|
||||
assert.strictEqual(result.hasUI, true, 'hasUI must be true');
|
||||
assert.ok(result.tokens.includes('form'), `Expected "form" in tokens, got: ${JSON.stringify(result.tokens)}`);
|
||||
assert.ok(result.tokens.includes('view'), `Expected "view" in tokens, got: ${JSON.stringify(result.tokens)}`);
|
||||
});
|
||||
});
|
||||
Reference in New Issue
Block a user