fix(ci): pin action SHAs and enforce coverage on all events
- Pin actions/checkout and actions/setup-node to SHA for supply chain safety - Run coverage threshold on all events (not just PRs) so direct pushes to main are also gated - Remove .planning/ artifact that was dev bookkeeping Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
12
.github/workflows/test.yml
vendored
12
.github/workflows/test.yml
vendored
@@ -25,10 +25,10 @@ jobs:
|
||||
node-version: [18, 20, 22]
|
||||
|
||||
steps:
|
||||
- uses: actions/checkout@v4
|
||||
- uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4
|
||||
|
||||
- name: Set up Node.js ${{ matrix.node-version }}
|
||||
uses: actions/setup-node@v4
|
||||
uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4
|
||||
with:
|
||||
node-version: ${{ matrix.node-version }}
|
||||
cache: 'npm'
|
||||
@@ -36,15 +36,11 @@ jobs:
|
||||
- name: Install dependencies
|
||||
run: npm ci
|
||||
|
||||
- name: Run tests
|
||||
if: github.event_name != 'pull_request'
|
||||
run: npm test
|
||||
|
||||
- name: Run tests with coverage
|
||||
# c8 v11 requires Node 20+ (engines: ^20.0.0 || >=22.0.0). Node 18 EOL April 2025.
|
||||
if: github.event_name == 'pull_request' && matrix.node-version != 18
|
||||
if: matrix.node-version != 18
|
||||
run: npm run test:coverage
|
||||
|
||||
- name: Run tests (Node 18, coverage not supported)
|
||||
if: github.event_name == 'pull_request' && matrix.node-version == 18
|
||||
if: matrix.node-version == 18
|
||||
run: npm test
|
||||
|
||||
@@ -1,37 +0,0 @@
|
||||
---
|
||||
phase: 13-verification-milestone-cleanup
|
||||
plan: "03"
|
||||
subsystem: documentation
|
||||
tags: [verification, coverage, cov-tooling, retroactive]
|
||||
requirements-completed: [COV-01, COV-02, COV-03]
|
||||
duration: 2min
|
||||
completed: 2026-02-25
|
||||
---
|
||||
|
||||
# Phase 13 Plan 03: Create 12-VERIFICATION.md Summary
|
||||
|
||||
**12-VERIFICATION.md created for Phase 12, retroactively confirming COV-01, COV-02, COV-03 with live test run evidence**
|
||||
|
||||
## Performance
|
||||
|
||||
- **Duration:** 2 min
|
||||
- **Completed:** 2026-02-25
|
||||
- **Tasks:** 2
|
||||
- **Files modified:** 1
|
||||
|
||||
## Accomplishments
|
||||
|
||||
- Ran `npm run test:coverage` (433 pass, 0 fail; all 11 modules above 70%) to capture live evidence
|
||||
- Confirmed CI workflow has `Run tests with coverage` step with `if: github.event_name == 'pull_request'`
|
||||
- Created 12-VERIFICATION.md at .planning/phases/12-coverage-tooling/12-VERIFICATION.md
|
||||
- All 3 COV requirements (COV-01–03) confirmed PASS with specific evidence
|
||||
- Phase 12 Goal verified: c8 integrated, 70% threshold enforced, CI workflow operational
|
||||
|
||||
## Files Created/Modified
|
||||
|
||||
- `.planning/phases/12-coverage-tooling/12-VERIFICATION.md` — Phase 12 verification (72 lines)
|
||||
|
||||
## Self-Check: PASSED
|
||||
|
||||
- 12-VERIFICATION.md: created, verified COV-01–03 references present (grep count: 5)
|
||||
- Commit: bd9bdad (docs)
|
||||
Reference in New Issue
Block a user