Commit Graph

908 Commits

Author SHA1 Message Date
Ethan Hurst
29a87cba7c test(09-01): add cmdStateLoad, cmdStateGet, cmdStatePatch, cmdStateUpdate CLI tests
- 3 cmdStateLoad tests: state+config+roadmap detection, missing STATE.md, --raw flag output
- 5 cmdStateGet tests: full content, bold field extraction, section extraction, missing field error, missing file error
- 5 cmdStatePatch/cmdStateUpdate tests: batch update, failed fields reporting, single field update, field not found, missing STATE.md
2026-02-26 05:49:31 +10:00
Ethan Hurst
1ca7df13a0 test(09-01): add stateExtractField and stateReplaceField unit tests
- 4 stateExtractField tests: simple extraction, colon-in-value, null on missing, case-insensitive
- 4 stateReplaceField tests: replace value, null on missing, preserves surrounding content, round-trip
2026-02-26 05:49:31 +10:00
Ethan Hurst
ec943fec72 test(08-02): add cmdInitProgress, cmdInitQuick, cmdInitMapCodebase, cmdInitNewProject, cmdInitNewMilestone tests
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-02-26 05:47:33 +10:00
Ethan Hurst
add7799cee test(08-01): add cmdInitTodos, cmdInitMilestoneOp, cmdInitPhaseOp fallback tests
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-02-26 05:47:33 +10:00
Ethan Hurst
c027fe6542 test(07-02): add cmdCommit and cmdWebsearch tests for commands.cjs
cmdCommit tests (5 cases) with real git repos via createTempGitProject:
- commit_docs=false skip, .planning gitignored skip, nothing-to-commit
- Successful commit with hash and git log verification
- Amend mode with commit count verification

cmdWebsearch tests (6 cases) with fetch mocking and stdout interception:
- No API key returns available=false, no query returns error
- Successful response with correct result shape
- URL parameter construction verification
- API error (non-200) handling, network failure handling

Covers requirements CMD-04, CMD-05.
2026-02-26 05:47:33 +10:00
Ethan Hurst
d4ec9c69a9 test(07-01): add utility function tests for commands.cjs
Add 14 new tests across 5 describe blocks:
- cmdGenerateSlug: normal text, special chars, numbers, hyphens, empty input
- cmdCurrentTimestamp: date, filename, full, default format
- cmdListTodos: empty dir, multiple, area filter match/miss, malformed
- cmdVerifyPathExists: file, directory, missing, absolute, no-arg
- cmdResolveModel: known agent, unknown agent, default profile, no-arg

Covers requirements CMD-01, CMD-02, CMD-03.
2026-02-26 05:47:33 +10:00
Ethan Hurst
ad7c79aa6f feat(06-01): add CI status badge to README
- Badge shows workflow status for main branch
- Links to test.yml workflow in GitHub Actions
- Uses for-the-badge style matching existing badges
- Placed after npm downloads badge, before Discord badge
2026-02-26 05:47:33 +10:00
Ethan Hurst
9aa9695731 feat(06-01): create GitHub Actions test workflow
- Tests workflow: push/PR to main + workflow_dispatch
- 3x3 matrix: ubuntu/macos/windows x Node 18/20/22 (9 jobs)
- Concurrency groups with cancel-in-progress
- 10-minute timeout, fail-fast enabled
- Steps: checkout, setup-node with npm cache, npm ci, npm test
2026-02-26 05:47:19 +10:00
Ethan Hurst
e0e7929449 test(05-02): add 7 requirements mark-complete ID format and edge case tests
- single requirement checkbox + traceability table update
- mixed prefixes (TEST-XX, REG-XX, INFRA-XX) in single call
- space-separated ID input format
- bracket-wrapped [REQ-01, REQ-02] input format
- mixed valid/invalid IDs: valid updated, invalid in not_found
- idempotent: re-marking already-complete does not corrupt
- missing REQUIREMENTS.md returns {updated: false, reason: 'not found'}
2026-02-26 05:47:19 +10:00
Ethan Hurst
5778ff3e59 test(05-01): add 5 milestone complete archiving and defensive tests
- --archive-phases flag moves phase dirs to milestones/vX.Y-phases/
- archived REQUIREMENTS.md contains header with version, SHIPPED, date
- STATE.md status/activity/description updated during milestone complete
- missing ROADMAP.md handled gracefully without crash
- empty phases directory handled with zero counts
2026-02-26 05:47:19 +10:00
Ethan Hurst
e8e497bc9d test(03-03): add 20 tests for verify references, commits, artifacts, key-links
- verify references (5): valid refs, missing refs, backtick paths, template skip, not found
- verify commits (3): valid hash, invalid hash, mixed valid+invalid
- verify artifacts (6): all criteria pass, missing file, line count, pattern, export, no artifacts
- verify key-links (6): pattern in source, pattern in target, pattern not found, no-pattern
  string inclusion, source not found, no key_links in frontmatter

Notes:
- parseMustHavesBlock requires 4-space indent for block name, 6-space for items,
  8-space for sub-keys; helpers use this format explicitly
- @https:// refs are NOT skipped by verify references (only backtick http refs are);
  test reflects actual behavior (only template expressions are skipped)
2026-02-26 05:47:19 +10:00
Ethan Hurst
ebe96fe9ee test(03-03): add 8 verify-summary tests including REG-03 and search(-1) regression
- verify-summary returns not found for nonexistent summary
- verify-summary passes for valid summary with real files and commits
- verify-summary reports missing files mentioned in backticks
- verify-summary detects self-check pass and fail indicators
- REG-03: returns self_check 'not_found' when no section exists (not a failure)
- search(-1) regression: guard on line 79 prevents -1 from content.search()
- respects --check-count parameter to limit file checking
2026-02-26 05:47:19 +10:00
Ethan Hurst
0342886eb0 feat(03-02): add comprehensive validate-health test suite
- 16 tests covering all 8 health checks (E001-E005, W001-W007, I001)
- 5 repair tests covering config creation, config reset, STATE regeneration, STATE backup, repairable_count
- Tests overall status logic (healthy/degraded/broken)
- All 21 tests pass with zero failures
2026-02-26 05:47:19 +10:00
Ethan Hurst
9f87ba215b test(03-01): add verify plan-structure and phase-completeness tests
- Add validPlanContent() helper for building valid PLAN.md fixtures
- 7 tests for verify plan-structure: missing frontmatter, valid plan,
  missing name, missing action, wave/depends_on, checkpoint/autonomous,
  and file-not-found
- 4 tests for verify phase-completeness: complete phase, missing summary,
  orphan summary, nonexistent phase
- All 14 tests in verify.test.cjs pass (3 existing + 11 new)
2026-02-26 05:47:19 +10:00
Ethan Hurst
339966e27d feat(03-01): add createTempGitProject helper to tests/helpers.cjs
- Creates temp dir with .planning/phases structure
- Initializes git repo with user config
- Writes initial PROJECT.md and commits it
- Exports createTempGitProject alongside existing helpers
2026-02-26 05:47:19 +10:00
Ethan Hurst
15dca91365 test(02-02): add frontmatter merge and validate CLI integration tests
- frontmatter merge: multi-field merge, conflict overwrite, missing file, invalid JSON
- frontmatter validate: all 3 schemas (plan, summary, verification), missing fields
  detection with count, unknown schema error, missing file error
2026-02-26 05:47:19 +10:00
Ethan Hurst
68b22fad10 test(02-02): add frontmatter get and set CLI integration tests
- frontmatter get: all fields, specific field, missing field, missing file, no frontmatter
- frontmatter set: update existing, add new, JSON array value, missing file, body preservation
- Per-test temp file creation and cleanup pattern
2026-02-26 05:47:19 +10:00
Ethan Hurst
ceb10de3dd test(02-01): add spliceFrontmatter, parseMustHavesBlock, and FRONTMATTER_SCHEMAS tests
- spliceFrontmatter: replace existing, add to plain content, exact body preservation
- parseMustHavesBlock: truths as strings, artifacts as objects with min_lines,
  key_links with from/to/via/pattern, nested arrays, missing block, no frontmatter
- FRONTMATTER_SCHEMAS: plan/summary/verification required fields, all schema names
2026-02-26 05:47:19 +10:00
Ethan Hurst
f722a6aeba test(02-01): add extractFrontmatter and reconstructFrontmatter unit tests
- extractFrontmatter: simple key-value, quotes, nested objects, block arrays,
  inline arrays, REG-04 quoted comma edge case, empty/missing frontmatter,
  emoji/non-ASCII, object-to-array conversion, empty line skipping
- reconstructFrontmatter: simple values, empty/short/long arrays, quoted
  colons/hashes, nested objects, nested arrays, null/undefined skipping
- Round-trip identity tests: simple, nested, and multi-type fixtures
2026-02-26 05:47:19 +10:00
Ethan Hurst
a5fd00278d test(01-02): add phase utility, string helper, and roadmap tests
- escapeRegex: special chars, empty string, plain string
- generateSlugInternal: kebab-case, special chars, null/empty
- normalizePhaseName: padding, letters, decimals, multi-level
- comparePhaseNum: numeric sort, letters, decimals, equality
- safeReadFile: existing file, missing file
- pathExistsInternal: existing, non-existing, absolute paths
- getMilestoneInfo: version extraction, defaults
- searchPhaseInDir: finding dirs, plans/summaries, incomplete,
  research/context detection, slug generation
- findPhaseInternal: current phases, archived milestones, null
- getRoadmapPhaseInternal: export exists (REG-02), goal extraction,
  colon-outside-bold format, missing roadmap, section text
2026-02-26 05:47:19 +10:00
Ethan Hurst
abeacf0290 test(01-01): add loadConfig and resolveModelInternal tests
- 10 loadConfig tests: defaults, model_profile, nested keys, branching,
  model_overrides presence/absence (REG-01), invalid JSON, parallelization
- 17 resolveModelInternal tests: all 3 profiles (quality/balanced/budget)
  with 4 agent types each, override precedence, opus->inherit mapping,
  unknown agent fallback
2026-02-26 05:47:19 +10:00
Ethan Hurst
752e038914 fix: load model_overrides from config and use resolveModelInternal in CLI
loadConfig() never returned model_overrides, so resolveModelInternal()
could never find per-agent overrides — they were silently ignored.

Additionally, cmdResolveModel duplicated model resolution logic but
skipped the override check entirely. Now delegates to resolveModelInternal
so both code paths behave consistently.
2026-02-26 05:47:19 +10:00
Lex Christopherson
7f5ae23fc2 1.21.0 2026-02-25 07:22:43 -06:00
Lex Christopherson
74ca2c78f3 docs: update changelog for v1.21.0 2026-02-25 07:22:38 -06:00
Lex Christopherson
0ca1a59ab3 feat: add YAML frontmatter sync to STATE.md for machine readability 2026-02-25 07:20:14 -06:00
Lex Christopherson
5cb2e740fd feat: improve onboarding UX with /gsd:new-project as default command 2026-02-25 07:20:14 -06:00
Lex Christopherson
334c61f9a4 chore: update Discord invite to vanity URL 2026-02-25 07:20:14 -06:00
Lex Christopherson
3fddd62d50 feat: planning improvements — PRD express path, interface-first planning, living retrospective (#644)
Cherry-pick from @smledbetter with conflict resolution and project-specific reference removed.

Co-Authored-By: Stevo <smledbetter@users.noreply.github.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-02-23 14:00:42 -06:00
Lex Christopherson
2fc9b1d6ae feat(gsd-verifier): add standard project_context block
The verifier was the only agent missing the <project_context> section
that executor, planner, researcher, and plan-checker all have. This
aligns it with the existing pattern so project skills and CLAUDE.md
instructions are applied during verification and anti-pattern scanning.

Closes discussion from PR #723.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-02-23 13:43:34 -06:00
TÂCHES
bc77456204 fix: handle multi-level decimal phases and escape regex in phase operations (#720)
Phase number parsing only matched single-decimal (e.g. 03.2) but crashed
on multi-level decimals (e.g. 03.2.1). Requirement IDs with regex
metacharacters (parentheses, dots) were interpolated raw into RegExp
constructors, causing SyntaxError crashes.

- Add escapeRegex() utility for safe regex interpolation
- Update normalizePhaseName/comparePhaseNum for multi-level decimals
- Replace all .replace('.', '\\.') with escapeRegex() across modules
- Escape reqId before regex interpolation in cmdPhaseComplete
- Update all phase dir matching regexes from (?:\.\d+)? to (?:\.\d+)*
- Add regression test for phase complete 03.2.1

Closes #621

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
2026-02-23 13:32:02 -06:00
TÂCHES
7715e6d1df Fix /gsd:update to always install latest package (#719)
* Fix /gsd:update to pin installer to latest

* Harden /gsd:update install detection with global fallback

---------

Co-authored-by: Colin <colin@solvely.net>
2026-02-23 10:04:11 -06:00
Fana
8b90235dea refactor: compress Nyquist validation layer to align with GSD meta-prompt conventions (#699)
Reduces token overhead of Dimension 8 and related agent additions by ~37%
with no behavioral change. Removes theory explanation, dead XML tags
(<manual>, <sampling_rate>), aspirational execution tracking, and
documentation-density prose from runtime agent bodies.

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
2026-02-23 09:57:47 -06:00
Colin Johnson
77d434709d Fix STATE.md decision corruption and dollar handling (#701) 2026-02-23 09:55:54 -06:00
TÂCHES
0176a3ec5b fix: map requirements-completed frontmatter in summary-extract (#627) (#716)
Add requirements_completed field to summary-extract output, mapping
from SUMMARY frontmatter requirements-completed key. Enables
/gsd:audit-milestone cross-check to receive data from SUMMARY source.

Re-applied from #631 against refactored codebase (commands.cjs + split tests).

Co-authored-by: Colin Johnson <Solvely-Colin@users.noreply.github.com>
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
2026-02-23 09:55:22 -06:00
TÂCHES
3704829aa6 fix: clamp progress bar percent to prevent RangeError crash (#715)
When orphaned SUMMARY.md files cause totalSummaries > totalPlans, the
progress percentage exceeds 100%, making String.repeat() throw RangeError
on negative arguments. Clamp percent to Math.min(100, ...) at all three
computation sites (state, commands, roadmap).

Closes #633

Co-authored-by: vinicius-tersi <vinicius-tersi@users.noreply.github.com>
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
2026-02-23 09:51:28 -06:00
Lex Christopherson
6b27d8d74b feat: add Codex skills-first runtime support (#665)
Add native Codex support to the installer with a skills-first integration
path (--codex), including Codex-specific install/uninstall/manifest handling.

Closes #449
2026-02-23 09:46:54 -06:00
Lex Christopherson
e9e11580a4 merge: resolve conflicts with main for Codex skills-first support
- bin/install.js: integrate isCommand parameter (Gemini TOML fix) with Codex branch
- package.json: keep v1.20.6 with Codex description
- CHANGELOG.md: merge Codex entries into Unreleased above existing releases
2026-02-23 09:46:48 -06:00
Lex Christopherson
d9058210f7 fix(add-tests): add state-snapshot after test generation
Records test generation in project state via state-snapshot call,
keeping add-tests consistent with other GSD workflows that track
their operations.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-02-23 09:42:10 -06:00
vinicius-tersi
a92512af2c feat: add /gsd:add-tests command for post-phase test generation (#635)
New command that generates unit and E2E tests for completed phases:
- Analyzes implementation files and classifies into TDD/E2E/Skip
- Enforces RED-GREEN gates for both unit and E2E tests
- Uses phase SUMMARY.md, CONTEXT.md, and VERIFICATION.md as test specs
- Presents test plan for user approval before generating

Test classification rules:
- TDD: pure functions where expect(fn(input)).toBe(output) is writable
- E2E: UI behavior verifiable by Playwright (keyboard, navigation, forms)
- Skip: styling, config, glue code, migrations, simple CRUD

Ref: Issue #302
2026-02-23 09:39:56 -06:00
Lex Christopherson
acb76fee16 test: add TBD guard coverage for phase_req_ids extraction
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-02-23 09:35:43 -06:00
dush999
ea3c22d345 fix: propagate phase_req_ids from ROADMAP to workflow agents (#684) (#702)
Added TBD guard test before merge.
2026-02-23 09:35:28 -06:00
Lex Christopherson
3a56a207a5 fix(gsd-tools): support --cwd override for state-snapshot
Add --cwd <path> / --cwd=<path> support so sandboxed subagents running
outside the project root can target a specific directory. Invalid paths
return a clear error. Tests ported to tests/state.test.cjs (the old
monolithic test file was split into domain files on main).

Closes #622

Co-Authored-By: Colin Johnson <colin@solvely.net>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-02-23 09:31:06 -06:00
Lex Christopherson
b1a7776a7d Merge branch 'main' into codex/debug-human-verify-gate-630
Resolve CHANGELOG.md conflict — keep both PR entry and v1.20.6 release notes.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-02-23 09:28:03 -06:00
Lex Christopherson
8638ea87d0 1.20.6 2026-02-23 00:31:03 -06:00
Lex Christopherson
6eaf560e09 docs: update changelog for v1.20.6 2026-02-23 00:30:59 -06:00
Lex Christopherson
81462dbb10 chore: ignore local working documents 2026-02-23 00:30:07 -06:00
Lex Christopherson
ed11f41ff2 Merge branch 'main' into fix/universal-phase-number-support
Rebased PR #639 onto refactored modular structure (lib/core.cjs, lib/phase.cjs, etc.)

Changes ported from monolithic gsd-tools.cjs to new modules:
- Add comparePhaseNum() helper to lib/core.cjs for universal phase sorting
- Update normalizePhaseName() regex to handle letter-suffix phases (12A, 12B)
- Update all phase-matching regexes across lib/*.cjs with [A-Z]? pattern
- Replace parseFloat-based sorting with comparePhaseNum throughout
- Add 15 new tests for comparePhaseNum, normalizePhaseName, and letter-suffix sorting

Sort order: 12 → 12.1 → 12.2 → 12A → 12A.1 → 12A.2 → 12B → 13

Co-Authored-By: vinicius-tersi <MDQ6VXNlcjUyNDk2NDYw>
2026-02-22 07:16:38 -06:00
min-k-khant
131f24b5cd fix: auto-advance chain broken — Skills don't resolve inside Task subagents (#669)
The `--auto` flag on discuss-phase and plan-phase chains stages automatically:
discuss → plan → execute, each in a fresh context window. Currently the chain
is broken because auto-advance spawns `Task(prompt="Run /gsd:plan-phase --auto")`
which requires the Skill tool — but Skills don't resolve inside Task subagents.

Result: plan-phase never runs from discuss's auto-advance, execute-phase never
runs from plan's auto-advance, and gsd-executor subagents are never spawned.

Fix: Replace `Task(prompt="Run /gsd:XXX")` with Task calls that tell the
subagent to read the workflow .md file directly via @file references — the same
pattern that already works for gsd-executor spawning in execute-phase.

Changes:
- execute-phase.md: Add --no-transition flag handling so execute-phase can
  return status to parent instead of running transition.md when spawned by
  plan-phase's auto-advance
- plan-phase.md: Replace Skill-based Task call with direct @file reference
  to execute-phase.md, passing --no-transition to prevent transition chaining
- discuss-phase.md: Replace Skill-based Task call with direct @file reference
  to plan-phase.md, with richer return status handling (PHASE COMPLETE,
  PLANNING COMPLETE, PLANNING INCONCLUSIVE, GAPS FOUND)

Nesting depth: discuss → Task(plan) → Task(execute) → Task(executor) = 3 levels
max. Each level gets clean 200k context.

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
2026-02-20 14:41:22 -06:00
vinicius-tersi
7542d364b4 feat: context window monitor hook with agent-side WARNING/CRITICAL alerts
Adds PostToolUse hook that reads context metrics from statusline bridge file and injects alerts into agent conversation when context is low.

Features:
- Two-tier alerts: WARNING (<=35% remaining) and CRITICAL (<=25%)
- Smart debounce: 5 tool uses between warnings, severity escalation bypasses
- Silent fail: never blocks tool execution
- Security: session_id sanitized to prevent path traversal

Ref #212
2026-02-20 14:40:08 -06:00
Lex Christopherson
bfdd64fd59 Merge branch 'feature/nyquist-validation-layer' 2026-02-20 14:28:25 -06:00