fix(verification): keep passed uat results across verifier re-runs #2
Merged
jakub
merged 2 commits from 2026-10-11 10:44:26 +00:00
fix/uat-verification-stale-loop into next
2 Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
Jakub Zych
|
7b50026075 |
test: align pinned workflow text with the uat canonicalize seam
Some checks failed
Validate Branch Name / PR mergeability (pull_request) Successful in 24s
Changeset Required / PR mergeability (pull_request) Successful in 10s
Default Flip Documentation / PR mergeability (pull_request) Successful in 9s
Dependabot Auto-Merge / auto-merge (pull_request) Has been skipped
Docs Required / PR mergeability (pull_request) Successful in 10s
Mutation Testing / PR mergeability (pull_request) Successful in 10s
Security Scan / PR mergeability (pull_request) Successful in 10s
Tests / PR mergeability (pull_request) Successful in 10s
Tests / Base branch health (pull_request) Successful in 11s
Tests / Detect test scope (pull_request) Successful in 16s
PR Target Validator / validate-target (pull_request_target) Successful in 14s
Validate Branch Name / check-branch (pull_request) Successful in 9s
Changeset Required / changeset-lint (pull_request) Successful in 27s
Default Flip Documentation / default-flip-documentation (pull_request) Successful in 27s
Docs Required / docs-lint (pull_request) Successful in 6m35s
Mutation Testing / Detect changed covered modules (pull_request) Successful in 20s
Security Scan / security (pull_request) Successful in 6m31s
Tests / lint-tests (pull_request) Failing after 1m56s
Tests / plugin-validate (pull_request) Successful in 1m2s
Tests / test (ubuntu-latest, 24, shard 1/3) (pull_request) Failing after 20s
Tests / test (ubuntu-latest, 24, shard 2/3) (pull_request) Failing after 19s
Tests / test (ubuntu-latest, 24, shard 3/3) (pull_request) Failing after 18s
Tests / test (ubuntu-latest, 24) (pull_request) Failing after 19s
Tests / test (inert CI) (pull_request) Has been skipped
Tests / QA loop walk (smell ratchet) (pull_request) Failing after 20s
Mutation Testing / Stryker (${{ matrix.name }}) (pull_request) Has been skipped
Tests / Coverage gate (merged shards) (pull_request) Has been skipped
Tests / Publish emitted-baseline artifact (pull_request) Has been skipped
Mutation Testing / Stryker mutation score (changed files only) (pull_request) Has been skipped
Branch Cleanup / Delete merged PR branch (pull_request) Failing after 10s
Branch Cleanup / Weekly orphaned branch sweep (pull_request) Has been skipped
Tests / conformance test (macos-latest, 24) (pull_request) Has been cancelled
Tests / conformance test (windows-latest, 24, shard 1/3) (pull_request) Has been cancelled
Tests / conformance test (windows-latest, 24, shard 2/3) (pull_request) Has been cancelled
Tests / conformance test (windows-latest, 24, shard 3/3) (pull_request) Has been cancelled
Tests / Required tests (pull_request) Has been cancelled
verify-work now calls verification.canonicalize-uat instead of hand-rolling the status flip, and progress's Route V.stale re-verifies in place. The flip's behavior is covered in tests/uat-evidence.test.cjs; these tests keep the workflow's side of the contract. Refreshes the compact-content benchmark baseline for the moved bytes. |
||
|
Jakub Zych
|
aa03fc7fa9 |
fix(verification): keep passed uat results across verifier re-runs
A phase whose human UAT passed could loop forever between execute-phase and verify-work. A gap-closure plan, or a later phase editing a covered file, made the report stale; verify-work only recorded a passed UAT against human_needed; the re-run verifier could not see the UAT file and re-emitted human_needed; and execute-phase's human_needed branch then rewrote *-UAT.md with every row back to [pending]. - verification.uat-evidence: recorded UAT rows plus the covered implementation files changed since the UAT. The verifier (Step 8b) treats a row that passed on unchanged code as verified and re-lists only affected rows, each with a retest_reason. - verification.seed-uat: merges the report's human items into *-UAT.md. Existing rows are kept byte-for-byte; a pass is reset only with a recorded reason. - verification.canonicalize-uat: the single human_needed -> passed flip, gated on the uat-only row predicate; refuses a stale report. - verification.status reports stale_reason; init.progress lists every executed-but-stale phase in reverify_phases. - verify-work and progress re-run the verifier themselves for a stale report instead of routing to execute-phase; execute-phase records a gap-closure checkpoint's UAT answers before dispatching the verifier. Fail-closed properties are unchanged: a malformed fingerprint and a real change to covered code still read stale. Emitted-Drift-Ack-Growth: execute-phase.md — verify_phase_goal gains the gap-closure uat-record pointer and the merge-not-overwrite human_needed branch; the uat template it replaced moved into verification.seed-uat Emitted-Drift-Ack-Growth: msd-verifier.md — new step 8b pointer to the lazily loaded verifier-uat-evidence reference plus the human_verified frontmatter key Emitted-Drift-Ack-Growth: progress.md — route v.stale now re-verifies every stale executed phase in place instead of naming one command |