* fix(#373): replace unquoted $GSD_SDK with space-safe gsd_run launcher Workflow bash blocks resolved the runtime as GSD_SDK="node $GSD_TOOLS" and invoked it unquoted ($GSD_SDK query ...). On install paths containing spaces (e.g. /Volumes/Mini Me/...) the unquoted expansion word-split into `node /Volumes/Mini gsd-tools.cjs ...`, failing with "Cannot find module '/Volumes/Mini'" and getting masked by `2>/dev/null || echo "{}"` into a silent empty state. Replace the string variable with a single-line shell launcher that defines a gsd_run function, invokes the runtime with a fully-quoted path and "$@", and preserves the local-cjs / installed-gsd-tools-on-PATH fallback (#3668) plus the loud not-found error and install hint. The launcher uses _GSD_SHIM_NAME indirection so no workflow emits the /gsd-tools substring that the do.md dispatcher-parity scanner would misread, and is single-line to stay within the per-file progressive-disclosure line budgets (#2551). The canonical launcher lives in get-shit-done/workflows/_runtime-launcher.snippet.sh, is propagated once per file by scripts/sync-runtime-launcher.cjs, and is locked by tests/runtime-launcher-parity.test.cjs (fails CI on drift, on a reappearing $GSD_SDK token, or on a /gsd-tools substring). Dependent workflow-assertion tests are updated from $GSD_SDK to gsd_run, and the runtime launcher is registered in CONTEXT.md. Fixes #373 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * ci(#373): add changeset fragment and allow-test-rule for parity guard The runtime-launcher parity test is a structural drift guard that reads workflow markdown to assert the canonical launcher is present and the retired $GSD_SDK / /gsd-tools tokens are absent; annotate it with allow-test-rule per the no-source-grep lint escape hatch. Add the required .changeset fragment for this user-facing fix. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * test(#373): make parity PATH-fallback assertion cross-platform (Windows) Subtest (E) compared GSD_TOOLS against the Node-side absolute temp path, but the value originates from git-bash which reports the POSIX form, so the prefix comparison failed on windows-latest while the launcher itself worked (the installed stub was invoked). Assert the resolved binary by normalized suffix (/bin/gsd-tools, not .cjs) instead of the absolute prefix; the behavioral stub-invocation assertion is unchanged. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
296 lines
8.7 KiB
Markdown
296 lines
8.7 KiB
Markdown
<purpose>
|
|
Edit any field of an existing phase in ROADMAP.md in place. The phase number and position are always preserved. Guarded against in-progress and completed phases unless --force is passed. Validates depends_on references before writing. Shows a diff and requests confirmation before writing.
|
|
</purpose>
|
|
|
|
<required_reading>
|
|
Read all files referenced by the invoking prompt's execution_context before starting.
|
|
</required_reading>
|
|
|
|
<process>
|
|
|
|
<step name="parse_arguments">
|
|
Parse the command arguments:
|
|
- First argument: phase number to edit (integer or decimal)
|
|
- Optional flag: --force (allow editing in_progress/completed phases)
|
|
|
|
Examples:
|
|
`/gsd-edit-phase 5` → phase = 5, force = false
|
|
`/gsd-edit-phase 5 --force` → phase = 5, force = true
|
|
`/gsd-edit-phase 12.1` → phase = 12.1, force = false
|
|
|
|
If no argument provided:
|
|
|
|
```
|
|
ERROR: Phase number required
|
|
Usage: /gsd-edit-phase <phase-number> [--force]
|
|
Example: /gsd-edit-phase 5
|
|
Example: /gsd-edit-phase 5 --force
|
|
```
|
|
|
|
Exit.
|
|
</step>
|
|
|
|
<step name="init_context">
|
|
Load phase operation context:
|
|
|
|
```bash
|
|
_GSD_SHIM_NAME="gsd-tools.cjs"; GSD_TOOLS="${RUNTIME_DIR:-$(git rev-parse --show-toplevel 2>/dev/null || pwd)}/get-shit-done/bin/${_GSD_SHIM_NAME}"; if [ -f "$GSD_TOOLS" ]; then gsd_run() { node "$GSD_TOOLS" "$@"; }; elif command -v gsd-tools >/dev/null 2>&1; then GSD_TOOLS="$(command -v gsd-tools)"; gsd_run() { "$GSD_TOOLS" "$@"; }; else echo "ERROR: gsd-tools.cjs not found at $GSD_TOOLS and gsd-tools is not on PATH. Run: npx -y @opengsd/get-shit-done-redux@latest --claude --local" >&2; exit 1; fi
|
|
INIT=$(gsd_run query init.phase-op "${target}")
|
|
if [[ "$INIT" == @file:* ]]; then INIT=$(cat "${INIT#@file:}"); fi
|
|
```
|
|
|
|
Check `roadmap_exists` from init JSON. If false:
|
|
```
|
|
ERROR: No roadmap found (.planning/ROADMAP.md)
|
|
Run /gsd:new-project to initialize.
|
|
```
|
|
Exit.
|
|
</step>
|
|
|
|
<step name="load_phase">
|
|
Read the current phase section from ROADMAP.md:
|
|
|
|
```bash
|
|
PHASE_DATA=$(gsd_run query roadmap get-phase "${target}")
|
|
```
|
|
|
|
Parse the JSON result. If `found` is false:
|
|
|
|
```
|
|
ERROR: Phase {target} not found in ROADMAP.md
|
|
|
|
Available phases can be seen with /gsd:progress.
|
|
```
|
|
|
|
Exit.
|
|
|
|
Extract from the result:
|
|
- `phase_name` — the phase title
|
|
- `goal` — the phase goal/description
|
|
- `success_criteria` — array of criteria
|
|
- `section` — full raw section text (preserves depends_on, requirements, plans, etc.)
|
|
|
|
Also parse the full section text to extract additional fields not in the SDK result:
|
|
- `depends_on` — from `**Depends on:** ...` or `**Depends on**: ...` line
|
|
- `requirements` — from `**Requirements:** ...` block if present
|
|
</step>
|
|
|
|
<step name="check_phase_status">
|
|
Determine the phase status from disk. Compare against STATE.md current phase:
|
|
|
|
```bash
|
|
ANALYZE=$(gsd_run query roadmap analyze)
|
|
```
|
|
|
|
Find the phase entry in the `phases` array. Extract `disk_status`.
|
|
|
|
Map disk_status to a user-friendly status:
|
|
- `complete` → status = `completed`
|
|
- `planned` or `partial` → status = `in_progress`
|
|
- `empty`, `no_directory`, `discussed`, `researched` → status = `future`
|
|
|
|
If status is `in_progress` or `completed` AND `--force` was NOT passed:
|
|
|
|
```
|
|
ERROR: Cannot edit Phase {target} — status is {status}
|
|
|
|
Editing an in-progress or completed phase may invalidate executed plans.
|
|
|
|
To edit anyway, run:
|
|
/gsd-edit-phase {target} --force
|
|
```
|
|
|
|
Exit.
|
|
|
|
If `--force` was passed and status is `in_progress` or `completed`, continue with a warning printed to the user:
|
|
|
|
```
|
|
WARNING: Editing Phase {target} which is {status}. Proceeding due to --force.
|
|
```
|
|
</step>
|
|
|
|
<step name="present_current_values">
|
|
Display the current phase fields clearly:
|
|
|
|
```
|
|
Current values for Phase {target}: {phase_name}
|
|
|
|
Title: {phase_name}
|
|
Goal: {goal}
|
|
Depends on: {depends_on or "(none)"}
|
|
Requirements: {requirements or "(none)"}
|
|
Success Criteria:
|
|
1. {criterion_1}
|
|
2. {criterion_2}
|
|
...
|
|
```
|
|
|
|
Then ask the user what they want to change:
|
|
|
|
```
|
|
What would you like to do?
|
|
|
|
[1] Edit specific fields (title, goal, depends_on, requirements, success_criteria)
|
|
[2] Regenerate all fields from a clarified intent
|
|
[3] Cancel
|
|
|
|
Enter choice (1, 2, or 3):
|
|
```
|
|
|
|
Wait for user input.
|
|
</step>
|
|
|
|
<step name="collect_edits">
|
|
|
|
**If user chose [3] Cancel:** Exit cleanly.
|
|
|
|
**If user chose [1] Edit specific fields:**
|
|
|
|
Ask which fields to edit. For each field the user wants to change, prompt for the new value. Only fields the user explicitly answers become updates; empty answers preserve the existing value.
|
|
|
|
```
|
|
Which fields do you want to update? (comma-separated or "all")
|
|
Options: title, goal, depends_on, requirements, success_criteria
|
|
```
|
|
|
|
For each selected field, ask:
|
|
|
|
```
|
|
New value for {field} [current: {current_value}]:
|
|
```
|
|
|
|
Build an `updates` map of {field → new_value} for non-empty answers.
|
|
|
|
**If user chose [2] Regenerate all from clarified intent:**
|
|
|
|
Ask the user:
|
|
|
|
```
|
|
Describe the revised intent for Phase {target} (replace the current description):
|
|
```
|
|
|
|
Wait for user input. Use the clarified intent to rewrite all fields:
|
|
- Generate a clear, concise `title` from the intent
|
|
- Write a complete `goal` statement
|
|
- Produce updated `requirements` if the original had them
|
|
- Generate `success_criteria` (3-5 measurable criteria)
|
|
- Preserve `depends_on` unless the user explicitly mentioned changing it
|
|
</step>
|
|
|
|
<step name="validate_depends_on">
|
|
If `depends_on` is being updated (or preserved as non-empty), validate that every referenced phase number exists in ROADMAP.md:
|
|
|
|
```bash
|
|
ALL_PHASES=$(gsd_run query roadmap analyze)
|
|
```
|
|
|
|
Parse the `phases` array to get all valid phase numbers.
|
|
|
|
For each phase number referenced in `depends_on`:
|
|
- Normalize it (strip whitespace, "Phase" prefix if present)
|
|
- Check it is in the valid phase numbers set
|
|
- It must not reference itself (phase {target})
|
|
|
|
If any reference is invalid:
|
|
|
|
```
|
|
ERROR: depends_on references invalid phase(s): {bad_refs}
|
|
|
|
Valid phase numbers: {valid_list}
|
|
|
|
Fix the depends_on field and try again.
|
|
```
|
|
|
|
Exit (do not write).
|
|
</step>
|
|
|
|
<step name="show_diff_and_confirm">
|
|
Build the updated phase section by applying the changes to the original `section` text:
|
|
|
|
- For `title`: replace the heading text after `Phase {N}:`
|
|
- For `goal`: replace the `**Goal:**` line value
|
|
- For `depends_on`: replace or add the `**Depends on:**` line
|
|
- For `requirements`: replace or add the requirements block
|
|
- For `success_criteria`: replace the numbered list under `**Success Criteria**:`
|
|
- For full regeneration: rebuild the entire section from the new field values
|
|
|
|
Show a unified-style diff of old vs. new:
|
|
|
|
```
|
|
Proposed changes to Phase {target}:
|
|
|
|
--- current
|
|
+++ updated
|
|
@@ ...
|
|
- **Goal:** {old_goal}
|
|
+ **Goal:** {new_goal}
|
|
...
|
|
|
|
Apply these changes? (y/n):
|
|
```
|
|
|
|
Wait for confirmation. If the user says `n`, exit without writing.
|
|
</step>
|
|
|
|
<step name="write_updated_phase">
|
|
Write the updated phase back in place in ROADMAP.md.
|
|
|
|
Read the full ROADMAP.md content, locate the phase section by its header (`## Phase {N}:` or `### Phase {N}:`), and replace exactly the old section text with the new section text. All content before and after the section (including other phases, milestone headers, and the summary checklist) must be left unchanged.
|
|
|
|
After writing ROADMAP.md, update STATE.md Roadmap Evolution:
|
|
|
|
```bash
|
|
gsd_run query state.add-roadmap-evolution \
|
|
--phase {target} \
|
|
--action edited \
|
|
--note "edited fields: {changed_field_list}"
|
|
```
|
|
</step>
|
|
|
|
<step name="completion">
|
|
Present completion summary:
|
|
|
|
```
|
|
Phase {target} updated in ROADMAP.md.
|
|
|
|
Fields changed: {changed_field_list}
|
|
|
|
---
|
|
|
|
## What's Next
|
|
|
|
- `/gsd:progress` — view updated roadmap
|
|
- `/gsd:plan-phase {target}` — re-plan this phase (if needed)
|
|
- `/gsd:discuss-phase {target}` — discuss implementation approach
|
|
|
|
---
|
|
```
|
|
</step>
|
|
|
|
</process>
|
|
|
|
<anti_patterns>
|
|
- Don't renumber the phase — number and position must be preserved exactly
|
|
- Don't modify other phases when editing one
|
|
- Don't skip depends_on validation (invalid references block writes)
|
|
- Don't write without showing a diff and getting confirmation
|
|
- Don't edit in_progress/completed phases without --force
|
|
- Don't use raw Write on ROADMAP.md without reading it first; always replace section in place
|
|
- Don't modify the phase directory structure — only ROADMAP.md changes
|
|
- Don't commit the change — that's the user's decision
|
|
</anti_patterns>
|
|
|
|
<success_criteria>
|
|
Edit-phase is complete when:
|
|
|
|
- [ ] Phase {target} found and loaded from ROADMAP.md
|
|
- [ ] Status check performed; in_progress/completed blocked without --force
|
|
- [ ] Current values presented to user
|
|
- [ ] User chose edit mode (specific fields or full regeneration)
|
|
- [ ] depends_on references validated; invalid references blocked
|
|
- [ ] Diff shown and confirmed by user
|
|
- [ ] Updated phase written back in place; number, position, and status preserved
|
|
- [ ] STATE.md Roadmap Evolution updated
|
|
- [ ] User informed of next steps
|
|
</success_criteria>
|