* fix(#373): replace unquoted $GSD_SDK with space-safe gsd_run launcher Workflow bash blocks resolved the runtime as GSD_SDK="node $GSD_TOOLS" and invoked it unquoted ($GSD_SDK query ...). On install paths containing spaces (e.g. /Volumes/Mini Me/...) the unquoted expansion word-split into `node /Volumes/Mini gsd-tools.cjs ...`, failing with "Cannot find module '/Volumes/Mini'" and getting masked by `2>/dev/null || echo "{}"` into a silent empty state. Replace the string variable with a single-line shell launcher that defines a gsd_run function, invokes the runtime with a fully-quoted path and "$@", and preserves the local-cjs / installed-gsd-tools-on-PATH fallback (#3668) plus the loud not-found error and install hint. The launcher uses _GSD_SHIM_NAME indirection so no workflow emits the /gsd-tools substring that the do.md dispatcher-parity scanner would misread, and is single-line to stay within the per-file progressive-disclosure line budgets (#2551). The canonical launcher lives in get-shit-done/workflows/_runtime-launcher.snippet.sh, is propagated once per file by scripts/sync-runtime-launcher.cjs, and is locked by tests/runtime-launcher-parity.test.cjs (fails CI on drift, on a reappearing $GSD_SDK token, or on a /gsd-tools substring). Dependent workflow-assertion tests are updated from $GSD_SDK to gsd_run, and the runtime launcher is registered in CONTEXT.md. Fixes #373 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * ci(#373): add changeset fragment and allow-test-rule for parity guard The runtime-launcher parity test is a structural drift guard that reads workflow markdown to assert the canonical launcher is present and the retired $GSD_SDK / /gsd-tools tokens are absent; annotate it with allow-test-rule per the no-source-grep lint escape hatch. Add the required .changeset fragment for this user-facing fix. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * test(#373): make parity PATH-fallback assertion cross-platform (Windows) Subtest (E) compared GSD_TOOLS against the Node-side absolute temp path, but the value originates from git-bash which reports the POSIX form, so the prefix comparison failed on windows-latest while the launcher itself worked (the installed stub was invoked). Assert the resolved binary by normalized suffix (/bin/gsd-tools, not .cjs) instead of the absolute prefix; the behavioral stub-invocation assertion is unchanged. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
157 lines
4.4 KiB
Markdown
157 lines
4.4 KiB
Markdown
<purpose>
|
|
Remove an unstarted future phase from the project roadmap, delete its directory, renumber all subsequent phases to maintain a clean linear sequence, and commit the change. The git commit serves as the historical record of removal.
|
|
</purpose>
|
|
|
|
<required_reading>
|
|
Read all files referenced by the invoking prompt's execution_context before starting.
|
|
</required_reading>
|
|
|
|
<process>
|
|
|
|
<step name="parse_arguments">
|
|
Parse the command arguments:
|
|
- Argument is the phase number to remove (integer or decimal)
|
|
- Example: `/gsd-remove-phase 17` → phase = 17
|
|
- Example: `/gsd-remove-phase 16.1` → phase = 16.1
|
|
|
|
If no argument provided:
|
|
|
|
```
|
|
ERROR: Phase number required
|
|
Usage: /gsd-remove-phase <phase-number>
|
|
Example: /gsd-remove-phase 17
|
|
```
|
|
|
|
Exit.
|
|
</step>
|
|
|
|
<step name="init_context">
|
|
Load phase operation context:
|
|
|
|
```bash
|
|
_GSD_SHIM_NAME="gsd-tools.cjs"; GSD_TOOLS="${RUNTIME_DIR:-$(git rev-parse --show-toplevel 2>/dev/null || pwd)}/get-shit-done/bin/${_GSD_SHIM_NAME}"; if [ -f "$GSD_TOOLS" ]; then gsd_run() { node "$GSD_TOOLS" "$@"; }; elif command -v gsd-tools >/dev/null 2>&1; then GSD_TOOLS="$(command -v gsd-tools)"; gsd_run() { "$GSD_TOOLS" "$@"; }; else echo "ERROR: gsd-tools.cjs not found at $GSD_TOOLS and gsd-tools is not on PATH. Run: npx -y @opengsd/get-shit-done-redux@latest --claude --local" >&2; exit 1; fi
|
|
INIT=$(gsd_run query init.phase-op "${target}")
|
|
if [[ "$INIT" == @file:* ]]; then INIT=$(cat "${INIT#@file:}"); fi
|
|
```
|
|
|
|
Extract: `phase_found`, `phase_dir`, `phase_number`, `commit_docs`, `roadmap_exists`.
|
|
|
|
Also read STATE.md and ROADMAP.md content for parsing current position.
|
|
</step>
|
|
|
|
<step name="validate_future_phase">
|
|
Verify the phase is a future phase (not started):
|
|
|
|
1. Compare target phase to current phase from STATE.md
|
|
2. Target must be > current phase number
|
|
|
|
If target <= current phase:
|
|
|
|
```
|
|
ERROR: Cannot remove Phase {target}
|
|
|
|
Only future phases can be removed:
|
|
- Current phase: {current}
|
|
- Phase {target} is current or completed
|
|
|
|
To abandon current work, use /gsd:pause-work instead.
|
|
```
|
|
|
|
Exit.
|
|
</step>
|
|
|
|
<step name="confirm_removal">
|
|
Present removal summary and confirm:
|
|
|
|
```
|
|
Removing Phase {target}: {Name}
|
|
|
|
This will:
|
|
- Delete: .planning/phases/{target}-{slug}/
|
|
- Renumber all subsequent phases
|
|
- Update: ROADMAP.md, STATE.md
|
|
|
|
Proceed? (y/n)
|
|
```
|
|
|
|
Wait for confirmation.
|
|
</step>
|
|
|
|
<step name="execute_removal">
|
|
**Delegate the entire removal operation to `gsd-tools.cjs query phase.remove`:**
|
|
|
|
```bash
|
|
RESULT=$(gsd_run query phase.remove "${target}")
|
|
```
|
|
|
|
If the phase has executed plans (SUMMARY.md files), the CLI will error. Use `--force` only if the user confirms:
|
|
|
|
```bash
|
|
RESULT=$(gsd_run query phase.remove "${target}" --force)
|
|
```
|
|
|
|
The CLI handles:
|
|
- Deleting the phase directory
|
|
- Renumbering all subsequent directories (in reverse order to avoid conflicts)
|
|
- Renaming all files inside renumbered directories (PLAN.md, SUMMARY.md, etc.)
|
|
- Updating ROADMAP.md (removing section, renumbering all phase references, updating dependencies)
|
|
- Updating STATE.md (decrementing phase count)
|
|
|
|
Extract from result: `removed`, `directory_deleted`, `renamed_directories`, `renamed_files`, `roadmap_updated`, `state_updated`.
|
|
</step>
|
|
|
|
<step name="commit">
|
|
Stage and commit the removal:
|
|
|
|
```bash
|
|
gsd_run query commit "chore: remove phase {target} ({original-phase-name})" --files .planning/
|
|
```
|
|
|
|
The commit message preserves the historical record of what was removed.
|
|
</step>
|
|
|
|
<step name="completion">
|
|
Present completion summary:
|
|
|
|
```
|
|
Phase {target} ({original-name}) removed.
|
|
|
|
Changes:
|
|
- Deleted: .planning/phases/{target}-{slug}/
|
|
- Renumbered: {N} directories and {M} files
|
|
- Updated: ROADMAP.md, STATE.md
|
|
- Committed: chore: remove phase {target} ({original-name})
|
|
|
|
---
|
|
|
|
## What's Next
|
|
|
|
Would you like to:
|
|
- `/gsd:progress` — see updated roadmap status
|
|
- Continue with current phase
|
|
- Review roadmap
|
|
|
|
---
|
|
```
|
|
</step>
|
|
|
|
</process>
|
|
|
|
<anti_patterns>
|
|
|
|
- Don't remove completed phases (have SUMMARY.md files) without --force
|
|
- Don't remove current or past phases
|
|
- Don't manually renumber — use `gsd-tools.cjs query phase.remove` which handles all renumbering
|
|
- Don't add "removed phase" notes to STATE.md — git commit is the record
|
|
- Don't modify completed phase directories
|
|
</anti_patterns>
|
|
|
|
<success_criteria>
|
|
Phase removal is complete when:
|
|
|
|
- [ ] Target phase validated as future/unstarted
|
|
- [ ] `gsd-tools.cjs query phase.remove` executed successfully
|
|
- [ ] Changes committed with descriptive message
|
|
- [ ] User informed of changes
|
|
</success_criteria>
|