* chore(#604): rename get-shit-done/ runtime directory to gsd-core/ Renames the installed runtime directory `get-shit-done/` to `gsd-core/` so the on-disk name matches the package (`@opengsd/gsd-core`), repo, and binary (`gsd-tools`). The npm package name and binary are unchanged; npx/npm consumers are unaffected. Mechanical (bulk, ~90% of the diff): - `git mv get-shit-done gsd-core` - Swept path/identifier references across the repo via `perl -pe 's/get-shit-done(?!-\w)/gsd-core/g'`. The negative lookahead preserves the five legitimate slug variants that are NOT the directory: get-shit-done-{OLD,cc,classic,cli,redux} (old package/repo names). - Build/manifest wiring: package.json (bin, files, coverage globs), tsconfig.build.json (outDir), ~86 .gitignore build-output entries, stryker.config.mjs, scan-ignore files, install.js path strings. - Frozen (not rewritten): CHANGELOG.md history; translated docs (README.<locale>.md and docs/{ja-JP,ko-KR,pt-BR,zh-CN}/). New logic (review here): - src/installer-migrations/003-rename-get-shit-done-to-gsd-core.cts: a proper ADR-0008 installer migration. On upgrade it walks the legacy `~/.claude/get-shit-done/` tree, classifies each file via the prior install manifest, and emits remove-managed / backup-and-remove for managed files while PRESERVING unknown user-added files. Symlink-safe (skips a symlinked root and symlinked entries; bounds-checks every path under configDir). The framework rolls back on install failure. Emptied dirs may remain (framework has no recursive dir-removal primitive) — documented. - scripts/lint-legacy-dir-name.cjs: CI regression guard forbidding the bare `get-shit-done` directory token (split token to avoid self-match; case- insensitive; `(?!-\w)` lookahead allows the slug variants; allowlists CHANGELOG, translated docs, and `gsd-allow-legacy-name` marker lines). Wired into the lint-tests CI job. - Restored scripts/lint-package-identity-drift.cjs detection regexes (the mechanical sweep had wrongly rewritten the old-name patterns it exists to detect) and marked them as intentional legacy references. - TDD tests for the migration and the guard; do.md slash-command guard regex tightened so a `/gsd-core/bin` path segment is not mistaken for a command; changeset + docs/installer-migrations.md row added. Breaking: the installed runtime path moves `~/.claude/get-shit-done/` -> `~/.claude/gsd-core/`. Migration 003 removes the stale legacy dir's managed files (preserving user files) on upgrade. Users with custom hooks/configs hardcoding the old path must update them. Closes #604 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): unsweep pending changesets + allowlist injection-example docs CI fixes for the rename PR: - Do not sweep pending .changeset/*.md (ephemeral release-note fragments, like CHANGELOG); reverted those body edits so 5 pre-existing malformed fragments (missing type/pr) no longer enter the PR diff and trip docs-lint. Allowlisted .changeset/ in the legacy-name guard accordingly. - Allowlisted TEST-EXAMPLES.md and docs/explanation/security-model.md in prompt-injection-scan.sh: they contain intentional injection examples / security-model prose; the path-reference rewrites are kept. CodeQL alerts on this PR are pre-existing (alert lines unchanged by this PR; none in the new migration/guard) and are out of scope for the rename. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): resolve CodeQL alerts surfaced on this PR The rename diff touched files carrying pre-existing CodeQL findings; per the no-pre-existing-dismissal rule, fixing every surfaced alert rather than waving them off. All behavior-preserving: - scripts/ci-test-scope.cjs: build the config-path match from string .includes() instead of a RegExp over an arg-derived value (js/regex-injection). - src/profile-output.cts: escape backslashes before pipe-escaping desc/safeName so the table-cell escape is complete (js/incomplete-sanitization). - tests/{bug-2643,bug-2808,docs-parity-live-registry}: two-pass HTML-comment strip so a bare/unclosed `<!--` cannot survive (js/incomplete-multi-character-sanitization). - tests/inline-plan-threshold: drop the no-op `\s`->`\s` identity replace, keep the meaningful POSIX-class conversion (js/identity-replacement). Verified: build:lib green; the touched test files + ci-test-scope + profile-output suites pass; lint:legacy-name clean. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): correctly resolve remaining CodeQL alerts (regex-injection + sanitization) The prior commit's fixes for two alerts were ineffective: - ci-test-scope.cjs js/regex-injection: the alert is the CLI-arg-derived `file` reaching static regex `.test(file)` calls (not the config rule). Removed ALL regex over file/t — startsWith/includes/=== string checks + an isWindowsHint helper — so there is no regex sink for the tainted value. - js/incomplete-multi-character-sanitization (3 test files): a single `.replace(/<!--...-->/g,'')` can let `<!--` re-form. Replaced with a fixpoint loop (replace until stable) plus a final bare-opener strip. Verified: no regex over file/t remains; ci-test-scope + the 3 test suites pass; lint:legacy-name clean. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): make ci-test-scope + comment-strippers regex-free to clear CodeQL CodeQL flags the regex PATTERNS syntactically (regex-injection on the --files arg split; incomplete-multi-character-sanitization on the <!--...--> replace), so loop fixes do not satisfy it. Made these paths regex-free: - ci-test-scope.cjs splitFiles: char-by-char separator tokenizer (no /[,\\s]+/). - 3 test files: indexOf/slice HTML-comment stripper (no .replace(/<!--/)). Behavior preserved; ci-test-scope + the 3 suites pass; guard clean. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): unblock security base64 scan on the large rename diff The security job hit its 10m timeout: base64-scan.sh choked on the binary test fixture tests/feat-3594-parser-property-style.test.cjs (embedded NUL/ non-UTF8 bytes -> thousands of bogus blobs + "ignored null byte" warnings), and the ~800-file rename diff is slow to scan regardless. - scripts/base64-scan.sh: skip binary-by-content files (grep -Iq .) — they can't carry base64-obfuscated *text* and feeding NUL bytes through the per-line scanner is pathologically slow. collect_files already filtered binary *extensions*; this catches binary *content* in text extensions. - .github/workflows/security-scan.yml: raise the security job timeout 10m->30m to accommodate very large diffs (the scan itself is unchanged). Verified locally: scan skips the fixture, 0 "ignored null byte" warnings, 0 findings, exit 0. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): sweep get-shit-done refs introduced by merging next The branch was updated with next (#614/#384/#618 etc.), which reference the get-shit-done/ dir (still named that on next). Swept the stale references in the merged files to gsd-core so the rename stays consistent and lint:legacy-name passes: - commands/gsd/discuss-phase.md (runtime-launcher shim paths) - src/core.cts (getAgentsDir layout comments) - tests/bug-384-agents-runtime-aware.test.cjs (require path to runtime lib) Verified: guard 0 violations; build green. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): exclude gsd-core/ path segments from bug-3683 command cross-ref invariant The #614 runtime-launcher shim added to discuss-phase.md references `${_GSD_RUNTIME_ROOT}/gsd-core/bin/...`. bug-3683's REF_PATTERN excluded path-y refs only via lookbehind, but `}` precedes `/gsd-core/` in the shim, so it mis-read the directory path as a dangling `/gsd-core` command ref (same class as the #604 bug-2954 fix). Added a trailing `(?![\w-]*\/)` so `/gsd-<x>/...` path segments are not treated as slash-command references. Verified locally on BOTH platforms before pushing: - mac (node 26) full suite: 0 failures - gsd-test-runner (linux, node22 image) full suite: 0 failures - bug-3683 + bug-2954 pass. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): lazily resolve findProjectRoot in gsd-tools (harden flaky CI) CI intermittently failed state.test's gsd-tools subprocess with "findProjectRoot is not a function" (flip-flopping across legs; not reproducible on mac full suite, gsd-test linux full suite, test:unit, or state.test x8). findProjectRoot is a re-export from core.cjs (sourced from project-root.cjs); binding it via destructure at module-load can be undefined under a load-ordering edge. Resolve it lazily at call time via a small wrapper so the lookup happens after core.cjs is fully initialized. Verified green on BOTH platforms before pushing: - mac (node 26) full suite: 0 failures - gsd-test-runner (linux, node22) full suite: 0 failures - state.test.cjs: 106/106; gsd-tools loads cleanly. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): allowlist verification-patterns.md placeholder examples in secret scan The rename git-mv'd references/verification-patterns.md into gsd-core/, pulling it into the secret-scan diff. It documents stub/placeholder RED-FLAG env-var examples (illustrative Stripe test-key / database-URL / API-key placeholders) — not real credentials. Added it to .secretscanignore with the strict annotation, mirroring the existing gsd-core/workflows/plan-phase.md exception. Verified locally: secret-scan-lint --strict OK; secret-scan --diff origin/next exits 0 with 0 findings. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
163 lines
6.1 KiB
Markdown
163 lines
6.1 KiB
Markdown
<questioning_guide>
|
|
|
|
Project initialization is dream extraction, not requirements gathering. You're helping the user discover and articulate what they want to build. This isn't a contract negotiation — it's collaborative thinking.
|
|
|
|
<philosophy>
|
|
|
|
**You are a thinking partner, not an interviewer.**
|
|
|
|
The user often has a fuzzy idea. Your job is to help them sharpen it. Ask questions that make them think "oh, I hadn't considered that" or "yes, that's exactly what I mean."
|
|
|
|
Don't interrogate. Collaborate. Don't follow a script. Follow the thread.
|
|
|
|
</philosophy>
|
|
|
|
<the_goal>
|
|
|
|
By the end of questioning, you need enough clarity to write a PROJECT.md that downstream phases can act on:
|
|
|
|
- **Research** needs: what domain to research, what the user already knows, what unknowns exist
|
|
- **Requirements** needs: clear enough vision to scope v1 features
|
|
- **Roadmap** needs: clear enough vision to decompose into phases, what "done" looks like
|
|
- **plan-phase** needs: specific requirements to break into tasks, context for implementation choices
|
|
- **execute-phase** needs: success criteria to verify against, the "why" behind requirements
|
|
|
|
A vague PROJECT.md forces every downstream phase to guess. The cost compounds.
|
|
|
|
</the_goal>
|
|
|
|
<how_to_question>
|
|
|
|
**Start open.** Let them dump their mental model. Don't interrupt with structure.
|
|
|
|
**Follow energy.** Whatever they emphasized, dig into that. What excited them? What problem sparked this?
|
|
|
|
**Challenge vagueness.** Never accept fuzzy answers. "Good" means what? "Users" means who? "Simple" means how?
|
|
|
|
**Make the abstract concrete.** "Walk me through using this." "What does that actually look like?"
|
|
|
|
**Clarify ambiguity.** "When you say Z, do you mean A or B?" "You mentioned X — tell me more."
|
|
|
|
**Know when to stop.** When you understand what they want, why they want it, who it's for, and what done looks like — offer to proceed.
|
|
|
|
</how_to_question>
|
|
|
|
<question_types>
|
|
|
|
Use these as inspiration, not a checklist. Pick what's relevant to the thread.
|
|
|
|
**Motivation — why this exists:**
|
|
- "What prompted this?"
|
|
- "What are you doing today that this replaces?"
|
|
- "What would you do if this existed?"
|
|
|
|
**Concreteness — what it actually is:**
|
|
- "Walk me through using this"
|
|
- "You said X — what does that actually look like?"
|
|
- "Give me an example"
|
|
|
|
**Clarification — what they mean:**
|
|
- "When you say Z, do you mean A or B?"
|
|
- "You mentioned X — tell me more about that"
|
|
|
|
**Success — how you'll know it's working:**
|
|
- "How will you know this is working?"
|
|
- "What does done look like?"
|
|
|
|
</question_types>
|
|
|
|
<using_askuserquestion>
|
|
|
|
Use AskUserQuestion to help users think by presenting concrete options to react to.
|
|
|
|
**Good options:**
|
|
- Interpretations of what they might mean
|
|
- Specific examples to confirm or deny
|
|
- Concrete choices that reveal priorities
|
|
|
|
**Bad options:**
|
|
- Generic categories ("Technical", "Business", "Other")
|
|
- Leading options that presume an answer
|
|
- Too many options (2-4 is ideal)
|
|
- Headers longer than 12 characters (hard limit — validation will reject them)
|
|
|
|
**Example — vague answer:**
|
|
User says "it should be fast"
|
|
|
|
- header: "Fast"
|
|
- question: "Fast how?"
|
|
- options: ["Sub-second response", "Handles large datasets", "Quick to build", "Let me explain"]
|
|
|
|
**Example — following a thread:**
|
|
User mentions "frustrated with current tools"
|
|
|
|
- header: "Frustration"
|
|
- question: "What specifically frustrates you?"
|
|
- options: ["Too many clicks", "Missing features", "Unreliable", "Let me explain"]
|
|
|
|
**Tip for users — modifying an option:**
|
|
Users who want a slightly modified version of an option can select "Other" and reference the option by number: `#1 but for finger joints only` or `#2 with pagination disabled`. This avoids retyping the full option text.
|
|
|
|
</using_askuserquestion>
|
|
|
|
<freeform_rule>
|
|
|
|
**When the user wants to explain freely, STOP using AskUserQuestion.**
|
|
|
|
If a user selects "Other" and their response signals they want to describe something in their own words (e.g., "let me describe it", "I'll explain", "something else", or any open-ended reply that isn't choosing/modifying an existing option), you MUST:
|
|
|
|
1. **Ask your follow-up as plain text** — NOT via AskUserQuestion
|
|
2. **Wait for them to type at the normal prompt**
|
|
3. **Resume AskUserQuestion** only after processing their freeform response
|
|
|
|
The same applies if YOU include a freeform-indicating option (like "Let me explain" or "Describe in detail") and the user selects it.
|
|
|
|
**Wrong:** User says "let me describe it" → AskUserQuestion("What feature?", ["Feature A", "Feature B", "Describe in detail"])
|
|
**Right:** User says "let me describe it" → "Go ahead — what are you thinking?"
|
|
|
|
</freeform_rule>
|
|
|
|
<context_checklist>
|
|
|
|
Use this as a **background checklist**, not a conversation structure. Check these mentally as you go. If gaps remain, weave questions naturally.
|
|
|
|
- [ ] What they're building (concrete enough to explain to a stranger)
|
|
- [ ] Why it needs to exist (the problem or desire driving it)
|
|
- [ ] Who it's for (even if just themselves)
|
|
- [ ] What "done" looks like (observable outcomes)
|
|
|
|
Four things. If they volunteer more, capture it.
|
|
|
|
</context_checklist>
|
|
|
|
<decision_gate>
|
|
|
|
When you could write a clear PROJECT.md, offer to proceed:
|
|
|
|
- header: "Ready?"
|
|
- question: "I think I understand what you're after. Ready to create PROJECT.md?"
|
|
- options:
|
|
- "Create PROJECT.md" — Let's move forward
|
|
- "Keep exploring" — I want to share more / ask me more
|
|
|
|
If "Keep exploring" — ask what they want to add or identify gaps and probe naturally.
|
|
|
|
Loop until "Create PROJECT.md" selected.
|
|
|
|
</decision_gate>
|
|
|
|
<anti_patterns>
|
|
|
|
- **Checklist walking** — Going through domains regardless of what they said
|
|
- **Canned questions** — "What's your core value?" "What's out of scope?" regardless of context
|
|
- **Corporate speak** — "What are your success criteria?" "Who are your stakeholders?"
|
|
- **Interrogation** — Firing questions without building on answers
|
|
- **Rushing** — Minimizing questions to get to "the work"
|
|
- **Shallow acceptance** — Taking vague answers without probing
|
|
- **Premature constraints** — Asking about tech stack before understanding the idea
|
|
- **User skills** — NEVER ask about user's technical experience. Claude builds.
|
|
|
|
</anti_patterns>
|
|
|
|
</questioning_guide>
|