* chore(#604): rename get-shit-done/ runtime directory to gsd-core/ Renames the installed runtime directory `get-shit-done/` to `gsd-core/` so the on-disk name matches the package (`@opengsd/gsd-core`), repo, and binary (`gsd-tools`). The npm package name and binary are unchanged; npx/npm consumers are unaffected. Mechanical (bulk, ~90% of the diff): - `git mv get-shit-done gsd-core` - Swept path/identifier references across the repo via `perl -pe 's/get-shit-done(?!-\w)/gsd-core/g'`. The negative lookahead preserves the five legitimate slug variants that are NOT the directory: get-shit-done-{OLD,cc,classic,cli,redux} (old package/repo names). - Build/manifest wiring: package.json (bin, files, coverage globs), tsconfig.build.json (outDir), ~86 .gitignore build-output entries, stryker.config.mjs, scan-ignore files, install.js path strings. - Frozen (not rewritten): CHANGELOG.md history; translated docs (README.<locale>.md and docs/{ja-JP,ko-KR,pt-BR,zh-CN}/). New logic (review here): - src/installer-migrations/003-rename-get-shit-done-to-gsd-core.cts: a proper ADR-0008 installer migration. On upgrade it walks the legacy `~/.claude/get-shit-done/` tree, classifies each file via the prior install manifest, and emits remove-managed / backup-and-remove for managed files while PRESERVING unknown user-added files. Symlink-safe (skips a symlinked root and symlinked entries; bounds-checks every path under configDir). The framework rolls back on install failure. Emptied dirs may remain (framework has no recursive dir-removal primitive) — documented. - scripts/lint-legacy-dir-name.cjs: CI regression guard forbidding the bare `get-shit-done` directory token (split token to avoid self-match; case- insensitive; `(?!-\w)` lookahead allows the slug variants; allowlists CHANGELOG, translated docs, and `gsd-allow-legacy-name` marker lines). Wired into the lint-tests CI job. - Restored scripts/lint-package-identity-drift.cjs detection regexes (the mechanical sweep had wrongly rewritten the old-name patterns it exists to detect) and marked them as intentional legacy references. - TDD tests for the migration and the guard; do.md slash-command guard regex tightened so a `/gsd-core/bin` path segment is not mistaken for a command; changeset + docs/installer-migrations.md row added. Breaking: the installed runtime path moves `~/.claude/get-shit-done/` -> `~/.claude/gsd-core/`. Migration 003 removes the stale legacy dir's managed files (preserving user files) on upgrade. Users with custom hooks/configs hardcoding the old path must update them. Closes #604 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): unsweep pending changesets + allowlist injection-example docs CI fixes for the rename PR: - Do not sweep pending .changeset/*.md (ephemeral release-note fragments, like CHANGELOG); reverted those body edits so 5 pre-existing malformed fragments (missing type/pr) no longer enter the PR diff and trip docs-lint. Allowlisted .changeset/ in the legacy-name guard accordingly. - Allowlisted TEST-EXAMPLES.md and docs/explanation/security-model.md in prompt-injection-scan.sh: they contain intentional injection examples / security-model prose; the path-reference rewrites are kept. CodeQL alerts on this PR are pre-existing (alert lines unchanged by this PR; none in the new migration/guard) and are out of scope for the rename. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): resolve CodeQL alerts surfaced on this PR The rename diff touched files carrying pre-existing CodeQL findings; per the no-pre-existing-dismissal rule, fixing every surfaced alert rather than waving them off. All behavior-preserving: - scripts/ci-test-scope.cjs: build the config-path match from string .includes() instead of a RegExp over an arg-derived value (js/regex-injection). - src/profile-output.cts: escape backslashes before pipe-escaping desc/safeName so the table-cell escape is complete (js/incomplete-sanitization). - tests/{bug-2643,bug-2808,docs-parity-live-registry}: two-pass HTML-comment strip so a bare/unclosed `<!--` cannot survive (js/incomplete-multi-character-sanitization). - tests/inline-plan-threshold: drop the no-op `\s`->`\s` identity replace, keep the meaningful POSIX-class conversion (js/identity-replacement). Verified: build:lib green; the touched test files + ci-test-scope + profile-output suites pass; lint:legacy-name clean. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): correctly resolve remaining CodeQL alerts (regex-injection + sanitization) The prior commit's fixes for two alerts were ineffective: - ci-test-scope.cjs js/regex-injection: the alert is the CLI-arg-derived `file` reaching static regex `.test(file)` calls (not the config rule). Removed ALL regex over file/t — startsWith/includes/=== string checks + an isWindowsHint helper — so there is no regex sink for the tainted value. - js/incomplete-multi-character-sanitization (3 test files): a single `.replace(/<!--...-->/g,'')` can let `<!--` re-form. Replaced with a fixpoint loop (replace until stable) plus a final bare-opener strip. Verified: no regex over file/t remains; ci-test-scope + the 3 test suites pass; lint:legacy-name clean. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): make ci-test-scope + comment-strippers regex-free to clear CodeQL CodeQL flags the regex PATTERNS syntactically (regex-injection on the --files arg split; incomplete-multi-character-sanitization on the <!--...--> replace), so loop fixes do not satisfy it. Made these paths regex-free: - ci-test-scope.cjs splitFiles: char-by-char separator tokenizer (no /[,\\s]+/). - 3 test files: indexOf/slice HTML-comment stripper (no .replace(/<!--/)). Behavior preserved; ci-test-scope + the 3 suites pass; guard clean. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): unblock security base64 scan on the large rename diff The security job hit its 10m timeout: base64-scan.sh choked on the binary test fixture tests/feat-3594-parser-property-style.test.cjs (embedded NUL/ non-UTF8 bytes -> thousands of bogus blobs + "ignored null byte" warnings), and the ~800-file rename diff is slow to scan regardless. - scripts/base64-scan.sh: skip binary-by-content files (grep -Iq .) — they can't carry base64-obfuscated *text* and feeding NUL bytes through the per-line scanner is pathologically slow. collect_files already filtered binary *extensions*; this catches binary *content* in text extensions. - .github/workflows/security-scan.yml: raise the security job timeout 10m->30m to accommodate very large diffs (the scan itself is unchanged). Verified locally: scan skips the fixture, 0 "ignored null byte" warnings, 0 findings, exit 0. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): sweep get-shit-done refs introduced by merging next The branch was updated with next (#614/#384/#618 etc.), which reference the get-shit-done/ dir (still named that on next). Swept the stale references in the merged files to gsd-core so the rename stays consistent and lint:legacy-name passes: - commands/gsd/discuss-phase.md (runtime-launcher shim paths) - src/core.cts (getAgentsDir layout comments) - tests/bug-384-agents-runtime-aware.test.cjs (require path to runtime lib) Verified: guard 0 violations; build green. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): exclude gsd-core/ path segments from bug-3683 command cross-ref invariant The #614 runtime-launcher shim added to discuss-phase.md references `${_GSD_RUNTIME_ROOT}/gsd-core/bin/...`. bug-3683's REF_PATTERN excluded path-y refs only via lookbehind, but `}` precedes `/gsd-core/` in the shim, so it mis-read the directory path as a dangling `/gsd-core` command ref (same class as the #604 bug-2954 fix). Added a trailing `(?![\w-]*\/)` so `/gsd-<x>/...` path segments are not treated as slash-command references. Verified locally on BOTH platforms before pushing: - mac (node 26) full suite: 0 failures - gsd-test-runner (linux, node22 image) full suite: 0 failures - bug-3683 + bug-2954 pass. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): lazily resolve findProjectRoot in gsd-tools (harden flaky CI) CI intermittently failed state.test's gsd-tools subprocess with "findProjectRoot is not a function" (flip-flopping across legs; not reproducible on mac full suite, gsd-test linux full suite, test:unit, or state.test x8). findProjectRoot is a re-export from core.cjs (sourced from project-root.cjs); binding it via destructure at module-load can be undefined under a load-ordering edge. Resolve it lazily at call time via a small wrapper so the lookup happens after core.cjs is fully initialized. Verified green on BOTH platforms before pushing: - mac (node 26) full suite: 0 failures - gsd-test-runner (linux, node22) full suite: 0 failures - state.test.cjs: 106/106; gsd-tools loads cleanly. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): allowlist verification-patterns.md placeholder examples in secret scan The rename git-mv'd references/verification-patterns.md into gsd-core/, pulling it into the secret-scan diff. It documents stub/placeholder RED-FLAG env-var examples (illustrative Stripe test-key / database-URL / API-key placeholders) — not real credentials. Added it to .secretscanignore with the strict annotation, mirroring the existing gsd-core/workflows/plan-phase.md exception. Verified locally: secret-scan-lint --strict OK; secret-scan --diff origin/next exits 0 with 0 findings. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
144 lines
4.9 KiB
Markdown
144 lines
4.9 KiB
Markdown
---
|
|
type: prompt
|
|
name: gsd:complete-milestone
|
|
description: Archive completed milestone and prepare for next version
|
|
argument-hint: <version>
|
|
allowed-tools:
|
|
- Read
|
|
- Write
|
|
- Bash
|
|
requires: [audit-milestone, discuss-phase, execute-phase, new-milestone, phase, plan-phase, stats, update]
|
|
---
|
|
|
|
<objective>
|
|
Mark milestone {{version}} complete, archive to milestones/, and update ROADMAP.md and REQUIREMENTS.md.
|
|
|
|
Purpose: Create historical record of shipped version, archive milestone artifacts (roadmap + requirements), and prepare for next milestone.
|
|
Output: Milestone archived (roadmap + requirements), PROJECT.md evolved, git tagged.
|
|
</objective>
|
|
|
|
<execution_context>
|
|
**Load these files NOW (before proceeding):**
|
|
|
|
- @~/.claude/gsd-core/workflows/complete-milestone.md (main workflow)
|
|
- @~/.claude/gsd-core/templates/milestone-archive.md (archive template)
|
|
</execution_context>
|
|
|
|
<context>
|
|
**Project files:**
|
|
- `.planning/ROADMAP.md`
|
|
- `.planning/REQUIREMENTS.md`
|
|
- `.planning/STATE.md`
|
|
- `.planning/PROJECT.md`
|
|
|
|
**User input:**
|
|
|
|
- Version: {{version}} (e.g., "1.0", "1.1", "2.0")
|
|
</context>
|
|
|
|
<process>
|
|
|
|
**Follow complete-milestone.md workflow:**
|
|
|
|
0. **Check for audit:**
|
|
|
|
- Look for `.planning/v{{version}}-MILESTONE-AUDIT.md`
|
|
- If missing or stale: recommend `/gsd:audit-milestone` first
|
|
- If audit status is `gaps_found`: recommend closing the gaps inline
|
|
(the audit output already enumerates them — insert closure phases
|
|
via `/gsd:phase --insert <N>` plus the standard
|
|
discuss/plan/execute chain) before proceeding.
|
|
- If audit status is `passed`: proceed to step 1
|
|
|
|
```markdown
|
|
## Pre-flight Check
|
|
|
|
{If no v{{version}}-MILESTONE-AUDIT.md:}
|
|
⚠ No milestone audit found. Run `/gsd:audit-milestone` first to verify
|
|
requirements coverage, cross-phase integration, and E2E flows.
|
|
|
|
{If audit has gaps:}
|
|
⚠ Milestone audit found gaps. The audit output already enumerates the
|
|
unsatisfied requirements, cross-phase issues, and broken flows — insert
|
|
a closure phase per gap with `/gsd:phase --insert <N>` and run the
|
|
standard `/gsd:discuss-phase` → `/gsd:plan-phase` → `/gsd:execute-phase`
|
|
chain. Or proceed anyway to accept the gaps as tech debt.
|
|
|
|
{If audit passed:}
|
|
✓ Milestone audit passed. Proceeding with completion.
|
|
```
|
|
|
|
1. **Verify readiness:**
|
|
|
|
- Check all phases in milestone have completed plans (SUMMARY.md exists)
|
|
- Present milestone scope and stats
|
|
- Wait for confirmation
|
|
|
|
2. **Gather stats:**
|
|
|
|
- Count phases, plans, tasks
|
|
- Calculate git range, file changes, LOC
|
|
- Extract timeline from git log
|
|
- Present summary, confirm
|
|
|
|
3. **Extract accomplishments:**
|
|
|
|
- Read all phase SUMMARY.md files in milestone range
|
|
- Extract 4-6 key accomplishments
|
|
- Present for approval
|
|
|
|
4. **Archive milestone:**
|
|
|
|
- Create `.planning/milestones/v{{version}}-ROADMAP.md`
|
|
- Extract full phase details from ROADMAP.md
|
|
- Fill milestone-archive.md template
|
|
- Update ROADMAP.md to one-line summary with link
|
|
|
|
5. **Archive requirements:**
|
|
|
|
- Create `.planning/milestones/v{{version}}-REQUIREMENTS.md`
|
|
- Mark all v1 requirements as complete (checkboxes checked)
|
|
- Note requirement outcomes (validated, adjusted, dropped)
|
|
- Delete `.planning/REQUIREMENTS.md` (fresh one created for next milestone)
|
|
|
|
6. **Update PROJECT.md:**
|
|
|
|
- Add "Current State" section with shipped version
|
|
- Add "Next Milestone Goals" section
|
|
- Archive previous content in `<details>` (if v1.1+)
|
|
|
|
7. **Commit and tag:**
|
|
|
|
- Stage: MILESTONES.md, PROJECT.md, ROADMAP.md, STATE.md, archive files
|
|
- Commit: `chore: archive v{{version}} milestone`
|
|
- Tag: `git tag -a v{{version}} -m "[milestone summary]"`
|
|
- Ask about pushing tag
|
|
|
|
8. **Offer next steps:**
|
|
- `/gsd:new-milestone` — start next milestone (questioning → research → requirements → roadmap)
|
|
|
|
</process>
|
|
|
|
<success_criteria>
|
|
|
|
- Milestone archived to `.planning/milestones/v{{version}}-ROADMAP.md`
|
|
- Requirements archived to `.planning/milestones/v{{version}}-REQUIREMENTS.md`
|
|
- `.planning/REQUIREMENTS.md` deleted (fresh for next milestone)
|
|
- ROADMAP.md collapsed to one-line entry
|
|
- PROJECT.md updated with current state
|
|
- Git tag v{{version}} created (if `git.create_tag` enabled)
|
|
- Commit successful
|
|
- User knows next steps (including need for fresh requirements)
|
|
</success_criteria>
|
|
|
|
<critical_rules>
|
|
|
|
- **Load workflow first:** Read complete-milestone.md before executing
|
|
- **Verify completion:** All phases must have SUMMARY.md files
|
|
- **User confirmation:** Wait for approval at verification gates
|
|
- **Archive before deleting:** Always create archive files before updating/deleting originals
|
|
- **One-line summary:** Collapsed milestone in ROADMAP.md should be single line with link
|
|
- **Context efficiency:** Archive keeps ROADMAP.md and REQUIREMENTS.md constant size per milestone
|
|
- **Fresh requirements:** Next milestone starts with `/gsd:new-milestone` which includes requirements definition
|
|
</critical_rules>
|