golem15/msd-core
4
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity
Files
463cffd8944cedbaeda633c7c8e0e2c8cb874485
msd-core/docs/RELEASE-v1.42.3.md
Tom Boucher 463cffd894 chore(#604): rename get-shit-done/ runtime directory to gsd-core/ (#615) 
* chore(#604): rename get-shit-done/ runtime directory to gsd-core/

Renames the installed runtime directory `get-shit-done/` to `gsd-core/` so the
on-disk name matches the package (`@opengsd/gsd-core`), repo, and binary
(`gsd-tools`). The npm package name and binary are unchanged; npx/npm consumers
are unaffected.

Mechanical (bulk, ~90% of the diff):
- `git mv get-shit-done gsd-core`
- Swept path/identifier references across the repo via
  `perl -pe 's/get-shit-done(?!-\w)/gsd-core/g'`. The negative lookahead
  preserves the five legitimate slug variants that are NOT the directory:
  get-shit-done-{OLD,cc,classic,cli,redux} (old package/repo names).
- Build/manifest wiring: package.json (bin, files, coverage globs),
  tsconfig.build.json (outDir), ~86 .gitignore build-output entries,
  stryker.config.mjs, scan-ignore files, install.js path strings.
- Frozen (not rewritten): CHANGELOG.md history; translated docs
  (README.<locale>.md and docs/{ja-JP,ko-KR,pt-BR,zh-CN}/).

New logic (review here):
- src/installer-migrations/003-rename-get-shit-done-to-gsd-core.cts: a proper
  ADR-0008 installer migration. On upgrade it walks the legacy
  `~/.claude/get-shit-done/` tree, classifies each file via the prior install
  manifest, and emits remove-managed / backup-and-remove for managed files
  while PRESERVING unknown user-added files. Symlink-safe (skips a symlinked
  root and symlinked entries; bounds-checks every path under configDir). The
  framework rolls back on install failure. Emptied dirs may remain (framework
  has no recursive dir-removal primitive) — documented.
- scripts/lint-legacy-dir-name.cjs: CI regression guard forbidding the bare
  `get-shit-done` directory token (split token to avoid self-match; case-
  insensitive; `(?!-\w)` lookahead allows the slug variants; allowlists
  CHANGELOG, translated docs, and `gsd-allow-legacy-name` marker lines).
  Wired into the lint-tests CI job.
- Restored scripts/lint-package-identity-drift.cjs detection regexes (the
  mechanical sweep had wrongly rewritten the old-name patterns it exists to
  detect) and marked them as intentional legacy references.
- TDD tests for the migration and the guard; do.md slash-command guard regex
  tightened so a `/gsd-core/bin` path segment is not mistaken for a command;
  changeset + docs/installer-migrations.md row added.

Breaking: the installed runtime path moves `~/.claude/get-shit-done/` ->
`~/.claude/gsd-core/`. Migration 003 removes the stale legacy dir's managed
files (preserving user files) on upgrade. Users with custom hooks/configs
hardcoding the old path must update them.

Closes #604

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* fix(#604): unsweep pending changesets + allowlist injection-example docs

CI fixes for the rename PR:
- Do not sweep pending .changeset/*.md (ephemeral release-note fragments,
  like CHANGELOG); reverted those body edits so 5 pre-existing malformed
  fragments (missing type/pr) no longer enter the PR diff and trip docs-lint.
  Allowlisted .changeset/ in the legacy-name guard accordingly.
- Allowlisted TEST-EXAMPLES.md and docs/explanation/security-model.md in
  prompt-injection-scan.sh: they contain intentional injection examples /
  security-model prose; the path-reference rewrites are kept.

CodeQL alerts on this PR are pre-existing (alert lines unchanged by this PR;
none in the new migration/guard) and are out of scope for the rename.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* fix(#604): resolve CodeQL alerts surfaced on this PR

The rename diff touched files carrying pre-existing CodeQL findings; per the
no-pre-existing-dismissal rule, fixing every surfaced alert rather than waving
them off. All behavior-preserving:

- scripts/ci-test-scope.cjs: build the config-path match from string
  .includes() instead of a RegExp over an arg-derived value (js/regex-injection).
- src/profile-output.cts: escape backslashes before pipe-escaping desc/safeName
  so the table-cell escape is complete (js/incomplete-sanitization).
- tests/{bug-2643,bug-2808,docs-parity-live-registry}: two-pass HTML-comment
  strip so a bare/unclosed `<!--` cannot survive (js/incomplete-multi-character-sanitization).
- tests/inline-plan-threshold: drop the no-op `\s`->`\s` identity replace,
  keep the meaningful POSIX-class conversion (js/identity-replacement).

Verified: build:lib green; the touched test files + ci-test-scope + profile-output
suites pass; lint:legacy-name clean.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* fix(#604): correctly resolve remaining CodeQL alerts (regex-injection + sanitization)

The prior commit's fixes for two alerts were ineffective:
- ci-test-scope.cjs js/regex-injection: the alert is the CLI-arg-derived `file`
  reaching static regex `.test(file)` calls (not the config rule). Removed ALL
  regex over file/t — startsWith/includes/=== string checks + an isWindowsHint
  helper — so there is no regex sink for the tainted value.
- js/incomplete-multi-character-sanitization (3 test files): a single
  `.replace(/<!--...-->/g,'')` can let `<!--` re-form. Replaced with a fixpoint
  loop (replace until stable) plus a final bare-opener strip.

Verified: no regex over file/t remains; ci-test-scope + the 3 test suites pass;
lint:legacy-name clean.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* fix(#604): make ci-test-scope + comment-strippers regex-free to clear CodeQL

CodeQL flags the regex PATTERNS syntactically (regex-injection on the
--files arg split; incomplete-multi-character-sanitization on the <!--...-->
replace), so loop fixes do not satisfy it. Made these paths regex-free:
- ci-test-scope.cjs splitFiles: char-by-char separator tokenizer (no /[,\\s]+/).
- 3 test files: indexOf/slice HTML-comment stripper (no .replace(/<!--/)).
Behavior preserved; ci-test-scope + the 3 suites pass; guard clean.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* fix(#604): unblock security base64 scan on the large rename diff

The security job hit its 10m timeout: base64-scan.sh choked on the binary
test fixture tests/feat-3594-parser-property-style.test.cjs (embedded NUL/
non-UTF8 bytes -> thousands of bogus blobs + "ignored null byte" warnings),
and the ~800-file rename diff is slow to scan regardless.

- scripts/base64-scan.sh: skip binary-by-content files (grep -Iq .) — they
  can't carry base64-obfuscated *text* and feeding NUL bytes through the
  per-line scanner is pathologically slow. collect_files already filtered
  binary *extensions*; this catches binary *content* in text extensions.
- .github/workflows/security-scan.yml: raise the security job timeout 10m->30m
  to accommodate very large diffs (the scan itself is unchanged).

Verified locally: scan skips the fixture, 0 "ignored null byte" warnings,
0 findings, exit 0.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* fix(#604): sweep get-shit-done refs introduced by merging next

The branch was updated with next (#614/#384/#618 etc.), which reference the
get-shit-done/ dir (still named that on next). Swept the stale references in
the merged files to gsd-core so the rename stays consistent and lint:legacy-name
passes:
- commands/gsd/discuss-phase.md (runtime-launcher shim paths)
- src/core.cts (getAgentsDir layout comments)
- tests/bug-384-agents-runtime-aware.test.cjs (require path to runtime lib)

Verified: guard 0 violations; build green.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* fix(#604): exclude gsd-core/ path segments from bug-3683 command cross-ref invariant

The #614 runtime-launcher shim added to discuss-phase.md references
`${_GSD_RUNTIME_ROOT}/gsd-core/bin/...`. bug-3683's REF_PATTERN excluded path-y
refs only via lookbehind, but `}` precedes `/gsd-core/` in the shim, so it
mis-read the directory path as a dangling `/gsd-core` command ref (same class as
the #604 bug-2954 fix). Added a trailing `(?![\w-]*\/)` so `/gsd-<x>/...` path
segments are not treated as slash-command references.

Verified locally on BOTH platforms before pushing:
- mac (node 26) full suite: 0 failures
- gsd-test-runner (linux, node22 image) full suite: 0 failures
- bug-3683 + bug-2954 pass.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* fix(#604): lazily resolve findProjectRoot in gsd-tools (harden flaky CI)

CI intermittently failed state.test's gsd-tools subprocess with
"findProjectRoot is not a function" (flip-flopping across legs; not reproducible
on mac full suite, gsd-test linux full suite, test:unit, or state.test x8).
findProjectRoot is a re-export from core.cjs (sourced from project-root.cjs);
binding it via destructure at module-load can be undefined under a load-ordering
edge. Resolve it lazily at call time via a small wrapper so the lookup happens
after core.cjs is fully initialized.

Verified green on BOTH platforms before pushing:
- mac (node 26) full suite: 0 failures
- gsd-test-runner (linux, node22) full suite: 0 failures
- state.test.cjs: 106/106; gsd-tools loads cleanly.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* fix(#604): allowlist verification-patterns.md placeholder examples in secret scan

The rename git-mv'd references/verification-patterns.md into gsd-core/, pulling
it into the secret-scan diff. It documents stub/placeholder RED-FLAG env-var
examples (illustrative Stripe test-key / database-URL / API-key placeholders) —
not real credentials. Added it to .secretscanignore with the strict annotation,
mirroring the existing gsd-core/workflows/plan-phase.md exception.

Verified locally: secret-scan-lint --strict OK; secret-scan --diff origin/next
exits 0 with 0 findings.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
2026-06-02 18:35:29 -04:00

158 lines
7.0 KiB
Markdown
Raw Blame History

# v1.42.3 Release Notes
Hotfix release. Published to npm under the `latest` tag.
```bash
npx @opengsd/get-shit-done-redux@latest
```
---
## What's in this release
1.42.3 is a stability hotfix on top of 1.42.2. The headline is **Codex
CLI 0.130.0 install routability** — after `npx @opengsd/get-shit-done-redux@latest
--codex`, `$gsd-*` skills now resolve correctly under Codex 0.130.0 and
later, where the previous build left users with zero routable
entrypoints. The release also ships **runtime-aware slash formatting**
so emitted commands match the install's routing shape (Claude → `/gsd-*`,
Codex → `$gsd-*`) instead of the deprecated colon form, an **argv-based
subprocess** fix for `check.ship-ready` that closes a shell-injection
class through git refnames, the **`phase_status` field on
init.plan-phase** that gates `/gsd:plan-phase` on closed phases, plus
correctness fixes for archived-phase warnings, future-phase warnings,
canonical Codex hooks, and the SDK bridge load path.
### Fixed
- **Codex CLI 0.130.0 install now materializes routable skills** —
`bin/install.js` writes `~/.codex/skills/gsd-<name>/SKILL.md` for every
shipped command so `$gsd-*` skills resolve after install. Codex 0.130.0
dropped the extra-skills-roots discovery the previous build relied on,
leaving users with a successful-looking install and zero usable
commands. Documented minimum Codex CLI version (0.130.0) inline in the
Codex sections of `USER-GUIDE.md` and `CONFIGURATION.md`.
([#3562](https://github.com/GSD-redux/get-shit-done-redux/pull/3568),
[#3582](https://github.com/GSD-redux/get-shit-done-redux/pull/3609))
- **Runtime-aware slash formatter for user-facing emissions** —
`runtime-slash.cjs` produces `/gsd-<cmd>` for skills-based runtimes
(Claude, Cursor, OpenCode, Kilo, etc.) and `$gsd-<cmd>` for Codex.
The deprecated colon form `/gsd:<cmd>` is no longer emitted at
runtime, so the recommendations from `init`, `phase`, `verify`,
`milestone`, `validate-command-router`, `workstream`, `profile-output`,
`drift`, `gsd2-import`, and `commands` now paste cleanly into the
active runtime.
([#3584](https://github.com/GSD-redux/get-shit-done-redux/pull/3606))
- **Argv-based subprocess for `check.ship-ready`** — every git/gh probe
in `sdk/src/query/check-ship-ready.ts` now uses `execFileSync` with an
argv array instead of `execSync` with shell-interpolated strings.
Closes a shell-injection class where a malicious branch name (e.g.
`foo;touch INJ;bar`) interpolated into `git config --get
branch.<name>.merge` triggered arbitrary code execution.
([#3587](https://github.com/GSD-redux/get-shit-done-redux/pull/3611))
- **`init.plan-phase` surfaces `phase_status`; `/gsd:plan-phase` gates
on closed phases** — `init.plan-phase` payload now carries the
authoritative phase status (`Pending` / `Planned` / `Executed` /
`Complete`) from `determinePhaseStatus`. The plan-phase workflow
short-circuits on `Complete` (with `--force` override), and
`--reviews` against a closed phase hard-errors with no override.
Prevents accidental re-planning over shipped code.
([#3569](https://github.com/GSD-redux/get-shit-done-redux/pull/3581))
- **Canonical `[features].hooks` for Codex configs, legacy alias
recognized** — Codex config emission uses the canonical
`features.hooks` key while still accepting the legacy `codex_hooks`
shape on read. Fixes the install where the previous key drift left
Codex unable to find managed hooks.
([#3566](https://github.com/GSD-redux/get-shit-done-redux/pull/3573))
- **SDK bridge loads via the public package export** — fixes a stale
internal path that broke SDK dispatch after install on some package
layouts.
([#3567](https://github.com/GSD-redux/get-shit-done-redux/pull/3574))
- **W006/W007 health warnings skip archived and future phases** —
`/gsd:health` no longer flags phases that are intentionally
unimplemented (future) or archived as missing-on-disk or
missing-from-roadmap.
([#3559](https://github.com/GSD-redux/get-shit-done-redux/pull/3565),
[#3560](https://github.com/GSD-redux/get-shit-done-redux/pull/3564))
- **Ultraplan runtime gates on Claude Code markers** — `/gsd:ultraplan`
detects the runtime via Claude Code markers and fails closed when
the version is unavailable, instead of running against an unknown
runtime.
([#3561](https://github.com/GSD-redux/get-shit-done-redux/pull/3563))
- **Padded phase IDs match unpadded ROADMAP prose** — phase routing
through `phaseMarkdownRegexSource` handles `02.7` ↔ `2.7` and
similar padding mismatches so `/gsd:phase complete 02` updates a
ROADMAP that uses the short `### Phase 2:` form.
([#3537](https://github.com/GSD-redux/get-shit-done-redux/pull/3538))
- **W007 ignores archived phase directories** — phases under
`.planning/milestones/v*/` no longer trigger
"exists on disk but not in roadmap" warnings against the active
roadmap.
([#3560](https://github.com/GSD-redux/get-shit-done-redux/pull/3564))
- **Prompt-user migration actions resolve in non-TTY runs** —
`installer-migration-authoring` flows complete cleanly under CI /
non-interactive shells; error grouping clarified.
([#3541](https://github.com/GSD-redux/get-shit-done-redux/pull/3547))
- **Executor agents forbidden from `git stash`** — execution agents
no longer use shared stash storage, which violated worktree
isolation when multiple agents ran in parallel.
([#3542](https://github.com/GSD-redux/get-shit-done-redux/pull/3546))
- **Configuration manifests load from the installed payload** —
`configuration.generated.cjs` looks in the installed
`gsd-core/bin/shared/` path first, then falls back to
source-checkout `sdk/shared/`. Fixes the install where the manifest
loader failed on the runtime layout because the source-tree path
doesn't exist after install.
([#3571](https://github.com/GSD-redux/get-shit-done-redux/pull/3572))
---
## What was in 1.42.1
[`RELEASE-v1.42.1.md`](RELEASE-v1.42.1.md) — package legitimacy gate
against slopsquatting, skill-surface budgeting (`--profile=core` /
`standard` / `full`), installer migration framework, configurable
`/gsd-ship` PR body sections, `review.default_reviewers`, optional
fallow structural review, structured `--json-errors` CLI mode, plus
30+ correctness fixes across `project_code` phase prefixes, phase
completion idempotency, nested git detection, Codex install migration,
SDK install readiness, and decimal-phase dependencies.
---
## Installing
```bash
# npm (global)
npm install -g @opengsd/get-shit-done-redux@latest
# npx (one-shot)
npx @opengsd/get-shit-done-redux@latest
# Pin to this exact version
npm install -g @opengsd/get-shit-done-redux@1.42.3
```
The installer is idempotent — re-running on an existing install
updates in-place, preserving your `.planning/` directory and local
patches.
### Codex CLI requirement
Codex installs (`--codex`) require **Codex CLI 0.130.0 or later**.
Earlier Codex versions used a discovery mechanism that the current
install layout does not target; upgrade Codex first, then re-run the
GSD installer.
Reference in New Issue View Git Blame Copy Permalink