da4a86d8c1
Phase B-provide of epic #1258. Adds a build-generated skills/ dir + a skills manifest field so plugin-installed GSD exposes gsd-core:<skill> the native Claude Code way. Closes the gap where plugin-only installs lacked the skill surface because bin/install.js never ran. - scripts/gen-plugin-skills.cjs: build step converting commands/gsd/*.md to skills/gsd-<stem>/SKILL.md via convertClaudeCommandToClaudeSkill - .claude-plugin/plugin.json: add "skills": "./skills/" - package.json: add skills to files, gen:plugin-skills to build chain - tests/issue-766-plugin-manifest.test.cjs: Section H conformance (manifest field + dir + frontmatter + count parity) + C2 skills symlink - docs/adr/766-*.md: dated amendment adding skills surface row - .changeset/rapid-bears-hum.md: type Added - skills/: 69 generated gsd-<stem>/SKILL.md files (build-committed) Closes #1596
60 lines
2.7 KiB
Markdown
60 lines
2.7 KiB
Markdown
---
|
|
name: gsd-code-review
|
|
description: "Review source files changed during a phase for bugs, security issues, and code quality problems"
|
|
argument-hint: "<phase-number> [--depth=quick|standard|deep] [--files file1,file2,...] [--fix [--all] [--auto]]"
|
|
allowed-tools:
|
|
- Read
|
|
- Bash
|
|
- Glob
|
|
- Grep
|
|
- Write
|
|
- Agent
|
|
---
|
|
|
|
<objective>
|
|
Review source files changed during a phase for bugs, security vulnerabilities, and code quality problems.
|
|
|
|
Spawns the gsd-code-reviewer agent to analyze code at the specified depth level. Produces REVIEW.md artifact in the phase directory with severity-classified findings.
|
|
|
|
Arguments:
|
|
- Phase number (required) — which phase's changes to review (e.g., "2" or "02")
|
|
- `--depth=quick|standard|deep` (optional) — review depth level, overrides workflow.code_review_depth config
|
|
- quick: Pattern-matching only (~2 min)
|
|
- standard: Per-file analysis with language-specific checks (~5-15 min, default)
|
|
- deep: Cross-file analysis including import graphs and call chains (~15-30 min)
|
|
- `--files file1,file2,...` (optional) — explicit comma-separated file list, skips SUMMARY/git scoping (highest precedence for scoping)
|
|
- `--fix` (optional) — after review completes (or if REVIEW.md already exists), auto-apply fixes found. Spawns gsd-code-fixer agent. Accepts sub-flags:
|
|
- `--all` — include Info findings in fix scope (default: Critical + Warning only)
|
|
- `--auto` — enable fix + re-review iteration loop, capped at 3 iterations
|
|
|
|
Output: {padded_phase}-REVIEW.md in phase directory + inline summary of findings
|
|
</objective>
|
|
|
|
<execution_context>
|
|
@~/.claude/gsd-core/workflows/code-review.md
|
|
</execution_context>
|
|
|
|
<context>
|
|
Phase: $ARGUMENTS (first positional argument is phase number)
|
|
|
|
Optional flags parsed from $ARGUMENTS:
|
|
- `--depth=VALUE` — Depth override (quick|standard|deep). If provided, overrides workflow.code_review_depth config.
|
|
- `--files=file1,file2,...` — Explicit file list override. Has highest precedence for file scoping per D-08. When provided, workflow skips SUMMARY.md extraction and git diff fallback entirely.
|
|
|
|
Context files (CLAUDE.md, SUMMARY.md, phase state) are resolved inside the workflow via `gsd-tools query init.phase-op` and delegated to agent via `<files_to_read>` blocks.
|
|
</context>
|
|
|
|
<process>
|
|
This command is a thin dispatch layer. It parses arguments and delegates to the workflow.
|
|
|
|
Execute end-to-end.
|
|
|
|
The workflow (not this command) enforces these gates:
|
|
- Phase validation (before config gate)
|
|
- Config gate check (workflow.code_review)
|
|
- File scoping (--files override > SUMMARY.md > git diff fallback)
|
|
- Empty scope check (skip if no files)
|
|
- Agent spawning (gsd-code-reviewer)
|
|
- Result presentation (inline summary + next steps)
|
|
</process>
|