8789211038
* fix(insert-phase): update STATE.md next-phase recommendation after inserting a phase Closes #2502 * fix(insert-phase): update all STATE.md pointers; tighten test scope Two follow-up fixes from CodeRabbit review of #2509: 1. The update_project_state instruction only said to find "the line" for the next-phase recommendation. STATE.md can have multiple pointers (structured current_phase: field AND prose recommendation text). Updated wording to explicitly require updating all of them in the same edit. 2. The regression test for the next-phase pointer update scanned the entire file, so a match anywhere would pass even if update_project_state itself was missing the instruction. Scoped the assertion to only the content inside <step name="update_project_state"> to prevent false positives. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
135 lines
3.8 KiB
Markdown
135 lines
3.8 KiB
Markdown
<purpose>
|
|
Insert a decimal phase for urgent work discovered mid-milestone between existing integer phases. Uses decimal numbering (72.1, 72.2, etc.) to preserve the logical sequence of planned phases while accommodating urgent insertions without renumbering the entire roadmap.
|
|
</purpose>
|
|
|
|
<required_reading>
|
|
Read all files referenced by the invoking prompt's execution_context before starting.
|
|
</required_reading>
|
|
|
|
<process>
|
|
|
|
<step name="parse_arguments">
|
|
Parse the command arguments:
|
|
- First argument: integer phase number to insert after
|
|
- Remaining arguments: phase description
|
|
|
|
Example: `/gsd-insert-phase 72 Fix critical auth bug`
|
|
-> after = 72
|
|
-> description = "Fix critical auth bug"
|
|
|
|
If arguments missing:
|
|
|
|
```
|
|
ERROR: Both phase number and description required
|
|
Usage: /gsd-insert-phase <after> <description>
|
|
Example: /gsd-insert-phase 72 Fix critical auth bug
|
|
```
|
|
|
|
Exit.
|
|
|
|
Validate first argument is an integer.
|
|
</step>
|
|
|
|
<step name="init_context">
|
|
Load phase operation context:
|
|
|
|
```bash
|
|
INIT=$(gsd-sdk query init.phase-op "${after_phase}")
|
|
if [[ "$INIT" == @file:* ]]; then INIT=$(cat "${INIT#@file:}"); fi
|
|
```
|
|
|
|
Check `roadmap_exists` from init JSON. If false:
|
|
```
|
|
ERROR: No roadmap found (.planning/ROADMAP.md)
|
|
```
|
|
Exit.
|
|
</step>
|
|
|
|
<step name="insert_phase">
|
|
**Delegate the phase insertion to `gsd-sdk query phase.insert`:**
|
|
|
|
```bash
|
|
RESULT=$(gsd-sdk query phase.insert "${after_phase}" "${description}")
|
|
```
|
|
|
|
The CLI handles:
|
|
- Verifying target phase exists in ROADMAP.md
|
|
- Calculating next decimal phase number (checking existing decimals on disk)
|
|
- Generating slug from description
|
|
- Creating the phase directory (`.planning/phases/{N.M}-{slug}/`)
|
|
- Inserting the phase entry into ROADMAP.md after the target phase with (INSERTED) marker
|
|
|
|
Extract from result: `phase_number`, `after_phase`, `name`, `slug`, `directory`.
|
|
</step>
|
|
|
|
<step name="update_project_state">
|
|
Update STATE.md to reflect the inserted phase:
|
|
|
|
1. Read `.planning/STATE.md`
|
|
2. Update STATE.md's next-phase pointers to the newly inserted phase `{decimal_phase}`:
|
|
- Update structured field(s) used by tooling (e.g. `current_phase:`) to `{decimal_phase}`.
|
|
- Update human-readable recommendation text (e.g. `## Current Phase`, `Next recommended run:`) to `{decimal_phase}`.
|
|
- If multiple pointer locations exist, update all of them in the same edit.
|
|
3. Under "## Accumulated Context" → "### Roadmap Evolution" add entry:
|
|
```
|
|
- Phase {decimal_phase} inserted after Phase {after_phase}: {description} (URGENT)
|
|
```
|
|
|
|
If "Roadmap Evolution" section doesn't exist, create it.
|
|
</step>
|
|
|
|
<step name="completion">
|
|
Present completion summary:
|
|
|
|
```
|
|
Phase {decimal_phase} inserted after Phase {after_phase}:
|
|
- Description: {description}
|
|
- Directory: .planning/phases/{decimal-phase}-{slug}/
|
|
- Status: Not planned yet
|
|
- Marker: (INSERTED) - indicates urgent work
|
|
|
|
Roadmap updated: .planning/ROADMAP.md
|
|
Project state updated: .planning/STATE.md
|
|
|
|
---
|
|
|
|
## Next Up
|
|
|
|
**Phase {decimal_phase}: {description}** -- urgent insertion
|
|
|
|
`/clear` then:
|
|
|
|
`/gsd-plan-phase {decimal_phase}`
|
|
|
|
---
|
|
|
|
**Also available:**
|
|
- Review insertion impact: Check if Phase {next_integer} dependencies still make sense
|
|
- Review roadmap
|
|
|
|
---
|
|
```
|
|
</step>
|
|
|
|
</process>
|
|
|
|
<anti_patterns>
|
|
|
|
- Don't use this for planned work at end of milestone (use /gsd-add-phase)
|
|
- Don't insert before Phase 1 (decimal 0.1 makes no sense)
|
|
- Don't renumber existing phases
|
|
- Don't modify the target phase content
|
|
- Don't create plans yet (that's /gsd-plan-phase)
|
|
- Don't commit changes (user decides when to commit)
|
|
</anti_patterns>
|
|
|
|
<success_criteria>
|
|
Phase insertion is complete when:
|
|
|
|
- [ ] `gsd-sdk query phase.insert` executed successfully
|
|
- [ ] Phase directory created
|
|
- [ ] Roadmap updated with new phase entry (includes "(INSERTED)" marker)
|
|
- [ ] STATE.md updated with roadmap evolution note
|
|
- [ ] User informed of next steps and dependency implications
|
|
</success_criteria>
|