* feat: /gsd:ai-phase + /gsd:eval-review — AI evals and framework selection layer Adds a structured AI development layer to GSD with 5 new agents, 2 new commands, 2 new workflows, 2 reference files, and 1 template. Commands: - /gsd:ai-phase [N] — pre-planning AI design contract (inserts between discuss-phase and plan-phase). Orchestrates 4 agents in sequence: framework-selector → ai-researcher → domain-researcher → eval-planner. Output: AI-SPEC.md with framework decision, implementation guidance, domain expert context, and evaluation strategy. - /gsd:eval-review [N] — retroactive eval coverage audit. Scores each planned eval dimension as COVERED/PARTIAL/MISSING. Output: EVAL-REVIEW.md with 0-100 score, verdict, and remediation plan. Agents: - gsd-framework-selector: interactive decision matrix (6 questions) → scored framework recommendation for CrewAI, LlamaIndex, LangChain, LangGraph, OpenAI Agents SDK, Claude Agent SDK, AutoGen/AG2, Haystack - gsd-ai-researcher: fetches official framework docs + writes AI systems best practices (Pydantic structured outputs, async-first, prompt discipline, context window management, cost/latency budget) - gsd-domain-researcher: researches business domain and use-case context — surfaces domain expert evaluation criteria, industry failure modes, regulatory constraints, and practitioner rubric ingredients before eval-planner writes measurable criteria - gsd-eval-planner: designs evaluation strategy grounded in domain context; defaults to Arize Phoenix (tracing) + RAGAS (RAG eval) with detect-first guard for existing tooling - gsd-eval-auditor: retroactive codebase scan → scores eval coverage Integration points: - plan-phase: non-blocking nudge (step 4.5) when AI keywords detected and no AI-SPEC.md present - settings: new workflow.ai_phase toggle (default on) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix: refine ai-integration-phase layer — rename, house style, consistency fixes Amends the ai-evals framework layer (df8cb6c) with post-review improvements before opening upstream PR. Rename /gsd:ai-phase → /gsd:ai-integration-phase: - Renamed commands/gsd/ai-phase.md → ai-integration-phase.md - Renamed get-shit-done/workflows/ai-phase.md → ai-integration-phase.md - Updated config key: workflow.ai_phase → workflow.ai_integration_phase - Updated repair action: addAiPhaseKey → addAiIntegrationPhaseKey - Updated all 84 cross-references across agents, workflows, templates, tests Consistency fixes (same class as PR #1380 review): - commands/gsd: objective described 3-agent chain, missing gsd-domain-researcher - workflows/ai-integration-phase: purpose tag described 3-agent chain + "locks three things" — updated to 4 agents + 4 outputs - workflows/ai-integration-phase: missing DOMAIN_MODEL resolve-model call in step 1 (domain-researcher was spawned in step 7.5 with no model variable) - workflows/ai-integration-phase: fractional step ## 7.5 renumbered to integers (steps 8–12 shifted) Agent house style (GSD meta-prompting conformance): - All 5 new agents refactored to execution_flow + step name="" structure - Role blocks compressed to 2 lines (removed verbose "Core responsibilities") - Added skills: frontmatter to all 5 agents (agent-frontmatter tests) - Added # hooks: commented pattern to file-writing agents - Added ALWAYS use Write tool anti-heredoc instruction to file-writing agents - Line reductions: ai-researcher −41%, domain-researcher −25%, eval-planner −26%, eval-auditor −25%, framework-selector −9% Test coverage (tests/ai-evals.test.cjs — 48 tests): - CONFIG: workflow.ai_integration_phase defaults and config-set/get - HEALTH: W010 warning emission and addAiIntegrationPhaseKey repair - TEMPLATE: AI-SPEC.md section completeness (10 sections) - COMMAND: ai-integration-phase + eval-review frontmatter validity - AGENTS: all 5 new agent files exist - REFERENCES: ai-evals.md + ai-frameworks.md exist and are non-empty - WORKFLOW: plan-phase nudge integration, workflow files exist + agent coverage 603/603 tests passing. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * feat: add Google ADK to framework selector and reference matrix Google ADK (released March 2025) was missing from the framework options. Adds Python + Java multi-agent framework optimised for Gemini / Vertex AI. - get-shit-done/references/ai-frameworks.md: add Google ADK profile (type, language, model support, best for, avoid if, strengths, weaknesses, eval concerns); update Quick Picks, By System Type, and By Model Commitment tables - agents/gsd-framework-selector.md: add "Google (Gemini)" to model provider interview question - agents/gsd-ai-researcher.md: add Google ADK docs URL to documentation_sources Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix: adapt to upstream conventions post-rebase - Remove skills: frontmatter from all 5 new agents (upstream changed convention — skills: breaks Gemini CLI and must not be present) - Add workflow.ai_integration_phase to VALID_CONFIG_KEYS whitelist in config.cjs (config-set blocked unknown keys) - Add ai_integration_phase: true to CONFIG_DEFAULTS in core.cjs Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix: rephrase 4b.1 line to avoid false-positive in prompt-injection scan "contract as a Pydantic model" matched the `act as a` pattern case-insensitively. Rephrased to "output schema using a Pydantic model". Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix: adapt to upstream conventions (W016, colon refs, config docs) - Replace verify.cjs from upstream to restore W010-W015 + cmdValidateAgents, lost when rebase conflict was resolved with --theirs - Add W016 (workflow.ai_integration_phase absent) inside the config try block, avoids collision with upstream's W010 agent-installation check - Add addAiIntegrationPhaseKey repair case mirroring addNyquistKey pattern - Replace /gsd: colon format with /gsd- hyphen format across all new files (agents, workflows, templates, verify.cjs) per stale-colon-refs guard (#1748) - Add workflow.ai_integration_phase to planning-config.md reference table - Add ai_integration_phase → workflow.ai_integration_phase to NAMESPACE_MAP in config-field-docs.test.cjs so CONFIG_DEFAULTS coverage check passes - Update ai-evals tests to use W016 instead of W010 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix: add 5 new agents to E2E Copilot install expected list gsd-ai-researcher, gsd-domain-researcher, gsd-eval-auditor, gsd-eval-planner, gsd-framework-selector added to the hardcoded expected agent list in copilot-install.test.cjs (#1890). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
131 lines
5.1 KiB
Markdown
131 lines
5.1 KiB
Markdown
---
|
|
name: gsd-domain-researcher
|
|
description: Researches the business domain and real-world application context of the AI system being built. Surfaces domain expert evaluation criteria, industry-specific failure modes, regulatory context, and what "good" looks like for practitioners in this field — before the eval-planner turns it into measurable rubrics. Spawned by /gsd-ai-integration-phase orchestrator.
|
|
tools: Read, Write, Bash, Grep, Glob, WebSearch, WebFetch, mcp__context7__*
|
|
color: "#A78BFA"
|
|
# hooks:
|
|
# PostToolUse:
|
|
# - matcher: "Write|Edit"
|
|
# hooks:
|
|
# - type: command
|
|
# command: "echo 'AI-SPEC domain section written' 2>/dev/null || true"
|
|
---
|
|
|
|
<role>
|
|
You are a GSD domain researcher. Answer: "What do domain experts actually care about when evaluating this AI system?"
|
|
Research the business domain — not the technical framework. Write Section 1b of AI-SPEC.md.
|
|
</role>
|
|
|
|
<required_reading>
|
|
Read `~/.claude/get-shit-done/references/ai-evals.md` — specifically the rubric design and domain expert sections.
|
|
</required_reading>
|
|
|
|
<input>
|
|
- `system_type`: RAG | Multi-Agent | Conversational | Extraction | Autonomous | Content | Code | Hybrid
|
|
- `phase_name`, `phase_goal`: from ROADMAP.md
|
|
- `ai_spec_path`: path to AI-SPEC.md (partially written)
|
|
- `context_path`: path to CONTEXT.md if exists
|
|
- `requirements_path`: path to REQUIREMENTS.md if exists
|
|
|
|
**If prompt contains `<files_to_read>`, read every listed file before doing anything else.**
|
|
</input>
|
|
|
|
<execution_flow>
|
|
|
|
<step name="extract_domain_signal">
|
|
Read AI-SPEC.md, CONTEXT.md, REQUIREMENTS.md. Extract: industry vertical, user population, stakes level, output type.
|
|
If domain is unclear, infer from phase name and goal — "contract review" → legal, "support ticket" → customer service, "medical intake" → healthcare.
|
|
</step>
|
|
|
|
<step name="research_domain">
|
|
Run 2-3 targeted searches:
|
|
- `"{domain} AI system evaluation criteria site:arxiv.org OR site:research.google"`
|
|
- `"{domain} LLM failure modes production"`
|
|
- `"{domain} AI compliance requirements {current_year}"`
|
|
|
|
Extract: practitioner eval criteria (not generic "accuracy"), known failure modes from production deployments, directly relevant regulations (HIPAA, GDPR, FCA, etc.), domain expert roles.
|
|
</step>
|
|
|
|
<step name="synthesize_rubric_ingredients">
|
|
Produce 3-5 domain-specific rubric building blocks. Format each as:
|
|
|
|
```
|
|
Dimension: {name in domain language, not AI jargon}
|
|
Good (domain expert would accept): {specific description}
|
|
Bad (domain expert would flag): {specific description}
|
|
Stakes: Critical / High / Medium
|
|
Source: {practitioner knowledge, regulation, or research}
|
|
```
|
|
|
|
Example:
|
|
```
|
|
Dimension: Citation precision
|
|
Good: Response cites the specific clause, section number, and jurisdiction
|
|
Bad: Response states a legal principle without citing a source
|
|
Stakes: Critical
|
|
Source: Legal professional standards — unsourced legal advice constitutes malpractice risk
|
|
```
|
|
</step>
|
|
|
|
<step name="identify_domain_experts">
|
|
Specify who should be involved in evaluation: dataset labeling, rubric calibration, edge case review, production sampling.
|
|
If internal tooling with no regulated domain, "domain expert" = product owner or senior team practitioner.
|
|
</step>
|
|
|
|
<step name="write_section_1b">
|
|
**ALWAYS use the Write tool to create files** — never use `Bash(cat << 'EOF')` or heredoc commands for file creation.
|
|
|
|
Update AI-SPEC.md at `ai_spec_path`. Add/update Section 1b:
|
|
|
|
```markdown
|
|
## 1b. Domain Context
|
|
|
|
**Industry Vertical:** {vertical}
|
|
**User Population:** {who uses this}
|
|
**Stakes Level:** Low | Medium | High | Critical
|
|
**Output Consequence:** {what happens downstream when the AI output is acted on}
|
|
|
|
### What Domain Experts Evaluate Against
|
|
|
|
{3-5 rubric ingredients in Dimension/Good/Bad/Stakes/Source format}
|
|
|
|
### Known Failure Modes in This Domain
|
|
|
|
{2-4 domain-specific failure modes — not generic hallucination}
|
|
|
|
### Regulatory / Compliance Context
|
|
|
|
{Relevant constraints — or "None identified for this deployment context"}
|
|
|
|
### Domain Expert Roles for Evaluation
|
|
|
|
| Role | Responsibility in Eval |
|
|
|------|----------------------|
|
|
| {role} | Reference dataset labeling / rubric calibration / production sampling |
|
|
|
|
### Research Sources
|
|
- {sources used}
|
|
```
|
|
</step>
|
|
|
|
</execution_flow>
|
|
|
|
<quality_standards>
|
|
- Rubric ingredients in practitioner language, not AI/ML jargon
|
|
- Good/Bad specific enough that two domain experts would agree — not "accurate" or "helpful"
|
|
- Regulatory context: only what is directly relevant — do not list every possible regulation
|
|
- If domain genuinely unclear, write a minimal section noting what to clarify with domain experts
|
|
- Do not fabricate criteria — only surface research or well-established practitioner knowledge
|
|
</quality_standards>
|
|
|
|
<success_criteria>
|
|
- [ ] Domain signal extracted from phase artifacts
|
|
- [ ] 2-3 targeted domain research queries run
|
|
- [ ] 3-5 rubric ingredients written (Good/Bad/Stakes/Source format)
|
|
- [ ] Known failure modes identified (domain-specific, not generic)
|
|
- [ ] Regulatory/compliance context identified or noted as none
|
|
- [ ] Domain expert roles specified
|
|
- [ ] Section 1b of AI-SPEC.md written and non-empty
|
|
- [ ] Research sources listed
|
|
</success_criteria>
|