* refactor(shell-projection): remove deprecated wrappers + finalize ADRs (Phase 4, #3468) Final phase of the shell-command-projection expansion. Removes the legacy core.cjs wrappers (`atomicWriteFileSync`, `safeReadFile`, `normalizeMd`) now that every call site lives behind the seam, plus three Phase-3 stragglers (`graphify.cjs`, `template.cjs`, dead import in `profile-pipeline.cjs`). Documentation: - ADR-0009: addendum noting Phase 1–4 scope expansion (subprocess + file I/O ownership), supersession of "does not execute" constraint, and resolution of open Q4. - ADR-0010: status changed to Superseded by ADR-0009 with explanation. - CONTEXT.md "Shell Command Projection Module" entry already current from Phase 1 — no edit needed. Tests: - `tests/atomic-write.test.cjs` deleted — wrapper it tested is gone; `atomic-write-coverage.test.cjs` (Phase 3) covers platformWriteSync. - `tests/core.test.cjs::safeReadFile` + `::normalizeMd` describes deleted — wrappers are gone. - `tests/concurrency-safety.test.cjs` normalizeMd suite (behavioral / perf / snapshot) repointed via 2-line shim at the seam's `normalizeContent` — full regression coverage preserved. Test result: 9059/9041/18 — exact pre-Phase-4 baseline. All 18 failures are pre-existing path-with-spaces local-env issues. Closes #3468 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * refactor(shell-projection): migrate remaining raw fs.writeFileSync sites (Phase 4, #3468) Sweeps the 7 raw fs.writeFileSync call sites that bypassed the seam through Phase 3, folding them into platformWriteSync. Net -14 lines: deletes the local writeFileAtomicSync helper in installer-migrations.cjs and collapses surface.cjs's manual tmp+rename into a single seam call. Sites migrated: - drift.cjs (1) — frontmatter write - learnings.cjs (1) — learning record JSON write - install-profiles.cjs (1) — profile marker write (collapsed redundant mkdir) - gsd2-import.cjs (1) — imported file write (collapsed redundant mkdir) - surface.cjs (1) — surface state write (replaced manual tmp+rename block) - installer-migrations.cjs (3) — journal init/finalize + rewrite-json action; deleted private writeFileAtomicSync helper and its three call sites Two sites intentionally retained outside the seam: - planning-workspace.cjs:241 — workspace lock (wx-flag atomic-create; previously excluded by Phase 3) - installer-migrations.cjs:220 — install migration lock (fd write into wx-opened handle) - writeInstallState (installer-migrations.cjs) — strict atomic contract for install state; the seam's fallback-to-direct-write on rename failure would silently violate the invariant that install state must never be left half-written. Inline tmp+rename with rethrow keeps the original guarantee. Tests: 9059 / 9041 / 18 — exactly the pre-Phase-4 baseline; 18 failures are the pre-existing path-with-spaces local-env issues, identical files as before. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * fix(installer-migrations): use strict atomic write for rollback install-state restore The rollback path was restoring INSTALL_STATE via platformWriteSync, which falls back to a direct write on rename failure and would silently violate the half-written invariant that the install-state contract guarantees elsewhere. Extracts the strict tmp+rename logic from writeInstallState into a shared atomicWriteInstallState(configDir, content) helper and routes both writeInstallState and rollbackAppliedMigrationResult through it. Preserves the existing null-handling (rmSync when previousInstallStateBytes === null) and existing failure-collection (failures.push on caught errors). Byte-faithful restore: previousInstallStateBytes is written as-is (no JSON parse round-trip), preserving the exact prior file contents on restore. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
229 lines
7.5 KiB
JavaScript
229 lines
7.5 KiB
JavaScript
/**
|
|
* Template — Template selection and fill operations
|
|
*/
|
|
|
|
const fs = require('fs');
|
|
const path = require('path');
|
|
const { normalizePhaseName, findPhaseInternal, generateSlugInternal, toPosixPath, output, error } = require('./core.cjs');
|
|
const { platformWriteSync } = require('./shell-command-projection.cjs');
|
|
const { planningDir } = require('./planning-workspace.cjs');
|
|
const { reconstructFrontmatter } = require('./frontmatter.cjs');
|
|
|
|
function cmdTemplateSelect(cwd, planPath, raw) {
|
|
if (!planPath) {
|
|
error('plan-path required');
|
|
}
|
|
|
|
try {
|
|
const fullPath = path.join(cwd, planPath);
|
|
const content = fs.readFileSync(fullPath, 'utf-8');
|
|
|
|
// Simple heuristics
|
|
const taskMatch = content.match(/###\s*Task\s*\d+/g) || [];
|
|
const taskCount = taskMatch.length;
|
|
|
|
const decisionMatch = content.match(/decision/gi) || [];
|
|
const hasDecisions = decisionMatch.length > 0;
|
|
|
|
// Count file mentions
|
|
const fileMentions = new Set();
|
|
const filePattern = /`([^`]+\.[a-zA-Z]+)`/g;
|
|
let m;
|
|
while ((m = filePattern.exec(content)) !== null) {
|
|
if (m[1].includes('/') && !m[1].startsWith('http')) {
|
|
fileMentions.add(m[1]);
|
|
}
|
|
}
|
|
const fileCount = fileMentions.size;
|
|
|
|
let template = 'templates/summary-standard.md';
|
|
let type = 'standard';
|
|
|
|
if (taskCount <= 2 && fileCount <= 3 && !hasDecisions) {
|
|
template = 'templates/summary-minimal.md';
|
|
type = 'minimal';
|
|
} else if (hasDecisions || fileCount > 6 || taskCount > 5) {
|
|
template = 'templates/summary-complex.md';
|
|
type = 'complex';
|
|
}
|
|
|
|
const result = { template, type, taskCount, fileCount, hasDecisions };
|
|
output(result, raw, template);
|
|
} catch (e) {
|
|
// Fallback to standard
|
|
output({ template: 'templates/summary-standard.md', type: 'standard', error: e.message }, raw, 'templates/summary-standard.md');
|
|
}
|
|
}
|
|
|
|
function cmdTemplateFill(cwd, templateType, options, raw) {
|
|
if (!templateType) { error('template type required: summary, plan, or verification'); }
|
|
if (!options.phase) { error('--phase required'); }
|
|
|
|
const phaseInfo = findPhaseInternal(cwd, options.phase);
|
|
if (!phaseInfo || !phaseInfo.found) { output({ error: 'Phase not found', phase: options.phase }, raw); return; }
|
|
|
|
const padded = normalizePhaseName(options.phase);
|
|
const today = new Date().toISOString().split('T')[0];
|
|
const phaseName = options.name || phaseInfo.phase_name || 'Unnamed';
|
|
const phaseSlug = phaseInfo.phase_slug || generateSlugInternal(phaseName);
|
|
const phaseId = `${padded}-${phaseSlug}`;
|
|
const planNum = (options.plan || '01').padStart(2, '0');
|
|
const fields = options.fields || {};
|
|
|
|
let frontmatter, body, fileName;
|
|
|
|
switch (templateType) {
|
|
case 'summary': {
|
|
frontmatter = {
|
|
phase: phaseId,
|
|
plan: planNum,
|
|
subsystem: '[primary category]',
|
|
tags: [],
|
|
provides: [],
|
|
affects: [],
|
|
'tech-stack': { added: [], patterns: [] },
|
|
'key-files': { created: [], modified: [] },
|
|
'key-decisions': [],
|
|
'patterns-established': [],
|
|
duration: '[X]min',
|
|
completed: today,
|
|
...fields,
|
|
};
|
|
body = [
|
|
`# Phase ${options.phase}: ${phaseName} Summary`,
|
|
'',
|
|
'**[Substantive one-liner describing outcome]**',
|
|
'',
|
|
'## Performance',
|
|
'- **Duration:** [time]',
|
|
'- **Tasks:** [count completed]',
|
|
'- **Files modified:** [count]',
|
|
'',
|
|
'## Accomplishments',
|
|
'- [Key outcome 1]',
|
|
'- [Key outcome 2]',
|
|
'',
|
|
'## Task Commits',
|
|
'1. **Task 1: [task name]** - `hash`',
|
|
'',
|
|
'## Files Created/Modified',
|
|
'- `path/to/file.ts` - What it does',
|
|
'',
|
|
'## Decisions & Deviations',
|
|
'[Key decisions or "None - followed plan as specified"]',
|
|
'',
|
|
'## Next Phase Readiness',
|
|
'[What\'s ready for next phase]',
|
|
].join('\n');
|
|
fileName = `${padded}-${planNum}-SUMMARY.md`;
|
|
break;
|
|
}
|
|
case 'plan': {
|
|
const planType = options.type || 'execute';
|
|
const wave = parseInt(options.wave) || 1;
|
|
frontmatter = {
|
|
phase: phaseId,
|
|
plan: planNum,
|
|
type: planType,
|
|
wave,
|
|
depends_on: [],
|
|
files_modified: [],
|
|
autonomous: true,
|
|
user_setup: [],
|
|
must_haves: { truths: [], artifacts: [], key_links: [] },
|
|
...fields,
|
|
};
|
|
const planBase = planningDir(cwd);
|
|
const projectRef = toPosixPath(path.relative(cwd, path.join(planBase, 'PROJECT.md')));
|
|
const roadmapRef = toPosixPath(path.relative(cwd, path.join(planBase, 'ROADMAP.md')));
|
|
const stateRef = toPosixPath(path.relative(cwd, path.join(planBase, 'STATE.md')));
|
|
body = [
|
|
`# Phase ${options.phase} Plan ${planNum}: [Title]`,
|
|
'',
|
|
'## Objective',
|
|
'- **What:** [What this plan builds]',
|
|
'- **Why:** [Why it matters for the phase goal]',
|
|
'- **Output:** [Concrete deliverable]',
|
|
'',
|
|
'## Context',
|
|
`@${projectRef}`,
|
|
`@${roadmapRef}`,
|
|
`@${stateRef}`,
|
|
'',
|
|
'## Tasks',
|
|
'',
|
|
'<task type="code">',
|
|
' <name>[Task name]</name>',
|
|
' <files>[file paths]</files>',
|
|
' <action>[What to do]</action>',
|
|
' <verify>[How to verify]</verify>',
|
|
' <done>[Definition of done]</done>',
|
|
'</task>',
|
|
'',
|
|
'## Verification',
|
|
'[How to verify this plan achieved its objective]',
|
|
'',
|
|
'## Success Criteria',
|
|
'- [ ] [Criterion 1]',
|
|
'- [ ] [Criterion 2]',
|
|
].join('\n');
|
|
fileName = `${padded}-${planNum}-PLAN.md`;
|
|
break;
|
|
}
|
|
case 'verification': {
|
|
frontmatter = {
|
|
phase: phaseId,
|
|
verified: new Date().toISOString(),
|
|
status: 'pending',
|
|
score: '0/0 must-haves verified',
|
|
...fields,
|
|
};
|
|
body = [
|
|
`# Phase ${options.phase}: ${phaseName} — Verification`,
|
|
'',
|
|
'## Observable Truths',
|
|
'| # | Truth | Status | Evidence |',
|
|
'|---|-------|--------|----------|',
|
|
'| 1 | [Truth] | pending | |',
|
|
'',
|
|
'## Required Artifacts',
|
|
'| Artifact | Expected | Status | Details |',
|
|
'|----------|----------|--------|---------|',
|
|
'| [path] | [what] | pending | |',
|
|
'',
|
|
'## Key Link Verification',
|
|
'| From | To | Via | Status | Details |',
|
|
'|------|----|----|--------|---------|',
|
|
'| [source] | [target] | [connection] | pending | |',
|
|
'',
|
|
'## Requirements Coverage',
|
|
'| Requirement | Status | Blocking Issue |',
|
|
'|-------------|--------|----------------|',
|
|
'| [req] | pending | |',
|
|
'',
|
|
'## Result',
|
|
'[Pending verification]',
|
|
].join('\n');
|
|
fileName = `${padded}-VERIFICATION.md`;
|
|
break;
|
|
}
|
|
default:
|
|
error(`Unknown template type: ${templateType}. Available: summary, plan, verification`);
|
|
return;
|
|
}
|
|
|
|
const fullContent = `---\n${reconstructFrontmatter(frontmatter)}\n---\n\n${body}\n`;
|
|
const outPath = path.join(cwd, phaseInfo.directory, fileName);
|
|
|
|
if (fs.existsSync(outPath)) {
|
|
output({ error: 'File already exists', path: toPosixPath(path.relative(cwd, outPath)) }, raw);
|
|
return;
|
|
}
|
|
|
|
platformWriteSync(outPath, fullContent);
|
|
const relPath = toPosixPath(path.relative(cwd, outPath));
|
|
output({ created: true, path: relPath, template: templateType }, raw, relPath);
|
|
}
|
|
|
|
module.exports = { cmdTemplateSelect, cmdTemplateFill };
|