Tom Boucher 9cbb48afa1 fix(#2753): scan every key occurrence when asserting a documented default (#2756)
* fix(#2753): scan every key occurrence when asserting a documented default

The settings-default assertion located each key with indexOf and checked only a
400-char window after the FIRST match. Its stated contract is "the workflow
documents the default for this key"; what it actually asserted was "the first
mention of this key is followed by the default" - an ordering assumption that was
never part of the contract and that breaks the moment a workflow names a key in
prose before its settings-table entry.

PR #2558 does exactly that: a shared language directive puts response_language at
index 6 while the table documents null at 7185, so the gate failed a document that
was correct, and the failure message showed the prose window rather than the cause.

Extracted findDocumentedDefault, which scans every occurrence and reports how many
it examined. Widening the window to the whole file was rejected - it would pass on
any unrelated occurrence of the token - as was parsing the settings table, which
would couple the check to table markup. The negative case still fails: a key that
no occurrence documents is a failure, now with the occurrence count so a genuine
miss stays distinguishable from this false negative.

* fix(#2753): guard the empty needle and de-vacuum the newline test

Isolated review found a real hang: String#indexOf('', pos) clamps to str.length
rather than returning -1, so an empty key made the scan loop stabilize at the end
of the document and spin forever. Unreachable from SPEC_FIELDS today, but the
docstring claimed termination while reasoning only about self-overlap. Guarded,
with the clamping behavior named so the guard is not tidied away later.

The newline test asserted only that CRLF and LF agree, which a constant stub
satisfies. It now pins the absolute verdict on both, plus a document neither style
can rescue.

Added the property test the review noted was missing: windowSize is a budget limit,
so the verdict is asserted to be exactly "key + gap + default fits the window" over
disjoint alphabets. It would have caught the empty-key hang on its own.

* fix(#2753): assert examined-occurrence count, not the document's total

The no-regression test asserted occurrences === 2 because the fixture mentions the
key twice. The scan short-circuits on the first documenting window, so exactly one
occurrence is examined - the assertion was describing the fixture rather than the
function.

Documented the semantic properly instead of just correcting the number:
occurrences is how many were EXAMINED before deciding, so on success it is the
1-based position of the match and on failure the document's full count. The
asymmetry is deliberate - the failure path is where the number must be trustworthy,
since "examined N, none documented it" is what separates a genuine miss from the
first-occurrence false negative this function removes.
2026-07-28 08:58:27 -04:00

GSD Core

Git. Ship. Done.

English · Português · 简体中文 · 日本語 · 한국어

A light-weight meta-prompting, context engineering, and spec-driven development system for Claude Code, OpenCode, Antigravity CLI, Kimi CLI, Kilo, Codex, Copilot, Cursor, Windsurf, and more.

npm version npm downloads Tests Discord GitHub stars License


What is GSD Core

GSD Core is a context-engineering and spec-driven development framework that drives AI coding agents (Claude Code, Codex, Antigravity CLI, Kimi CLI, Copilot, Cursor, and more) through a disciplined phase loop. It solves context rot — the quality degradation that accumulates as an AI fills its context window — by running all heavy research, planning, and execution work in fresh-context subagents while keeping your main session lean.


How it works

Each milestone repeats the same five-step loop, one phase at a time:

  1. Discuss — capture implementation decisions before anything is planned
  2. Plan — research, decompose, and verify the plan fits a fresh context window
  3. Execute — run plans in parallel waves; each executor starts with a clean 200k-token context
  4. Verify — walk through what was built; diagnose and fix before declaring done
  5. Ship — create the PR, archive the phase, repeat for the next one

Quickstart

npx @opengsd/gsd-core@latest

The installer prompts for your runtime (Claude Code, OpenCode, Antigravity CLI, Kimi CLI, Kilo, Codex, Copilot, Cursor, Windsurf, and more) and whether to install globally or locally. The installer is required for cross-runtime compatibility — do not copy files from agents/ or commands/ directly.

On another runtime or without Node.js? See Install on your runtime.

Once installed, start a new project or onboard an existing repo:

/gsd-new-project   # greenfield project
/gsd-onboard       # existing codebase

New here? Follow Your first project for a guided walkthrough from install to first shipped phase, or Onboarding an existing codebase for brownfield setup.


Documentation

What's new in 1.7.0 → docs/whats-new-1.7.0.md

Tutorials — learning by doing:

How-to guides — task-focused recipes:

Reference — authoritative facts:

Explanation — concepts and design decisions:

Full index: docs/README.md. Other languages: 日本語 · 한국어 · Português · 简体中文.


Why it works

Most AI-coding setups fail at scale because context bloat silently degrades output quality, there is no shared memory between sessions, and nothing verifies that code actually works. GSD Core solves all three: heavy work runs in fresh subagents, structured artifacts like STATE.md and CONTEXT.md survive session boundaries, and the verify step walks through what was built and generates fix plans before a phase is declared done. See docs/explanation/context-engineering.md for the full reasoning.

Troubleshooting? See docs/how-to/recover-and-troubleshoot.md.


Community

Project Platform
gsd-opencode Original OpenCode port
Discord Community support

Star History

Star History Chart

License

MIT License. See LICENSE for details.


Claude Code is powerful. GSD Core makes it reliable.

Description
No description provided
Readme MIT 77 MiB
Languages
JavaScript 82.3%
TypeScript 17.4%
Shell 0.3%