* chore(#604): rename get-shit-done/ runtime directory to gsd-core/ Renames the installed runtime directory `get-shit-done/` to `gsd-core/` so the on-disk name matches the package (`@opengsd/gsd-core`), repo, and binary (`gsd-tools`). The npm package name and binary are unchanged; npx/npm consumers are unaffected. Mechanical (bulk, ~90% of the diff): - `git mv get-shit-done gsd-core` - Swept path/identifier references across the repo via `perl -pe 's/get-shit-done(?!-\w)/gsd-core/g'`. The negative lookahead preserves the five legitimate slug variants that are NOT the directory: get-shit-done-{OLD,cc,classic,cli,redux} (old package/repo names). - Build/manifest wiring: package.json (bin, files, coverage globs), tsconfig.build.json (outDir), ~86 .gitignore build-output entries, stryker.config.mjs, scan-ignore files, install.js path strings. - Frozen (not rewritten): CHANGELOG.md history; translated docs (README.<locale>.md and docs/{ja-JP,ko-KR,pt-BR,zh-CN}/). New logic (review here): - src/installer-migrations/003-rename-get-shit-done-to-gsd-core.cts: a proper ADR-0008 installer migration. On upgrade it walks the legacy `~/.claude/get-shit-done/` tree, classifies each file via the prior install manifest, and emits remove-managed / backup-and-remove for managed files while PRESERVING unknown user-added files. Symlink-safe (skips a symlinked root and symlinked entries; bounds-checks every path under configDir). The framework rolls back on install failure. Emptied dirs may remain (framework has no recursive dir-removal primitive) — documented. - scripts/lint-legacy-dir-name.cjs: CI regression guard forbidding the bare `get-shit-done` directory token (split token to avoid self-match; case- insensitive; `(?!-\w)` lookahead allows the slug variants; allowlists CHANGELOG, translated docs, and `gsd-allow-legacy-name` marker lines). Wired into the lint-tests CI job. - Restored scripts/lint-package-identity-drift.cjs detection regexes (the mechanical sweep had wrongly rewritten the old-name patterns it exists to detect) and marked them as intentional legacy references. - TDD tests for the migration and the guard; do.md slash-command guard regex tightened so a `/gsd-core/bin` path segment is not mistaken for a command; changeset + docs/installer-migrations.md row added. Breaking: the installed runtime path moves `~/.claude/get-shit-done/` -> `~/.claude/gsd-core/`. Migration 003 removes the stale legacy dir's managed files (preserving user files) on upgrade. Users with custom hooks/configs hardcoding the old path must update them. Closes #604 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): unsweep pending changesets + allowlist injection-example docs CI fixes for the rename PR: - Do not sweep pending .changeset/*.md (ephemeral release-note fragments, like CHANGELOG); reverted those body edits so 5 pre-existing malformed fragments (missing type/pr) no longer enter the PR diff and trip docs-lint. Allowlisted .changeset/ in the legacy-name guard accordingly. - Allowlisted TEST-EXAMPLES.md and docs/explanation/security-model.md in prompt-injection-scan.sh: they contain intentional injection examples / security-model prose; the path-reference rewrites are kept. CodeQL alerts on this PR are pre-existing (alert lines unchanged by this PR; none in the new migration/guard) and are out of scope for the rename. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): resolve CodeQL alerts surfaced on this PR The rename diff touched files carrying pre-existing CodeQL findings; per the no-pre-existing-dismissal rule, fixing every surfaced alert rather than waving them off. All behavior-preserving: - scripts/ci-test-scope.cjs: build the config-path match from string .includes() instead of a RegExp over an arg-derived value (js/regex-injection). - src/profile-output.cts: escape backslashes before pipe-escaping desc/safeName so the table-cell escape is complete (js/incomplete-sanitization). - tests/{bug-2643,bug-2808,docs-parity-live-registry}: two-pass HTML-comment strip so a bare/unclosed `<!--` cannot survive (js/incomplete-multi-character-sanitization). - tests/inline-plan-threshold: drop the no-op `\s`->`\s` identity replace, keep the meaningful POSIX-class conversion (js/identity-replacement). Verified: build:lib green; the touched test files + ci-test-scope + profile-output suites pass; lint:legacy-name clean. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): correctly resolve remaining CodeQL alerts (regex-injection + sanitization) The prior commit's fixes for two alerts were ineffective: - ci-test-scope.cjs js/regex-injection: the alert is the CLI-arg-derived `file` reaching static regex `.test(file)` calls (not the config rule). Removed ALL regex over file/t — startsWith/includes/=== string checks + an isWindowsHint helper — so there is no regex sink for the tainted value. - js/incomplete-multi-character-sanitization (3 test files): a single `.replace(/<!--...-->/g,'')` can let `<!--` re-form. Replaced with a fixpoint loop (replace until stable) plus a final bare-opener strip. Verified: no regex over file/t remains; ci-test-scope + the 3 test suites pass; lint:legacy-name clean. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): make ci-test-scope + comment-strippers regex-free to clear CodeQL CodeQL flags the regex PATTERNS syntactically (regex-injection on the --files arg split; incomplete-multi-character-sanitization on the <!--...--> replace), so loop fixes do not satisfy it. Made these paths regex-free: - ci-test-scope.cjs splitFiles: char-by-char separator tokenizer (no /[,\\s]+/). - 3 test files: indexOf/slice HTML-comment stripper (no .replace(/<!--/)). Behavior preserved; ci-test-scope + the 3 suites pass; guard clean. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): unblock security base64 scan on the large rename diff The security job hit its 10m timeout: base64-scan.sh choked on the binary test fixture tests/feat-3594-parser-property-style.test.cjs (embedded NUL/ non-UTF8 bytes -> thousands of bogus blobs + "ignored null byte" warnings), and the ~800-file rename diff is slow to scan regardless. - scripts/base64-scan.sh: skip binary-by-content files (grep -Iq .) — they can't carry base64-obfuscated *text* and feeding NUL bytes through the per-line scanner is pathologically slow. collect_files already filtered binary *extensions*; this catches binary *content* in text extensions. - .github/workflows/security-scan.yml: raise the security job timeout 10m->30m to accommodate very large diffs (the scan itself is unchanged). Verified locally: scan skips the fixture, 0 "ignored null byte" warnings, 0 findings, exit 0. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): sweep get-shit-done refs introduced by merging next The branch was updated with next (#614/#384/#618 etc.), which reference the get-shit-done/ dir (still named that on next). Swept the stale references in the merged files to gsd-core so the rename stays consistent and lint:legacy-name passes: - commands/gsd/discuss-phase.md (runtime-launcher shim paths) - src/core.cts (getAgentsDir layout comments) - tests/bug-384-agents-runtime-aware.test.cjs (require path to runtime lib) Verified: guard 0 violations; build green. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): exclude gsd-core/ path segments from bug-3683 command cross-ref invariant The #614 runtime-launcher shim added to discuss-phase.md references `${_GSD_RUNTIME_ROOT}/gsd-core/bin/...`. bug-3683's REF_PATTERN excluded path-y refs only via lookbehind, but `}` precedes `/gsd-core/` in the shim, so it mis-read the directory path as a dangling `/gsd-core` command ref (same class as the #604 bug-2954 fix). Added a trailing `(?![\w-]*\/)` so `/gsd-<x>/...` path segments are not treated as slash-command references. Verified locally on BOTH platforms before pushing: - mac (node 26) full suite: 0 failures - gsd-test-runner (linux, node22 image) full suite: 0 failures - bug-3683 + bug-2954 pass. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): lazily resolve findProjectRoot in gsd-tools (harden flaky CI) CI intermittently failed state.test's gsd-tools subprocess with "findProjectRoot is not a function" (flip-flopping across legs; not reproducible on mac full suite, gsd-test linux full suite, test:unit, or state.test x8). findProjectRoot is a re-export from core.cjs (sourced from project-root.cjs); binding it via destructure at module-load can be undefined under a load-ordering edge. Resolve it lazily at call time via a small wrapper so the lookup happens after core.cjs is fully initialized. Verified green on BOTH platforms before pushing: - mac (node 26) full suite: 0 failures - gsd-test-runner (linux, node22) full suite: 0 failures - state.test.cjs: 106/106; gsd-tools loads cleanly. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): allowlist verification-patterns.md placeholder examples in secret scan The rename git-mv'd references/verification-patterns.md into gsd-core/, pulling it into the secret-scan diff. It documents stub/placeholder RED-FLAG env-var examples (illustrative Stripe test-key / database-URL / API-key placeholders) — not real credentials. Added it to .secretscanignore with the strict annotation, mirroring the existing gsd-core/workflows/plan-phase.md exception. Verified locally: secret-scan-lint --strict OK; secret-scan --diff origin/next exits 0 with 0 findings. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
278 lines
9.3 KiB
Markdown
278 lines
9.3 KiB
Markdown
# Smart Discuss — Autonomous Mode
|
|
|
|
Smart discuss is the autonomous-optimized variant of `gsd-discuss-phase`. It proposes grey area answers in batch tables — the user accepts or overrides per area — then writes an identical CONTEXT.md to what discuss-phase produces.
|
|
|
|
**Inputs:** `PHASE_NUM` from execute_phase. Run init to get phase paths:
|
|
|
|
```bash
|
|
PHASE_STATE=$(gsd-tools query init.phase-op ${PHASE_NUM})
|
|
```
|
|
|
|
Parse from JSON: `phase_dir`, `phase_slug`, `padded_phase`, `phase_name`.
|
|
|
|
---
|
|
|
|
## Sub-step 1: Load prior context
|
|
|
|
Read project-level and prior phase context to avoid re-asking decided questions.
|
|
|
|
**Read project files:**
|
|
|
|
```bash
|
|
cat .planning/PROJECT.md 2>/dev/null || true
|
|
cat .planning/REQUIREMENTS.md 2>/dev/null || true
|
|
cat .planning/STATE.md 2>/dev/null || true
|
|
```
|
|
|
|
Extract from these:
|
|
- **PROJECT.md** — Vision, principles, non-negotiables, user preferences
|
|
- **REQUIREMENTS.md** — Acceptance criteria, constraints, must-haves vs nice-to-haves
|
|
- **STATE.md** — Current progress, decisions logged so far
|
|
|
|
**Read all prior CONTEXT.md files:**
|
|
|
|
```bash
|
|
(find .planning/phases -name "*-CONTEXT.md" 2>/dev/null || true) | sort
|
|
```
|
|
|
|
For each CONTEXT.md where phase number < current phase:
|
|
- Read the `<decisions>` section — these are locked preferences
|
|
- Read `<specifics>` — particular references or "I want it like X" moments
|
|
- Note patterns (e.g., "user consistently prefers minimal UI", "user rejected verbose output")
|
|
|
|
**Build internal prior_decisions context** (do not write to file):
|
|
|
|
```
|
|
<prior_decisions>
|
|
## Project-Level
|
|
- [Key principle or constraint from PROJECT.md]
|
|
- [Requirement affecting this phase from REQUIREMENTS.md]
|
|
|
|
## From Prior Phases
|
|
### Phase N: [Name]
|
|
- [Decision relevant to current phase]
|
|
- [Preference that establishes a pattern]
|
|
</prior_decisions>
|
|
```
|
|
|
|
If no prior context exists, continue without — expected for early phases.
|
|
|
|
---
|
|
|
|
## Sub-step 2: Scout Codebase
|
|
|
|
Lightweight codebase scan to inform grey area identification and proposals. Keep under ~5% context.
|
|
|
|
**Check for existing codebase maps:**
|
|
|
|
```bash
|
|
ls .planning/codebase/*.md 2>/dev/null || true
|
|
```
|
|
|
|
**If codebase maps exist:** Read the most relevant ones (CONVENTIONS.md, STRUCTURE.md, STACK.md based on phase type). Extract reusable components, established patterns, integration points. Skip to building context below.
|
|
|
|
**If no codebase maps, do targeted grep:**
|
|
|
|
Extract key terms from the phase goal. Search for related files:
|
|
|
|
```bash
|
|
grep -rl "{term1}\|{term2}" src/ app/ --include="*.ts" --include="*.tsx" --include="*.js" --include="*.jsx" 2>/dev/null | head -10 || true
|
|
ls src/components/ src/hooks/ src/lib/ src/utils/ 2>/dev/null || true
|
|
```
|
|
|
|
Read the 3-5 most relevant files to understand existing patterns.
|
|
|
|
**Build internal codebase_context** (do not write to file):
|
|
- **Reusable assets** — existing components, hooks, utilities usable in this phase
|
|
- **Established patterns** — how the codebase does state management, styling, data fetching
|
|
- **Integration points** — where new code connects (routes, nav, providers)
|
|
|
|
---
|
|
|
|
## Sub-step 3: Analyze Phase and Generate Proposals
|
|
|
|
**Get phase details:**
|
|
|
|
```bash
|
|
DETAIL=$(gsd-tools query roadmap.get-phase ${PHASE_NUM})
|
|
```
|
|
|
|
Extract `goal`, `requirements`, `success_criteria` from the JSON response.
|
|
|
|
**Infrastructure detection — check FIRST before generating grey areas:**
|
|
|
|
A phase is pure infrastructure when ALL of these are true:
|
|
1. Goal keywords match: "scaffolding", "plumbing", "setup", "configuration", "migration", "refactor", "rename", "restructure", "upgrade", "infrastructure"
|
|
2. AND success criteria are all technical: "file exists", "test passes", "config valid", "command runs"
|
|
3. AND no user-facing behavior is described (no "users can", "displays", "shows", "presents")
|
|
|
|
**If infrastructure-only:** Skip Sub-step 4. Jump directly to Sub-step 5 with minimal CONTEXT.md. Display:
|
|
|
|
```
|
|
Phase ${PHASE_NUM}: Infrastructure phase — skipping discuss, writing minimal context.
|
|
```
|
|
|
|
Use these defaults for the CONTEXT.md:
|
|
- `<domain>`: Phase boundary from ROADMAP goal
|
|
- `<decisions>`: Single "### Claude's Discretion" subsection — "All implementation choices are at Claude's discretion — pure infrastructure phase"
|
|
- `<code_context>`: Whatever the codebase scout found
|
|
- `<specifics>`: "No specific requirements — infrastructure phase"
|
|
- `<deferred>`: "None"
|
|
|
|
**If NOT infrastructure — generate grey area proposals:**
|
|
|
|
Determine domain type from the phase goal:
|
|
- Something users **SEE** → visual: layout, interactions, states, density
|
|
- Something users **CALL** → interface: contracts, responses, errors, auth
|
|
- Something users **RUN** → execution: invocation, output, behavior modes, flags
|
|
- Something users **READ** → content: structure, tone, depth, flow
|
|
- Something being **ORGANIZED** → organization: criteria, grouping, exceptions, naming
|
|
|
|
Check prior_decisions — skip grey areas already decided in prior phases.
|
|
|
|
Generate **3-4 grey areas** with **~4 questions each**. For each question:
|
|
- **Pre-select a recommended answer** based on: prior decisions (consistency), codebase patterns (reuse), domain conventions (standard approaches), ROADMAP success criteria
|
|
- Generate **1-2 alternatives** per question
|
|
- **Annotate** with prior decision context ("You decided X in Phase N") and code context ("Component Y exists with Z variants") where relevant
|
|
|
|
---
|
|
|
|
## Sub-step 4: Present Proposals Per Area
|
|
|
|
Present grey areas **one at a time**. For each area (M of N):
|
|
|
|
Display a table:
|
|
|
|
```
|
|
### Grey Area {M}/{N}: {Area Name}
|
|
|
|
| # | Question | ✅ Recommended | Alternative(s) |
|
|
|---|----------|---------------|-----------------|
|
|
| 1 | {question} | {answer} — {rationale} | {alt1}; {alt2} |
|
|
| 2 | {question} | {answer} — {rationale} | {alt1} |
|
|
| 3 | {question} | {answer} — {rationale} | {alt1}; {alt2} |
|
|
| 4 | {question} | {answer} — {rationale} | {alt1} |
|
|
```
|
|
|
|
Then prompt the user via **AskUserQuestion**:
|
|
- **header:** "Area {M}/{N}"
|
|
- **question:** "Accept these answers for {Area Name}?"
|
|
- **options:** Build dynamically — always "Accept all" first, then "Change Q1" through "Change QN" for each question (up to 4), then "Discuss deeper" last. Cap at 6 explicit options max (AskUserQuestion adds "Other" automatically).
|
|
|
|
**On "Accept all":** Record all recommended answers for this area. Move to next area.
|
|
|
|
**On "Change QN":** Use AskUserQuestion with the alternatives for that specific question:
|
|
- **header:** "{Area Name}"
|
|
- **question:** "Q{N}: {question text}"
|
|
- **options:** List the 1-2 alternatives plus "You decide" (maps to Claude's Discretion)
|
|
|
|
Record the user's choice. Re-display the updated table with the change reflected. Re-present the full acceptance prompt so the user can make additional changes or accept.
|
|
|
|
**On "Discuss deeper":** Switch to interactive mode for this area only — ask questions one at a time using AskUserQuestion with 2-3 concrete options per question plus "You decide". After 4 questions, prompt:
|
|
- **header:** "{Area Name}"
|
|
- **question:** "More questions about {area name}, or move to next?"
|
|
- **options:** "More questions" / "Next area"
|
|
|
|
If "More questions", ask 4 more. If "Next area", display final summary table of captured answers for this area and move on.
|
|
|
|
**On "Other" (free text):** Interpret as either a specific change request or general feedback. Incorporate into the area's decisions, re-display updated table, re-present acceptance prompt.
|
|
|
|
**Scope creep handling:** If user mentions something outside the phase domain:
|
|
|
|
```
|
|
"{Feature} sounds like a new capability — that belongs in its own phase.
|
|
I'll note it as a deferred idea.
|
|
|
|
Back to {current area}: {return to current question}"
|
|
```
|
|
|
|
Track deferred ideas internally for inclusion in CONTEXT.md.
|
|
|
|
---
|
|
|
|
## Sub-step 5: Write CONTEXT.md
|
|
|
|
After all areas are resolved (or infrastructure skip), write the CONTEXT.md file.
|
|
|
|
**File path:** `${phase_dir}/${padded_phase}-CONTEXT.md`
|
|
|
|
Use **exactly** this structure (identical to discuss-phase output):
|
|
|
|
```markdown
|
|
# Phase {PHASE_NUM}: {Phase Name} - Context
|
|
|
|
**Gathered:** {date}
|
|
**Status:** Ready for planning
|
|
|
|
<domain>
|
|
## Phase Boundary
|
|
|
|
{Domain boundary statement from analysis — what this phase delivers}
|
|
|
|
</domain>
|
|
|
|
<decisions>
|
|
## Implementation Decisions
|
|
|
|
### {Area 1 Name}
|
|
- {Accepted/chosen answer for Q1}
|
|
- {Accepted/chosen answer for Q2}
|
|
- {Accepted/chosen answer for Q3}
|
|
- {Accepted/chosen answer for Q4}
|
|
|
|
### {Area 2 Name}
|
|
- {Accepted/chosen answer for Q1}
|
|
- {Accepted/chosen answer for Q2}
|
|
...
|
|
|
|
### Claude's Discretion
|
|
{Any "You decide" answers collected — note Claude has flexibility here}
|
|
|
|
</decisions>
|
|
|
|
<code_context>
|
|
## Existing Code Insights
|
|
|
|
### Reusable Assets
|
|
- {From codebase scout — components, hooks, utilities}
|
|
|
|
### Established Patterns
|
|
- {From codebase scout — state management, styling, data fetching}
|
|
|
|
### Integration Points
|
|
- {From codebase scout — where new code connects}
|
|
|
|
</code_context>
|
|
|
|
<specifics>
|
|
## Specific Ideas
|
|
|
|
{Any specific references or "I want it like X" from discussion}
|
|
{If none: "No specific requirements — open to standard approaches"}
|
|
|
|
</specifics>
|
|
|
|
<deferred>
|
|
## Deferred Ideas
|
|
|
|
{Ideas captured but out of scope for this phase}
|
|
{If none: "None — discussion stayed within phase scope"}
|
|
|
|
</deferred>
|
|
```
|
|
|
|
Write the file.
|
|
|
|
**Commit:**
|
|
|
|
```bash
|
|
gsd-tools query commit "docs(${PADDED_PHASE}): smart discuss context" --files "${phase_dir}/${padded_phase}-CONTEXT.md"
|
|
```
|
|
|
|
Display confirmation:
|
|
|
|
```
|
|
Created: {path}
|
|
Decisions captured: {count} across {area_count} areas
|
|
```
|