The convergence lint only scanned src/ + gsd-core/bin, so ~35 test files still imported core.cjs. Repoint all 33 behaviour importers to the leaf modules directly (same symbol->leaf map as the src migration; leaves are the objects core re-exported by reference), delete the now-meaningless shim-identity describe blocks in the 8 leaf tests, and delete tests/core.test.cjs (forwarded-behaviour coverage now lives at the leaves; resolveWorktreeRoot test relocated to worktree-safety in T0) and tests/lint-core-spine-imports.test.cjs (the lint is removed in T-final). Dropped the stale core.test.cjs entries from the allow-test-rule-refs allowlist; eslint-rules RuleTester fixture path pointed at io.cjs. After T6: ZERO test imports core.cjs. core.cts still builds (now fully unused); T-final deletes it. No behaviour change. Closes #1291 Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
91 lines
2.9 KiB
JavaScript
91 lines
2.9 KiB
JavaScript
// Tests for getMilestoneFromPhaseId and getPhaseDirFromPhaseId helpers (issue #39).
|
|
|
|
'use strict';
|
|
|
|
const { describe, test } = require('node:test');
|
|
const assert = require('node:assert/strict');
|
|
|
|
const {
|
|
getMilestoneFromPhaseId,
|
|
getPhaseDirFromPhaseId,
|
|
} = require('../gsd-core/bin/lib/phase-id.cjs');
|
|
|
|
// ─── getMilestoneFromPhaseId ────────────────────────────────────────────────
|
|
|
|
describe('getMilestoneFromPhaseId', () => {
|
|
test('maps milestone integer 1 to v1.0', () => {
|
|
assert.strictEqual(getMilestoneFromPhaseId('1-01'), 'v1.0');
|
|
});
|
|
|
|
test('uses only the top-level integer: 2-4-1 → v2.0', () => {
|
|
assert.strictEqual(getMilestoneFromPhaseId('2-4-1'), 'v2.0');
|
|
});
|
|
|
|
test('handles double-digit milestone: 10-01 → v10.0', () => {
|
|
assert.strictEqual(getMilestoneFromPhaseId('10-01'), 'v10.0');
|
|
});
|
|
|
|
test('returns null for sentinel 999 (backlog)', () => {
|
|
assert.strictEqual(getMilestoneFromPhaseId('999-1'), null);
|
|
});
|
|
|
|
test('returns null for sentinel 0 (pre-milestone spike)', () => {
|
|
assert.strictEqual(getMilestoneFromPhaseId('0-1'), null);
|
|
});
|
|
|
|
test('returns null when there is no hyphen separator', () => {
|
|
assert.strictEqual(getMilestoneFromPhaseId('1'), null);
|
|
});
|
|
|
|
test('strips project_code prefix: CK-2-01 → v2.0', () => {
|
|
assert.strictEqual(getMilestoneFromPhaseId('CK-2-01'), 'v2.0');
|
|
});
|
|
|
|
test('strips longer project_code prefix: GSD-10-01 → v10.0', () => {
|
|
assert.strictEqual(getMilestoneFromPhaseId('GSD-10-01'), 'v10.0');
|
|
});
|
|
|
|
test('returns null for fully non-numeric input', () => {
|
|
assert.strictEqual(getMilestoneFromPhaseId('invalid'), null);
|
|
});
|
|
});
|
|
|
|
// ─── getPhaseDirFromPhaseId ─────────────────────────────────────────────────
|
|
|
|
describe('getPhaseDirFromPhaseId', () => {
|
|
test('produces zero-padded dir with project code', () => {
|
|
assert.strictEqual(
|
|
getPhaseDirFromPhaseId('2-01', 'Setup Database', 'GSD'),
|
|
'GSD-02-01-setup-database',
|
|
);
|
|
});
|
|
|
|
test('omits project code when not provided', () => {
|
|
assert.strictEqual(
|
|
getPhaseDirFromPhaseId('2-01', 'Setup Database'),
|
|
'02-01-setup-database',
|
|
);
|
|
});
|
|
|
|
test('handles double-digit milestone with project code', () => {
|
|
assert.strictEqual(
|
|
getPhaseDirFromPhaseId('10-01', 'Build Feature', 'CK'),
|
|
'CK-10-01-build-feature',
|
|
);
|
|
});
|
|
|
|
test('produces zero-padded dir without project code: 1-01 → 01-01-setup', () => {
|
|
assert.strictEqual(
|
|
getPhaseDirFromPhaseId('1-01', 'Setup'),
|
|
'01-01-setup',
|
|
);
|
|
});
|
|
|
|
test('returns null for phase IDs without the M-NN hyphen form', () => {
|
|
assert.strictEqual(
|
|
getPhaseDirFromPhaseId('nohyphen', 'Some Title', 'GSD'),
|
|
null,
|
|
);
|
|
});
|
|
});
|