* fix(#2851): replace bare gsd-tools invocations with absolute path `gsd-tools` is not a published bin entry — package.json declares only get-shit-done-cc and gsd-sdk. The shipped invocation pattern is `node "$HOME/.claude/get-shit-done/bin/gsd-tools.cjs" <subcommand>`, used by every other workflow file. Two leaked bare invocations: - get-shit-done/workflows/plan-phase.md §13e (gap-analysis) — reported in #2851; gap-analysis silently skipped on every plan-phase run - get-shit-done/workflows/ingest-docs.md §finalize (commit) — caught by the new structural test; ingest-docs commit step was broken Both updated to canonical absolute-path form. Adds tests/bug-2851-workflow-bare-gsd-tools.test.cjs which parses every markdown file under get-shit-done/workflows/, extracts shell-fenced code blocks, tokenizes each line, and asserts no token in command position is the bare string `gsd-tools` (the trailing `.cjs` is a different token). The test also asserts plan-phase.md's gap-analysis call uses the canonical `node …/gsd-tools.cjs` form. Closes #2851 * fix(#2851): catch third bare gsd-tools call in ingest-docs.md init After the first commit, the structural test was strengthened to detect bare `gsd-tools` inside `$(...)` and backtick command-substitution forms. The improved test surfaced a third leak: ingest-docs.md:55: INIT=$(gsd-tools init ingest-docs) Fixed to canonical form INIT=$(node "$HOME/.claude/get-shit-done/bin/gsd-tools.cjs" init ingest-docs) plus the standard `@file:` handoff line that every other workflow uses when capturing INIT (required by tests/windows-robustness.test.cjs). Updated tests/bug-2801-ingest-docs-handler.test.cjs to match either the bare `gsd-tools init ingest-docs` or canonical `gsd-tools.cjs" init ingest-docs` form — the test's intent is to verify the dispatch handler is wired, not to lock the bare-bin form that #2851 removes. Closes #2851 * test(#2851): tighten ingest-docs and gap-analysis assertions to canonical form CodeRabbit caught two soft assertions in the regression tests: 1. tests/bug-2801: the init-ingest-docs assertion accepted both the legacy bare `gsd-tools` form and the canonical node-path form. Since #2851 is the fix that removes the bare form, the test should only accept the canonical absolute-path invocation. Switched to parsed-bash-block extraction with an anchored regex on the full `node "$HOME/.claude/get-shit-done/bin/gsd-tools.cjs"` path. 2. tests/bug-2851: the gap-analysis assertion used two loose .includes()/word-boundary checks. Replaced with a single assert.match() against the full canonical path so non-canonical forms fail. * test(#2851): env-assignment skip accepts lowercase identifiers too CodeRabbit caught: the cmdIdx-skip regex /^[A-Z_][A-Z0-9_]*=/ only matched uppercase variable names, so a line like `tmp=1 gsd-tools init` would tokenize to ['tmp=1','gsd-tools','init'], the regex would fail on 'tmp=1', cmdIdx would stay at 0, and the command-position check would compare 'tmp=1' against 'gsd-tools' — false negative. POSIX shell variable names are [A-Za-z_][A-Za-z0-9_]*. Widen the regex to match the actual lexical rule. Existing uppercase forms still work (FOO=bar gsd-tools); now lowercase forms (tmp=1 gsd-tools) and mixed case forms are also detected.
335 lines
13 KiB
Markdown
335 lines
13 KiB
Markdown
# Ingest Docs Workflow
|
|
|
|
Scan a repo for mixed planning documents (ADR, PRD, SPEC, DOC), synthesize them into a consolidated context, and bootstrap or merge into `.planning/`.
|
|
|
|
- `[path]` — optional target directory to scan (defaults to repo root)
|
|
- `--mode new|merge` — override auto-detect (defaults: `new` if `.planning/` absent, `merge` if present)
|
|
- `--manifest <file>` — YAML file listing `{path, type, precedence?}` per doc; overrides heuristic classification
|
|
- `--resolve auto|interactive` — conflict resolution (v1: only `auto` is supported; `interactive` is reserved)
|
|
|
|
---
|
|
|
|
<step name="banner">
|
|
|
|
Display the stage banner:
|
|
|
|
```
|
|
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
|
|
GSD ► INGEST DOCS
|
|
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
|
|
```
|
|
|
|
</step>
|
|
|
|
<step name="parse_arguments">
|
|
|
|
Parse `$ARGUMENTS`:
|
|
|
|
- First positional token (if not a flag) → `SCAN_PATH` (default: `.`)
|
|
- `--mode new|merge` → `MODE` (default: auto-detect)
|
|
- `--manifest <file>` → `MANIFEST_PATH` (optional)
|
|
- `--resolve auto|interactive` → `RESOLVE_MODE` (default: `auto`; reject `interactive` in v1 with message "interactive resolution is planned for a future release")
|
|
|
|
**Validate paths:**
|
|
|
|
```bash
|
|
case "{SCAN_PATH}" in *..*) echo "SECURITY_ERROR: path contains traversal sequence"; exit 1 ;; esac
|
|
test -d "{SCAN_PATH}" || echo "PATH_NOT_FOUND"
|
|
if [ -n "{MANIFEST_PATH}" ]; then
|
|
case "{MANIFEST_PATH}" in *..*) echo "SECURITY_ERROR: manifest path contains traversal"; exit 1 ;; esac
|
|
test -f "{MANIFEST_PATH}" || echo "MANIFEST_NOT_FOUND"
|
|
fi
|
|
```
|
|
|
|
**Containment (required):** After resolving `SCAN_PATH` and `MANIFEST_PATH` relative to the repo root, canonicalize each with `realpath` (or platform equivalent) and assert the result is under `realpath("$REPO_ROOT")`. Reject absolute paths outside the repo (e.g. `/tmp`, `C:\Windows`) even when they do not contain `..`.
|
|
|
|
If `PATH_NOT_FOUND` or `MANIFEST_NOT_FOUND`: display error and exit.
|
|
|
|
</step>
|
|
|
|
<step name="init_and_mode_detect">
|
|
|
|
Run the init query:
|
|
|
|
```bash
|
|
INIT=$(node "$HOME/.claude/get-shit-done/bin/gsd-tools.cjs" init ingest-docs)
|
|
if [[ "$INIT" == @file:* ]]; then INIT=$(cat "${INIT#@file:}"); fi
|
|
```
|
|
|
|
Parse `project_exists`, `planning_exists`, `has_git`, `project_path` from INIT.
|
|
|
|
**Auto-detect MODE** if not set:
|
|
- `planning_exists: true` → `MODE=merge`
|
|
- `planning_exists: false` → `MODE=new`
|
|
|
|
If user passed `--mode new` but `.planning/` already exists: display warning and require explicit confirm via `AskUserQuestion` (approve-revise-abort from `references/gate-prompts.md`) before overwriting.
|
|
|
|
If `has_git: false` and `MODE=new`: initialize git:
|
|
```bash
|
|
git init
|
|
```
|
|
|
|
**Detect runtime** using the same pattern as `new-project.md`:
|
|
- execution_context path `/.codex/` → `RUNTIME=codex`
|
|
- `/.gemini/` → `RUNTIME=gemini`
|
|
- `/.opencode/` or `/.config/opencode/` → `RUNTIME=opencode`
|
|
- else → `RUNTIME=claude`
|
|
|
|
Fall back to env vars (`CODEX_HOME`, `GEMINI_CONFIG_DIR`, `OPENCODE_CONFIG_DIR`) if execution_context is unavailable.
|
|
|
|
</step>
|
|
|
|
<step name="discover_docs">
|
|
|
|
Build the doc list from three sources, in order:
|
|
|
|
**1. Manifest (if provided)** — authoritative:
|
|
|
|
Read `MANIFEST_PATH`. Expected YAML shape:
|
|
|
|
```yaml
|
|
docs:
|
|
- path: docs/adr/0001-db.md
|
|
type: ADR
|
|
precedence: 0 # optional, lower = higher precedence
|
|
- path: docs/prd/auth.md
|
|
type: PRD
|
|
```
|
|
|
|
Each entry provides `path` (required, relative to repo root) + `type` (required, one of ADR|PRD|SPEC|DOC) + `precedence` (optional integer).
|
|
|
|
**2. Directory conventions** (skipped when manifest is provided):
|
|
|
|
```bash
|
|
# ADRs
|
|
find {SCAN_PATH} -type f \( -path '*/adr/*' -o -path '*/adrs/*' -o -name 'ADR-*.md' -o -regex '.*/[0-9]\{4\}-.*\.md' \) 2>/dev/null
|
|
|
|
# PRDs
|
|
find {SCAN_PATH} -type f \( -path '*/prd/*' -o -path '*/prds/*' -o -name 'PRD-*.md' \) 2>/dev/null
|
|
|
|
# SPECs / RFCs
|
|
find {SCAN_PATH} -type f \( -path '*/spec/*' -o -path '*/specs/*' -o -path '*/rfc/*' -o -path '*/rfcs/*' -o -name 'SPEC-*.md' -o -name 'RFC-*.md' \) 2>/dev/null
|
|
|
|
# Generic docs (fall-through candidates)
|
|
find {SCAN_PATH} -type f -path '*/docs/*' -name '*.md' 2>/dev/null
|
|
```
|
|
|
|
De-duplicate the union (a file matched by multiple patterns is one doc).
|
|
|
|
**3. Content heuristics** (run during classification, not here) — the classifier handles frontmatter `type:` and H1 inspection for docs that didn't match a convention.
|
|
|
|
**Cap:** hard limit of 50 docs per invocation (documented v1 constraint). If the discovered set exceeds 50:
|
|
|
|
```
|
|
GSD > Discovered {N} docs, which exceeds the v1 cap of 50.
|
|
Use --manifest to narrow the set to ≤ 50 files, or run
|
|
/gsd-ingest-docs again with a narrower <path>.
|
|
```
|
|
|
|
Exit without proceeding.
|
|
|
|
**Display discovered set** and request approval (see `references/gate-prompts.md` — `yes-no-pick` pattern works; or `approve-revise-abort`):
|
|
|
|
```
|
|
Discovered {N} documents:
|
|
{N} ADR | {N} PRD | {N} SPEC | {N} DOC | {N} unclassified
|
|
|
|
docs/adr/0001-architecture.md [ADR] (from manifest|directory|heuristic)
|
|
docs/adr/0002-database.md [ADR] (directory)
|
|
docs/prd/auth.md [PRD] (manifest)
|
|
...
|
|
```
|
|
|
|
**Text mode:** apply the same `--text`/`text_mode` rule as other workflows — replace `AskUserQuestion` with a numbered list.
|
|
|
|
Use `AskUserQuestion` (approve-revise-abort):
|
|
- question: "Proceed with classification of these {N} documents?"
|
|
- header: "Approve?"
|
|
- options: Approve | Revise | Abort
|
|
|
|
On Abort: exit cleanly with "Ingest cancelled."
|
|
On Revise: exit with guidance to re-run with `--manifest` or a narrower path.
|
|
|
|
</step>
|
|
|
|
<step name="classify_parallel">
|
|
|
|
Create staging directory:
|
|
|
|
```bash
|
|
mkdir -p .planning/intel/classifications/
|
|
```
|
|
|
|
For each discovered doc, spawn `gsd-doc-classifier` in parallel. In Claude Code, issue all Task calls in a single message with multiple tool uses so the harness runs them concurrently. For Copilot / sequential runtimes, fall back to sequential dispatch.
|
|
|
|
Per-spawn prompt fields:
|
|
- `FILEPATH` — absolute path to the doc
|
|
- `OUTPUT_DIR` — `.planning/intel/classifications/`
|
|
- `MANIFEST_TYPE` — the type from the manifest if present, else omit
|
|
- `MANIFEST_PRECEDENCE` — the precedence integer from the manifest if present, else omit
|
|
- `<required_reading>` — `agents/gsd-doc-classifier.md` (the agent definition itself)
|
|
|
|
Collect the one-line confirmations from each classifier. If any classifier errors out, surface the error and abort without touching `.planning/` further.
|
|
|
|
</step>
|
|
|
|
<step name="synthesize">
|
|
|
|
Spawn `gsd-doc-synthesizer` once:
|
|
|
|
```
|
|
Task({
|
|
subagent_type: "gsd-doc-synthesizer",
|
|
prompt: "
|
|
CLASSIFICATIONS_DIR: .planning/intel/classifications/
|
|
INTEL_DIR: .planning/intel/
|
|
CONFLICTS_PATH: .planning/INGEST-CONFLICTS.md
|
|
MODE: {MODE}
|
|
EXISTING_CONTEXT: {paths to existing .planning files if MODE=merge, else empty}
|
|
PRECEDENCE: {array from manifest defaults or default ['ADR','SPEC','PRD','DOC']}
|
|
|
|
<required_reading>
|
|
- agents/gsd-doc-synthesizer.md
|
|
- get-shit-done/references/doc-conflict-engine.md
|
|
</required_reading>
|
|
"
|
|
})
|
|
```
|
|
|
|
> **ORCHESTRATOR RULE — CODEX RUNTIME**: After calling Task() above, stop working on this task immediately. Do not read or synthesize any classified documents independently while the subagent is active. Wait for the subagent to return its result. This prevents duplicate work, conflicting edits, and wasted context. Only resume when the subagent result is available.
|
|
|
|
The synthesizer writes:
|
|
- `.planning/intel/decisions.md`, `.planning/intel/requirements.md`, `.planning/intel/constraints.md`, `.planning/intel/context.md`
|
|
- `.planning/intel/SYNTHESIS.md`
|
|
- `.planning/INGEST-CONFLICTS.md`
|
|
|
|
</step>
|
|
|
|
<step name="conflict_gate">
|
|
|
|
Read `.planning/INGEST-CONFLICTS.md`. Count entries in each bucket (the synthesizer always writes the three-bucket header; parse the `### BLOCKERS ({N})`, `### WARNINGS ({N})`, `### INFO ({N})` lines).
|
|
|
|
Apply the safety semantics from `references/doc-conflict-engine.md`. Operation noun: `ingest`.
|
|
|
|
**If BLOCKERS > 0:**
|
|
|
|
Render the report to the user, then display:
|
|
|
|
```
|
|
GSD > BLOCKED: {N} blockers must be resolved before ingest can proceed.
|
|
```
|
|
|
|
Exit WITHOUT writing PROJECT.md, REQUIREMENTS.md, ROADMAP.md, or STATE.md. The staging intel files remain for inspection. The safety gate holds — no destination files are written when blockers exist.
|
|
|
|
**If WARNINGS > 0 and BLOCKERS = 0:**
|
|
|
|
Render the report, then ask via AskUserQuestion (approve-revise-abort):
|
|
- question: "Review the competing variants above. Resolve manually and proceed, or abort?"
|
|
- header: "Approve?"
|
|
- options: Approve | Abort
|
|
|
|
On Abort: exit cleanly with "Ingest cancelled. Staged intel preserved at `.planning/intel/`."
|
|
|
|
**If BLOCKERS = 0 and WARNINGS = 0:**
|
|
|
|
Proceed to routing silently, or optionally display `GSD > No conflicts. Auto-resolved: {N}.`
|
|
|
|
</step>
|
|
|
|
<step name="route_new_mode">
|
|
|
|
**Applies only when MODE=new.**
|
|
|
|
Audit PROJECT.md field requirements that `gsd-roadmapper` expects. For fields derivable from `.planning/intel/SYNTHESIS.md` (project scope, goals/non-goals, constraints, locked decisions), synthesize from the intel. For fields NOT derivable (project name, developer-facing success metric, target runtime), prompt via `AskUserQuestion` one at a time — minimal question set, no interrogation.
|
|
|
|
Delegate to `gsd-roadmapper`:
|
|
|
|
```
|
|
Task({
|
|
subagent_type: "gsd-roadmapper",
|
|
prompt: "
|
|
Mode: new-project-from-ingest
|
|
Intel: .planning/intel/SYNTHESIS.md (entry point)
|
|
Per-type intel: .planning/intel/{decisions,requirements,constraints,context}.md
|
|
User-supplied fields: {collected in previous step}
|
|
|
|
Produce:
|
|
- .planning/PROJECT.md
|
|
- .planning/REQUIREMENTS.md
|
|
- .planning/ROADMAP.md
|
|
- .planning/STATE.md
|
|
|
|
Treat ADR-locked decisions as locked in PROJECT.md <decisions> blocks.
|
|
"
|
|
})
|
|
```
|
|
|
|
> **ORCHESTRATOR RULE — CODEX RUNTIME**: After calling Task() above, stop working on this task immediately. Do not read more intel files, write planning artifacts, or create ROADMAP.md independently while the subagent is active. Wait for the subagent to return its result. This prevents duplicate work, conflicting edits, and wasted context. Only resume when the subagent result is available.
|
|
|
|
</step>
|
|
|
|
<step name="route_merge_mode">
|
|
|
|
**Applies only when MODE=merge.**
|
|
|
|
Load existing `.planning/ROADMAP.md`, `.planning/PROJECT.md`, `.planning/REQUIREMENTS.md`, all `CONTEXT.md` files under `.planning/phases/`.
|
|
|
|
The synthesizer has already hard-blocked on any LOCKED-in-ingest vs LOCKED-in-existing contradiction; if we reach this step, no such blockers remain.
|
|
|
|
Plan the merge:
|
|
- **New requirements** from synthesized `.planning/intel/requirements.md` that do not overlap existing REQUIREMENTS.md entries → append to REQUIREMENTS.md
|
|
- **New decisions** from synthesized `.planning/intel/decisions.md` that do not overlap existing CONTEXT.md `<decisions>` blocks → write to a new phase's CONTEXT.md or append to the next milestone's requirements
|
|
- **New scope** → derive phase additions following the `new-milestone.md` pattern; append phases to `.planning/ROADMAP.md`
|
|
|
|
Preview the merge diff to the user and gate via approve-revise-abort before writing.
|
|
|
|
</step>
|
|
|
|
<step name="finalize">
|
|
|
|
Commit the ingest results:
|
|
|
|
```bash
|
|
node "$HOME/.claude/get-shit-done/bin/gsd-tools.cjs" commit \
|
|
"docs: ingest {N} docs from {SCAN_PATH} (#2387)" --files \
|
|
.planning/PROJECT.md \
|
|
.planning/REQUIREMENTS.md \
|
|
.planning/ROADMAP.md \
|
|
.planning/STATE.md \
|
|
.planning/intel/ \
|
|
.planning/INGEST-CONFLICTS.md
|
|
```
|
|
|
|
(For merge mode, substitute the actual set of modified files.)
|
|
|
|
Display completion:
|
|
|
|
```
|
|
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
|
|
GSD ► INGEST DOCS COMPLETE
|
|
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
|
|
```
|
|
|
|
Show:
|
|
- Mode ran (new or merge)
|
|
- Docs ingested (count + type breakdown)
|
|
- Decisions locked, requirements created, constraints captured
|
|
- Conflict report path (`.planning/INGEST-CONFLICTS.md`)
|
|
- Next step: `/gsd-plan-phase 1` (new mode) or `/gsd-plan-phase N` (merge, pointing at the first newly-added phase)
|
|
|
|
</step>
|
|
|
|
---
|
|
|
|
## Anti-Patterns
|
|
|
|
Do NOT:
|
|
- Violate the shared conflict-engine contract in `references/doc-conflict-engine.md` (no markdown tables, no new severity labels, no bypass of the BLOCKER gate)
|
|
- Write PROJECT.md, REQUIREMENTS.md, ROADMAP.md, or STATE.md when BLOCKERs exist in the conflict report
|
|
- Skip the 50-doc cap — larger sets must use `--manifest` to narrow the scope
|
|
- Auto-resolve LOCKED-vs-LOCKED ADR contradictions — those are BLOCKERs in both modes
|
|
- Merge competing PRD acceptance variants into a combined criterion — preserve all variants for user resolution
|
|
- Bypass the discovery approval gate — users must see the classified doc list before classifiers spawn
|
|
- Skip path validation on `SCAN_PATH` or `MANIFEST_PATH`
|
|
- Implement `--resolve interactive` in this v1 — the flag is reserved; reject with a future-release message
|